)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":21537,"name":"Yurii Prokulevych","email":"yprokule@redhat.com","username":"yprokule"},"change_message_id":"2461eb973e64ffaec55ab9ade686925851f57519","unresolved":false,"context_lines":[{"line_number":11,"context_line":"configuration value has changed."},{"line_number":12,"context_line":"During the upgrade, host_prep_tasks are being run and if the"},{"line_number":13,"context_line":"new templates bring some configuration change then the Docker"},{"line_number":14,"context_line":"service gets restarted. The issue is the point at which they"},{"line_number":15,"context_line":"get restarted, which is after the upgrade_tasks have already"},{"line_number":16,"context_line":"run and prior to the deploy_tasks. This is causing issues with"},{"line_number":17,"context_line":"Pacemaker handled resources."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"For that reason, we include the very same task running in host_prep_tasks"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f79a3b5_7830e7ea","line":16,"range":{"start_line":14,"start_character":23,"end_line":16,"end_character":58},"updated":"2018-12-10 09:04:25.000000000","message":"Docker is started with a \u0027--live-restore\u0027 option, which \u0027Enable live restore of running containers when the daemon starts so that they are not restarted.\u0027\nhttps://github.com/openstack/puppet-tripleo/blob/master/manifests/profile/base/docker.pp#L88\nAnd iiuc this addresses issue with pcs managed services and docker\u0027s restarte, though I leave it to Damien and Michele to confirm.","commit_id":"331cfb08b78e8c1004fc7e9ab9637882cf11eaaa"},{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"e71dd32c6c1b9a3ac0923903e729d291dea7e514","unresolved":false,"context_lines":[{"line_number":11,"context_line":"configuration value has changed."},{"line_number":12,"context_line":"During the upgrade, host_prep_tasks are being run and if the"},{"line_number":13,"context_line":"new templates bring some configuration change then the Docker"},{"line_number":14,"context_line":"service gets restarted. The issue is the point at which they"},{"line_number":15,"context_line":"get restarted, which is after the upgrade_tasks have already"},{"line_number":16,"context_line":"run and prior to the deploy_tasks. This is causing issues with"},{"line_number":17,"context_line":"Pacemaker handled resources."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"For that reason, we include the very same task running in host_prep_tasks"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f79a3b5_78ed47ff","line":16,"range":{"start_line":14,"start_character":23,"end_line":16,"end_character":58},"in_reply_to":"3f79a3b5_7830e7ea","updated":"2018-12-10 09:16:39.000000000","message":"That is correct but it seems that on a number of occasions even restarting it with live-restore is problematic. This is very likely due to the fact that docker takes a long time to go through the running containers and reattach to them \u0027causing timeouts.","commit_id":"331cfb08b78e8c1004fc7e9ab9637882cf11eaaa"}],"puppet/services/docker-registry.yaml":[{"author":{"_account_id":21537,"name":"Yurii Prokulevych","email":"yprokule@redhat.com","username":"yprokule"},"change_message_id":"71fb38ae2fadb3b4a41f13b06e519f3ce30fee39","unresolved":false,"context_lines":[{"line_number":65,"context_line":"              name: container-registry"},{"line_number":66,"context_line":"              tasks_from: docker-distribution"},{"line_number":67,"context_line":"      upgrade_tasks:"},{"line_number":68,"context_line":"        - block: "},{"line_number":69,"context_line":"            - name: Install docker packages on upgrade if missing"},{"line_number":70,"context_line":"              when: step|int \u003d\u003d 3"},{"line_number":71,"context_line":"              package: name\u003ddocker-distribution state\u003dlatest"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_d4b0df8e","line":68,"range":{"start_line":68,"start_character":16,"end_line":68,"end_character":17},"updated":"2018-12-10 14:47:47.000000000","message":"rogue space","commit_id":"331cfb08b78e8c1004fc7e9ab9637882cf11eaaa"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"eecbc8b71e90acf327ab59611115c3a0dc1a210a","unresolved":false,"context_lines":[{"line_number":65,"context_line":"              name: container-registry"},{"line_number":66,"context_line":"              tasks_from: docker-distribution"},{"line_number":67,"context_line":"      upgrade_tasks:"},{"line_number":68,"context_line":"        - block: "},{"line_number":69,"context_line":"            - name: Install docker packages on upgrade if missing"},{"line_number":70,"context_line":"              when: step|int \u003d\u003d 3"},{"line_number":71,"context_line":"              package: name\u003ddocker-distribution state\u003dlatest"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_2cdc5214","line":68,"range":{"start_line":68,"start_character":16,"end_line":68,"end_character":17},"in_reply_to":"3f79a3b5_d4b0df8e","updated":"2018-12-11 14:28:09.000000000","message":"Thanks","commit_id":"331cfb08b78e8c1004fc7e9ab9637882cf11eaaa"}]}