)]}'
{"docker/services/pacemaker/ovn-dbs.yaml":[{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"c40a3c0d4e1e27d8e70dfc6d53c00ffbb60ca7df","unresolved":false,"context_lines":[{"line_number":280,"context_line":"                ovn_dbs_docker_image: {get_param: DockerOvnDbsImage}"},{"line_number":281,"context_line":"                ovn_dbs_docker_image_latest: *ovn_dbs_image_pcmklatest"},{"line_number":282,"context_line":"            - name: set is_bootstrap_node fact"},{"line_number":283,"context_line":"              set_fact: is_bootstrap_node\u003d{{ovn_dbs_short_bootstrap_node_name|lower \u003d\u003d ansible_hostname|lower}}"},{"line_number":284,"context_line":"            - name: Prepare the switch to new ovn-dbs container image name in pacemaker"},{"line_number":285,"context_line":"              when: ovn_dbs_containerized|bool"},{"line_number":286,"context_line":"              block:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ffd0ebdf_fcf7d6d3","line":283,"range":{"start_line":283,"start_character":24,"end_line":283,"end_character":41},"updated":"2019-01-03 12:17:36.000000000","message":"Now that this task won\u0027t be run before each step, we probably need to rename these to include the service name, otherwise the is_bootstrap_node fact will collide between services when they all use the same name. (We could even do the renames first in a separate patch.)","commit_id":"7a2eddff28fb10c19c0f1d228917b4aaa69e3ada"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"2e1978fbc30a88f22fe0a6b88d40b5694179478b","unresolved":false,"context_lines":[{"line_number":280,"context_line":"                ovn_dbs_docker_image: {get_param: DockerOvnDbsImage}"},{"line_number":281,"context_line":"                ovn_dbs_docker_image_latest: *ovn_dbs_image_pcmklatest"},{"line_number":282,"context_line":"            - name: set is_bootstrap_node fact"},{"line_number":283,"context_line":"              set_fact: is_bootstrap_node\u003d{{ovn_dbs_short_bootstrap_node_name|lower \u003d\u003d ansible_hostname|lower}}"},{"line_number":284,"context_line":"            - name: Prepare the switch to new ovn-dbs container image name in pacemaker"},{"line_number":285,"context_line":"              when: ovn_dbs_containerized|bool"},{"line_number":286,"context_line":"              block:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ffd0ebdf_54ed80ed","line":283,"range":{"start_line":283,"start_character":24,"end_line":283,"end_character":41},"in_reply_to":"ffd0ebdf_dc7c52b7","updated":"2019-01-04 14:55:39.000000000","message":"https://review.openstack.org/#/c/628171/","commit_id":"7a2eddff28fb10c19c0f1d228917b4aaa69e3ada"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"7bae9e74217b0d5ed9eb3a85161da633486ff2e9","unresolved":false,"context_lines":[{"line_number":280,"context_line":"                ovn_dbs_docker_image: {get_param: DockerOvnDbsImage}"},{"line_number":281,"context_line":"                ovn_dbs_docker_image_latest: *ovn_dbs_image_pcmklatest"},{"line_number":282,"context_line":"            - name: set is_bootstrap_node fact"},{"line_number":283,"context_line":"              set_fact: is_bootstrap_node\u003d{{ovn_dbs_short_bootstrap_node_name|lower \u003d\u003d ansible_hostname|lower}}"},{"line_number":284,"context_line":"            - name: Prepare the switch to new ovn-dbs container image name in pacemaker"},{"line_number":285,"context_line":"              when: ovn_dbs_containerized|bool"},{"line_number":286,"context_line":"              block:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ffd0ebdf_dc7c52b7","line":283,"range":{"start_line":283,"start_character":24,"end_line":283,"end_character":41},"in_reply_to":"ffd0ebdf_fcf7d6d3","updated":"2019-01-03 12:53:29.000000000","message":"Agreed with Jose that i\u0027ll look into this, i\u0027ll -1 this patch until then.","commit_id":"7a2eddff28fb10c19c0f1d228917b4aaa69e3ada"}],"docker/services/pacemaker/rabbitmq.yaml":[{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"5a2f8b0ae1648a39f037db41ce0b8d7411b9a1c5","unresolved":false,"context_lines":[{"line_number":318,"context_line":"              block:"},{"line_number":319,"context_line":"                - name: Get rabbitmq image id currently used by pacemaker"},{"line_number":320,"context_line":"                  shell: \"{{container_cli}} images | awk \u0027/rabbitmq.* pcmklatest/{print $3}\u0027 | uniq\""},{"line_number":321,"context_line":"                  register: rabbitmq_current_pcmklatest_id"},{"line_number":322,"context_line":"                - name: Temporarily tag the current rabbitmq image id with the upgraded image name"},{"line_number":323,"context_line":"                  import_role:"},{"line_number":324,"context_line":"                    name: tripleo-container-tag"},{"line_number":325,"context_line":"                  vars:"},{"line_number":326,"context_line":"                    container_image: \"{{rabbitmq_current_pcmklatest_id.stdout}}\""},{"line_number":327,"context_line":"                    container_image_latest: \"{{rabbitmq_docker_image_latest}}\""},{"line_number":328,"context_line":"                  when: rabbitmq_current_pcmklatest_id.stdout !\u003d \u0027\u0027"},{"line_number":329,"context_line":"        - when: step|int \u003d\u003d 1"},{"line_number":330,"context_line":"          block:"},{"line_number":331,"context_line":"            # NON-CONTAINERIZED"},{"line_number":332,"context_line":"            - name: Rabbitmq baremetal to container upgrade tasks"},{"line_number":333,"context_line":"              when: not rabbit_containerized|bool"},{"line_number":334,"context_line":"              block:"},{"line_number":335,"context_line":"                - name: Check cluster resource status of rabbitmq"},{"line_number":336,"context_line":"                  pacemaker_resource:"},{"line_number":337,"context_line":"                    resource: {get_attr: [RabbitmqBase, role_data, service_name]}"},{"line_number":338,"context_line":"                    check_mode: false"},{"line_number":339,"context_line":"                    state: show"},{"line_number":340,"context_line":"                  ignore_errors: true"},{"line_number":341,"context_line":"                  register: rabbitmq_res"},{"line_number":342,"context_line":"                - when:"},{"line_number":343,"context_line":"                    - is_rabbitmq_bootstrap_node"},{"line_number":344,"context_line":"                    - rabbitmq_res|succeeded"},{"line_number":345,"context_line":"                  block:"},{"line_number":346,"context_line":"                    - name: Disable the rabbitmq cluster resource."},{"line_number":347,"context_line":"                      pacemaker_resource:"},{"line_number":348,"context_line":"                        resource: {get_attr: [RabbitmqBase, role_data, service_name]}"},{"line_number":349,"context_line":"                        state: disable"},{"line_number":350,"context_line":"                        wait_for_resource: true"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"dfd5e7cf_d4993779","line":347,"range":{"start_line":321,"start_character":4,"end_line":347,"end_character":41},"updated":"2019-01-10 13:21:12.000000000","message":"I think we will need really good reviews from pidone, getting regressions from this kind of changes seems pretty much easy IMHO.","commit_id":"f7fd27fc8b25720c9ce2ba67250a3f76c990be2d"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"69db9997cefd70babd0e86fa42c4cf8815044bb3","unresolved":false,"context_lines":[{"line_number":318,"context_line":"              block:"},{"line_number":319,"context_line":"                - name: Get rabbitmq image id currently used by pacemaker"},{"line_number":320,"context_line":"                  shell: \"{{container_cli}} images | awk \u0027/rabbitmq.* pcmklatest/{print $3}\u0027 | uniq\""},{"line_number":321,"context_line":"                  register: rabbitmq_current_pcmklatest_id"},{"line_number":322,"context_line":"                - name: Temporarily tag the current rabbitmq image id with the upgraded image name"},{"line_number":323,"context_line":"                  import_role:"},{"line_number":324,"context_line":"                    name: tripleo-container-tag"},{"line_number":325,"context_line":"                  vars:"},{"line_number":326,"context_line":"                    container_image: \"{{rabbitmq_current_pcmklatest_id.stdout}}\""},{"line_number":327,"context_line":"                    container_image_latest: \"{{rabbitmq_docker_image_latest}}\""},{"line_number":328,"context_line":"                  when: rabbitmq_current_pcmklatest_id.stdout !\u003d \u0027\u0027"},{"line_number":329,"context_line":"        - when: step|int \u003d\u003d 1"},{"line_number":330,"context_line":"          block:"},{"line_number":331,"context_line":"            # NON-CONTAINERIZED"},{"line_number":332,"context_line":"            - name: Rabbitmq baremetal to container upgrade tasks"},{"line_number":333,"context_line":"              when: not rabbit_containerized|bool"},{"line_number":334,"context_line":"              block:"},{"line_number":335,"context_line":"                - name: Check cluster resource status of rabbitmq"},{"line_number":336,"context_line":"                  pacemaker_resource:"},{"line_number":337,"context_line":"                    resource: {get_attr: [RabbitmqBase, role_data, service_name]}"},{"line_number":338,"context_line":"                    check_mode: false"},{"line_number":339,"context_line":"                    state: show"},{"line_number":340,"context_line":"                  ignore_errors: true"},{"line_number":341,"context_line":"                  register: rabbitmq_res"},{"line_number":342,"context_line":"                - when:"},{"line_number":343,"context_line":"                    - is_rabbitmq_bootstrap_node"},{"line_number":344,"context_line":"                    - rabbitmq_res|succeeded"},{"line_number":345,"context_line":"                  block:"},{"line_number":346,"context_line":"                    - name: Disable the rabbitmq cluster resource."},{"line_number":347,"context_line":"                      pacemaker_resource:"},{"line_number":348,"context_line":"                        resource: {get_attr: [RabbitmqBase, role_data, service_name]}"},{"line_number":349,"context_line":"                        state: disable"},{"line_number":350,"context_line":"                        wait_for_resource: true"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bfdaf3ff_b12f28f5","line":347,"range":{"start_line":321,"start_character":4,"end_line":347,"end_character":41},"in_reply_to":"dfd5e7cf_d4993779","updated":"2019-01-11 15:40:18.000000000","message":"should I split it into pacemaker services and the rest?","commit_id":"f7fd27fc8b25720c9ce2ba67250a3f76c990be2d"}]}