)]}'
{"deployment/rabbitmq/rabbitmq-container-puppet.yaml":[{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"4cac344b09b27012592fe9d2f634f5dc4915ea3e","unresolved":false,"context_lines":[{"line_number":204,"context_line":"            rabbitmq::use_config_file_for_plugins: true"},{"line_number":205,"context_line":"            rabbitmq::management_ssl: {get_param: EnableInternalTLS}"},{"line_number":206,"context_line":"            rabbitmq::ssl_management_port: 15672"},{"line_number":207,"context_line":"            rabbitmq::management_ip_address:"},{"line_number":208,"context_line":"              str_replace:"},{"line_number":209,"context_line":"                template:"},{"line_number":210,"context_line":"                  \"%{hiera(\u0027$NETWORK\u0027)}\""},{"line_number":211,"context_line":"                params:"},{"line_number":212,"context_line":"                  $NETWORK: {get_param: [ServiceNetMap, RabbitmqNetwork]}"},{"line_number":213,"context_line":"          - if:"},{"line_number":214,"context_line":"            - internal_tls_enabled"},{"line_number":215,"context_line":"            - tripleo::certmonger::rabbitmq::postsave_cmd: \"true\" # TODO: restart the rabbitmq container here"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fdfeff1_be8d297d","line":212,"range":{"start_line":207,"start_character":0,"end_line":212,"end_character":73},"updated":"2019-02-13 06:35:26.000000000","message":"How about we leave this listening on 127.0.0.1 so we have one less security aspect to worry about and you can still use it to add/remove queues?","commit_id":"f64e7ad0b09da43dd2b5e17108611f19aab60bc1"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"4c1419bf361ea6c99d43311caa0e997034efe564","unresolved":false,"context_lines":[{"line_number":204,"context_line":"            rabbitmq::use_config_file_for_plugins: true"},{"line_number":205,"context_line":"            rabbitmq::management_ssl: {get_param: EnableInternalTLS}"},{"line_number":206,"context_line":"            rabbitmq::ssl_management_port: 15672"},{"line_number":207,"context_line":"            rabbitmq::management_ip_address:"},{"line_number":208,"context_line":"              str_replace:"},{"line_number":209,"context_line":"                template:"},{"line_number":210,"context_line":"                  \"%{hiera(\u0027$NETWORK\u0027)}\""},{"line_number":211,"context_line":"                params:"},{"line_number":212,"context_line":"                  $NETWORK: {get_param: [ServiceNetMap, RabbitmqNetwork]}"},{"line_number":213,"context_line":"          - if:"},{"line_number":214,"context_line":"            - internal_tls_enabled"},{"line_number":215,"context_line":"            - tripleo::certmonger::rabbitmq::postsave_cmd: \"true\" # TODO: restart the rabbitmq container here"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fdfeff1_24104c4e","line":212,"range":{"start_line":207,"start_character":0,"end_line":212,"end_character":73},"in_reply_to":"9fdfeff1_be8d297d","updated":"2019-02-13 09:19:12.000000000","message":"yes, that will work.","commit_id":"f64e7ad0b09da43dd2b5e17108611f19aab60bc1"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"4fb3531721cc4c999a24859b65f3957d7492f455","unresolved":false,"context_lines":[{"line_number":199,"context_line":"                postsave_cmd: \"/usr/bin/certmonger-rabbitmq-refresh.sh\""},{"line_number":200,"context_line":"            - {}"},{"line_number":201,"context_line":"          - rabbitmq::admin_enable: false"},{"line_number":202,"context_line":"            rabbitmq::management_enable: true"},{"line_number":203,"context_line":"            rabbitmq::use_config_file_for_plugins: true"},{"line_number":204,"context_line":"            rabbitmq::management_ip_address: 127.0.0.1"},{"line_number":205,"context_line":"          - if:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9fdfeff1_4b00c6ab","line":202,"range":{"start_line":202,"start_character":22,"end_line":202,"end_character":38},"updated":"2019-02-15 13:44:58.000000000","message":"it is also recommended to add\n\nrabbit.collect_statistics_interval\u003d30000\nrabbitmq_management.rates_mode\u003dnone\n\nSee also\nhttps://youtu.be/UAUbkqMKd8s?t\u003d1380\nhttps://www.rabbitmq.com/management.html","commit_id":"1c69070e1fa5c784ea74e9529e9da5d3d7576466"},{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"e9f1cc1090c43b3352e86a926d371283d600f5a5","unresolved":false,"context_lines":[{"line_number":199,"context_line":"                postsave_cmd: \"/usr/bin/certmonger-rabbitmq-refresh.sh\""},{"line_number":200,"context_line":"            - {}"},{"line_number":201,"context_line":"          - rabbitmq::admin_enable: false"},{"line_number":202,"context_line":"            rabbitmq::management_enable: true"},{"line_number":203,"context_line":"            rabbitmq::use_config_file_for_plugins: true"},{"line_number":204,"context_line":"            rabbitmq::management_ip_address: 127.0.0.1"},{"line_number":205,"context_line":"          - if:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9fdfeff1_ab24d20d","line":202,"range":{"start_line":202,"start_character":22,"end_line":202,"end_character":38},"in_reply_to":"9fdfeff1_4b00c6ab","updated":"2019-02-15 13:59:11.000000000","message":"Good idea, since we are mainly using it as a simple API for things it is best if we do not load rabbitmq unnecessarily","commit_id":"1c69070e1fa5c784ea74e9529e9da5d3d7576466"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"641a866878894d0701a38382d8a9a5d070676a51","unresolved":false,"context_lines":[{"line_number":199,"context_line":"                postsave_cmd: \"/usr/bin/certmonger-rabbitmq-refresh.sh\""},{"line_number":200,"context_line":"            - {}"},{"line_number":201,"context_line":"          - rabbitmq::admin_enable: false"},{"line_number":202,"context_line":"            rabbitmq::management_enable: true"},{"line_number":203,"context_line":"            rabbitmq::use_config_file_for_plugins: true"},{"line_number":204,"context_line":"            rabbitmq::management_ip_address: 127.0.0.1"},{"line_number":205,"context_line":"          - if:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9fdfeff1_8199afc4","line":202,"range":{"start_line":202,"start_character":22,"end_line":202,"end_character":38},"in_reply_to":"9fdfeff1_ab24d20d","updated":"2019-02-15 15:02:15.000000000","message":"Done. (Did\u0027nt test this, let\u0027s check CI results for sanity.)","commit_id":"1c69070e1fa5c784ea74e9529e9da5d3d7576466"}]}