)]}'
{"deployment/nova/nova-ironic-container-puppet.yaml":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"72943be43c75c0d2f44dfb764ff00447923de68a","unresolved":false,"context_lines":[{"line_number":47,"context_line":"  IronicApiMaxRetries:"},{"line_number":48,"context_line":"    description: Timeout (seconds) to wait for node serial console state changed. Set to 0 to disable timeout."},{"line_number":49,"context_line":"    type: number"},{"line_number":50,"context_line":"    default: -1"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"conditions:"},{"line_number":53,"context_line":"  ironic_api_max_retry_cond:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7faddb67_0357485a","line":50,"updated":"2019-07-15 12:57:42.000000000","message":"The default is good as it\u0027s not configuring it by default.","commit_id":"95dcd2f0fd3d1f1c1d70556d669e9266e0451ea6"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"aff47954f8af95098b3ca2a203284cabdc5ef8a7","unresolved":false,"context_lines":[{"line_number":47,"context_line":"  IronicApiMaxRetries:"},{"line_number":48,"context_line":"    description: Timeout (seconds) to wait for node serial console state changed. Set to 0 to disable timeout."},{"line_number":49,"context_line":"    type: number"},{"line_number":50,"context_line":"    default: -1"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"conditions:"},{"line_number":53,"context_line":"  ironic_api_max_retry_cond:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7faddb67_6e862316","line":50,"in_reply_to":"7faddb67_0357485a","updated":"2019-07-15 13:39:27.000000000","message":"I\u0027m not sure if you\u0027re just stating the way this patch is done or if there is something required from my side. :) Perhaps I should update the commit message describing explicitly that if the IronicApiMaxRetries parameter is not used in the heat template, then it\u0027s not configured in the config files and it\u0027s up to Ironic to use its default?","commit_id":"95dcd2f0fd3d1f1c1d70556d669e9266e0451ea6"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"5abbcee1e0755d3d79764f9b5e7d07bee68f7744","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    tags:"},{"line_number":52,"context_line":"      - role_specific"},{"line_number":53,"context_line":"  IronicApiMaxRetries:"},{"line_number":54,"context_line":"    description: Timeout (seconds) to wait for node serial console state changed. Set to 0 to disable timeout."},{"line_number":55,"context_line":"    type: number"},{"line_number":56,"context_line":"    default: -1"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"7faddb67_7c275620","line":54,"updated":"2019-08-22 19:04:47.000000000","message":"the description seems wrong here. it\u0027s not a timeout is it?","commit_id":"2a64e9f009fe1981f6a4f6fc3510fe772e308c29"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"18cf0a77b44e02bdb16ab12fc8894cf50b26a510","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    tags:"},{"line_number":52,"context_line":"      - role_specific"},{"line_number":53,"context_line":"  IronicApiMaxRetries:"},{"line_number":54,"context_line":"    description: Timeout (seconds) to wait for node serial console state changed. Set to 0 to disable timeout."},{"line_number":55,"context_line":"    type: number"},{"line_number":56,"context_line":"    default: -1"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"7faddb67_c9f9df4e","line":54,"in_reply_to":"7faddb67_7c275620","updated":"2019-08-23 08:15:51.000000000","message":"Right! I don\u0027t know what was I thinking, lol. Thanks :)","commit_id":"2a64e9f009fe1981f6a4f6fc3510fe772e308c29"}],"environments/services/neutron-ml2-ansible.yaml":[{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"905f000da9271913001fc690207577b0b58a3d24","unresolved":false,"context_lines":[{"line_number":4,"context_line":"parameter_defaults:"},{"line_number":5,"context_line":"  IronicApiMaxRetries: 180"},{"line_number":6,"context_line":"  IronicDefaultNetworkInterface: neutron"},{"line_number":7,"context_line":"  NeutronMechanismDrivers: openvswitch,ansible"},{"line_number":8,"context_line":"  NeutronTypeDrivers: local,vxlan,vlan,flat"},{"line_number":9,"context_line":"  NeutronNetworkType: vlan"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9fdfeff1_f31fc3b4","line":7,"range":{"start_line":7,"start_character":2,"end_line":7,"end_character":25},"updated":"2019-02-21 13:06:10.000000000","message":"TripleO defaults now to \u0027ovn\u0027 so if you want to use openvswitch mech driver you need to define all the ML2/OVS services. Otherwise:\n\nNeutronMechanismDrivers: ovn,ansible","commit_id":"db13fba4a9f3137e385b8a70285f76a9779ad74a"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"250a315892b722aa289f1744835f1cbf7a4bbb73","unresolved":false,"context_lines":[{"line_number":4,"context_line":"parameter_defaults:"},{"line_number":5,"context_line":"  IronicApiMaxRetries: 180"},{"line_number":6,"context_line":"  IronicDefaultNetworkInterface: neutron"},{"line_number":7,"context_line":"  NeutronMechanismDrivers: openvswitch,ansible"},{"line_number":8,"context_line":"  NeutronTypeDrivers: local,vxlan,vlan,flat"},{"line_number":9,"context_line":"  NeutronNetworkType: vlan"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9fdfeff1_f3058315","line":7,"range":{"start_line":7,"start_character":2,"end_line":7,"end_character":25},"in_reply_to":"9fdfeff1_f31fc3b4","updated":"2019-02-21 13:17:48.000000000","message":"Thanks Daniel for pointing that out. I sent another review for this specific case: https://review.openstack.org/#/c/638416/","commit_id":"db13fba4a9f3137e385b8a70285f76a9779ad74a"}]}