)]}'
{"deployment/database/mysql-pacemaker-puppet.yaml":[{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"803a0086461b502399b10bf8df422ebf32adc567","unresolved":false,"context_lines":[{"line_number":414,"context_line":"          block:"},{"line_number":415,"context_line":"            - name: get the mysql host(s) from the limit option"},{"line_number":416,"context_line":"              set_fact:"},{"line_number":417,"context_line":"                mysql_node_upgraded: \"{{ mysql_node_upgraded|default([]) + [item.split(\u0027.\u0027)[0]] }}\""},{"line_number":418,"context_line":"                cacheable: no"},{"line_number":419,"context_line":"              when: item.split(\u0027.\u0027)[0] in ansible_limit.split(\u0027,\u0027)"},{"line_number":420,"context_line":"              with_list: \"{{ mysql_node_names }}\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5fc1f717_c551f937","line":417,"updated":"2019-03-18 07:49:20.000000000","message":"You missed the changes made in patchset 14 - 15 : https://review.openstack.org/#/c/631483/14..16/deployment/database/mysql-pacemaker-puppet.yaml , as otherwise you will have a list of lists in mysql_short_node_names_override:\n\n \"mysql_short_node_names_override\": [\n        [\n            \"overcloud-controller-0.internalapi.localdomain\"\n        ]\n    ],","commit_id":"aa605b469691f1f9fb9a38ebbb041d5edf5cd893"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"020d6e9f3778fac7b79e99d3d9c6a6c5c2ea37bc","unresolved":false,"context_lines":[{"line_number":414,"context_line":"          block:"},{"line_number":415,"context_line":"            - name: get the mysql host(s) from the limit option"},{"line_number":416,"context_line":"              set_fact:"},{"line_number":417,"context_line":"                mysql_node_upgraded: \"{{ mysql_node_upgraded|default([]) + [item.split(\u0027.\u0027)[0]] }}\""},{"line_number":418,"context_line":"                cacheable: no"},{"line_number":419,"context_line":"              when: item.split(\u0027.\u0027)[0] in ansible_limit.split(\u0027,\u0027)"},{"line_number":420,"context_line":"              with_list: \"{{ mysql_node_names }}\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5fc1f717_c16b2082","line":417,"in_reply_to":"5fc1f717_c551f937","updated":"2019-03-18 16:18:57.000000000","message":"Ok, you can dismiss my comment, I can see the code is different. You take the first element from the output and I checked the value applying this patch and the format is correct. Sorry for the noise.","commit_id":"aa605b469691f1f9fb9a38ebbb041d5edf5cd893"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"d50d4f56b12c3eb2d0c671ea28710ea1da165251","unresolved":false,"context_lines":[{"line_number":439,"context_line":"              set_fact:"},{"line_number":440,"context_line":"                internal_api_hosts: \"{{ internal_api_hosts|default([]) + [item] }}\""},{"line_number":441,"context_line":"                cacheable: no"},{"line_number":442,"context_line":"              when: item.split(\u0027.\u0027)[0] in upgraded_controllers"},{"line_number":443,"context_line":"              with_list: \"{{ mysql_node_names }}\""},{"line_number":444,"context_line":""},{"line_number":445,"context_line":"            - name: add the mysql short name to hiera data for the upgrade."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"bfb3d3c7_16792bfb","line":442,"updated":"2019-05-21 09:39:29.000000000","message":"it looks like upgraded_controllers isn\u0027t defined at this point: http://logs.openstack.org/56/643056/12/check/tripleo-ci-centos-7-scenario000-multinode-oooq-container-upgrades/4809f14/logs/undercloud/home/zuul/overcloud_upgrade_run_Controller.log.txt.gz#_2019-05-20_14_39_37","commit_id":"2bdeba3bb808dc451312028ad1acae5a80801233"}],"deployment/haproxy/haproxy-pacemaker-puppet.yaml":[{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"314d771ee52c260c0152ad60a7ce7b3aae12775e","unresolved":false,"context_lines":[{"line_number":476,"context_line":"            - name: Set HAProxy upgrade facts"},{"line_number":477,"context_line":"              block: *haproxy_update_upgrade_facts"},{"line_number":478,"context_line":"            - name: Prepare the switch to new haproxy container image name in pacemaker"},{"line_number":479,"context_line":"              block:"},{"line_number":480,"context_line":"                - name: Get haproxy image id currently used by pacemaker"},{"line_number":481,"context_line":"                  shell: \"{{container_cli}} images | awk \u0027/haproxy.* pcmklatest/{print $3}\u0027 | uniq\""},{"line_number":482,"context_line":"                  register: haproxy_current_pcmklatest_id"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5fc1f717_9844cb75","line":479,"updated":"2019-03-15 17:48:58.000000000","message":"I\u0027ll re-add the non-containerized tasks and removed them all for all services in a \"on-top\" patch. This way we don\u0027t mix up different things.","commit_id":"2a277a4ece82880da624cf91afce4b54daeea9b1"}],"deployment/tripleo-packages/tripleo-packages-baremetal-puppet.yaml":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"691c21c14baaeff94b3a0df3958ace38963bc6d2","unresolved":false,"context_lines":[{"line_number":299,"context_line":"        - name: Install libibverbs (https://bugs.launchpad.net/tripleo/+bug/1817743)"},{"line_number":300,"context_line":"          when: step|int \u003d\u003d 2"},{"line_number":301,"context_line":"          package:"},{"line_number":302,"context_line":"            name: libibverbs"},{"line_number":303,"context_line":"            state: installed"},{"line_number":304,"context_line":"        # The openvswitch package disables the systemd service on install. When installing"},{"line_number":305,"context_line":"        # the layered product we prevent the service from being killed, but it doesn\u0027t"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"9fb8cfa7_1477b9a2","line":302,"updated":"2019-06-06 21:04:15.000000000","message":"can we just make this a dependency since not having it makes ovs commands very unhappy?","commit_id":"04502e9b44dfbaf856210c3f865f9940c34fe86f"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"973b8675d3c07edde7f9940fd3df1e3dd1c490bc","unresolved":false,"context_lines":[{"line_number":299,"context_line":"        - name: Install libibverbs (https://bugs.launchpad.net/tripleo/+bug/1817743)"},{"line_number":300,"context_line":"          when: step|int \u003d\u003d 2"},{"line_number":301,"context_line":"          package:"},{"line_number":302,"context_line":"            name: libibverbs"},{"line_number":303,"context_line":"            state: installed"},{"line_number":304,"context_line":"        # The openvswitch package disables the systemd service on install. When installing"},{"line_number":305,"context_line":"        # the layered product we prevent the service from being killed, but it doesn\u0027t"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"9fb8cfa7_518d3679","line":302,"in_reply_to":"9fb8cfa7_00644e21","updated":"2019-06-07 13:59:03.000000000","message":"IMHO I disagree because the giant warnings are obnoxious for the end user and makes them think something is seriously wrong. I won\u0027t block this but I think the package should pull it in unless there\u0027s a specific reason not to (like it breaks something). The warnings IMHO make it not an optional dependency.","commit_id":"04502e9b44dfbaf856210c3f865f9940c34fe86f"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"a27956dcf9100380569542db935b340a0f0c3165","unresolved":false,"context_lines":[{"line_number":299,"context_line":"        - name: Install libibverbs (https://bugs.launchpad.net/tripleo/+bug/1817743)"},{"line_number":300,"context_line":"          when: step|int \u003d\u003d 2"},{"line_number":301,"context_line":"          package:"},{"line_number":302,"context_line":"            name: libibverbs"},{"line_number":303,"context_line":"            state: installed"},{"line_number":304,"context_line":"        # The openvswitch package disables the systemd service on install. When installing"},{"line_number":305,"context_line":"        # the layered product we prevent the service from being killed, but it doesn\u0027t"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"9fb8cfa7_00644e21","line":302,"in_reply_to":"9fb8cfa7_1477b9a2","updated":"2019-06-07 12:16:03.000000000","message":"I read this: https://bugzilla.redhat.com/show_bug.cgi?id\u003d1658141\n\nAnd basically the way i understand it is:\n\n* We don\u0027t want to make it a dependency because it\u0027s only needed for a minority of use cases. The warnings should be harmless.\n\n* When Puppet comes into the mix, the warnings are no longer harmless because they break parsing in some resource provider. (It did break upgrade in my testing.)\n\nSo for now, to me it still seems like the best solution is probably just installing libibverbs in t-h-t?","commit_id":"04502e9b44dfbaf856210c3f865f9940c34fe86f"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"66d3e60b487992e51c7aa3c3602ea11d81aa6968","unresolved":false,"context_lines":[{"line_number":299,"context_line":"        - name: Install libibverbs (https://bugs.launchpad.net/tripleo/+bug/1817743)"},{"line_number":300,"context_line":"          when: step|int \u003d\u003d 2"},{"line_number":301,"context_line":"          package:"},{"line_number":302,"context_line":"            name: libibverbs"},{"line_number":303,"context_line":"            state: installed"},{"line_number":304,"context_line":"        # The openvswitch package disables the systemd service on install. When installing"},{"line_number":305,"context_line":"        # the layered product we prevent the service from being killed, but it doesn\u0027t"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"9fb8cfa7_cc5d0dea","line":302,"in_reply_to":"9fb8cfa7_518d3679","updated":"2019-06-07 14:33:33.000000000","message":"Yea that\u0027s a fair point. I updated the BZ with info that it\u0027s affecting OpenStack upgrade, and a link to this discussion.","commit_id":"04502e9b44dfbaf856210c3f865f9940c34fe86f"}]}