)]}'
{"deployment/nova/nova-compute-container-puppet.yaml":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"1d03476590ea339de21b2515c45d42ce52844b9d","unresolved":false,"context_lines":[{"line_number":772,"context_line":"          tags: down"},{"line_number":773,"context_line":"          delegate_to: localhost"},{"line_number":774,"context_line":"          environment:"},{"line_number":775,"context_line":"            OS_AUTH_TYPE: password"},{"line_number":776,"context_line":"            OS_AUTH_URL: {{ overcloud_keystone_url }}"},{"line_number":777,"context_line":"            OS_PASSWORD: {{ overcloud_admin_password }}"},{"line_number":778,"context_line":"            OS_PROJECT: admin"},{"line_number":779,"context_line":"            OS_USERNAME: admin"},{"line_number":780,"context_line":"          block:"},{"line_number":781,"context_line":"            - name: Get nova-compute service ID"},{"line_number":782,"context_line":"              command: openstack compute service list --service nova-compute --host {{ hostname }} | grep {{ hostname }} | awk \u0027{print $2}\u0027"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fce034c_648bb56d","line":779,"range":{"start_line":775,"start_character":0,"end_line":779,"end_character":30},"updated":"2019-04-19 01:51:57.000000000","message":"I wonder if we can have something like \"use_openstack_credentials\" in tripleo-common but for the overcloud, loading credentials here isn\u0027t what I like ...","commit_id":"41d664664e10b779c2dc0fff5d5fe6b314d1d319"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"616db1a991e0c63e848b2225c2931d7709fa52e1","unresolved":false,"context_lines":[{"line_number":795,"context_line":"                nova_compute_service_id: \"{{ nova_compute_service_result.stdout }}\""},{"line_number":796,"context_line":"            - name: Disable nova-compute service"},{"line_number":797,"context_line":"              command: openstack compute service set {{ ansible_fqdn }} nova-compute --disable"},{"line_number":798,"context_line":"            - name: Delete nova-compute service"},{"line_number":799,"context_line":"              command: openstack compute service delete {{ nova_compute_service_id }}"},{"line_number":800,"context_line":"        - name: Stop nova-compute container healthcheck"},{"line_number":801,"context_line":"          service:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ffb9cba7_5a891373","line":798,"range":{"start_line":798,"start_character":20,"end_line":798,"end_character":47},"updated":"2019-04-23 13:59:44.000000000","message":"probably should stop nova-compute container before this","commit_id":"31d6453b23933ec0d9bb1083e09bc3643d3606e9"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"1b074f4e2628ec061d8a545b2ee83cfcfb273e9a","unresolved":false,"context_lines":[{"line_number":795,"context_line":"                nova_compute_service_id: \"{{ nova_compute_service_result.stdout }}\""},{"line_number":796,"context_line":"            - name: Disable nova-compute service"},{"line_number":797,"context_line":"              command: openstack compute service set {{ ansible_fqdn }} nova-compute --disable"},{"line_number":798,"context_line":"            - name: Delete nova-compute service"},{"line_number":799,"context_line":"              command: openstack compute service delete {{ nova_compute_service_id }}"},{"line_number":800,"context_line":"        - name: Stop nova-compute container healthcheck"},{"line_number":801,"context_line":"          service:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ffb9cba7_e3aa9e83","line":798,"range":{"start_line":798,"start_character":20,"end_line":798,"end_character":47},"in_reply_to":"ffb9cba7_03f812e3","updated":"2019-04-23 16:07:13.000000000","message":"... but still disable the service before stopping nova-compute, so split this block up","commit_id":"31d6453b23933ec0d9bb1083e09bc3643d3606e9"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"445d41c86d064a93f2d61dfaf0c71660781fd561","unresolved":false,"context_lines":[{"line_number":795,"context_line":"                nova_compute_service_id: \"{{ nova_compute_service_result.stdout }}\""},{"line_number":796,"context_line":"            - name: Disable nova-compute service"},{"line_number":797,"context_line":"              command: openstack compute service set {{ ansible_fqdn }} nova-compute --disable"},{"line_number":798,"context_line":"            - name: Delete nova-compute service"},{"line_number":799,"context_line":"              command: openstack compute service delete {{ nova_compute_service_id }}"},{"line_number":800,"context_line":"        - name: Stop nova-compute container healthcheck"},{"line_number":801,"context_line":"          service:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ffb9cba7_03f812e3","line":798,"range":{"start_line":798,"start_character":20,"end_line":798,"end_character":47},"in_reply_to":"ffb9cba7_5a891373","updated":"2019-04-23 15:54:06.000000000","message":"Done","commit_id":"31d6453b23933ec0d9bb1083e09bc3643d3606e9"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"aa3fd51db1dfb3221f176d3d4fe4bfab80798073","unresolved":false,"context_lines":[{"line_number":802,"context_line":"            name: tripleo_nova_compute_healthcheck"},{"line_number":803,"context_line":"            state: stopped"},{"line_number":804,"context_line":"            enabled: no"},{"line_number":805,"context_line":"          when: step|int \u003d\u003d 1"},{"line_number":806,"context_line":"        - name: Stop nova-compute container"},{"line_number":807,"context_line":"          service:"},{"line_number":808,"context_line":"            name: tripleo_nova_compute"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ffb9cba7_17b054f4","line":805,"updated":"2019-04-23 13:48:57.000000000","message":"missing down tag?","commit_id":"31d6453b23933ec0d9bb1083e09bc3643d3606e9"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"445d41c86d064a93f2d61dfaf0c71660781fd561","unresolved":false,"context_lines":[{"line_number":802,"context_line":"            name: tripleo_nova_compute_healthcheck"},{"line_number":803,"context_line":"            state: stopped"},{"line_number":804,"context_line":"            enabled: no"},{"line_number":805,"context_line":"          when: step|int \u003d\u003d 1"},{"line_number":806,"context_line":"        - name: Stop nova-compute container"},{"line_number":807,"context_line":"          service:"},{"line_number":808,"context_line":"            name: tripleo_nova_compute"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ffb9cba7_e3f29e06","line":805,"in_reply_to":"ffb9cba7_17b054f4","updated":"2019-04-23 15:54:06.000000000","message":"Done","commit_id":"31d6453b23933ec0d9bb1083e09bc3643d3606e9"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"aa3fd51db1dfb3221f176d3d4fe4bfab80798073","unresolved":false,"context_lines":[{"line_number":808,"context_line":"            name: tripleo_nova_compute"},{"line_number":809,"context_line":"            state: stopped"},{"line_number":810,"context_line":"            enabled: no"},{"line_number":811,"context_line":"          when: step|int \u003d\u003d 1"},{"line_number":812,"context_line":"      fast_forward_upgrade_tasks:"},{"line_number":813,"context_line":"        - when:"},{"line_number":814,"context_line":"            - step|int \u003d\u003d 0"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ffb9cba7_b7a2a899","line":811,"updated":"2019-04-23 13:48:57.000000000","message":"missing down tag?","commit_id":"31d6453b23933ec0d9bb1083e09bc3643d3606e9"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"445d41c86d064a93f2d61dfaf0c71660781fd561","unresolved":false,"context_lines":[{"line_number":808,"context_line":"            name: tripleo_nova_compute"},{"line_number":809,"context_line":"            state: stopped"},{"line_number":810,"context_line":"            enabled: no"},{"line_number":811,"context_line":"          when: step|int \u003d\u003d 1"},{"line_number":812,"context_line":"      fast_forward_upgrade_tasks:"},{"line_number":813,"context_line":"        - when:"},{"line_number":814,"context_line":"            - step|int \u003d\u003d 0"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ffb9cba7_a3dca674","line":811,"in_reply_to":"ffb9cba7_b7a2a899","updated":"2019-04-23 15:54:06.000000000","message":"Done","commit_id":"31d6453b23933ec0d9bb1083e09bc3643d3606e9"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"46fca6fa126d1bac3a0811c5aba90879c5119f6a","unresolved":false,"context_lines":[{"line_number":806,"context_line":"            # Some tasks are running from the Undercloud which has"},{"line_number":807,"context_line":"            # the OpenStack clients installed."},{"line_number":808,"context_line":"            - name: Get nova-compute service ID"},{"line_number":809,"context_line":"              shell: openstack compute service list --service nova-compute --host {{ ansible_fqdn }} | grep {{ ansible_fqdn }} | awk \u0027{print $2}\u0027"},{"line_number":810,"context_line":"              register: nova_compute_service_result"},{"line_number":811,"context_line":"              delegate_to: localhost"},{"line_number":812,"context_line":"            - name: Set fact nova_compute_service_id"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"ffb9cba7_e3d33b37","line":809,"updated":"2019-04-26 14:36:31.000000000","message":"what about the check mode for these?","commit_id":"fba7cb877bb383808d800ec396075d2269febf47"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"13b58310e1a4bcef8d54d5487b84fc289daebfb4","unresolved":false,"context_lines":[{"line_number":806,"context_line":"            # Some tasks are running from the Undercloud which has"},{"line_number":807,"context_line":"            # the OpenStack clients installed."},{"line_number":808,"context_line":"            - name: Get nova-compute service ID"},{"line_number":809,"context_line":"              shell: openstack compute service list --service nova-compute --host {{ ansible_fqdn }} | grep {{ ansible_fqdn }} | awk \u0027{print $2}\u0027"},{"line_number":810,"context_line":"              register: nova_compute_service_result"},{"line_number":811,"context_line":"              delegate_to: localhost"},{"line_number":812,"context_line":"            - name: Set fact nova_compute_service_id"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"dfbec78f_ba6cd908","line":809,"in_reply_to":"ffb9cba7_0393ef50","updated":"2019-05-05 14:23:54.000000000","message":"Done","commit_id":"fba7cb877bb383808d800ec396075d2269febf47"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"13b58310e1a4bcef8d54d5487b84fc289daebfb4","unresolved":false,"context_lines":[{"line_number":806,"context_line":"            # Some tasks are running from the Undercloud which has"},{"line_number":807,"context_line":"            # the OpenStack clients installed."},{"line_number":808,"context_line":"            - name: Get nova-compute service ID"},{"line_number":809,"context_line":"              shell: openstack compute service list --service nova-compute --host {{ ansible_fqdn }} | grep {{ ansible_fqdn }} | awk \u0027{print $2}\u0027"},{"line_number":810,"context_line":"              register: nova_compute_service_result"},{"line_number":811,"context_line":"              delegate_to: localhost"},{"line_number":812,"context_line":"            - name: Set fact nova_compute_service_id"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"dfbec78f_fa625116","line":809,"in_reply_to":"ffb9cba7_e3d33b37","updated":"2019-05-05 14:23:54.000000000","message":"\u003e what about the check mode for these?\n\nnice shot.","commit_id":"fba7cb877bb383808d800ec396075d2269febf47"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"641aea3e596e2addd5b45b391cb883e475cdcb04","unresolved":false,"context_lines":[{"line_number":806,"context_line":"            # Some tasks are running from the Undercloud which has"},{"line_number":807,"context_line":"            # the OpenStack clients installed."},{"line_number":808,"context_line":"            - name: Get nova-compute service ID"},{"line_number":809,"context_line":"              shell: openstack compute service list --service nova-compute --host {{ ansible_fqdn }} | grep {{ ansible_fqdn }} | awk \u0027{print $2}\u0027"},{"line_number":810,"context_line":"              register: nova_compute_service_result"},{"line_number":811,"context_line":"              delegate_to: localhost"},{"line_number":812,"context_line":"            - name: Set fact nova_compute_service_id"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"ffb9cba7_0393ef50","line":809,"in_reply_to":"ffb9cba7_e3d33b37","updated":"2019-04-26 14:45:12.000000000","message":"we could also get the id with \"openstack compute service list --service nova-compute --host {{ ansible_fqdn }} --column ID --format value\" instead of the pipes","commit_id":"fba7cb877bb383808d800ec396075d2269febf47"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"bb3116a806448351858adb9ee6ba1338797b2c7a","unresolved":false,"context_lines":[{"line_number":865,"context_line":"              check_mode: no"},{"line_number":866,"context_line":"            - name: Set fact nova_compute_service_id"},{"line_number":867,"context_line":"              set_fact:"},{"line_number":868,"context_line":"                nova_compute_service_id: \"{{ nova_compute_service_result.stdout }}\""},{"line_number":869,"context_line":"              delegate_to: localhost"},{"line_number":870,"context_line":"              check_mode: no"},{"line_number":871,"context_line":"            - name: Disable nova-compute service"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"dfbec78f_6dbf7bfb","line":868,"updated":"2019-05-06 20:12:49.000000000","message":"does this work when you scale down multiple nodes at once? where does the fact get set in that case, especially since it is delegated to localhost? It seems like there would be a conflict.","commit_id":"d1b187a56a1eeec0f6d6104acf5ca0d43959a689"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"a1a42e3a99d4fe2cdfae717fa0a6504e15461469","unresolved":false,"context_lines":[{"line_number":865,"context_line":"              check_mode: no"},{"line_number":866,"context_line":"            - name: Set fact nova_compute_service_id"},{"line_number":867,"context_line":"              set_fact:"},{"line_number":868,"context_line":"                nova_compute_service_id: \"{{ nova_compute_service_result.stdout }}\""},{"line_number":869,"context_line":"              delegate_to: localhost"},{"line_number":870,"context_line":"              check_mode: no"},{"line_number":871,"context_line":"            - name: Disable nova-compute service"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"dfbec78f_957675d8","line":868,"in_reply_to":"dfbec78f_6dbf7bfb","updated":"2019-05-07 07:46:54.000000000","message":"I just tested again to scale down 2 compute nodes at the same time:\n\nhttps://asciinema.org/a/VwGsHcHDDSNREumlRMowELfaD\n\nThe playbook runs these for each host part of limit-host from the mistral workbook, which is in the inventory so I think this is good.\nAlso in the demo, you can see the 2 computes being disabled and the hypervisor removed.","commit_id":"d1b187a56a1eeec0f6d6104acf5ca0d43959a689"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"5418910d157e068e49bcd43ae1897e8322186060","unresolved":false,"context_lines":[{"line_number":865,"context_line":"              check_mode: no"},{"line_number":866,"context_line":"            - name: Set fact nova_compute_service_id"},{"line_number":867,"context_line":"              set_fact:"},{"line_number":868,"context_line":"                nova_compute_service_id: \"{{ nova_compute_service_result.stdout }}\""},{"line_number":869,"context_line":"              delegate_to: localhost"},{"line_number":870,"context_line":"              check_mode: no"},{"line_number":871,"context_line":"            - name: Disable nova-compute service"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"dfbec78f_79c14e2e","line":868,"in_reply_to":"dfbec78f_957675d8","updated":"2019-05-09 14:56:38.000000000","message":"ok, if you say it works.","commit_id":"d1b187a56a1eeec0f6d6104acf5ca0d43959a689"}]}