)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"b732cbc72e5a309a423235d1b2b94cd7e47fc5e6","unresolved":false,"context_lines":[{"line_number":25,"context_line":"continue to exist on the filesystem. Since that directory is"},{"line_number":26,"context_line":"now being fully removed there is nothing to clean."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Also, add become to removal task so we do not introduce"},{"line_number":29,"context_line":"bug 1827273."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Change-Id: I7a01146a135254ccb948b8e793859f8fa3bdc690"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"dfbec78f_e64bb7ad","line":28,"updated":"2019-05-03 08:28:26.000000000","message":"mistral user doesn\u0027t have sudo though [1], we probably don\u0027t want the additional patch in rocky because the playbook is executed within the -executor container\n\n1. http://logs.openstack.org/16/656416/3/check/tripleo-ci-centos-7-scenario004-multinode-oooq-container/53d3cf5/logs/undercloud/home/zuul/overcloud_deploy.log.txt.gz#_2019-05-02_21_57_58","commit_id":"0294f77f2309f42024bb7b8abe1e858ba93c1524"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"0481fedc733863603f5bb1e8c6a21c98fa2d748d","unresolved":false,"context_lines":[{"line_number":25,"context_line":"continue to exist on the filesystem. Since that directory is"},{"line_number":26,"context_line":"now being fully removed there is nothing to clean."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Also, add become to removal task so we do not introduce"},{"line_number":29,"context_line":"bug 1827273."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Change-Id: I7a01146a135254ccb948b8e793859f8fa3bdc690"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"dfbec78f_7d88b11e","line":28,"in_reply_to":"dfbec78f_d7be5efe","updated":"2019-05-03 16:46:22.000000000","message":"we\u0027ll have to check what is happening then because in CI they all seem to be owned by mistral [1] ... not sure if ceph-ansible itself needs sudo credentials only on the target nodes or also on the undercloud\n\n1. http://logs.openstack.org/16/656416/3/check/tripleo-ci-centos-7-scenario004-multinode-oooq-container/53d3cf5/logs/undercloud/home/zuul/overcloud_deploy.log.txt.gz#_2019-05-02_21_57_54","commit_id":"0294f77f2309f42024bb7b8abe1e858ba93c1524"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"70a635f0256c8d995f9571a5a2d744ada5a4565b","unresolved":false,"context_lines":[{"line_number":25,"context_line":"continue to exist on the filesystem. Since that directory is"},{"line_number":26,"context_line":"now being fully removed there is nothing to clean."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Also, add become to removal task so we do not introduce"},{"line_number":29,"context_line":"bug 1827273."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Change-Id: I7a01146a135254ccb948b8e793859f8fa3bdc690"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"dfbec78f_d7be5efe","line":28,"in_reply_to":"dfbec78f_e64bb7ad","updated":"2019-05-03 15:25:37.000000000","message":"Keys are created and owned by different users when ceph-ansible is done. When become is not used in _stein_ I see the error below [1]. I have not reproduced this error in rocky but since files end up owned by root and only writeable by root I think this will fail without become.\n\n  John\n\n[1]\n\nTASK [Remove ceph-ansible fetch directory] *************************************\nMonday 29 April 2019  23:03:51 +0000 (0:00:00.061)       0:19:44.704 **********\nfatal: [undercloud]: FAILED! \u003d\u003e {\"changed\": false, \"msg\": \"rmtree failed: [Errno 13] Permission denied: \u0027ceph.mgr.overcloud-controller-0.keyring\u0027\"}\n\nHere are the permissoins:\n\n(undercloud) [stack@undercloud-0 ceph-ansible]$ ls -l $(sudo find . -name ceph.mgr.overcloud-controller-0.keyring)\n-rw-r--r--. 1 root root 153 Apr 29 22:59 ./fetch_dir/17227faa-6ace-11e9-a5e4-525400ec1d33/etc/ceph/ceph.mgr.overcloud-controller-0.keyring\n(undercloud) [stack@undercloud-0 ceph-ansible]$","commit_id":"0294f77f2309f42024bb7b8abe1e858ba93c1524"}],"docker/services/ceph-ansible/ceph-base.yaml":[{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"82298354020c994e008bd64e4b0ade46fa619b38","unresolved":false,"context_lines":[{"line_number":632,"context_line":"              file:"},{"line_number":633,"context_line":"                path: \"{{playbook_dir}}/ceph-ansible/fetch_dir/\""},{"line_number":634,"context_line":"                state: absent"},{"line_number":635,"context_line":"              become: true"},{"line_number":636,"context_line":"      external_update_tasks:"},{"line_number":637,"context_line":"        - when: step|int \u003d\u003d 0"},{"line_number":638,"context_line":"          tags: ceph"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"dfbec78f_5805c979","line":635,"updated":"2019-05-02 20:00:58.000000000","message":"added change from https://review.opendev.org/#/c/656700","commit_id":"d8a2ca1f7a0d5f0e52c223c844c4f68d91b544ea"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"8816c72338a5590c950425d14d2318195ddc3a85","unresolved":false,"context_lines":[{"line_number":632,"context_line":"              file:"},{"line_number":633,"context_line":"                path: \"{{playbook_dir}}/ceph-ansible/fetch_dir/\""},{"line_number":634,"context_line":"                state: absent"},{"line_number":635,"context_line":"              become: true"},{"line_number":636,"context_line":"      external_update_tasks:"},{"line_number":637,"context_line":"        - when: step|int \u003d\u003d 0"},{"line_number":638,"context_line":"          tags: ceph"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"dfbec78f_982021fa","line":635,"in_reply_to":"dfbec78f_5805c979","updated":"2019-05-02 20:03:43.000000000","message":"if you want to do this, probably better to mention it explicitly in the commit msg","commit_id":"d8a2ca1f7a0d5f0e52c223c844c4f68d91b544ea"}]}