)]}'
{"deployment/undercloud/minion-rabbitmq-puppet.yaml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"cdbe9f0820a1c0f972ede2387128ca697364d4ba","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    description: Service to provide oslo messaging credentials for the Undercloud Minion"},{"line_number":72,"context_line":"    value:"},{"line_number":73,"context_line":"      service_name: oslo_messaging_minion"},{"line_number":74,"context_line":"      global_config_settings:"},{"line_number":75,"context_line":"        oslo_messaging_notify_scheme: rabbit"},{"line_number":76,"context_line":"        oslo_messaging_notify_user_name: {get_param: NotifyUserName}"},{"line_number":77,"context_line":"        oslo_messaging_notify_password: {get_param: NotifyPassword}"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"9fb8cfa7_5402160b","line":74,"updated":"2019-06-21 13:01:55.000000000","message":"shouldn\u0027t this be merged with GlobalConfigSettings?","commit_id":"a63b930d929e92f2162402201de0bec4cade3cf3"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"4e4652c8c6dc56d5aebf110c9425c9a7ee9c0d3c","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    description: Service to provide oslo messaging credentials for the Undercloud Minion"},{"line_number":72,"context_line":"    value:"},{"line_number":73,"context_line":"      service_name: oslo_messaging_minion"},{"line_number":74,"context_line":"      global_config_settings:"},{"line_number":75,"context_line":"        oslo_messaging_notify_scheme: rabbit"},{"line_number":76,"context_line":"        oslo_messaging_notify_user_name: {get_param: NotifyUserName}"},{"line_number":77,"context_line":"        oslo_messaging_notify_password: {get_param: NotifyPassword}"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"9fb8cfa7_741cfa69","line":74,"in_reply_to":"9fb8cfa7_5402160b","updated":"2019-06-21 13:03:33.000000000","message":"nevermind, it seems it\u0027s ok","commit_id":"a63b930d929e92f2162402201de0bec4cade3cf3"}],"environments/undercloud/undercloud-minion.yaml":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"d3f82c075921c6cdf1d9a089dcf7cbaaa53138c7","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  # Type: comma_delimited_list"},{"line_number":13,"context_line":"  DnsServers: []"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"  # The container image to use for the rabbitmq config_volume"},{"line_number":16,"context_line":"  # Mandatory. This parameter must be set by the user."},{"line_number":17,"context_line":"  # Type: string"},{"line_number":18,"context_line":"  DockerRabbitmqConfigImage: \u0027\u0027"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  # image"},{"line_number":21,"context_line":"  # Mandatory. This parameter must be set by the user."},{"line_number":22,"context_line":"  # Type: string"},{"line_number":23,"context_line":"  DockerRabbitmqImage: \u0027\u0027"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"  # Set to true to enable package installation at deploy time"},{"line_number":26,"context_line":"  # Type: boolean"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"bfb3d3c7_7a47a1bd","line":23,"range":{"start_line":15,"start_character":0,"end_line":23,"end_character":25},"updated":"2019-05-29 14:55:55.000000000","message":"these might not need to be here anymore since we reworked the rpc port stuff. will need to test","commit_id":"a627d65ecdef5d4f04dc783c523327f6a7ee4ef7"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"fde9c93a993c0285fcff1a4eb52a2dd236047235","unresolved":false,"context_lines":[{"line_number":120,"context_line":"  OS::TripleO::Services::HeatApi: OS::Heat::None"},{"line_number":121,"context_line":"  OS::TripleO::Services::HeatApiCfn: OS::Heat::None"},{"line_number":122,"context_line":"  OS::TripleO::Services::HeatApiCloudwatch: OS::Heat::None"},{"line_number":123,"context_line":"  OS::TripleO::Services::HeatEngine: OS::Heat::None"},{"line_number":124,"context_line":"  OS::TripleO::Services::Horizon: OS::Heat::None"},{"line_number":125,"context_line":"  OS::TripleO::Services::IpaClient: OS::Heat::None"},{"line_number":126,"context_line":"  OS::TripleO::Services::Ipsec: OS::Heat::None"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"9fb8cfa7_145a5e29","line":123,"range":{"start_line":123,"start_character":25,"end_line":123,"end_character":35},"updated":"2019-06-21 13:06:18.000000000","message":"the same?..","commit_id":"a63b930d929e92f2162402201de0bec4cade3cf3"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"aa8dc7c0b4843bf480cc2d2012d7153d75533956","unresolved":false,"context_lines":[{"line_number":120,"context_line":"  OS::TripleO::Services::HeatApi: OS::Heat::None"},{"line_number":121,"context_line":"  OS::TripleO::Services::HeatApiCfn: OS::Heat::None"},{"line_number":122,"context_line":"  OS::TripleO::Services::HeatApiCloudwatch: OS::Heat::None"},{"line_number":123,"context_line":"  OS::TripleO::Services::HeatEngine: OS::Heat::None"},{"line_number":124,"context_line":"  OS::TripleO::Services::Horizon: OS::Heat::None"},{"line_number":125,"context_line":"  OS::TripleO::Services::IpaClient: OS::Heat::None"},{"line_number":126,"context_line":"  OS::TripleO::Services::Ipsec: OS::Heat::None"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"9fb8cfa7_5431b6a1","line":123,"range":{"start_line":123,"start_character":25,"end_line":123,"end_character":35},"in_reply_to":"9fb8cfa7_145a5e29","updated":"2019-06-21 13:24:44.000000000","message":"Is set to none because it can be disabled/enabled via minion.conf. We enable it as a deployment time option","commit_id":"a63b930d929e92f2162402201de0bec4cade3cf3"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"4bb9d54796349314b72e8637e596ce559c66780a","unresolved":false,"context_lines":[{"line_number":125,"context_line":"  OS::TripleO::Services::IpaClient: OS::Heat::None"},{"line_number":126,"context_line":"  OS::TripleO::Services::Ipsec: OS::Heat::None"},{"line_number":127,"context_line":"  OS::TripleO::Services::IronicApi: OS::Heat::None"},{"line_number":128,"context_line":"  OS::TripleO::Services::IronicConductor: OS::Heat::None"},{"line_number":129,"context_line":"  OS::TripleO::Services::IronicInspector: OS::Heat::None"},{"line_number":130,"context_line":"  OS::TripleO::Services::IronicNeutronAgent: OS::Heat::None"},{"line_number":131,"context_line":"  OS::TripleO::Services::IronicPxe: OS::Heat::None"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"9fb8cfa7_94308eea","line":128,"updated":"2019-06-21 13:05:25.000000000","message":"this probably should not be set to None?","commit_id":"a63b930d929e92f2162402201de0bec4cade3cf3"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"aa8dc7c0b4843bf480cc2d2012d7153d75533956","unresolved":false,"context_lines":[{"line_number":125,"context_line":"  OS::TripleO::Services::IpaClient: OS::Heat::None"},{"line_number":126,"context_line":"  OS::TripleO::Services::Ipsec: OS::Heat::None"},{"line_number":127,"context_line":"  OS::TripleO::Services::IronicApi: OS::Heat::None"},{"line_number":128,"context_line":"  OS::TripleO::Services::IronicConductor: OS::Heat::None"},{"line_number":129,"context_line":"  OS::TripleO::Services::IronicInspector: OS::Heat::None"},{"line_number":130,"context_line":"  OS::TripleO::Services::IronicNeutronAgent: OS::Heat::None"},{"line_number":131,"context_line":"  OS::TripleO::Services::IronicPxe: OS::Heat::None"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"9fb8cfa7_f4278a63","line":128,"in_reply_to":"9fb8cfa7_94308eea","updated":"2019-06-21 13:24:44.000000000","message":"same","commit_id":"a63b930d929e92f2162402201de0bec4cade3cf3"}],"roles/UndercloudMinion.yaml":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"b73ebce5969934bbcb8ef76aec18e1b0de59653d","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    - OS::TripleO::Services::CertmongerUser"},{"line_number":15,"context_line":"    - OS::TripleO::Services::ContainerImagePrepare"},{"line_number":16,"context_line":"    - OS::TripleO::Services::ContainersLogrotateCrond"},{"line_number":17,"context_line":"    - OS::TripleO::Services::HAproxy"},{"line_number":18,"context_line":"    - OS::TripleO::Services::HeatEngine"},{"line_number":19,"context_line":"    - OS::TripleO::Services::IronicConductor"},{"line_number":20,"context_line":"    - OS::TripleO::Services::Keepalived"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dfbec78f_6e3d42ba","line":17,"range":{"start_line":17,"start_character":6,"end_line":17,"end_character":36},"updated":"2019-05-05 14:53:39.000000000","message":"HAproxy?","commit_id":"6ce7d6bf5c23577dc3f9c675f0d174306ceb207f"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"b73ebce5969934bbcb8ef76aec18e1b0de59653d","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    - OS::TripleO::Services::Keepalived"},{"line_number":21,"context_line":"    - OS::TripleO::Services::Kernel"},{"line_number":22,"context_line":"    - OS::TripleO::Services::LoginDefs"},{"line_number":23,"context_line":"    - OS::TripleO::Services::Memcached"},{"line_number":24,"context_line":"    - OS::TripleO::Services::MySQLClient"},{"line_number":25,"context_line":"    - OS::TripleO::Services::OpenStackClients"},{"line_number":26,"context_line":"    - OS::TripleO::Services::Podman"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dfbec78f_2e474a4e","line":23,"range":{"start_line":23,"start_character":6,"end_line":23,"end_character":38},"updated":"2019-05-05 14:53:39.000000000","message":"Why memcached?","commit_id":"6ce7d6bf5c23577dc3f9c675f0d174306ceb207f"}],"sample-env-generator/undercloud-minion.yaml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"284fa27602c2a98375aa39dbb7f75883b804e1f3","unresolved":false,"context_lines":[{"line_number":62,"context_line":"      OS::TripleO::Services::UndercloudMinionMessaging: ../../deployment/undercloud/minion-rabbitmq-puppet.yaml"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"      # Disable by default"},{"line_number":65,"context_line":"      OS::TripleO::Services::IronicConductor: OS::Heat::None"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"      # Disable all the services not used when deploying just a minion"},{"line_number":68,"context_line":"      OS::TripleO::Services::AodhApi: OS::Heat::None"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"9fb8cfa7_347682a6","line":65,"range":{"start_line":65,"start_character":29,"end_line":65,"end_character":35},"updated":"2019-06-21 13:08:04.000000000","message":"I think we might want to be able to set rpctransport for ironic conductor?","commit_id":"a63b930d929e92f2162402201de0bec4cade3cf3"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"aa8dc7c0b4843bf480cc2d2012d7153d75533956","unresolved":false,"context_lines":[{"line_number":62,"context_line":"      OS::TripleO::Services::UndercloudMinionMessaging: ../../deployment/undercloud/minion-rabbitmq-puppet.yaml"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"      # Disable by default"},{"line_number":65,"context_line":"      OS::TripleO::Services::IronicConductor: OS::Heat::None"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"      # Disable all the services not used when deploying just a minion"},{"line_number":68,"context_line":"      OS::TripleO::Services::AodhApi: OS::Heat::None"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"9fb8cfa7_54d69629","line":65,"range":{"start_line":65,"start_character":29,"end_line":65,"end_character":35},"in_reply_to":"9fb8cfa7_347682a6","updated":"2019-06-21 13:24:44.000000000","message":"Do you mean we need another service or what?","commit_id":"a63b930d929e92f2162402201de0bec4cade3cf3"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"d6c3d77c70ee50202c4b50825e832b34ddd228b9","unresolved":false,"context_lines":[{"line_number":62,"context_line":"      OS::TripleO::Services::UndercloudMinionMessaging: ../../deployment/undercloud/minion-rabbitmq-puppet.yaml"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"      # Disable by default"},{"line_number":65,"context_line":"      OS::TripleO::Services::IronicConductor: OS::Heat::None"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"      # Disable all the services not used when deploying just a minion"},{"line_number":68,"context_line":"      OS::TripleO::Services::AodhApi: OS::Heat::None"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"9fb8cfa7_9443aeaf","line":65,"range":{"start_line":65,"start_character":29,"end_line":65,"end_character":35},"in_reply_to":"9fb8cfa7_54d69629","updated":"2019-06-21 13:36:25.000000000","message":"No, we don\u0027t, that was my misunderstanding :)","commit_id":"a63b930d929e92f2162402201de0bec4cade3cf3"}]}