)]}'
{"deployment/ceph-ansible/ceph-base.yaml":[{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"98e453cef1ae3ee697b45c2f1d0113b661b0d648","unresolved":false,"context_lines":[{"line_number":680,"context_line":"              include_role:"},{"line_number":681,"context_line":"                role: ceph"},{"line_number":682,"context_line":"                tasks_from: ceph-health"},{"line_number":683,"context_line":"              delegate_to: overcloud-controller-0 # hack DNM"},{"line_number":684,"context_line":"              # delegate_to: \"{{ groups[mon_group_name][0] }}\""},{"line_number":685,"context_line":"              tags:"},{"line_number":686,"context_line":"                - opendev-validation"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dfbec78f_00f88146","line":683,"range":{"start_line":683,"start_character":0,"end_line":683,"end_character":60},"updated":"2019-05-14 21:25:45.000000000","message":"I want to see if this is sufficient to trigger the depends-on and get the result I want in CI. However, this shouldn\u0027t be merged as it\u0027s a hack.","commit_id":"f6b42c83b62bf8b48b117a1aad6709a6985d443a"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"98e453cef1ae3ee697b45c2f1d0113b661b0d648","unresolved":false,"context_lines":[{"line_number":681,"context_line":"                role: ceph"},{"line_number":682,"context_line":"                tasks_from: ceph-health"},{"line_number":683,"context_line":"              delegate_to: overcloud-controller-0 # hack DNM"},{"line_number":684,"context_line":"              # delegate_to: \"{{ groups[mon_group_name][0] }}\""},{"line_number":685,"context_line":"              tags:"},{"line_number":686,"context_line":"                - opendev-validation"},{"line_number":687,"context_line":"                - opendev-validation-ceph"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dfbec78f_007ba1bd","line":684,"range":{"start_line":684,"start_character":14,"end_line":684,"end_character":62},"updated":"2019-05-14 21:25:45.000000000","message":"It\u0027s going to need to run the Health check task wherever OS::TripleO::Services::CephMon [1] service is composed and run it on only one of those servers. E.g. we have edge and multi-ceph architectures where the Mons run on the HCI nodes [2]. \n\nUntil I do some tripleo inventory updates so I can refer to those hosts as with the syntax commented out above, this cannot merge.\n\n\n[1] https://github.com/openstack/tripleo-heat-templates/blob/master/roles_data.yaml#L56\n\n[2] https://github.com/openstack/tripleo-heat-templates/blob/master/roles/HciCephMon.yaml","commit_id":"f6b42c83b62bf8b48b117a1aad6709a6985d443a"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"3df08d76544aba275b8bbbef8df7347b3fe499de","unresolved":false,"context_lines":[{"line_number":680,"context_line":"              include_role:"},{"line_number":681,"context_line":"                role: ceph"},{"line_number":682,"context_line":"                tasks_from: ceph-health"},{"line_number":683,"context_line":"              delegate_to: \"{{ groups[ceph_mon][0] }}\""},{"line_number":684,"context_line":"              tags:"},{"line_number":685,"context_line":"                - opendev-validation"},{"line_number":686,"context_line":"                - opendev-validation-ceph"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bfb3d3c7_55dc8773","line":683,"range":{"start_line":683,"start_character":14,"end_line":683,"end_character":54},"updated":"2019-05-20 16:56:33.000000000","message":"It turns out that the ceph monitor service_name [1] already exists as an Ansible inventory group in the inventory generated by config-download\u0027s tripleo-ansible-inventory. Thus, I can use the existing inventory to delegate this task the first host of the Ceph mon group.\n\n[1] https://github.com/openstack/tripleo-heat-templates/blob/master/deployment/ceph-ansible/ceph-mon.yaml#L75","commit_id":"3ae3f22ef5897b91d6267de4245757d10c9d3cb0"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"bc3aec6cf0a90b82b1c04c307a9bce9859588f4b","unresolved":false,"context_lines":[{"line_number":680,"context_line":"              include_role:"},{"line_number":681,"context_line":"                role: ceph"},{"line_number":682,"context_line":"                tasks_from: ceph-health"},{"line_number":683,"context_line":"              delegate_to: \"{{ groups[ceph_mon][0] }}\""},{"line_number":684,"context_line":"              tags:"},{"line_number":685,"context_line":"                - opendev-validation"},{"line_number":686,"context_line":"                - opendev-validation-ceph"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bfb3d3c7_59ccc134","line":683,"range":{"start_line":683,"start_character":14,"end_line":683,"end_character":54},"in_reply_to":"bfb3d3c7_55dc8773","updated":"2019-05-20 20:08:17.000000000","message":"but... I guess I\u0027ll use when instead.\n\n2019-05-20 19:09:40,035 p\u003d21289 u\u003droot |  ERROR! \u0027delegate_to\u0027 is not a valid attribute for a IncludeRole\n\nhttp://logs.openstack.org/75/657175/4/check/tripleo-ci-centos-7-scenario001-standalone/e26da68/logs/undercloud/home/zuul/undercloud-ansible-Xi7NEZ/ansible.log.txt.gz","commit_id":"3ae3f22ef5897b91d6267de4245757d10c9d3cb0"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"e4c4c320c786e2c2b0fa889923afb0a9edb3d5c1","unresolved":false,"context_lines":[{"line_number":680,"context_line":"              include_role:"},{"line_number":681,"context_line":"                role: ceph"},{"line_number":682,"context_line":"                tasks_from: ceph-health"},{"line_number":683,"context_line":"              when: inventory_hostname \u003d\u003d \"{{ groups[ceph_mon][0] }}\""},{"line_number":684,"context_line":"              tags:"},{"line_number":685,"context_line":"                - opendev-validation"},{"line_number":686,"context_line":"                - opendev-validation-ceph"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bfb3d3c7_d72e23f9","line":683,"updated":"2019-05-21 19:30:18.000000000","message":"Failed [1] with:\n\nerror while evaluating conditional (inventory_hostname \u003d\u003d \\\"{{ groups[ceph_mon][0] }}\\\"): \n\n\u0027ceph_mon\u0027 is undefined\\n\\n\n\n\nThe inventory [2] has an ansible group called ceph_mon:\n\nceph_mon:\n  children:\n    Standalone: {}\n  vars: {ansible_ssh_user: root}\n\nwhich references the following host standalone:\n\nStandalone:\n  hosts:\n    standalone:\n      ansible_host: 192.168.24.1\n      ctlplane_ip: 192.168.24.1\n\nLet me double check the syntax I can use to reference.\n\n[1] http://logs.openstack.org/75/657175/5/check/tripleo-ci-centos-7-scenario001-standalone/b734ba6/logs/undercloud/home/zuul/undercloud-ansible-YzlnqA/ansible.log.txt.gz#_2019-05-20_21_31_08_755\n\n[2] http://logs.openstack.org/75/657175/5/check/tripleo-ci-centos-7-scenario001-standalone/b734ba6/logs/undercloud/home/zuul/undercloud-ansible-YzlnqA/inventory.yaml.txt.gz","commit_id":"9c5f24786190a16458bcd52c6bf9cb8e13acf8ba"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"8428925da52de99a94fd1b3565657dda9d51426b","unresolved":false,"context_lines":[{"line_number":683,"context_line":"              include_role:"},{"line_number":684,"context_line":"                role: ceph"},{"line_number":685,"context_line":"                tasks_from: ceph-health"},{"line_number":686,"context_line":"              delegate_to: groups[\u0027ceph_mon\u0027][0]"},{"line_number":687,"context_line":"              tags:"},{"line_number":688,"context_line":"                - opendev-validation"},{"line_number":689,"context_line":"                - opendev-validation-ceph"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9fb8cfa7_b1d1695a","line":686,"range":{"start_line":686,"start_character":14,"end_line":686,"end_character":47},"updated":"2019-06-03 18:27:59.000000000","message":"If your tripleo deployment includes ceph, then the inventory generated by config-download will contain the following groups:\n\n- ceph_mon\n- ceph_osd\n- ceph_mgr\n- ceph_client\n\nThus, you may delegate tasks to a ceph mon like this","commit_id":"2b1def43b137ba69c5e6a3197b2e58f4bf4412c4"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"919724a218b1bb6cb47fd4e8fa72c0643855e94a","unresolved":false,"context_lines":[{"line_number":680,"context_line":"                path: \"{{playbook_dir}}/ceph-ansible/fetch_dir/\""},{"line_number":681,"context_line":"                state: absent"},{"line_number":682,"context_line":"            - name: ensure ceph health is OK before proceeding"},{"line_number":683,"context_line":"              import_role:"},{"line_number":684,"context_line":"                role: ceph"},{"line_number":685,"context_line":"                tasks_from: ceph-health"},{"line_number":686,"context_line":"              delegate_to: \"{{ groups[\u0027ceph_mon\u0027][0] }}\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9fb8cfa7_9104657d","line":683,"range":{"start_line":683,"start_character":14,"end_line":683,"end_character":25},"updated":"2019-06-03 18:49:46.000000000","message":"include_role doesn\u0027t work with delegate_to but import_role does\n\nhttps://github.com/ansible/ansible/issues/26336","commit_id":"c9d6ecdfdcd7c09c11b1364aef316f8ad6f96537"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"f8dc1c7fdb6bc2b31086c1a526e1c4a4aa9b19fa","unresolved":false,"context_lines":[{"line_number":192,"context_line":"                 in the Ceph cluster, according to ceph osd stat, for the"},{"line_number":193,"context_line":"                 deployment not to fail. Used to catch deployment errors early."},{"line_number":194,"context_line":"                 Set this value to 0 to disable this check."},{"line_number":195,"context_line":"    type: integer"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"conditions:"},{"line_number":198,"context_line":"  custom_registry_host:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"9fb8cfa7_ac0d8638","line":195,"range":{"start_line":195,"start_character":10,"end_line":195,"end_character":17},"updated":"2019-06-04 07:51:32.000000000","message":"chokes cos there is no such thing http://logs.openstack.org/75/657175/11/check/tripleo-ci-centos-7-scenario004-standalone/3ce2329/logs/undercloud/home/zuul/standalone_deploy.log.txt.gz#_2019-06-04_04_44_21\n\nshould be \u0027number\u0027 https://docs.openstack.org/heat/latest/template_guide/hot_spec.html#parameters-section","commit_id":"bee0b3fbffa923e892dfc6eb2cc6ec79935b2ea6"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"c8376b79d50f830168fba2347e37b999573799a3","unresolved":false,"context_lines":[{"line_number":192,"context_line":"                 in the Ceph cluster, according to ceph osd stat, for the"},{"line_number":193,"context_line":"                 deployment not to fail. Used to catch deployment errors early."},{"line_number":194,"context_line":"                 Set this value to 0 to disable this check."},{"line_number":195,"context_line":"    type: integer"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"conditions:"},{"line_number":198,"context_line":"  custom_registry_host:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"9fb8cfa7_5697b191","line":195,"range":{"start_line":195,"start_character":10,"end_line":195,"end_character":17},"in_reply_to":"9fb8cfa7_ac0d8638","updated":"2019-06-04 13:00:18.000000000","message":"Whops. Thanks. Fixed.","commit_id":"bee0b3fbffa923e892dfc6eb2cc6ec79935b2ea6"}]}