)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"3ef682cef1871344e6ef5aa6c7400e6cdf6f2798","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix haproxy firewall rules"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The problem we want to selve is that the change https://review.opendev.org/#/c/631486/"},{"line_number":10,"context_line":"(moving iptables creation to the host broke composable ha when services"},{"line_number":11,"context_line":"are not running on the controller).  We need to add --tags"},{"line_number":12,"context_line":"\u0027tripleo::haproxy::endpoint\u0027 to the tags of the puppet invocation,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dfbec78f_f9feb136","line":9,"range":{"start_line":9,"start_character":23,"end_line":9,"end_character":28},"updated":"2019-05-08 15:43:36.000000000","message":"typo: solve","commit_id":"ba909c9494b7a99027ccba6861cea68c73146688"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"3ef682cef1871344e6ef5aa6c7400e6cdf6f2798","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix haproxy firewall rules"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The problem we want to selve is that the change https://review.opendev.org/#/c/631486/"},{"line_number":10,"context_line":"(moving iptables creation to the host broke composable ha when services"},{"line_number":11,"context_line":"are not running on the controller).  We need to add --tags"},{"line_number":12,"context_line":"\u0027tripleo::haproxy::endpoint\u0027 to the tags of the puppet invocation,"},{"line_number":13,"context_line":"otherwise the implicit rules insidate tripleo::haproxy::endpoint will"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dfbec78f_39a2094d","line":10,"updated":"2019-05-08 15:43:36.000000000","message":"missing )","commit_id":"ba909c9494b7a99027ccba6861cea68c73146688"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"3ef682cef1871344e6ef5aa6c7400e6cdf6f2798","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The problem we want to selve is that the change https://review.opendev.org/#/c/631486/"},{"line_number":10,"context_line":"(moving iptables creation to the host broke composable ha when services"},{"line_number":11,"context_line":"are not running on the controller).  We need to add --tags"},{"line_number":12,"context_line":"\u0027tripleo::haproxy::endpoint\u0027 to the tags of the puppet invocation,"},{"line_number":13,"context_line":"otherwise the implicit rules insidate tripleo::haproxy::endpoint will"},{"line_number":14,"context_line":"never be created."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dfbec78f_d9888dc7","line":11,"range":{"start_line":11,"start_character":33,"end_line":11,"end_character":34},"updated":"2019-05-08 15:43:36.000000000","message":"trailing )","commit_id":"ba909c9494b7a99027ccba6861cea68c73146688"}],"common/deploy-steps.j2":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"66bdea8ba37aeb874a100397553783e236965c8e","unresolved":false,"context_lines":[{"line_number":430,"context_line":"                docker_puppet_process_count: DOCKER_PUPPET_PROCESS_COUNT"},{"line_number":431,"context_line":"                docker_puppet_mount_host_puppet: DOCKER_PUPPET_MOUNT_HOST_PUPPET"},{"line_number":432,"context_line":"              tasks:"},{"line_number":433,"context_line":"                - name: Write the config_step hieradata for the deploy step {{step}} tasks"},{"line_number":434,"context_line":"                  copy:"},{"line_number":435,"context_line":"                    content: \"{{ dict(step\u003dstep|int) | to_json }}\""},{"line_number":436,"context_line":"                    dest: /etc/puppet/hieradata/config_step.json"},{"line_number":437,"context_line":"                    force: true"},{"line_number":438,"context_line":"                    mode: \u00270600\u0027"},{"line_number":439,"context_line":"{%- for role in roles %}"},{"line_number":440,"context_line":"                - import_tasks: {{role.name}}/deploy_steps_tasks.yaml"},{"line_number":441,"context_line":"                  when: tripleo_role_name \u003d\u003d \u0027{{role.name}}\u0027"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"dfbec78f_9943cb6c","line":438,"range":{"start_line":433,"start_character":0,"end_line":438,"end_character":32},"updated":"2019-05-10 14:57:46.000000000","message":"I meant put this in the block in the haproxy tasks, but I guess this works as well","commit_id":"e11a3a92a3fff251a807614230f845545cb363ff"},{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"737a170ee69d307e1ff4b30e12167dfc77d5b9de","unresolved":false,"context_lines":[{"line_number":430,"context_line":"                docker_puppet_process_count: DOCKER_PUPPET_PROCESS_COUNT"},{"line_number":431,"context_line":"                docker_puppet_mount_host_puppet: DOCKER_PUPPET_MOUNT_HOST_PUPPET"},{"line_number":432,"context_line":"              tasks:"},{"line_number":433,"context_line":"                - name: Write the config_step hieradata for the deploy step {{step}} tasks"},{"line_number":434,"context_line":"                  copy:"},{"line_number":435,"context_line":"                    content: \"{{ dict(step\u003dstep|int) | to_json }}\""},{"line_number":436,"context_line":"                    dest: /etc/puppet/hieradata/config_step.json"},{"line_number":437,"context_line":"                    force: true"},{"line_number":438,"context_line":"                    mode: \u00270600\u0027"},{"line_number":439,"context_line":"{%- for role in roles %}"},{"line_number":440,"context_line":"                - import_tasks: {{role.name}}/deploy_steps_tasks.yaml"},{"line_number":441,"context_line":"                  when: tripleo_role_name \u003d\u003d \u0027{{role.name}}\u0027"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"dfbec78f_3c8dedd2","line":438,"range":{"start_line":433,"start_character":0,"end_line":438,"end_character":32},"in_reply_to":"dfbec78f_9943cb6c","updated":"2019-05-10 15:39:32.000000000","message":"of course this then gets interpreted by jinja2 and then we all die","commit_id":"e11a3a92a3fff251a807614230f845545cb363ff"}],"deployment/haproxy/haproxy-container-puppet.yaml":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"77500a0f6443a98136870221992e6efd620e5178","unresolved":false,"context_lines":[{"line_number":286,"context_line":"            set +e"},{"line_number":287,"context_line":"            export FACTER_step\u003d1"},{"line_number":288,"context_line":"            puppet apply {{ puppet_debug }} --detailed-exitcodes --summarize --color\u003dfalse \\"},{"line_number":289,"context_line":"                --modulepath {{ puppet_modulepath }} --tags {{ puppet_tags }} -e {{ puppet_execute }}"},{"line_number":290,"context_line":"            rc\u003d$?"},{"line_number":291,"context_line":"            set -e"},{"line_number":292,"context_line":"            set +ux"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dfbec78f_3ec0937b","line":289,"range":{"start_line":289,"start_character":81,"end_line":289,"end_character":101},"updated":"2019-05-09 21:31:39.000000000","message":"Put the quotes up here around this","commit_id":"23a8f6c4b287f6b5f14730afb9601cbe188d760f"},{"author":{"_account_id":30126,"name":"Luca Miccini","email":"lmiccini@redhat.com","username":"lmiccini2"},"change_message_id":"904c8314e1c3e437770113bca69ef783d547d005","unresolved":false,"context_lines":[{"line_number":295,"context_line":"            fi"},{"line_number":296,"context_line":"            exit $rc"},{"line_number":297,"context_line":"          vars:"},{"line_number":298,"context_line":"            puppet_execute: \u0027include ::tripleo::profile::base::haproxy\u0027"},{"line_number":299,"context_line":"            puppet_tags: \u0027tripleo::firewall::rule,tripleo::haproxy::endpoint\u0027"},{"line_number":300,"context_line":"            puppet_modulepath: \u0027/etc/puppet/modules:/opt/stack/puppet-modules:/usr/share/openstack-puppet/modules\u0027"},{"line_number":301,"context_line":"            puppet_debug:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dfbec78f_9be2f100","line":298,"range":{"start_line":298,"start_character":28,"end_line":298,"end_character":29},"updated":"2019-05-09 20:40:56.000000000","message":"I think we need to escape them?","commit_id":"23a8f6c4b287f6b5f14730afb9601cbe188d760f"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"6e27de335c91fabb4bdf0d07d7218fba53be9a33","unresolved":false,"context_lines":[{"line_number":295,"context_line":"            fi"},{"line_number":296,"context_line":"            exit $rc"},{"line_number":297,"context_line":"          vars:"},{"line_number":298,"context_line":"            puppet_execute: \u0027include ::tripleo::profile::base::haproxy\u0027"},{"line_number":299,"context_line":"            puppet_tags: \u0027tripleo::firewall::rule,tripleo::haproxy::endpoint\u0027"},{"line_number":300,"context_line":"            puppet_modulepath: \u0027/etc/puppet/modules:/opt/stack/puppet-modules:/usr/share/openstack-puppet/modules\u0027"},{"line_number":301,"context_line":"            puppet_debug:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dfbec78f_9e465f21","line":298,"range":{"start_line":298,"start_character":28,"end_line":298,"end_character":29},"in_reply_to":"dfbec78f_9be2f100","updated":"2019-05-09 21:32:28.000000000","message":"This is yaml so it\u0027s already being added as a string. Realistically we shouldn\u0027t need to quote any of this unless ansible is doing something weird in the shell and adding a line break or something","commit_id":"23a8f6c4b287f6b5f14730afb9601cbe188d760f"}],"deployment/haproxy/haproxy-pacemaker-puppet.yaml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"e7f78741890e401527d62dc27bf70469045fefe1","unresolved":false,"context_lines":[{"line_number":345,"context_line":"            fi"},{"line_number":346,"context_line":"            exit $rc"},{"line_number":347,"context_line":"          vars:"},{"line_number":348,"context_line":"            puppet_execute: include ::tripleo::profile::base::haproxy"},{"line_number":349,"context_line":"            puppet_tags: tripleo::firewall::rule"},{"line_number":350,"context_line":"            puppet_modulepath: /etc/puppet/modules:/opt/stack/puppet-modules:/usr/share/openstack-puppet/modules"},{"line_number":351,"context_line":"            puppet_debug:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"dfbec78f_b3d575e7","line":348,"range":{"start_line":348,"start_character":56,"end_line":348,"end_character":60},"updated":"2019-05-13 08:03:54.000000000","message":"shouldn\u0027t it remain being consumed as ::pacemaker::haproxy?","commit_id":"ef6c23ef64ec7d96a45aabb844cf9451c27ae29c"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"859b64c9a17076260c75a226b8fb229388cf00ad","unresolved":false,"context_lines":[{"line_number":345,"context_line":"            fi"},{"line_number":346,"context_line":"            exit $rc"},{"line_number":347,"context_line":"          vars:"},{"line_number":348,"context_line":"            puppet_execute: include ::tripleo::profile::base::haproxy"},{"line_number":349,"context_line":"            puppet_tags: tripleo::firewall::rule"},{"line_number":350,"context_line":"            puppet_modulepath: /etc/puppet/modules:/opt/stack/puppet-modules:/usr/share/openstack-puppet/modules"},{"line_number":351,"context_line":"            puppet_debug:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"dfbec78f_3303c575","line":348,"range":{"start_line":348,"start_character":56,"end_line":348,"end_character":60},"in_reply_to":"dfbec78f_b3d575e7","updated":"2019-05-13 08:04:51.000000000","message":"nvm, I can see that\u0027s explained in the commit msg","commit_id":"ef6c23ef64ec7d96a45aabb844cf9451c27ae29c"}]}