)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"b103395c786a9b23fbb779bbfdd30d446210c57d","unresolved":false,"context_lines":[{"line_number":16,"context_line":"`nova.compute.manager._reclaim_queued_deletes` did not have"},{"line_number":17,"context_line":"any token info, then call cinder api would be failed."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"So add user/project CONF with admin role at cinder group,"},{"line_number":20,"context_line":"and when determine context is_admin and without token, do"},{"line_number":21,"context_line":"authenticaion with user/project info to call cinder api."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"The corresponding nova changes merged in change"},{"line_number":24,"context_line":"https://review.opendev.org/#/c/522112/"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"dfbec78f_ed079d81","line":21,"range":{"start_line":19,"start_character":0,"end_line":21,"end_character":56},"updated":"2019-05-10 17:50:36.000000000","message":"style: I think a slightly reworded version of this paragraph is a better introduction to the patch. The paragraphs starting at L9 and L15 are backstory, and seem like a long introduction. Try reordering the paragraphs from 1,2,3 to 3,1,2 and see if you think it flows better.","commit_id":"3ef8b0a8a15ca63f043d4ac06829a3861b674b98"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"b103395c786a9b23fbb779bbfdd30d446210c57d","unresolved":false,"context_lines":[{"line_number":24,"context_line":"https://review.opendev.org/#/c/522112/"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Also rephrased CinderPassword parameter description in"},{"line_number":27,"context_line":"cinder service templates to make it generic, which otherwise"},{"line_number":28,"context_line":"raises Mismatched parameter definition error in pep8"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Depends-On: https://review.opendev.org/#/c/657918/"},{"line_number":31,"context_line":"Change-Id: If0f9e442e5ed3b2d94bc51e65c145519c51cbc86"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"dfbec78f_ed90fd45","line":28,"range":{"start_line":27,"start_character":44,"end_line":28,"end_character":52},"updated":"2019-05-10 17:50:36.000000000","message":"nit: I would drop the second half of the sentence. You only got the pep8 error because you tried to use a generic description in the nova file that didn\u0027t match cinder\u0027s description. Just saying you rephrased cinder\u0027s password description to be generic is sufficient.","commit_id":"3ef8b0a8a15ca63f043d4ac06829a3861b674b98"}],"deployment/nova/nova-base-puppet.yaml":[{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"f44e581af5bf60f52fb04aa320f3f17373e4da81","unresolved":false,"context_lines":[{"line_number":329,"context_line":"          nova::network::neutron::neutron_auth_url: {get_param: [EndpointMap, KeystoneV3Internal, uri]}"},{"line_number":330,"context_line":"          nova::rabbit_heartbeat_timeout_threshold: 60"},{"line_number":331,"context_line":"          nova::cinder_catalog_info: \u0027volumev3:cinderv3:internalURL\u0027"},{"line_number":332,"context_line":"          nova::compute::cinder::cinder_username: \u0027cinder\u0027"},{"line_number":333,"context_line":"          nova::compute::cinder::cinder_auth_type: \u0027v3password\u0027"},{"line_number":334,"context_line":"          nova::compute::cinder::cinder_project_name: \u0027service\u0027"},{"line_number":335,"context_line":"          nova::compute::cinder::cinder_password: {get_param: CinderPassword}"},{"line_number":336,"context_line":"          nova::compute::cinder::cinder_auth_url: {get_param: [EndpointMap, KeystoneV3Internal, uri]}"},{"line_number":337,"context_line":"          nova::compute::cinder::cinder_region_name: {get_param: KeystoneRegion}"},{"line_number":338,"context_line":"          nova::host: \"%{hiera(\u0027fqdn_canonical\u0027)}\""},{"line_number":339,"context_line":"          nova::notify_on_state_change: \u0027vm_and_task_state\u0027"},{"line_number":340,"context_line":"          nova::notification_driver: {get_param: NotificationDriver}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"dfbec78f_90f5e885","line":337,"range":{"start_line":332,"start_character":0,"end_line":337,"end_character":80},"updated":"2019-05-10 06:40:34.000000000","message":"Right we want the cinder section to be filled only only on computes? shouldn\u0027t we set it then in deployment/nova/nova-compute-container-puppet.yaml for computes only?","commit_id":"927454c65d99f3ceda3e3caaf30e3af15d8aaec4"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"7ba99d274a747900d28b0070b90651c48e34b96e","unresolved":false,"context_lines":[{"line_number":329,"context_line":"          nova::network::neutron::neutron_auth_url: {get_param: [EndpointMap, KeystoneV3Internal, uri]}"},{"line_number":330,"context_line":"          nova::rabbit_heartbeat_timeout_threshold: 60"},{"line_number":331,"context_line":"          nova::cinder_catalog_info: \u0027volumev3:cinderv3:internalURL\u0027"},{"line_number":332,"context_line":"          nova::cinder::cinder_username: \u0027cinder\u0027"},{"line_number":333,"context_line":"          nova::cinder::cinder_auth_type: \u0027v3password\u0027"},{"line_number":334,"context_line":"          nova::cinder::cinder_project_name: \u0027service\u0027"},{"line_number":335,"context_line":"          nova::cinder::cinder_password: {get_param: CinderPassword}"},{"line_number":336,"context_line":"          nova::cinder::cinder_auth_url: {get_param: [EndpointMap, KeystoneV3Internal, uri]}"},{"line_number":337,"context_line":"          nova::cinder::cinder_region_name: {get_param: KeystoneRegion}"},{"line_number":338,"context_line":"          nova::host: \"%{hiera(\u0027fqdn_canonical\u0027)}\""},{"line_number":339,"context_line":"          nova::notify_on_state_change: \u0027vm_and_task_state\u0027"},{"line_number":340,"context_line":"          nova::notification_driver: {get_param: NotificationDriver}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dfbec78f_139fbd5f","line":337,"range":{"start_line":332,"start_character":0,"end_line":337,"end_character":71},"updated":"2019-05-10 12:08:56.000000000","message":"since nova::cinder only gets included for computes [1] I still think it would be better to add this to deployment/nova/nova-compute-container-puppet.yaml to avoid confusion that people don\u0027t see the settings configured on all nodes.\n\n[1] https://review.opendev.org/#/c/657918/3/manifests/compute.pp","commit_id":"3ef8b0a8a15ca63f043d4ac06829a3861b674b98"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"b103395c786a9b23fbb779bbfdd30d446210c57d","unresolved":false,"context_lines":[{"line_number":329,"context_line":"          nova::network::neutron::neutron_auth_url: {get_param: [EndpointMap, KeystoneV3Internal, uri]}"},{"line_number":330,"context_line":"          nova::rabbit_heartbeat_timeout_threshold: 60"},{"line_number":331,"context_line":"          nova::cinder_catalog_info: \u0027volumev3:cinderv3:internalURL\u0027"},{"line_number":332,"context_line":"          nova::cinder::cinder_username: \u0027cinder\u0027"},{"line_number":333,"context_line":"          nova::cinder::cinder_auth_type: \u0027v3password\u0027"},{"line_number":334,"context_line":"          nova::cinder::cinder_project_name: \u0027service\u0027"},{"line_number":335,"context_line":"          nova::cinder::cinder_password: {get_param: CinderPassword}"},{"line_number":336,"context_line":"          nova::cinder::cinder_auth_url: {get_param: [EndpointMap, KeystoneV3Internal, uri]}"},{"line_number":337,"context_line":"          nova::cinder::cinder_region_name: {get_param: KeystoneRegion}"},{"line_number":338,"context_line":"          nova::host: \"%{hiera(\u0027fqdn_canonical\u0027)}\""},{"line_number":339,"context_line":"          nova::notify_on_state_change: \u0027vm_and_task_state\u0027"},{"line_number":340,"context_line":"          nova::notification_driver: {get_param: NotificationDriver}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dfbec78f_4d990977","line":337,"range":{"start_line":332,"start_character":0,"end_line":337,"end_character":71},"in_reply_to":"dfbec78f_139fbd5f","updated":"2019-05-10 17:50:36.000000000","message":"I agree. There\u0027s no need for cinder\u0027s password to appear in nova.conf on nodes that don\u0027t need privileged access to cinder.","commit_id":"3ef8b0a8a15ca63f043d4ac06829a3861b674b98"}],"deployment/nova/nova-compute-container-puppet.yaml":[{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"b02be72e2872e50fbc773ec276998279f9484cdf","unresolved":false,"context_lines":[{"line_number":425,"context_line":"            nova::cinder::project_name: \u0027service\u0027"},{"line_number":426,"context_line":"            nova::cinder::password: {get_param: CinderPassword}"},{"line_number":427,"context_line":"            nova::cinder::auth_url: {get_param: [EndpointMap, KeystoneV3Internal, uri]}"},{"line_number":428,"context_line":"            nova::cinder::region_name: {get_param: KeystoneRegion}"},{"line_number":429,"context_line":"            nova::compute::rbd::libvirt_rbd_secret_key: {get_param: CephClientKey}"},{"line_number":430,"context_line":"            nova::compute::rbd::libvirt_rbd_secret_uuid: {get_param: CephClusterFSID}"},{"line_number":431,"context_line":"            nova::compute::instance_usage_audit: true"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"dfbec78f_29aef297","line":428,"range":{"start_line":428,"start_character":51,"end_line":428,"end_character":65},"updated":"2019-05-13 10:13:05.000000000","message":"We don\u0027t have that parameter at the moment for compute. we\u0027d need to add it","commit_id":"37e98e15eb4b59edfe567ce4b1dac2865e565fce"}]}