)]}'
{"common/deploy-steps.j2":[{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"957354a2e45363457afdc247ed796df607466969","unresolved":false,"context_lines":[{"line_number":564,"context_line":"                  loop_control:"},{"line_number":565,"context_line":"                    loop_var: step"},{"line_number":566,"context_line":"{%- endfor %}"},{"line_number":567,"context_line":"            - hosts: DEPLOY_TARGET_HOST"},{"line_number":568,"context_line":"              name: Run update"},{"line_number":569,"context_line":"              gather_facts: no"},{"line_number":570,"context_line":"              tasks:"},{"line_number":571,"context_line":"{%- for role in roles %}"},{"line_number":572,"context_line":"                - import_tasks: {{role.name}}/host_prep_tasks.yaml"},{"line_number":573,"context_line":"                  when: tripleo_role_name \u003d\u003d \u0027{{role.name}}\u0027"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"dfbec78f_9aa63e53","line":570,"range":{"start_line":567,"start_character":0,"end_line":570,"end_character":20},"updated":"2019-05-13 14:00:57.000000000","message":"This should be removed, no?\n\nCurrently at the code is, IIUC it would run update_steps_tasks according to the ansible_serial, but host_prep/deploy_steps_tasks would run all in parallel. I don\u0027t think that\u0027s correct.","commit_id":"38c83d003c326a7e66aa25da73008dcc1313c2da"},{"author":{"_account_id":11166,"name":"Lukas Bezdicka","email":"social@v3.sk","username":"xbezdick"},"change_message_id":"f1da690d9ed5f1bb073156722592d43d155e90d4","unresolved":false,"context_lines":[{"line_number":589,"context_line":"                - import_tasks: {{role.name}}/host_prep_tasks.yaml"},{"line_number":590,"context_line":"                  when: tripleo_role_name \u003d\u003d \u0027{{role.name}}\u0027"},{"line_number":591,"context_line":"{%- endfor %}"},{"line_number":592,"context_line":"                - include_tasks: common_deploy_steps_tasks.yaml"},{"line_number":593,"context_line":"                  with_sequence: start\u003d1 end\u003d{{deploy_steps_max-1}}"},{"line_number":594,"context_line":"                  loop_control:"},{"line_number":595,"context_line":"                    loop_var: step"},{"line_number":596,"context_line":"                - include_tasks: post_update_steps_tasks.yaml"},{"line_number":597,"context_line":"                  with_sequence: start\u003d0 end\u003d{{post_update_steps_max-1}}"},{"line_number":598,"context_line":"                  loop_control:"},{"line_number":599,"context_line":"                    loop_var: step"},{"line_number":600,"context_line":"      external_update_steps_tasks: {get_attr: [ExternalUpdateTasks, value]}"},{"line_number":601,"context_line":"      external_update_steps_playbook:"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"bfb3d3c7_a4d6b4c2","line":598,"range":{"start_line":592,"start_character":0,"end_line":598,"end_character":31},"updated":"2019-05-23 14:34:36.000000000","message":"These also need to run in serial on controllers and in parallel on computes.","commit_id":"3fcda7d0c37d5ac5d56c7011f41bdc1133246f74"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"75ac79c4b26b1845b7cb7e359bc581b33ee44ca4","unresolved":false,"context_lines":[{"line_number":679,"context_line":"                - include_vars: global_vars.yaml"},{"line_number":680,"context_line":"            - hosts: DEPLOY_TARGET_HOST"},{"line_number":681,"context_line":"              name: Run pre-upgrade rolling tasks"},{"line_number":682,"context_line":"              serial: {{ deploy_serial | default(1) }}"},{"line_number":683,"context_line":"              gather_facts: no"},{"line_number":684,"context_line":"              any_errors_fatal: yes"},{"line_number":685,"context_line":"              tasks:"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"bfb3d3c7_7673c0b2","line":682,"updated":"2019-05-21 14:37:09.000000000","message":"what about this one left behind?","commit_id":"3fcda7d0c37d5ac5d56c7011f41bdc1133246f74"},{"author":{"_account_id":11166,"name":"Lukas Bezdicka","email":"social@v3.sk","username":"xbezdick"},"change_message_id":"f1da690d9ed5f1bb073156722592d43d155e90d4","unresolved":false,"context_lines":[{"line_number":679,"context_line":"                - include_vars: global_vars.yaml"},{"line_number":680,"context_line":"            - hosts: DEPLOY_TARGET_HOST"},{"line_number":681,"context_line":"              name: Run pre-upgrade rolling tasks"},{"line_number":682,"context_line":"              serial: {{ deploy_serial | default(1) }}"},{"line_number":683,"context_line":"              gather_facts: no"},{"line_number":684,"context_line":"              any_errors_fatal: yes"},{"line_number":685,"context_line":"              tasks:"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"bfb3d3c7_c4d168cf","line":682,"in_reply_to":"bfb3d3c7_7673c0b2","updated":"2019-05-23 14:34:36.000000000","message":"Actually you are right. I think here we\u0027ll also have to generate per role serial execution.","commit_id":"3fcda7d0c37d5ac5d56c7011f41bdc1133246f74"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"5391c1612c487e2595385f9702c0d9e5a884b3ef","unresolved":false,"context_lines":[{"line_number":649,"context_line":"            DEPLOY_SOURCE_HOST: {get_param: deployment_source_hosts}"},{"line_number":650,"context_line":"            DEPLOY_TARGET_HOST: {get_param: deployment_target_hosts}"},{"line_number":651,"context_line":"          template: |"},{"line_number":652,"context_line":"{%- for role in roles %}"},{"line_number":653,"context_line":"            - hosts: {{role.name}}"},{"line_number":654,"context_line":"              name: Gather facts from undercloud"},{"line_number":655,"context_line":"              gather_facts: yes"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"9fb8cfa7_18f883e3","line":652,"updated":"2019-06-05 05:08:13.000000000","message":"Nit: We don\u0027t need to change this spot, it\u0027s not being used, we\u0027d just introduce conflict here with the patch that is removing the pre_upgrade_rolling playbook.","commit_id":"afe81b679af8e072b36bd77b0192c274262e872b"}],"roles/CephStorage.yaml":[{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"5391c1612c487e2595385f9702c0d9e5a884b3ef","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    StorageMgmt:"},{"line_number":11,"context_line":"      subnet: storage_mgmt_subnet"},{"line_number":12,"context_line":"  uses_deprecated_params: False"},{"line_number":13,"context_line":"  update_serial: 25"},{"line_number":14,"context_line":"  deprecated_nic_config_name: \u0027ceph-storage.yaml\u0027"},{"line_number":15,"context_line":"  ServicesDefault:"},{"line_number":16,"context_line":"    - OS::TripleO::Services::Aide"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9fb8cfa7_8db18a92","line":13,"updated":"2019-06-05 05:08:13.000000000","message":"Going through the roles, i\u0027m wondering if the parallel updates are a safe default, or if we should default everywhere to 1 and let users change that if they know what they\u0027re doing.\n\nHere, if Docker is updated, the containers are restarted, aren\u0027t they? If that\u0027s right, parallelizing here could result in all OSD replicas getting restarted at the same time -- not nice...\n\nMakes me wonder how many other roles could suffer from the same problem, and which are those. ObjectStorage maybe too?","commit_id":"afe81b679af8e072b36bd77b0192c274262e872b"}],"roles_data.yaml":[{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"0869e1bbfd1f50662a8f15c6089c97308fd6ccc5","unresolved":false,"context_lines":[{"line_number":23,"context_line":"      subnet: storage_mgmt_subnet"},{"line_number":24,"context_line":"    Tenant:"},{"line_number":25,"context_line":"      subnet: tenant_subnet"},{"line_number":26,"context_line":"  ansible_serial: 1"},{"line_number":27,"context_line":"  # For systems with both IPv4 and IPv6, you may specify a gateway network for"},{"line_number":28,"context_line":"  # each, such as [\u0027ControlPlane\u0027, \u0027External\u0027]"},{"line_number":29,"context_line":"  default_route_networks: [\u0027External\u0027]"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"dfbec78f_ba6ea22c","line":26,"updated":"2019-05-13 13:53:19.000000000","message":"Just a nit: i think this file is generated from the individual files under `roles/` directory. We should edit those too, at least for the few roles included here in the default roles_data.yaml.\n\nI expect CI to fail on this patch as i think we have something that validates that roles_data.yaml matches roles/Controller.yaml etc.","commit_id":"38c83d003c326a7e66aa25da73008dcc1313c2da"}]}