)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"41e5da08686bf143efff9af5959d8971f563c904","unresolved":false,"context_lines":[{"line_number":14,"context_line":"This patch sets force_config_drive to true only when OVNMetadataEnable"},{"line_number":15,"context_line":"is set to false. If it\u0027s set to true then it doesn\u0027t touch"},{"line_number":16,"context_line":"force_config_drive option, leaving it up to environment to define it."},{"line_number":17,"context_line":"Default for force_config_drive is false when OVNMetadataEnable is set"},{"line_number":18,"context_line":"to true."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: Ib956ff2f521b9853c58eaa5500836c692dd9321d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bfb3d3c7_187298e4","line":18,"range":{"start_line":17,"start_character":0,"end_line":18,"end_character":8},"updated":"2019-05-22 17:01:30.000000000","message":"This sentence may need to be updated after latest change as force_config_drive isn\u0027t changed when OVSMetadataEnable is true.","commit_id":"cde0a77eb168fd3a42eeeef2071fe5d9e3a582f6"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"4c5afd46daecb688140c5f1dd88e58123d63b32f","unresolved":false,"context_lines":[{"line_number":14,"context_line":"This patch sets force_config_drive to true only when OVNMetadataEnable"},{"line_number":15,"context_line":"is set to false. If it\u0027s set to true then it doesn\u0027t touch"},{"line_number":16,"context_line":"force_config_drive option, leaving it up to environment to define it."},{"line_number":17,"context_line":"Default for force_config_drive is false when OVNMetadataEnable is set"},{"line_number":18,"context_line":"to true."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: Ib956ff2f521b9853c58eaa5500836c692dd9321d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bfb3d3c7_4c64c8e4","line":18,"range":{"start_line":17,"start_character":0,"end_line":18,"end_character":8},"in_reply_to":"bfb3d3c7_187298e4","updated":"2019-05-23 08:23:09.000000000","message":"Maybe I need to reword it better. I wanted to say that when you set OVNMetadataEnable to true, then the force_config_drive option is not touched but when you don\u0027t touch it, it\u0027s false by default.","commit_id":"cde0a77eb168fd3a42eeeef2071fe5d9e3a582f6"}],"deployment/ovn/ovn-controller-container-puppet.yaml":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"29bb3a45e911d83e1530f9d147a1b258c5a795d6","unresolved":false,"context_lines":[{"line_number":117,"context_line":"                 params:"},{"line_number":118,"context_line":"                   $NETWORK: {get_param: [ServiceNetMap, NeutronTenantNetwork]}"},{"line_number":119,"context_line":"            ovn::controller::ovn_bridge: {get_param: OVNIntegrationBridge}"},{"line_number":120,"context_line":"            if:"},{"line_number":121,"context_line":"              - force_config_drive"},{"line_number":122,"context_line":"              - nova::compute::force_config_drive: true"},{"line_number":123,"context_line":"            tripleo::profile::base::neutron::agents::ovn::ovn_db_host: {get_param: [EndpointMap, OvnDbInternal, host_nobrackets]}"},{"line_number":124,"context_line":"            tripleo::ovn_controller::firewall_rules:"},{"line_number":125,"context_line":"              \u0027118 neutron vxlan networks\u0027:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bfb3d3c7_4c7e1a6c","line":122,"range":{"start_line":120,"start_character":0,"end_line":122,"end_character":55},"updated":"2019-05-22 13:58:09.000000000","message":"I think we need to provide a value for false in the if statement here.\nAlso the if need to be a third entry in the map_merge, while testing I get the if literally merged into the map if I don\u0027t make it a third entry in the list of maps to merge.\n\ni.e:\n       map_merge:\n          - get_attr: [RoleParametersValue, value]\n          - ovn::southbound::port: {get_param: OVNSouthboundServerPort}\n            ovn::controller::ovn_encap_ip:\n              str_replace:\n                 template:\n                   \"%{hiera(\u0027$NETWORK\u0027)}\"\n                 params:\n                   $NETWORK: {get_param: [ServiceNetMap, NeutronTenantNetwork]}\n            ovn::controller::ovn_bridge: {get_param: OVNIntegrationBridge}\n          - if:\n              - force_config_drive\n              - nova::compute::force_config_drive: true\n              - {}\n\nWhitout the {} for the false I get an error like:\nERROR: resources.\u003cResource\u003e.properties.value.map_merge[1][1].if: : Arguments to \"if\" must be of the form: [condition_name, value_if_true, value_if_false]","commit_id":"6497c04d8caa21f4cd03c0873c2d82f626230b2f"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"20d5a52e69406669711927446b55b57fee03203a","unresolved":false,"context_lines":[{"line_number":117,"context_line":"                 params:"},{"line_number":118,"context_line":"                   $NETWORK: {get_param: [ServiceNetMap, NeutronTenantNetwork]}"},{"line_number":119,"context_line":"            ovn::controller::ovn_bridge: {get_param: OVNIntegrationBridge}"},{"line_number":120,"context_line":"            if:"},{"line_number":121,"context_line":"              - force_config_drive"},{"line_number":122,"context_line":"              - nova::compute::force_config_drive: true"},{"line_number":123,"context_line":"            tripleo::profile::base::neutron::agents::ovn::ovn_db_host: {get_param: [EndpointMap, OvnDbInternal, host_nobrackets]}"},{"line_number":124,"context_line":"            tripleo::ovn_controller::firewall_rules:"},{"line_number":125,"context_line":"              \u0027118 neutron vxlan networks\u0027:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bfb3d3c7_4c413a0b","line":122,"range":{"start_line":120,"start_character":0,"end_line":122,"end_character":55},"in_reply_to":"bfb3d3c7_4c7e1a6c","updated":"2019-05-22 14:00:58.000000000","message":"Thanks, will fix","commit_id":"6497c04d8caa21f4cd03c0873c2d82f626230b2f"}]}