)]}'
{"deployment/ironic/ironic-conductor-container-puppet.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9999d9d3f1b16958a89e99619da2c6c25e139858","unresolved":false,"context_lines":[{"line_number":219,"context_line":"    default: true"},{"line_number":220,"context_line":"    description: Whether to force power state during sync."},{"line_number":221,"context_line":"    type: boolean"},{"line_number":222,"context_line":"  IronicConductorGroupName:"},{"line_number":223,"context_line":"    description: The name of an Ironic Conductor Group."},{"line_number":224,"context_line":"    default: \u0027\u0027"},{"line_number":225,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bfb3d3c7_9271f5aa","line":222,"range":{"start_line":222,"start_character":22,"end_line":222,"end_character":26},"updated":"2019-05-31 06:17:54.000000000","message":"Why add Name here? I\u0027d prefer we keep it IronicConductorGroup as it is in the configuration.","commit_id":"610c5f23c3983cf7551242144e59877ed5bac451"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9999d9d3f1b16958a89e99619da2c6c25e139858","unresolved":false,"context_lines":[{"line_number":224,"context_line":"    default: \u0027\u0027"},{"line_number":225,"context_line":"    type: string"},{"line_number":226,"context_line":"    constraints:"},{"line_number":227,"context_line":"      - allowed_pattern: \u0027^[a-zA-Z0-9_\\-\\.]*?$\u0027"},{"line_number":228,"context_line":"  MonitoringSubscriptionIronicConductor:"},{"line_number":229,"context_line":"    default: \u0027overcloud-ironic-conductor\u0027"},{"line_number":230,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bfb3d3c7_92581531","line":227,"range":{"start_line":227,"start_character":44,"end_line":227,"end_character":45},"updated":"2019-05-31 06:17:54.000000000","message":"nit: not sure what the question sign does here, may be not needed","commit_id":"610c5f23c3983cf7551242144e59877ed5bac451"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"daea8e9b14833fd7581e0d8c46ecc6666ff1dc19","unresolved":false,"context_lines":[{"line_number":224,"context_line":"    default: \u0027\u0027"},{"line_number":225,"context_line":"    type: string"},{"line_number":226,"context_line":"    constraints:"},{"line_number":227,"context_line":"      - allowed_pattern: \u0027^[a-zA-Z0-9_\\-\\.]*?$\u0027"},{"line_number":228,"context_line":"  MonitoringSubscriptionIronicConductor:"},{"line_number":229,"context_line":"    default: \u0027overcloud-ironic-conductor\u0027"},{"line_number":230,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bfb3d3c7_c27eb8ad","line":227,"range":{"start_line":227,"start_character":44,"end_line":227,"end_character":45},"in_reply_to":"bfb3d3c7_827be0f2","updated":"2019-05-31 13:32:32.000000000","message":"indeed. thanks!","commit_id":"610c5f23c3983cf7551242144e59877ed5bac451"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"48a7854e1a6f4f1e441456a241c93fa19300f7c7","unresolved":false,"context_lines":[{"line_number":224,"context_line":"    default: \u0027\u0027"},{"line_number":225,"context_line":"    type: string"},{"line_number":226,"context_line":"    constraints:"},{"line_number":227,"context_line":"      - allowed_pattern: \u0027^[a-zA-Z0-9_\\-\\.]*?$\u0027"},{"line_number":228,"context_line":"  MonitoringSubscriptionIronicConductor:"},{"line_number":229,"context_line":"    default: \u0027overcloud-ironic-conductor\u0027"},{"line_number":230,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bfb3d3c7_e2be5cac","line":227,"range":{"start_line":227,"start_character":44,"end_line":227,"end_character":45},"in_reply_to":"bfb3d3c7_92581531","updated":"2019-05-31 13:21:02.000000000","message":"the question mark allows empty values into the allowed values","commit_id":"610c5f23c3983cf7551242144e59877ed5bac451"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"862cfc7e1d74d0c793430d85ad3d20e40aad2c60","unresolved":false,"context_lines":[{"line_number":224,"context_line":"    default: \u0027\u0027"},{"line_number":225,"context_line":"    type: string"},{"line_number":226,"context_line":"    constraints:"},{"line_number":227,"context_line":"      - allowed_pattern: \u0027^[a-zA-Z0-9_\\-\\.]*?$\u0027"},{"line_number":228,"context_line":"  MonitoringSubscriptionIronicConductor:"},{"line_number":229,"context_line":"    default: \u0027overcloud-ironic-conductor\u0027"},{"line_number":230,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bfb3d3c7_827be0f2","line":227,"range":{"start_line":227,"start_character":44,"end_line":227,"end_character":45},"in_reply_to":"bfb3d3c7_e2be5cac","updated":"2019-05-31 13:23:53.000000000","message":"The star should be enough, since it means 0+ repetitions.","commit_id":"610c5f23c3983cf7551242144e59877ed5bac451"}],"releasenotes/notes/ironic-conductor-groups-577543f8ca612f06.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9999d9d3f1b16958a89e99619da2c6c25e139858","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    `IronicConductorGroupName` allows to define an Ironic Conductor Group so"},{"line_number":5,"context_line":"    that the managed baremetal nodes may be later manually distributed by"},{"line_number":6,"context_line":"    operators across multiple conductors. By default,"},{"line_number":7,"context_line":"    `IronicConductorGroupName` takes an empty value, which creates no"},{"line_number":8,"context_line":"    conductor groups associated with the given Ironic Conductor service"},{"line_number":9,"context_line":"    instance."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bfb3d3c7_125d0514","line":9,"range":{"start_line":7,"start_character":4,"end_line":9,"end_character":13},"updated":"2019-05-31 06:17:54.000000000","message":"This is not entirely correct, there is the default conductor group \u0027\u0027","commit_id":"610c5f23c3983cf7551242144e59877ed5bac451"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"c2176176f3f03bb2e5fa3591a46a8494aad6e9ee","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    `IronicConductorGroupName` allows to define an Ironic Conductor Group so"},{"line_number":5,"context_line":"    that the managed baremetal nodes may be later manually distributed by"},{"line_number":6,"context_line":"    operators across multiple conductors. By default,"},{"line_number":7,"context_line":"    `IronicConductorGroupName` takes an empty value, which creates no"},{"line_number":8,"context_line":"    conductor groups associated with the given Ironic Conductor service"},{"line_number":9,"context_line":"    instance."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bfb3d3c7_6236ec53","line":9,"range":{"start_line":7,"start_character":4,"end_line":9,"end_character":13},"in_reply_to":"bfb3d3c7_125d0514","updated":"2019-05-31 13:22:21.000000000","message":"Should I clarify that t-h-t would not allow users to define the empty value for the group name as it is taken as a reserved value what means - change nothing and create no groups?","commit_id":"610c5f23c3983cf7551242144e59877ed5bac451"}]}