)]}'
{"deployment/neutron/neutron-api-container-puppet.yaml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"7046d9679fa9b1a2bd831812664311d6b0553565","unresolved":false,"context_lines":[{"line_number":115,"context_line":"  # TODO(bogdando): Right now OVN doesn\u0027t support AZ aware routing scheduling."},{"line_number":116,"context_line":"  # Later in Train cycle OVN ml2 driver will be extended to support it."},{"line_number":117,"context_line":"  # Until then, we have to determine if NeutronMechanismDrivers is OVN or OVS."},{"line_number":118,"context_line":"  NeutronMechanismDrivers:"},{"line_number":119,"context_line":"    default: \u0027ovn\u0027"},{"line_number":120,"context_line":"    description: |"},{"line_number":121,"context_line":"        The mechanism drivers for the Neutron tenant network."},{"line_number":122,"context_line":"    type: comma_delimited_list"},{"line_number":123,"context_line":"  NeutronDefaultAvailabilityZones:"},{"line_number":124,"context_line":"    description: Comma-separated list of default network availability zones to"},{"line_number":125,"context_line":"                 be used by Neutron if its resource is created without"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9fb8cfa7_54574d27","line":122,"range":{"start_line":118,"start_character":0,"end_line":122,"end_character":30},"updated":"2019-06-10 10:48:40.000000000","message":"so this can go once AZs fully implemented for OVN vs OVS cases","commit_id":"bb28607945492e06d97149d4f466ee9d95b1891a"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"c85e3d1455f7a890f92b7cbf9b38f3ac8611c3b6","unresolved":false,"context_lines":[{"line_number":314,"context_line":"              neutron::server::dhcp_load_type: {get_param: NeutronDhcpLoadType}"},{"line_number":315,"context_line":"              neutron::server::network_scheduler_driver:"},{"line_number":316,"context_line":"                {get_param: NeutronNetworkSchedulerDriver}"},{"line_number":317,"context_line":"              neutron::server::router_scheduler_driver:"},{"line_number":318,"context_line":"                {get_param: NeutronRouterSchedulerDriver}"},{"line_number":319,"context_line":"              neutron::server::default_availability_zones:"},{"line_number":320,"context_line":"                {str_split: [\u0027,\u0027, {get_param: NeutronDefaultAvailabilityZones}]}"},{"line_number":321,"context_line":"      service_config_settings:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9fb8cfa7_54a98d21","line":318,"range":{"start_line":317,"start_character":0,"end_line":318,"end_character":57},"updated":"2019-06-10 10:44:17.000000000","message":"please let me know if you think this is correct or a) we may allow all these to be defined unconditionally, or b) only omit router_scheduler_driver for OVN","commit_id":"bb28607945492e06d97149d4f466ee9d95b1891a"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"318ff7bec95c07422beed23058cc815e44f8a63d","unresolved":false,"context_lines":[{"line_number":316,"context_line":"                {get_param: NeutronNetworkSchedulerDriver}"},{"line_number":317,"context_line":"              neutron::server::router_scheduler_driver:"},{"line_number":318,"context_line":"                {get_param: NeutronRouterSchedulerDriver}"},{"line_number":319,"context_line":"              neutron::server::default_availability_zones:"},{"line_number":320,"context_line":"                {str_split: [\u0027,\u0027, {get_param: NeutronDefaultAvailabilityZones}]}"},{"line_number":321,"context_line":"      service_config_settings:"},{"line_number":322,"context_line":"        fluentd:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9fb8cfa7_d4381def","line":319,"updated":"2019-06-10 10:50:00.000000000","message":"(this one shall remain under the \"not az_unset\" condition anyway, disregard of the ovn or ovs)","commit_id":"bb28607945492e06d97149d4f466ee9d95b1891a"},{"author":{"_account_id":11082,"name":"Kamil Sambor","email":"ksambor@redhat.com","username":"ksambor"},"change_message_id":"5c9c8efb6e42cffcedab70e7bcb1c7639d6c07b0","unresolved":false,"context_lines":[{"line_number":126,"context_line":"                 availability zone hints. If not set, no AZs will be configured"},{"line_number":127,"context_line":"                 for Neutron network services."},{"line_number":128,"context_line":"    default: \u0027\u0027"},{"line_number":129,"context_line":"    type: string"},{"line_number":130,"context_line":"  NeutronNetworkSchedulerDriver:"},{"line_number":131,"context_line":"    description: The network schedule driver to use for avialability zones."},{"line_number":132,"context_line":"    default: neutron.scheduler.dhcp_agent_scheduler.AZAwareWeightScheduler"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9fb8cfa7_699077ee","line":129,"updated":"2019-06-10 15:03:30.000000000","message":"There is a resone why you not use comma_delimited_list?","commit_id":"71a64df7808a1130b0f4ea08cead836f6f74f038"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"5a6483b044f787aeda11bf766c1e970a05da15e8","unresolved":false,"context_lines":[{"line_number":126,"context_line":"                 availability zone hints. If not set, no AZs will be configured"},{"line_number":127,"context_line":"                 for Neutron network services."},{"line_number":128,"context_line":"    default: \u0027\u0027"},{"line_number":129,"context_line":"    type: string"},{"line_number":130,"context_line":"  NeutronNetworkSchedulerDriver:"},{"line_number":131,"context_line":"    description: The network schedule driver to use for avialability zones."},{"line_number":132,"context_line":"    default: neutron.scheduler.dhcp_agent_scheduler.AZAwareWeightScheduler"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9fb8cfa7_d3534038","line":129,"in_reply_to":"9fb8cfa7_699077ee","updated":"2019-06-11 07:44:59.000000000","message":"I could do that as well thanks. Not sure if str_split() would work for anything else than a string tho?","commit_id":"71a64df7808a1130b0f4ea08cead836f6f74f038"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"17e0284c6a307510c8cbda70d2d3c798a03844be","unresolved":false,"context_lines":[{"line_number":126,"context_line":"                 availability zone hints. If not set, no AZs will be configured"},{"line_number":127,"context_line":"                 for Neutron network services."},{"line_number":128,"context_line":"    default: \u0027\u0027"},{"line_number":129,"context_line":"    type: string"},{"line_number":130,"context_line":"  NeutronNetworkSchedulerDriver:"},{"line_number":131,"context_line":"    description: The network schedule driver to use for avialability zones."},{"line_number":132,"context_line":"    default: neutron.scheduler.dhcp_agent_scheduler.AZAwareWeightScheduler"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9fb8cfa7_5c9bdd64","line":129,"in_reply_to":"9fb8cfa7_d3534038","updated":"2019-06-11 09:55:18.000000000","message":"Done","commit_id":"71a64df7808a1130b0f4ea08cead836f6f74f038"}],"deployment/neutron/neutron-az-config.yaml":[{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"72c4d47451d52aee97aedd570021106ab5dbcea2","unresolved":false,"context_lines":[{"line_number":117,"context_line":"    description: Role data for the Neutron Availability Zone configuration value"},{"line_number":118,"context_line":"    service:"},{"line_number":119,"context_line":"      service_name: neutron_az_config"},{"line_number":120,"context_line":"      config_settings:"},{"line_number":121,"context_line":"        map_merge:"},{"line_number":122,"context_line":"          - get_attr: [NeutronBase, role_data, config_settings]"},{"line_number":123,"context_line":"          -"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9fb8cfa7_5dcb2e71","line":120,"updated":"2019-06-05 20:36:20.000000000","message":"should this be service_config_settings? how is this service meant to be used? isn\u0027t it supposed to influence the configuration of other *actual* neutron services (such as dhcp, etc).\n\nif so, i think you\u0027d want to enable this hiera for those services with service_config_settings.","commit_id":"569912c2b5d35a375f85fa26fb624b43d9936a95"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"72c4d47451d52aee97aedd570021106ab5dbcea2","unresolved":false,"context_lines":[{"line_number":133,"context_line":"            neutron::agents::dhcp::availability_zone:"},{"line_number":134,"context_line":"              {get_attr: [NeutronDhcpAgentAvailabilityZoneReal, value]}"},{"line_number":135,"context_line":"      step_config: |"},{"line_number":136,"context_line":"        include ::tripleo::profile::base::neutron"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9fb8cfa7_fdf0e2cb","line":136,"updated":"2019-06-05 20:36:20.000000000","message":"this doesn\u0027t make sense to me. step_config runs on the host right?","commit_id":"569912c2b5d35a375f85fa26fb624b43d9936a95"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"73b4b73cbcdf2083cbc85144f65d886f2a3f80dc","unresolved":false,"context_lines":[{"line_number":133,"context_line":"            neutron::agents::dhcp::availability_zone:"},{"line_number":134,"context_line":"              {get_attr: [NeutronDhcpAgentAvailabilityZoneReal, value]}"},{"line_number":135,"context_line":"      step_config: |"},{"line_number":136,"context_line":"        include ::tripleo::profile::base::neutron"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9fb8cfa7_1d55b61d","line":136,"in_reply_to":"9fb8cfa7_fdf0e2cb","updated":"2019-06-05 21:02:10.000000000","message":"Only if we invoke this as a top level service. If this is a nested stack it shouldn\u0027t run on the host. That being said, yea I don\u0027t think we need to be specifying the step_config here","commit_id":"569912c2b5d35a375f85fa26fb624b43d9936a95"}],"deployment/neutron/neutron-dhcp-container-puppet.yaml":[{"author":{"_account_id":11082,"name":"Kamil Sambor","email":"ksambor@redhat.com","username":"ksambor"},"change_message_id":"5c9c8efb6e42cffcedab70e7bcb1c7639d6c07b0","unresolved":false,"context_lines":[{"line_number":225,"context_line":"              - dhcp_ovs_intergation_bridge_unset"},{"line_number":226,"context_line":"              - {}"},{"line_number":227,"context_line":"              - neutron::agents::dhcp::ovs_integration_bridge: {get_param: NeutronDhcpOvsIntegrationBridge}"},{"line_number":228,"context_line":"          - if:"},{"line_number":229,"context_line":"              - az_unset"},{"line_number":230,"context_line":"              - {}"},{"line_number":231,"context_line":"              - neutron::agents::dhcp::availability_zone: {get_param: NeutronDhcpAgentAvailabilityZone}"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9fb8cfa7_6c8f2575","line":228,"updated":"2019-06-10 15:03:30.000000000","message":"this tht is used in https://opendev.org/openstack/tripleo-heat-templates/src/branch/master/environments/services/neutron-ovn-sriov.yaml#L12 so maybe it will be good to check if we have ovn driver here before set, but it ovn-sriov is experimental I\u0027m ok with how it is now","commit_id":"71a64df7808a1130b0f4ea08cead836f6f74f038"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"17e0284c6a307510c8cbda70d2d3c798a03844be","unresolved":false,"context_lines":[{"line_number":225,"context_line":"              - dhcp_ovs_intergation_bridge_unset"},{"line_number":226,"context_line":"              - {}"},{"line_number":227,"context_line":"              - neutron::agents::dhcp::ovs_integration_bridge: {get_param: NeutronDhcpOvsIntegrationBridge}"},{"line_number":228,"context_line":"          - if:"},{"line_number":229,"context_line":"              - az_unset"},{"line_number":230,"context_line":"              - {}"},{"line_number":231,"context_line":"              - neutron::agents::dhcp::availability_zone: {get_param: NeutronDhcpAgentAvailabilityZone}"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9fb8cfa7_bcc21933","line":228,"in_reply_to":"9fb8cfa7_33389cec","updated":"2019-06-11 09:55:18.000000000","message":"Done","commit_id":"71a64df7808a1130b0f4ea08cead836f6f74f038"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"5a6483b044f787aeda11bf766c1e970a05da15e8","unresolved":false,"context_lines":[{"line_number":225,"context_line":"              - dhcp_ovs_intergation_bridge_unset"},{"line_number":226,"context_line":"              - {}"},{"line_number":227,"context_line":"              - neutron::agents::dhcp::ovs_integration_bridge: {get_param: NeutronDhcpOvsIntegrationBridge}"},{"line_number":228,"context_line":"          - if:"},{"line_number":229,"context_line":"              - az_unset"},{"line_number":230,"context_line":"              - {}"},{"line_number":231,"context_line":"              - neutron::agents::dhcp::availability_zone: {get_param: NeutronDhcpAgentAvailabilityZone}"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9fb8cfa7_33389cec","line":228,"in_reply_to":"9fb8cfa7_6c8f2575","updated":"2019-06-11 07:44:59.000000000","message":"good catch thanks, I will update that with the ovn_enabled condition as well","commit_id":"71a64df7808a1130b0f4ea08cead836f6f74f038"}]}