)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"299b97d53d92c7ade72e94d21ee1dd19d619d835","unresolved":false,"context_lines":[{"line_number":10,"context_line":"moved to depends-on patch as Ansible roles. Replace calls"},{"line_number":11,"context_line":"to those tasks with include_role."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Depends-On: I19cd58275a0b8f8f84776a98008cd9b10ceda908"},{"line_number":14,"context_line":"Change-Id: I2acae0155fa4ca07a2e61019d94a8985b31dd003"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"9fb8cfa7_8b1fbf59","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":10},"updated":"2019-06-11 21:39:45.000000000","message":"Switched from tripleo-common proposal to tripleo-ansible","commit_id":"f240bc842c681440f1a212ac842ac71361825140"}],"deployment/ceph-ansible/ceph-base.yaml":[{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"0b2fb60a0c633646fc6caec70da532a2ba8a1407","unresolved":false,"context_lines":[{"line_number":406,"context_line":"                    data: {get_param: NodeDataLookup}"},{"line_number":407,"context_line":"            - name: create ceph-ansible working direcotry"},{"line_number":408,"context_line":"              include_role:"},{"line_number":409,"context_line":"                name: /usr/share/tripleo-common/playbooks/roles/ceph-work-dir"},{"line_number":410,"context_line":"                tasks_from: prepare"},{"line_number":411,"context_line":"            - name: prepare for ceph-ansible uuid gathering"},{"line_number":412,"context_line":"              include_role:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bfb3d3c7_6a48695b","line":409,"updated":"2019-05-24 21:32:41.000000000","message":"The tripleo-common roles are not in the default role path [1]. Octavia uses roles found in the same location but they do it by including the full path to a playbook in tripleo-common [2]. As per the way ansible roles work the relative pathed roles directory then gets used. In my case I\u0027m just doing an include_role. As per the docs [3] it is valid to refer to the roles by path [3]. \n\n[1] http://logs.openstack.org/01/661001/2/check/tripleo-ci-centos-7-scenario001-standalone/ef75b0c/logs/undercloud/home/zuul/undercloud-ansible-xXeUdS/ansible.log.txt.gz#_2019-05-24_17_38_33_920\n\n[2]  https://github.com/openstack/tripleo-heat-templates/blob/master/deployment/octavia/octavia-deployment-config.j2.yaml#L223\n\n[3]  https://docs.ansible.com/ansible/latest/user_guide/playbooks_reuse_roles.html#using-roles","commit_id":"23ed1b7a0a2089dcd1fd64eac4a376a010b5b582"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"8fd7acf55260096543c67ffc6062d21fd2648cef","unresolved":false,"context_lines":[{"line_number":429,"context_line":"                      data: {get_param: CephAnsibleEnvironmentVariables}"},{"line_number":430,"context_line":"                      expression: $.data.items().select($[0] + \u0027\u003d\u0027 + $[1]).join(\u0027 \u0027)"},{"line_number":431,"context_line":"                ceph_ansible_skip_tags: {get_param:  CephAnsibleSkipTags}"},{"line_number":432,"context_line":"            - name: get ssh private key"},{"line_number":433,"context_line":"              include_role:"},{"line_number":434,"context_line":"                name: /usr/share/tripleo-common/playbooks/roles/ceph-work-dir"},{"line_number":435,"context_line":"                tasks_from: get_ssh_private_key"},{"line_number":436,"context_line":"            - name: run nodes-uuid"},{"line_number":437,"context_line":"              include_role:"},{"line_number":438,"context_line":"                name: /usr/share/tripleo-common/playbooks/roles/ceph-uuid"},{"line_number":439,"context_line":"                tasks_from: gather"},{"line_number":440,"context_line":"            - name: create copy of ceph-ansible fetch directory"},{"line_number":441,"context_line":"              include_role:"},{"line_number":442,"context_line":"                name: /usr/share/tripleo-common/playbooks/roles/ceph-fetch-dir"},{"line_number":443,"context_line":"                tasks_from: create"},{"line_number":444,"context_line":"            - name: run ceph-ansible"},{"line_number":445,"context_line":"              include_role:"},{"line_number":446,"context_line":"                name: /usr/share/tripleo-common/playbooks/roles/ceph-run-ansible"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"bfb3d3c7_865ecd73","line":443,"range":{"start_line":432,"start_character":0,"end_line":443,"end_character":34},"updated":"2019-05-29 03:44:14.000000000","message":"Lines 408-415, in addition to the above, could all be executed as a dep of including the ceph-ansible role as below. I have these broken into separate role includes to split the tasks between step 1 and step 2 but is this still necessary? \n\nSwitching tripleo-common\u0027s roles/ceph-run-ansible from run.yml to main.yml could be undone if we don\u0027t like the ansible deps method. \n\nDo we want to make the changes here as short as this?\n\n https://review.opendev.org/#/c/660995/10/playbooks/ceph.yaml","commit_id":"14954aa4706d0a23f9145f0e638cee2e2d0cffce"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"f20fbf7b90b5e38f0b17fe9bc3d2cac0a7f9f316","unresolved":false,"context_lines":[{"line_number":429,"context_line":"                      data: {get_param: CephAnsibleEnvironmentVariables}"},{"line_number":430,"context_line":"                      expression: $.data.items().select($[0] + \u0027\u003d\u0027 + $[1]).join(\u0027 \u0027)"},{"line_number":431,"context_line":"                ceph_ansible_skip_tags: {get_param:  CephAnsibleSkipTags}"},{"line_number":432,"context_line":"            - name: get ssh private key"},{"line_number":433,"context_line":"              include_role:"},{"line_number":434,"context_line":"                name: /usr/share/tripleo-common/playbooks/roles/ceph-work-dir"},{"line_number":435,"context_line":"                tasks_from: get_ssh_private_key"},{"line_number":436,"context_line":"            - name: run nodes-uuid"},{"line_number":437,"context_line":"              include_role:"},{"line_number":438,"context_line":"                name: /usr/share/tripleo-common/playbooks/roles/ceph-uuid"},{"line_number":439,"context_line":"                tasks_from: gather"},{"line_number":440,"context_line":"            - name: create copy of ceph-ansible fetch directory"},{"line_number":441,"context_line":"              include_role:"},{"line_number":442,"context_line":"                name: /usr/share/tripleo-common/playbooks/roles/ceph-fetch-dir"},{"line_number":443,"context_line":"                tasks_from: create"},{"line_number":444,"context_line":"            - name: run ceph-ansible"},{"line_number":445,"context_line":"              include_role:"},{"line_number":446,"context_line":"                name: /usr/share/tripleo-common/playbooks/roles/ceph-run-ansible"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"bfb3d3c7_e6fa2941","line":443,"range":{"start_line":432,"start_character":0,"end_line":443,"end_character":34},"in_reply_to":"bfb3d3c7_865ecd73","updated":"2019-05-29 03:51:11.000000000","message":"In other words, I think this can get reduced further into:\n\n https://diffy.org/diff/ehhgr3wf07hyfahmjhiz1if6r","commit_id":"14954aa4706d0a23f9145f0e638cee2e2d0cffce"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"8e065d849b550eac84fcf494da5b34011e46d569","unresolved":false,"context_lines":[{"line_number":429,"context_line":"                      data: {get_param: CephAnsibleEnvironmentVariables}"},{"line_number":430,"context_line":"                      expression: $.data.items().select($[0] + \u0027\u003d\u0027 + $[1]).join(\u0027 \u0027)"},{"line_number":431,"context_line":"                ceph_ansible_skip_tags: {get_param:  CephAnsibleSkipTags}"},{"line_number":432,"context_line":"            - name: get ssh private key"},{"line_number":433,"context_line":"              include_role:"},{"line_number":434,"context_line":"                name: /usr/share/tripleo-common/playbooks/roles/ceph-work-dir"},{"line_number":435,"context_line":"                tasks_from: get_ssh_private_key"},{"line_number":436,"context_line":"            - name: run nodes-uuid"},{"line_number":437,"context_line":"              include_role:"},{"line_number":438,"context_line":"                name: /usr/share/tripleo-common/playbooks/roles/ceph-uuid"},{"line_number":439,"context_line":"                tasks_from: gather"},{"line_number":440,"context_line":"            - name: create copy of ceph-ansible fetch directory"},{"line_number":441,"context_line":"              include_role:"},{"line_number":442,"context_line":"                name: /usr/share/tripleo-common/playbooks/roles/ceph-fetch-dir"},{"line_number":443,"context_line":"                tasks_from: create"},{"line_number":444,"context_line":"            - name: run ceph-ansible"},{"line_number":445,"context_line":"              include_role:"},{"line_number":446,"context_line":"                name: /usr/share/tripleo-common/playbooks/roles/ceph-run-ansible"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"bfb3d3c7_a76741b7","line":443,"range":{"start_line":432,"start_character":0,"end_line":443,"end_character":34},"in_reply_to":"bfb3d3c7_e6fa2941","updated":"2019-05-29 15:44:08.000000000","message":"Moving everything to step two [1] and relying on the dependencies in the roles \nin the depends-on fails because the generated external_deploy_steps_tasks.yaml has\nstep 1 tasks outside of ceph-base [2]. The failure is [3]. I could pursue changing\nthose tasks as well to step 2.\n\n[1] http://ix.io/1KoJ\n[2] http://ix.io/1KoI\n[3] \n~~~\nPLAY [External deployment step 1] ************************************************************************\n\nTASK [set ceph-ansible facts] ****************************************************************************\nskipping: [undercloud] \u003d\u003e {\"changed\": false, \"skip_reason\": \"Conditional result was False\"}\n\nTASK [run ceph-ansible] **********************************************************************************\nskipping: [undercloud] \u003d\u003e {\"changed\": false, \"skip_reason\": \"Conditional result was False\"}\n\nTASK [backup and clean fetch directory] ******************************************************************\nskipping: [undercloud] \u003d\u003e {\"changed\": false, \"skip_reason\": \"Conditional result was False\"}\n\nTASK [set ceph-ansible group vars mgrs] ******************************************************************\nok: [undercloud] \u003d\u003e {\"ansible_facts\": {\"ceph_ansible_group_vars_mgrs\": {\"ceph_mgr_docker_extra_env\": \"-e MGR_DASHBOARD\u003d0\"}}, \"changed\": false}\n\nTASK [generate ceph-ansible group vars mgrs] *************************************************************\nfatal: [undercloud]: FAILED! \u003d\u003e {\"changed\": false, \"checksum\": \"06d130f3471f2ac09bb0161450878cf64bafd8af\", \"msg\": \"Destination directory /home/stack/train/config-download/ceph-ansible/group_vars does not exist\"}\n~~~","commit_id":"14954aa4706d0a23f9145f0e638cee2e2d0cffce"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"9e19f1b1b3ce21613c51aeeec5119d5353ea8314","unresolved":false,"context_lines":[{"line_number":246,"context_line":"          ceph_docker_registry: {get_attr: [DockerImageUrlParts, value, host]}"},{"line_number":247,"context_line":"          ceph_docker_image: {get_attr: [DockerImageUrlParts, value, image]}"},{"line_number":248,"context_line":"          ceph_docker_image_tag: {get_attr: [DockerImageUrlParts, value, image_tag]}"},{"line_number":249,"context_line":"          containerized_deployment: true"},{"line_number":250,"context_line":"          public_network:"},{"line_number":251,"context_line":"            list_join:"},{"line_number":252,"context_line":"              - \u0027,\u0027"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"9fb8cfa7_16e2ab30","line":249,"updated":"2019-06-18 09:02:05.000000000","message":"can we remove from tht all the static values which have a default in the role already?","commit_id":"84cb5345e27d8e5030e45f991bbb02afd6903787"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"a5c7e06943c4c65deec959cd221f214f6dc3afb9","unresolved":false,"context_lines":[{"line_number":246,"context_line":"          ceph_docker_registry: {get_attr: [DockerImageUrlParts, value, host]}"},{"line_number":247,"context_line":"          ceph_docker_image: {get_attr: [DockerImageUrlParts, value, image]}"},{"line_number":248,"context_line":"          ceph_docker_image_tag: {get_attr: [DockerImageUrlParts, value, image_tag]}"},{"line_number":249,"context_line":"          containerized_deployment: true"},{"line_number":250,"context_line":"          public_network:"},{"line_number":251,"context_line":"            list_join:"},{"line_number":252,"context_line":"              - \u0027,\u0027"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"9fb8cfa7_7a78f3c2","line":249,"in_reply_to":"9fb8cfa7_16e2ab30","updated":"2019-06-28 14:20:18.000000000","message":"Done\n\nhttps://review.opendev.org/#/c/664706/8/tripleo_ansible/roles/tripleo-ceph-common/defaults/main.yml@137","commit_id":"84cb5345e27d8e5030e45f991bbb02afd6903787"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"bc2f1c10943df636fbd40cf19f82c12db64c784d","unresolved":false,"context_lines":[{"line_number":240,"context_line":"      type: json"},{"line_number":241,"context_line":"      value:"},{"line_number":242,"context_line":"        vars:"},{"line_number":243,"context_line":"          docker: true"},{"line_number":244,"context_line":"          containerized_deployment: true"},{"line_number":245,"context_line":"          user_config: true"},{"line_number":246,"context_line":"          ceph_stable: true"},{"line_number":247,"context_line":"          ceph_origin: distro"},{"line_number":248,"context_line":"          openstack_config: true"},{"line_number":249,"context_line":"          pools: []"},{"line_number":250,"context_line":"          ntp_service_enabled: true"},{"line_number":251,"context_line":"          generate_fsid: false"},{"line_number":252,"context_line":"          fsid: { get_param: CephClusterFSID }"},{"line_number":253,"context_line":"          cluster: { get_param: CephClusterName }"},{"line_number":254,"context_line":"          ceph_docker_registry: {get_attr: [ContainerImageUrlParts, value, host]}"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"9fb8cfa7_3f9ca068","line":251,"range":{"start_line":243,"start_character":0,"end_line":251,"end_character":30},"updated":"2019-06-29 14:15:18.000000000","message":"Why are these static key:value pairs being included in the ceph_ansible_group_vars_all map when they could have been defaults in tripleo-ansible?\n\nWell, the new roles in tripleo-ansible [0] are roles to _prepare_ to run another ansible playbook.\n\nWe must not confuse the ansible running these roles (tripleo-ceph-*) which I\u0027ll refer to as the \"calling ansible\" with the ansible these roles call (ceph-ansible), which I\u0027ll refer to as the \"called ansible\".\n\nThe variables I was able to put into the triplo-ansible roles themselves [1] were for the calling ansible and not for the called ansible. The variables I was asked to move are for the called ansible. Unless the \"calling ansible\" is re-written to do a merge of the variables in tripleo-ceph-common with what comes from THT and give priority to what\u0027s in THT, they need to be separate.\n\nI\u0027ve added them back since that\u0027s been working for a while now and to keep the simplicity of the separation. We can consider the merge in the future.\n\n[0] https://review.opendev.org/#/c/664706/\n[1] https://review.opendev.org/#/c/664706/10/tripleo_ansible/roles/tripleo-ceph-fetch-dir/vars/main.yml","commit_id":"ca1ca90b328e99f8fd68b539e2fbddb2aaba2108"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"bc2f1c10943df636fbd40cf19f82c12db64c784d","unresolved":false,"context_lines":[{"line_number":411,"context_line":"            - name: set ceph-ansible facts"},{"line_number":412,"context_line":"              set_fact:"},{"line_number":413,"context_line":"                blacklisted_hostnames: {get_param: DeploymentServerBlacklist}"},{"line_number":414,"context_line":"                ceph_ansible_group_vars_all: {get_attr: [CephBaseAnsibleVars, value, vars]}"},{"line_number":415,"context_line":"                ceph_ansible_extra_vars:"},{"line_number":416,"context_line":"                  map_merge:"},{"line_number":417,"context_line":"                  - {get_param: CephAnsibleExtraConfig}"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"9fb8cfa7_ff8b681b","line":414,"updated":"2019-06-29 14:15:18.000000000","message":"This is the one variable which is set to the map above. It has a default in the new tripleo-ceph-common role in tripleo-ansible, but it\u0027s the value set here XOR the default in tripleo-ansible. We don\u0027t merge them and merging them might cause confusion.","commit_id":"ca1ca90b328e99f8fd68b539e2fbddb2aaba2108"}]}