)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"c49c03913811ecc3fbcc897c2c70ad8260876f71","unresolved":false,"context_lines":[{"line_number":19,"context_line":"needlessly running shell commands."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"\u003e Once this change has been merged a follow-up patch will be made"},{"line_number":22,"context_line":"  to tripleo-common to eliminate the tuned.pp manifest."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: I06d07f6f0949095cb716dd706e05f2e567c0d3d8"},{"line_number":25,"context_line":"Signed-off-by: Kevin Carter \u003ckecarter@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bfb3d3c7_93b07b45","line":22,"range":{"start_line":22,"start_character":5,"end_line":22,"end_character":19},"updated":"2019-05-24 17:00:20.000000000","message":"nit: puppet-tripleo","commit_id":"b49d897fc720eb5048f4d894b4615dc8cec02fef"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"ee8d36cecada8def39bb6ace9d21d9858061d6bc","unresolved":false,"context_lines":[{"line_number":19,"context_line":"needlessly running shell commands."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"\u003e Once this change has been merged a follow-up patch will be made"},{"line_number":22,"context_line":"  to tripleo-common to eliminate the tuned.pp manifest."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: I06d07f6f0949095cb716dd706e05f2e567c0d3d8"},{"line_number":25,"context_line":"Signed-off-by: Kevin Carter \u003ckecarter@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bfb3d3c7_93239b56","line":22,"range":{"start_line":22,"start_character":5,"end_line":22,"end_character":19},"in_reply_to":"bfb3d3c7_93b07b45","updated":"2019-05-24 17:12:46.000000000","message":"Done","commit_id":"b49d897fc720eb5048f4d894b4615dc8cec02fef"}],"deployment/tuned/tuned-baremetal-ansible.yaml":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"c49c03913811ecc3fbcc897c2c70ad8260876f71","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    default: \u0027false\u0027"},{"line_number":35,"context_line":"    description: Set to true to enable package installation at deploy time"},{"line_number":36,"context_line":"    type: boolean"},{"line_number":37,"context_line":"  TunedCustomProfile: "},{"line_number":38,"context_line":"    default: \u0027\u0027"},{"line_number":39,"context_line":"    description: Custom tuned profile"},{"line_number":40,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bfb3d3c7_73b3874e","line":37,"range":{"start_line":37,"start_character":21,"end_line":37,"end_character":22},"updated":"2019-05-24 17:00:20.000000000","message":"nit: some trailing spaces in this file","commit_id":"b49d897fc720eb5048f4d894b4615dc8cec02fef"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"ee8d36cecada8def39bb6ace9d21d9858061d6bc","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    default: \u0027false\u0027"},{"line_number":35,"context_line":"    description: Set to true to enable package installation at deploy time"},{"line_number":36,"context_line":"    type: boolean"},{"line_number":37,"context_line":"  TunedCustomProfile: "},{"line_number":38,"context_line":"    default: \u0027\u0027"},{"line_number":39,"context_line":"    description: Custom tuned profile"},{"line_number":40,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bfb3d3c7_5319a31f","line":37,"range":{"start_line":37,"start_character":21,"end_line":37,"end_character":22},"in_reply_to":"bfb3d3c7_73b3874e","updated":"2019-05-24 17:12:46.000000000","message":"Done","commit_id":"b49d897fc720eb5048f4d894b4615dc8cec02fef"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"102998d87e5d11b917cf4a1a4ab5e82d75f5f014","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    type: boolean"},{"line_number":37,"context_line":"  TunedCustomProfile:"},{"line_number":38,"context_line":"    default: \u0027\u0027"},{"line_number":39,"context_line":"    description: Custom tuned profile"},{"line_number":40,"context_line":"    type: string"},{"line_number":41,"context_line":"  TunedProfileName:"},{"line_number":42,"context_line":"    default: \u0027throughput-performance\u0027"},{"line_number":43,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bfb3d3c7_c9c86323","line":40,"range":{"start_line":39,"start_character":0,"end_line":40,"end_character":16},"updated":"2019-05-28 17:54:52.000000000","message":"You could put more detail here from the deprecated version so it\u0027s easier for a user to know how to use this parameter.\n\nhttps://review.opendev.org/#/c/661361/4/deployment/deprecated/tuned/tuned-baremetal-puppet.yml@41","commit_id":"479ce78931a3bc88b3b182b04c9d3226072ccd3d"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"aa99249e8aa9d851f1363aa7436d8319aa72feba","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    type: boolean"},{"line_number":37,"context_line":"  TunedCustomProfile:"},{"line_number":38,"context_line":"    default: \u0027\u0027"},{"line_number":39,"context_line":"    description: Custom tuned profile"},{"line_number":40,"context_line":"    type: string"},{"line_number":41,"context_line":"  TunedProfileName:"},{"line_number":42,"context_line":"    default: \u0027throughput-performance\u0027"},{"line_number":43,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bfb3d3c7_08316aa3","line":40,"range":{"start_line":39,"start_character":0,"end_line":40,"end_character":16},"in_reply_to":"bfb3d3c7_c9c86323","updated":"2019-05-30 14:38:03.000000000","message":"Done","commit_id":"479ce78931a3bc88b3b182b04c9d3226072ccd3d"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"102998d87e5d11b917cf4a1a4ab5e82d75f5f014","unresolved":false,"context_lines":[{"line_number":101,"context_line":"      ansible_group_vars:"},{"line_number":102,"context_line":"        tuned_profile: {get_param: TunedProfileName}"},{"line_number":103,"context_line":"        custom_profile: {get_param: TunedCustomProfile}"},{"line_number":104,"context_line":"        EnablePackageInstall: {get_param: EnablePackageInstall}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bfb3d3c7_c932a310","line":104,"range":{"start_line":104,"start_character":8,"end_line":104,"end_character":28},"updated":"2019-05-28 17:54:52.000000000","message":"Do we want to switch to using this variable name convention? I like it because it\u0027s easier to map the THT names to ansible names but it\u0027s a change in convention so we should ack/nack.","commit_id":"479ce78931a3bc88b3b182b04c9d3226072ccd3d"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"824855a3b4c7e09483f587392fd0c4c8e544a4d5","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            PATH: \"/bin:/usr/bin:/sbin:/usr/sbin\""},{"line_number":73,"context_line":"          changed_when: false"},{"line_number":74,"context_line":"          failed_when: false"},{"line_number":75,"context_line":"          register: tuned_check"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        - name: Run tuned setup"},{"line_number":78,"context_line":"          when:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bfb3d3c7_667ccb71","line":75,"updated":"2019-05-31 00:10:45.000000000","message":"Just a side comment about all of this but I wonder if we want to throw a warning if EnablePackageInstall is false and it\u0027s not installed but the service is enabled. We actually throw a warning if we try to install a package via puppet but it\u0027s actually noop\u0027d","commit_id":"8e482688da2acfaf11540c0a56ee66f166e4503e"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"7f5643f2f73c39c4548e0904ad16a0da23d3a4f7","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            PATH: \"/bin:/usr/bin:/sbin:/usr/sbin\""},{"line_number":73,"context_line":"          changed_when: false"},{"line_number":74,"context_line":"          failed_when: false"},{"line_number":75,"context_line":"          register: tuned_check"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        - name: Run tuned setup"},{"line_number":78,"context_line":"          when:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bfb3d3c7_5dace99d","line":75,"in_reply_to":"bfb3d3c7_3d6ed5c8","updated":"2019-05-31 13:49:20.000000000","message":"Noticed added to a follow on PR - https://review.opendev.org/#/c/662468/","commit_id":"8e482688da2acfaf11540c0a56ee66f166e4503e"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"07eb23620f0fd8a16a191401394dc17d8b462585","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            PATH: \"/bin:/usr/bin:/sbin:/usr/sbin\""},{"line_number":73,"context_line":"          changed_when: false"},{"line_number":74,"context_line":"          failed_when: false"},{"line_number":75,"context_line":"          register: tuned_check"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        - name: Run tuned setup"},{"line_number":78,"context_line":"          when:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bfb3d3c7_3d6ed5c8","line":75,"in_reply_to":"bfb3d3c7_667ccb71","updated":"2019-05-31 13:37:17.000000000","message":"Done","commit_id":"8e482688da2acfaf11540c0a56ee66f166e4503e"}],"extraconfig/pre_network/boot-params-service.yaml":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"8106f5febe6d6bac8b097fd3058c2d1362614796","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    tags:"},{"line_number":40,"context_line":"      - role_specific"},{"line_number":41,"context_line":"  TunedProfileName:"},{"line_number":42,"context_line":"    default: \u0027throughput-performance\u0027"},{"line_number":43,"context_line":"    type: string"},{"line_number":44,"context_line":"    description: Tuned Profile to apply to the host"},{"line_number":45,"context_line":"    tags:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bfb3d3c7_fab5e332","line":42,"updated":"2019-05-28 17:51:49.000000000","message":"Note for those who wonder but I think Kevin changed the default here to match with the default in puppet-tripleo: https://review.opendev.org/#/c/661789/1/manifests/profile/base/tuned.pp","commit_id":"479ce78931a3bc88b3b182b04c9d3226072ccd3d"}]}