)]}'
{"deployment/undercloud/undercloud-upgrade.yaml":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"0f5e31cb754e95fa2946ca95af19081dad44bba9","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        step_config: \u0027\u0027"},{"line_number":46,"context_line":"        config_image: \u0027\u0027"},{"line_number":47,"context_line":"      upgrade_tasks:"},{"line_number":48,"context_line":"        # With the layered product packaging, the key package is rhosp-openvswitch. It depends on"},{"line_number":49,"context_line":"        # a openvswitch package that includes the version as part of the name (e.g openvswitch2.10)."},{"line_number":50,"context_line":"        # This requires some additional special handling:"},{"line_number":51,"context_line":"        #   - During an upgrade the package name for openvswitch may change so"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bfb3d3c7_06fcefb2","line":48,"updated":"2019-05-31 00:20:47.000000000","message":"is rhosp-openvswitch going to land upstream?  If not I\u0027m not sure we should use this logic here.","commit_id":"bbc18dd8d8db9f24bfb1e7dbb5ee760bd9036465"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"d59eb2042e3e16fef4e5c5ed9396e223b1d8629b","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        step_config: \u0027\u0027"},{"line_number":46,"context_line":"        config_image: \u0027\u0027"},{"line_number":47,"context_line":"      upgrade_tasks:"},{"line_number":48,"context_line":"        # With the layered product packaging, the key package is rhosp-openvswitch. It depends on"},{"line_number":49,"context_line":"        # a openvswitch package that includes the version as part of the name (e.g openvswitch2.10)."},{"line_number":50,"context_line":"        # This requires some additional special handling:"},{"line_number":51,"context_line":"        #   - During an upgrade the package name for openvswitch may change so"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fb8cfa7_e87cddb6","line":48,"in_reply_to":"bfb3d3c7_06fcefb2","updated":"2019-06-03 12:50:12.000000000","message":"do you suggest to make this patch a downstream only one? then we should do the same in the tripleo-packages.yaml template too (https://github.com/openstack/tripleo-heat-templates/blob/master/deployment/tripleo-packages/tripleo-packages-baremetal-puppet.yaml#L102-L188) , shouldn\u0027t we?","commit_id":"bbc18dd8d8db9f24bfb1e7dbb5ee760bd9036465"},{"author":{"_account_id":29222,"name":"Natal Ngétal","email":"hobbestigrou@erakis.eu","username":"hobbestigrou"},"change_message_id":"e6a03d812276074aa76def62923c16c8a8f852d6","unresolved":false,"context_lines":[{"line_number":118,"context_line":"              set_fact:"},{"line_number":119,"context_line":"                package_suffix: \"{{ current_ovs_version }}\""},{"line_number":120,"context_line":"              when:"},{"line_number":121,"context_line":"                - current_ovs_major_version|int \u003e\u003d 3 or current_ovs_minor_version|int \u003e\u003d10"},{"line_number":122,"context_line":"            - name: remove old OpenvSwitch package(s) if version doesn\u0027t match"},{"line_number":123,"context_line":"              shell: |"},{"line_number":124,"context_line":"                rpm -e --noscripts --nopreun --nopostun --notriggers --nodeps $(rpm -qa \u0027openvswitch{{ package_suffix|default(\u0027\u0027) }}*\u0027 | grep -v \u0027selinux\u0027)"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bfb3d3c7_2747c2be","line":121,"updated":"2019-05-30 09:12:42.000000000","message":"I think you can replace your or by a new item list.","commit_id":"bbc18dd8d8db9f24bfb1e7dbb5ee760bd9036465"},{"author":{"_account_id":29222,"name":"Natal Ngétal","email":"hobbestigrou@erakis.eu","username":"hobbestigrou"},"change_message_id":"02ca53a5f2eade9854cfb36ddb08ceeb61460f6a","unresolved":false,"context_lines":[{"line_number":118,"context_line":"              set_fact:"},{"line_number":119,"context_line":"                package_suffix: \"{{ current_ovs_version }}\""},{"line_number":120,"context_line":"              when:"},{"line_number":121,"context_line":"                - current_ovs_major_version|int \u003e\u003d 3 or current_ovs_minor_version|int \u003e\u003d10"},{"line_number":122,"context_line":"            - name: remove old OpenvSwitch package(s) if version doesn\u0027t match"},{"line_number":123,"context_line":"              shell: |"},{"line_number":124,"context_line":"                rpm -e --noscripts --nopreun --nopostun --notriggers --nodeps $(rpm -qa \u0027openvswitch{{ package_suffix|default(\u0027\u0027) }}*\u0027 | grep -v \u0027selinux\u0027)"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bfb3d3c7_391a86cb","line":121,"in_reply_to":"bfb3d3c7_2747c2be","updated":"2019-05-30 10:19:10.000000000","message":"Sorry it\u0027s a wrong comment. Little cosmetic thing, you have only one item so maybe you can have the condition and when clause on the same line.","commit_id":"bbc18dd8d8db9f24bfb1e7dbb5ee760bd9036465"},{"author":{"_account_id":29222,"name":"Natal Ngétal","email":"hobbestigrou@erakis.eu","username":"hobbestigrou"},"change_message_id":"e6a03d812276074aa76def62923c16c8a8f852d6","unresolved":false,"context_lines":[{"line_number":168,"context_line":"              register: ovs_list_of_rpms"},{"line_number":169,"context_line":"            - name: Manual upgrade of OVS"},{"line_number":170,"context_line":"              shell: |"},{"line_number":171,"context_line":"                rpm -U --replacepkgs --notriggerun --nopostun {{item}}"},{"line_number":172,"context_line":"              args:"},{"line_number":173,"context_line":"                chdir: /root/OVS_UPGRADE"},{"line_number":174,"context_line":"              with_items:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bfb3d3c7_87254e0b","line":171,"updated":"2019-05-30 09:12:42.000000000","message":"Maybe here you can use command module, when it\u0027s possible it\u0027s better to use it for security reason.","commit_id":"bbc18dd8d8db9f24bfb1e7dbb5ee760bd9036465"},{"author":{"_account_id":29222,"name":"Natal Ngétal","email":"hobbestigrou@erakis.eu","username":"hobbestigrou"},"change_message_id":"460154dfd54c64649e99f0e9ae9c9c88d3ce7ac6","unresolved":false,"context_lines":[{"line_number":168,"context_line":"              register: ovs_list_of_rpms"},{"line_number":169,"context_line":"            - name: Manual upgrade of OVS"},{"line_number":170,"context_line":"              shell: |"},{"line_number":171,"context_line":"                rpm -U --replacepkgs --notriggerun --nopostun {{item}}"},{"line_number":172,"context_line":"              args:"},{"line_number":173,"context_line":"                chdir: /root/OVS_UPGRADE"},{"line_number":174,"context_line":"              with_items:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bfb3d3c7_99437242","line":171,"in_reply_to":"bfb3d3c7_07207eab","updated":"2019-05-30 09:37:15.000000000","message":"Yes you\u0027re right.","commit_id":"bbc18dd8d8db9f24bfb1e7dbb5ee760bd9036465"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"31f8514d0d6903bee60180f25c031243fe2f2fe5","unresolved":false,"context_lines":[{"line_number":168,"context_line":"              register: ovs_list_of_rpms"},{"line_number":169,"context_line":"            - name: Manual upgrade of OVS"},{"line_number":170,"context_line":"              shell: |"},{"line_number":171,"context_line":"                rpm -U --replacepkgs --notriggerun --nopostun {{item}}"},{"line_number":172,"context_line":"              args:"},{"line_number":173,"context_line":"                chdir: /root/OVS_UPGRADE"},{"line_number":174,"context_line":"              with_items:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bfb3d3c7_07207eab","line":171,"in_reply_to":"bfb3d3c7_87254e0b","updated":"2019-05-30 09:32:23.000000000","message":"That\u0027s a fair comment...maybe we could address it in a follow up patch where we would modify it in both templates: https://github.com/openstack/tripleo-heat-templates/blob/master/deployment/tripleo-packages/tripleo-packages-baremetal-puppet.yaml#L129","commit_id":"bbc18dd8d8db9f24bfb1e7dbb5ee760bd9036465"}]}