)]}'
{"network/config/multiple-nics/role.role.j2.yaml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"3c56521c027acaa680e183d5ee5f9fffad987249","unresolved":false,"context_lines":[{"line_number":156,"context_line":"{%-             endif %}"},{"line_number":157,"context_line":"{%-         endif %}"},{"line_number":158,"context_line":"{#- We need bridge also for ComputeDVR and Computes with OVN #}"},{"line_number":159,"context_line":"{%-     elif network.name in role.networks or role.name \u003d\u003d \u0027Networker\u0027 or role.name \u003d\u003d \u0027ComputeDVR\u0027 or (role.name \u003d\u003d \u0027Compute\u0027 and \u0027OS::TripleO::Services::OVNController\u0027 in role.ServicesDefault)%}"},{"line_number":160,"context_line":"              - type: ovs_bridge"},{"line_number":161,"context_line":"{%-         if network.name \u003d\u003d \"External\" %}"},{"line_number":162,"context_line":"                name: bridge_name"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bfb3d3c7_f53962f1","line":159,"range":{"start_line":159,"start_character":74,"end_line":159,"end_character":126},"updated":"2019-05-29 15:33:54.000000000","message":"may be a regex to cover also DPDK/SR-IOV enabled cases?","commit_id":"d5f1fb3ad7fd177ecf506e80d0a9034c6be08a12"},{"author":{"_account_id":12398,"name":"Dan Sneddon","email":"dsneddon@redhat.com","username":"dsneddon"},"change_message_id":"b3ac05ddf5713616588084a424c4eee8f73cee44","unresolved":false,"context_lines":[{"line_number":156,"context_line":"{%-             endif %}"},{"line_number":157,"context_line":"{%-         endif %}"},{"line_number":158,"context_line":"{#- We need bridge also for ComputeDVR and Computes with OVN #}"},{"line_number":159,"context_line":"{%-     elif network.name in role.networks or role.name \u003d\u003d \u0027Networker\u0027 or role.name \u003d\u003d \u0027ComputeDVR\u0027 or (role.name \u003d\u003d \u0027Compute\u0027 and \u0027OS::TripleO::Services::OVNController\u0027 in role.ServicesDefault)%}"},{"line_number":160,"context_line":"              - type: ovs_bridge"},{"line_number":161,"context_line":"{%-         if network.name \u003d\u003d \"External\" %}"},{"line_number":162,"context_line":"                name: bridge_name"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bfb3d3c7_b9ee641f","line":159,"range":{"start_line":159,"start_character":74,"end_line":159,"end_character":126},"in_reply_to":"bfb3d3c7_8c76dc3d","updated":"2019-05-31 01:37:58.000000000","message":"Compute roles are the most often renamed to other things. In spine/leaf deployments it is common to create roles like ComputeLeaf2, for instance.\n\nWould there ever be a reason to set OS::TripleO::Services::OVNController in a role that does not need an external bridge? Otherwise we can do the following:\n\nelif network.name in role.networks or role.name \u003d\u003d \u0027Networker\u0027 or role.name \u003d\u003d \u0027ComputeDVR\u0027 or (\u0027OS::TripleO::Services::OVNController\u0027 in role.ServicesDefault)\n\nWe can always implement a better mechanism in a later patch, but will the above work for all role names (Compute, Compute1, DC1Compute3, Foo)?","commit_id":"d5f1fb3ad7fd177ecf506e80d0a9034c6be08a12"},{"author":{"_account_id":11082,"name":"Kamil Sambor","email":"ksambor@redhat.com","username":"ksambor"},"change_message_id":"1ab5135bb84ecb3804bab9ac3b5b68bb7624279d","unresolved":false,"context_lines":[{"line_number":156,"context_line":"{%-             endif %}"},{"line_number":157,"context_line":"{%-         endif %}"},{"line_number":158,"context_line":"{#- We need bridge also for ComputeDVR and Computes with OVN #}"},{"line_number":159,"context_line":"{%-     elif network.name in role.networks or role.name \u003d\u003d \u0027Networker\u0027 or role.name \u003d\u003d \u0027ComputeDVR\u0027 or (role.name \u003d\u003d \u0027Compute\u0027 and \u0027OS::TripleO::Services::OVNController\u0027 in role.ServicesDefault)%}"},{"line_number":160,"context_line":"              - type: ovs_bridge"},{"line_number":161,"context_line":"{%-         if network.name \u003d\u003d \"External\" %}"},{"line_number":162,"context_line":"                name: bridge_name"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bfb3d3c7_32584986","line":159,"range":{"start_line":159,"start_character":74,"end_line":159,"end_character":126},"in_reply_to":"bfb3d3c7_8c76dc3d","updated":"2019-05-31 06:50:46.000000000","message":"IMO this sounds good but prefer to do this in follow up patch","commit_id":"d5f1fb3ad7fd177ecf506e80d0a9034c6be08a12"},{"author":{"_account_id":11082,"name":"Kamil Sambor","email":"ksambor@redhat.com","username":"ksambor"},"change_message_id":"1ab5135bb84ecb3804bab9ac3b5b68bb7624279d","unresolved":false,"context_lines":[{"line_number":156,"context_line":"{%-             endif %}"},{"line_number":157,"context_line":"{%-         endif %}"},{"line_number":158,"context_line":"{#- We need bridge also for ComputeDVR and Computes with OVN #}"},{"line_number":159,"context_line":"{%-     elif network.name in role.networks or role.name \u003d\u003d \u0027Networker\u0027 or role.name \u003d\u003d \u0027ComputeDVR\u0027 or (role.name \u003d\u003d \u0027Compute\u0027 and \u0027OS::TripleO::Services::OVNController\u0027 in role.ServicesDefault)%}"},{"line_number":160,"context_line":"              - type: ovs_bridge"},{"line_number":161,"context_line":"{%-         if network.name \u003d\u003d \"External\" %}"},{"line_number":162,"context_line":"                name: bridge_name"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bfb3d3c7_f2e2b19f","line":159,"range":{"start_line":159,"start_character":74,"end_line":159,"end_character":126},"in_reply_to":"bfb3d3c7_b9ee641f","updated":"2019-05-31 06:50:46.000000000","message":"Unfortunately Controller have the same service so we need to check if role is compute, but in next patch we can simplified this by additional parameter for br-ex","commit_id":"d5f1fb3ad7fd177ecf506e80d0a9034c6be08a12"},{"author":{"_account_id":12398,"name":"Dan Sneddon","email":"dsneddon@redhat.com","username":"dsneddon"},"change_message_id":"ce8e550aeabaec7d490e314a23b26c3d2ca7dce4","unresolved":false,"context_lines":[{"line_number":156,"context_line":"{%-             endif %}"},{"line_number":157,"context_line":"{%-         endif %}"},{"line_number":158,"context_line":"{#- We need bridge also for ComputeDVR and Computes with OVN #}"},{"line_number":159,"context_line":"{%-     elif network.name in role.networks or role.name \u003d\u003d \u0027Networker\u0027 or role.name \u003d\u003d \u0027ComputeDVR\u0027 or (role.name \u003d\u003d \u0027Compute\u0027 and \u0027OS::TripleO::Services::OVNController\u0027 in role.ServicesDefault)%}"},{"line_number":160,"context_line":"              - type: ovs_bridge"},{"line_number":161,"context_line":"{%-         if network.name \u003d\u003d \"External\" %}"},{"line_number":162,"context_line":"                name: bridge_name"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bfb3d3c7_8c76dc3d","line":159,"range":{"start_line":159,"start_character":74,"end_line":159,"end_character":126},"in_reply_to":"bfb3d3c7_d50bfe26","updated":"2019-05-31 01:33:49.000000000","message":"I am not crazy about doing this by role name. I think we should probably add a parameter to roles_data.yaml for whether or not the compute should have a bridge. That way we could check here like this:\n\n{%-     elif role.external_bridge or (role.name \u003d\u003d ‘Compute’ and ‘OS::TripleO::Service::OVNController’ in role.ServiceDefault) %}\n\nI’d like some feedback on this suggestion.","commit_id":"d5f1fb3ad7fd177ecf506e80d0a9034c6be08a12"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"64922697424ec0c23f16d3ef829235d8472f4643","unresolved":false,"context_lines":[{"line_number":156,"context_line":"{%-             endif %}"},{"line_number":157,"context_line":"{%-         endif %}"},{"line_number":158,"context_line":"{#- We need bridge also for ComputeDVR and Computes with OVN #}"},{"line_number":159,"context_line":"{%-     elif network.name in role.networks or role.name \u003d\u003d \u0027Networker\u0027 or role.name \u003d\u003d \u0027ComputeDVR\u0027 or (role.name \u003d\u003d \u0027Compute\u0027 and \u0027OS::TripleO::Services::OVNController\u0027 in role.ServicesDefault)%}"},{"line_number":160,"context_line":"              - type: ovs_bridge"},{"line_number":161,"context_line":"{%-         if network.name \u003d\u003d \"External\" %}"},{"line_number":162,"context_line":"                name: bridge_name"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bfb3d3c7_d50bfe26","line":159,"range":{"start_line":159,"start_character":74,"end_line":159,"end_character":126},"in_reply_to":"bfb3d3c7_f53962f1","updated":"2019-05-29 15:34:47.000000000","message":"oh wait, those are probably have yet been tested for OVN","commit_id":"d5f1fb3ad7fd177ecf506e80d0a9034c6be08a12"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"d77192c874675ef45d477ac85bfac83ee76de0f7","unresolved":false,"context_lines":[{"line_number":156,"context_line":"{%-             endif %}"},{"line_number":157,"context_line":"{%-         endif %}"},{"line_number":158,"context_line":"{#- We need bridge also for ComputeDVR and Computes with OVN #}"},{"line_number":159,"context_line":"{%-     elif network.name in role.networks or role.name \u003d\u003d \u0027Networker\u0027 or \u0027create_br_ex\u0027 in role.tags %}"},{"line_number":160,"context_line":"              - type: ovs_bridge"},{"line_number":161,"context_line":"{%-         if network.name \u003d\u003d \"External\" %}"},{"line_number":162,"context_line":"                name: bridge_name"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9fb8cfa7_e2bcf9bc","line":159,"range":{"start_line":159,"start_character":60,"end_line":159,"end_character":70},"updated":"2019-06-03 15:10:46.000000000","message":"can we not add the tag to the Networker node as well?","commit_id":"7dd8de0143f75b6784a041c7cd55cebde8919401"},{"author":{"_account_id":11082,"name":"Kamil Sambor","email":"ksambor@redhat.com","username":"ksambor"},"change_message_id":"fd4b5a002a615c5c53a717657ce462649f5e0fcc","unresolved":false,"context_lines":[{"line_number":156,"context_line":"{%-             endif %}"},{"line_number":157,"context_line":"{%-         endif %}"},{"line_number":158,"context_line":"{#- We need bridge also for ComputeDVR and Computes with OVN #}"},{"line_number":159,"context_line":"{%-     elif network.name in role.networks or role.name \u003d\u003d \u0027Networker\u0027 or \u0027create_br_ex\u0027 in role.tags %}"},{"line_number":160,"context_line":"              - type: ovs_bridge"},{"line_number":161,"context_line":"{%-         if network.name \u003d\u003d \"External\" %}"},{"line_number":162,"context_line":"                name: bridge_name"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9fb8cfa7_620f972e","line":159,"range":{"start_line":159,"start_character":60,"end_line":159,"end_character":70},"in_reply_to":"9fb8cfa7_e2bcf9bc","updated":"2019-06-04 09:48:07.000000000","message":"Done","commit_id":"7dd8de0143f75b6784a041c7cd55cebde8919401"}],"releasenotes/notes/create-br-ex-for-compute-b967312323d45d9b.yaml":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"e0153119f2ca7049a23e5c68e813c4c068f166b1","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Introduce new tag into roles that will create external_bridge (usable only"},{"line_number":5,"context_line":"    for multiple-nics)"},{"line_number":6,"context_line":"upgrade:"},{"line_number":7,"context_line":"  - |"},{"line_number":8,"context_line":"    During upgrade user will need to create custom roles_data.yaml and remove"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9fb8cfa7_c55f6de3","line":5,"updated":"2019-06-04 10:24:38.000000000","message":"nit: punctuation.","commit_id":"1bda55bb29c88135bad43b5e4f44a7672cf2ef3f"},{"author":{"_account_id":11082,"name":"Kamil Sambor","email":"ksambor@redhat.com","username":"ksambor"},"change_message_id":"01af4587c922f6f990124bd7006524cce7c24a94","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Introduce new tag into roles that will create external_bridge (usable only"},{"line_number":5,"context_line":"    for multiple-nics)"},{"line_number":6,"context_line":"upgrade:"},{"line_number":7,"context_line":"  - |"},{"line_number":8,"context_line":"    During upgrade user will need to create custom roles_data.yaml and remove"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9fb8cfa7_0f6a6db2","line":5,"in_reply_to":"9fb8cfa7_c55f6de3","updated":"2019-06-05 08:16:06.000000000","message":"Done","commit_id":"1bda55bb29c88135bad43b5e4f44a7672cf2ef3f"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"db12ae52caaaabea0aa0fa96c4f2b4dc5a116661","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    for multiple-nics)"},{"line_number":6,"context_line":"upgrade:"},{"line_number":7,"context_line":"  - |"},{"line_number":8,"context_line":"    During upgrade user will need to create custom roles_data.yaml and remove"},{"line_number":9,"context_line":"    external_bridge from tags to be sure that bridge will be not added"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9fb8cfa7_bbeb76ae","line":9,"range":{"start_line":8,"start_character":70,"end_line":9,"end_character":70},"updated":"2019-06-04 12:29:21.000000000","message":"What will be the outcome if the user misses the step of removing external_bridge on upgrade?  Will it be a performance hit or something else?","commit_id":"1bda55bb29c88135bad43b5e4f44a7672cf2ef3f"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"e0153119f2ca7049a23e5c68e813c4c068f166b1","unresolved":false,"context_lines":[{"line_number":6,"context_line":"upgrade:"},{"line_number":7,"context_line":"  - |"},{"line_number":8,"context_line":"    During upgrade user will need to create custom roles_data.yaml and remove"},{"line_number":9,"context_line":"    external_bridge from tags to be sure that bridge will be not added"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9fb8cfa7_855975ff","line":9,"updated":"2019-06-04 10:24:38.000000000","message":"nit: punctuation.","commit_id":"1bda55bb29c88135bad43b5e4f44a7672cf2ef3f"},{"author":{"_account_id":11082,"name":"Kamil Sambor","email":"ksambor@redhat.com","username":"ksambor"},"change_message_id":"01af4587c922f6f990124bd7006524cce7c24a94","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    for multiple-nics)"},{"line_number":6,"context_line":"upgrade:"},{"line_number":7,"context_line":"  - |"},{"line_number":8,"context_line":"    During upgrade user will need to create custom roles_data.yaml and remove"},{"line_number":9,"context_line":"    external_bridge from tags to be sure that bridge will be not added"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9fb8cfa7_cf63f5db","line":9,"range":{"start_line":8,"start_character":70,"end_line":9,"end_character":70},"in_reply_to":"9fb8cfa7_8d0d0a40","updated":"2019-06-05 08:16:06.000000000","message":"Done","commit_id":"1bda55bb29c88135bad43b5e4f44a7672cf2ef3f"},{"author":{"_account_id":12398,"name":"Dan Sneddon","email":"dsneddon@redhat.com","username":"dsneddon"},"change_message_id":"904880ebe4f332d24838a5d52f2288c7aa340fe1","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    for multiple-nics)"},{"line_number":6,"context_line":"upgrade:"},{"line_number":7,"context_line":"  - |"},{"line_number":8,"context_line":"    During upgrade user will need to create custom roles_data.yaml and remove"},{"line_number":9,"context_line":"    external_bridge from tags to be sure that bridge will be not added"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9fb8cfa7_8d0d0a40","line":9,"range":{"start_line":8,"start_character":70,"end_line":9,"end_character":70},"in_reply_to":"9fb8cfa7_bbeb76ae","updated":"2019-06-05 05:40:29.000000000","message":"The performance impact is minimal, similar to when installers use a br-isolated bridge to host VLANs. In the built-in multiple NICs templates it would cause Compute nodes to have an additional NIC configured. Since this change only affects the built-in templates, which are probably never used without customization in production deployments, I think it\u0027s OK. Documentation instructs the user render the example templates and adjust as needed.","commit_id":"1bda55bb29c88135bad43b5e4f44a7672cf2ef3f"}],"roles/Compute.yaml":[{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"dabcf18d37815ebed821b67e8f066165115554ef","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  description: |"},{"line_number":6,"context_line":"    Basic Compute Node role"},{"line_number":7,"context_line":"  CountDefault: 1"},{"line_number":8,"context_line":"  # Create external Neutron bridge (unset if using ML2/OVS without DVR)"},{"line_number":9,"context_line":"  tags:"},{"line_number":10,"context_line":"    - external_bridge"},{"line_number":11,"context_line":"  networks:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9fb8cfa7_58a03bf5","line":8,"updated":"2019-06-04 15:00:12.000000000","message":"Looks like a pep8 error - http://logs.openstack.org/39/661939/5/check/openstack-tox-pep8/3b40e45/job-output.txt.gz#_2019-06-04_12_46_34_812082","commit_id":"1bda55bb29c88135bad43b5e4f44a7672cf2ef3f"},{"author":{"_account_id":11082,"name":"Kamil Sambor","email":"ksambor@redhat.com","username":"ksambor"},"change_message_id":"01af4587c922f6f990124bd7006524cce7c24a94","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  description: |"},{"line_number":6,"context_line":"    Basic Compute Node role"},{"line_number":7,"context_line":"  CountDefault: 1"},{"line_number":8,"context_line":"  # Create external Neutron bridge (unset if using ML2/OVS without DVR)"},{"line_number":9,"context_line":"  tags:"},{"line_number":10,"context_line":"    - external_bridge"},{"line_number":11,"context_line":"  networks:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9fb8cfa7_ef5ef910","line":8,"in_reply_to":"9fb8cfa7_282dec94","updated":"2019-06-05 08:16:06.000000000","message":"Done","commit_id":"1bda55bb29c88135bad43b5e4f44a7672cf2ef3f"},{"author":{"_account_id":12398,"name":"Dan Sneddon","email":"dsneddon@redhat.com","username":"dsneddon"},"change_message_id":"904880ebe4f332d24838a5d52f2288c7aa340fe1","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  description: |"},{"line_number":6,"context_line":"    Basic Compute Node role"},{"line_number":7,"context_line":"  CountDefault: 1"},{"line_number":8,"context_line":"  # Create external Neutron bridge (unset if using ML2/OVS without DVR)"},{"line_number":9,"context_line":"  tags:"},{"line_number":10,"context_line":"    - external_bridge"},{"line_number":11,"context_line":"  networks:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9fb8cfa7_282dec94","line":8,"in_reply_to":"9fb8cfa7_58a03bf5","updated":"2019-06-05 05:40:29.000000000","message":"ERROR: Generated roles file not match the current /home/dsneddon/workspace/tripleo-heat-templates/roles_data.yaml\n\nWhen changing the roles you have to either add the identical line to roles_data.yaml, or you can run ./tools/roles-data-generate-samples.sh from the THT root.","commit_id":"1bda55bb29c88135bad43b5e4f44a7672cf2ef3f"}],"roles_data.yaml":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"d77192c874675ef45d477ac85bfac83ee76de0f7","unresolved":false,"context_lines":[{"line_number":194,"context_line":"  description: |"},{"line_number":195,"context_line":"    Basic Compute Node role"},{"line_number":196,"context_line":"  CountDefault: 1"},{"line_number":197,"context_line":"  tags:"},{"line_number":198,"context_line":"    - create_br_ex"},{"line_number":199,"context_line":"  networks:"},{"line_number":200,"context_line":"    InternalApi:"},{"line_number":201,"context_line":"      subnet: internal_api_subnet"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9fb8cfa7_8245fd72","line":198,"range":{"start_line":197,"start_character":0,"end_line":198,"end_character":18},"updated":"2019-06-03 15:10:46.000000000","message":"Could be just br-ex ? \n\nI like this because it solves the problem of duplicating roles.\n\nThe pita is that this actually still breaks upgrades. i.e anyone upgrading need to create a custom roles_data.yaml and remove this tag to ensure the bridge is\u0027nt added. (Now, I\u0027d also say that 99% of deployments do not point out the jinja rendered nic-config templates directly, so almost no one would actually be affected.) Maby add a releasnote with a comment in the upgrades section for this?","commit_id":"7dd8de0143f75b6784a041c7cd55cebde8919401"},{"author":{"_account_id":11082,"name":"Kamil Sambor","email":"ksambor@redhat.com","username":"ksambor"},"change_message_id":"fd4b5a002a615c5c53a717657ce462649f5e0fcc","unresolved":false,"context_lines":[{"line_number":194,"context_line":"  description: |"},{"line_number":195,"context_line":"    Basic Compute Node role"},{"line_number":196,"context_line":"  CountDefault: 1"},{"line_number":197,"context_line":"  tags:"},{"line_number":198,"context_line":"    - create_br_ex"},{"line_number":199,"context_line":"  networks:"},{"line_number":200,"context_line":"    InternalApi:"},{"line_number":201,"context_line":"      subnet: internal_api_subnet"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9fb8cfa7_e203870c","line":198,"range":{"start_line":197,"start_character":0,"end_line":198,"end_character":18},"in_reply_to":"9fb8cfa7_8245fd72","updated":"2019-06-04 09:48:07.000000000","message":"Done","commit_id":"7dd8de0143f75b6784a041c7cd55cebde8919401"},{"author":{"_account_id":12398,"name":"Dan Sneddon","email":"dsneddon@redhat.com","username":"dsneddon"},"change_message_id":"fb2113f9b038f3f9c10d4d6563597f9e6f483915","unresolved":false,"context_lines":[{"line_number":194,"context_line":"  description: |"},{"line_number":195,"context_line":"    Basic Compute Node role"},{"line_number":196,"context_line":"  CountDefault: 1"},{"line_number":197,"context_line":"  tags:"},{"line_number":198,"context_line":"    - create_br_ex"},{"line_number":199,"context_line":"  networks:"},{"line_number":200,"context_line":"    InternalApi:"},{"line_number":201,"context_line":"      subnet: internal_api_subnet"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9fb8cfa7_b6271fb7","line":198,"range":{"start_line":197,"start_character":0,"end_line":198,"end_character":18},"in_reply_to":"9fb8cfa7_8245fd72","updated":"2019-06-03 17:25:25.000000000","message":"I might go with a more generic \"external_bridge\", but it doesn\u0027t really matter.\n\nAs far as upgrades, I would be fine with adding a comment above this, like:\n\n# Create external Neutron bridge (unset if using ML2/OVS without DVR)","commit_id":"7dd8de0143f75b6784a041c7cd55cebde8919401"},{"author":{"_account_id":11082,"name":"Kamil Sambor","email":"ksambor@redhat.com","username":"ksambor"},"change_message_id":"fd4b5a002a615c5c53a717657ce462649f5e0fcc","unresolved":false,"context_lines":[{"line_number":194,"context_line":"  description: |"},{"line_number":195,"context_line":"    Basic Compute Node role"},{"line_number":196,"context_line":"  CountDefault: 1"},{"line_number":197,"context_line":"  tags:"},{"line_number":198,"context_line":"    - create_br_ex"},{"line_number":199,"context_line":"  networks:"},{"line_number":200,"context_line":"    InternalApi:"},{"line_number":201,"context_line":"      subnet: internal_api_subnet"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9fb8cfa7_c2fe8304","line":198,"range":{"start_line":197,"start_character":0,"end_line":198,"end_character":18},"in_reply_to":"9fb8cfa7_b6271fb7","updated":"2019-06-04 09:48:07.000000000","message":"Done","commit_id":"7dd8de0143f75b6784a041c7cd55cebde8919401"}]}