)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"08ff8e9021e52ad4cc4d9707fc33f5b775acff4e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Emilien Macchi \u003cemilien@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-06-06 13:30:19 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP - Use Ansible for {{server_resource_name}}"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Config In puppet/role.role.j2.yaml, replace the SoftwareDeployment resource for"},{"line_number":10,"context_line":"AllNodesDeployment with the usage of the new tripleo-hieradata role."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":21,"id":"9fb8cfa7_94af29e2","line":7,"updated":"2019-06-06 21:09:50.000000000","message":"{{server_resource_name}}Deployment","commit_id":"01afd51248b032009019b44dde7389b09c85a9e0"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"59080875a57f8635723661b1da7aa079ae5b80c7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Emilien Macchi \u003cemilien@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-06-06 13:30:19 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP - Use Ansible for {{server_resource_name}}"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Config In puppet/role.role.j2.yaml, replace the SoftwareDeployment resource for"},{"line_number":10,"context_line":"AllNodesDeployment with the usage of the new tripleo-hieradata role."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":21,"id":"9fb8cfa7_fa343afd","line":7,"in_reply_to":"9fb8cfa7_94af29e2","updated":"2019-06-10 21:18:18.000000000","message":"Done","commit_id":"01afd51248b032009019b44dde7389b09c85a9e0"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"08ff8e9021e52ad4cc4d9707fc33f5b775acff4e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"WIP - Use Ansible for {{server_resource_name}}"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Config In puppet/role.role.j2.yaml, replace the SoftwareDeployment resource for"},{"line_number":10,"context_line":"AllNodesDeployment with the usage of the new tripleo-hieradata role."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ib946b566d66300d23e7abc12498cc11d3f5fa5f8"},{"line_number":13,"context_line":"implements: blueprint reduce-deployment-resources"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":21,"id":"9fb8cfa7_3488bd6f","line":10,"updated":"2019-06-06 21:09:50.000000000","message":"you\u0027re not replacing anything for AllNodesDeployment in this patch","commit_id":"01afd51248b032009019b44dde7389b09c85a9e0"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"59080875a57f8635723661b1da7aa079ae5b80c7","unresolved":false,"context_lines":[{"line_number":7,"context_line":"WIP - Use Ansible for {{server_resource_name}}"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Config In puppet/role.role.j2.yaml, replace the SoftwareDeployment resource for"},{"line_number":10,"context_line":"AllNodesDeployment with the usage of the new tripleo-hieradata role."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ib946b566d66300d23e7abc12498cc11d3f5fa5f8"},{"line_number":13,"context_line":"implements: blueprint reduce-deployment-resources"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":21,"id":"9fb8cfa7_9a3bbee9","line":10,"in_reply_to":"9fb8cfa7_3488bd6f","updated":"2019-06-10 21:18:18.000000000","message":"Done","commit_id":"01afd51248b032009019b44dde7389b09c85a9e0"}],"common/deploy-steps.j2":[{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"85db2bba5b46d1f87df4110d2651b550bc3a7b5e","unresolved":false,"context_lines":[{"line_number":548,"context_line":"      external_post_deploy_steps_tasks: {get_attr: [ExternalPostDeployTasks, value]}"},{"line_number":549,"context_line":"{%- for role in roles %}"},{"line_number":550,"context_line":"      {{role.name}}/all-nodes-deployment-hieradata.j2: {get_param: {{role.name}}AllNodesDeploymentHieradata}"},{"line_number":551,"context_line":"      {{role.name}}/deployment-hieradata.j2: {get_param: {{role.name}}DeploymentHieradata}"},{"line_number":552,"context_line":"{%- endfor %}"},{"line_number":553,"context_line":"      update_steps_tasks: |"},{"line_number":554,"context_line":"{%- for role in roles %}"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"9fb8cfa7_36455db4","line":551,"updated":"2019-06-04 13:23:16.000000000","message":"you don\u0027t pass this parameter into this template","commit_id":"9be8c8d279a68d0bd82a396d600065a0ee9ea644"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"19cc42afd36534c2043fb3ef1d5550419df092dd","unresolved":false,"context_lines":[{"line_number":548,"context_line":"      external_post_deploy_steps_tasks: {get_attr: [ExternalPostDeployTasks, value]}"},{"line_number":549,"context_line":"{%- for role in roles %}"},{"line_number":550,"context_line":"      {{role.name}}/all-nodes-deployment-hieradata.j2: {get_param: {{role.name}}AllNodesDeploymentHieradata}"},{"line_number":551,"context_line":"      {{role.name}}/deployment-hieradata.j2: {get_param: {{role.name}}DeploymentHieradata}"},{"line_number":552,"context_line":"{%- endfor %}"},{"line_number":553,"context_line":"      update_steps_tasks: |"},{"line_number":554,"context_line":"{%- for role in roles %}"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"9fb8cfa7_d53b9635","line":551,"in_reply_to":"9fb8cfa7_36455db4","updated":"2019-06-04 14:40:13.000000000","message":"Done","commit_id":"9be8c8d279a68d0bd82a396d600065a0ee9ea644"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"08ff8e9021e52ad4cc4d9707fc33f5b775acff4e","unresolved":false,"context_lines":[{"line_number":559,"context_line":"      external_post_deploy_steps_tasks: {get_attr: [ExternalPostDeployTasks, value]}"},{"line_number":560,"context_line":"{%- for role in roles %}"},{"line_number":561,"context_line":"      {{role.name}}/all-nodes-deployment-hieradata.j2: {get_param: {{role.name}}AllNodesDeploymentHieradata}"},{"line_number":562,"context_line":"      {{role.name}}/deployment-hieradata.j2: {get_param: {{role.name}}DeploymentHieradata}"},{"line_number":563,"context_line":"{%- endfor %}"},{"line_number":564,"context_line":"      update_steps_tasks: |"},{"line_number":565,"context_line":"{%- for role in roles %}"}],"source_content_type":"text/x-jinja2","patch_set":21,"id":"9fb8cfa7_d4f36109","line":562,"updated":"2019-06-06 21:09:50.000000000","message":"you may need to also write the file with a .yaml extension. See:\nhttps://review.opendev.org/#/c/663771/\n\nThere\u0027s a co-dependency between tripleo-common and tripleo-heat-templates in this case, so we\u0027ll need to temporarily write both paths.","commit_id":"01afd51248b032009019b44dde7389b09c85a9e0"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"59080875a57f8635723661b1da7aa079ae5b80c7","unresolved":false,"context_lines":[{"line_number":559,"context_line":"      external_post_deploy_steps_tasks: {get_attr: [ExternalPostDeployTasks, value]}"},{"line_number":560,"context_line":"{%- for role in roles %}"},{"line_number":561,"context_line":"      {{role.name}}/all-nodes-deployment-hieradata.j2: {get_param: {{role.name}}AllNodesDeploymentHieradata}"},{"line_number":562,"context_line":"      {{role.name}}/deployment-hieradata.j2: {get_param: {{role.name}}DeploymentHieradata}"},{"line_number":563,"context_line":"{%- endfor %}"},{"line_number":564,"context_line":"      update_steps_tasks: |"},{"line_number":565,"context_line":"{%- for role in roles %}"}],"source_content_type":"text/x-jinja2","patch_set":21,"id":"9fb8cfa7_ba17a251","line":562,"in_reply_to":"9fb8cfa7_d4f36109","updated":"2019-06-10 21:18:18.000000000","message":"Done","commit_id":"01afd51248b032009019b44dde7389b09c85a9e0"}],"overcloud.j2.yaml":[{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"85db2bba5b46d1f87df4110d2651b550bc3a7b5e","unresolved":false,"context_lines":[{"line_number":1039,"context_line":"      ssh_known_hosts_hostnames: {get_attr: [SshKnownHostsHostnames, value]}"},{"line_number":1040,"context_line":"{%- for role in roles %}"},{"line_number":1041,"context_line":"      {{role.name}}Count: {get_param: {{role.name}}Count}"},{"line_number":1042,"context_line":"      {{role.name}}AllNodesDeploymentHieradata: {get_attr: [{{role.name}}allNodesConfig, all_nodes_config_hieradata]}"},{"line_number":1043,"context_line":"{%- endfor %}"},{"line_number":1044,"context_line":"      ServiceNetMapLower: {get_attr: [ServiceNetMap, service_net_map_lower]}"},{"line_number":1045,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9fb8cfa7_361ebdba","line":1042,"updated":"2019-06-04 13:23:16.000000000","message":"here you probably need to pass in the value of {{role.name}}DeploymentHieradata","commit_id":"9be8c8d279a68d0bd82a396d600065a0ee9ea644"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"00f215bf28dd23e901bf56c296e4bfb51adae4d3","unresolved":false,"context_lines":[{"line_number":1040,"context_line":"{%- for role in roles %}"},{"line_number":1041,"context_line":"      {{role.name}}Count: {get_param: {{role.name}}Count}"},{"line_number":1042,"context_line":"      {{role.name}}AllNodesDeploymentHieradata: {get_attr: [{{role.name}}allNodesConfig, all_nodes_config_hieradata]}"},{"line_number":1043,"context_line":"      {{role.name}}DeploymentHieradata: {get_attr: [{{role.name}}Config, config_hieradata]}"},{"line_number":1044,"context_line":"{%- endfor %}"},{"line_number":1045,"context_line":"      ServiceNetMapLower: {get_attr: [ServiceNetMap, service_net_map_lower]}"},{"line_number":1046,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9fb8cfa7_781bbf1a","line":1043,"updated":"2019-06-04 15:09:42.000000000","message":"this doesn\u0027t work, I need to move it","commit_id":"d3958707aed9757a7b3c58ecba3f52a4f0178bb3"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"568b0bc04e0a21a197a2843e846fb47449bbdd98","unresolved":false,"context_lines":[{"line_number":1040,"context_line":"{%- for role in roles %}"},{"line_number":1041,"context_line":"      {{role.name}}Count: {get_param: {{role.name}}Count}"},{"line_number":1042,"context_line":"      {{role.name}}AllNodesDeploymentHieradata: {get_attr: [{{role.name}}allNodesConfig, all_nodes_config_hieradata]}"},{"line_number":1043,"context_line":"      {{role.name}}DeploymentHieradata: {get_attr: [{{role.name}}Config, config_hieradata]}"},{"line_number":1044,"context_line":"{%- endfor %}"},{"line_number":1045,"context_line":"      ServiceNetMapLower: {get_attr: [ServiceNetMap, service_net_map_lower]}"},{"line_number":1046,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9fb8cfa7_f8824fc8","line":1043,"in_reply_to":"9fb8cfa7_781bbf1a","updated":"2019-06-04 15:19:55.000000000","message":"I removed it now I have this ansible task error:\n\nTASK [tripleo-hieradata : Copy hieradata files] ******************************************************************************************************************************\nfatal: [undercloud]: FAILED! \u003d\u003e {\"msg\": \"dict2items requires a dictionary, got \u003cclass \u0027ansible.template.AnsibleUndefined\u0027\u003e instead.\"","commit_id":"d3958707aed9757a7b3c58ecba3f52a4f0178bb3"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"59951f3c31d0eb0cfd7502a4fbd12a40b8651a58","unresolved":false,"context_lines":[{"line_number":1040,"context_line":"{%- for role in roles %}"},{"line_number":1041,"context_line":"      {{role.name}}Count: {get_param: {{role.name}}Count}"},{"line_number":1042,"context_line":"      {{role.name}}AllNodesDeploymentHieradata: {get_attr: [{{role.name}}allNodesConfig, all_nodes_config_hieradata]}"},{"line_number":1043,"context_line":"      {{role.name}}DeploymentHieradata: {get_attr: [{{role.name}}Config, config_hieradata]}"},{"line_number":1044,"context_line":"{%- endfor %}"},{"line_number":1045,"context_line":"      ServiceNetMapLower: {get_attr: [ServiceNetMap, service_net_map_lower]}"},{"line_number":1046,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9fb8cfa7_1e4b8b84","line":1043,"in_reply_to":"9fb8cfa7_f8824fc8","updated":"2019-06-04 17:01:26.000000000","message":"{{role.name}}Config isn\u0027t a resource in this template.\n\nyou probably want get_attr: [{{role.name}}DeploymentHieradata, value]\n\nor just get_attr: [{{role.name}}, config_hieradata]","commit_id":"d3958707aed9757a7b3c58ecba3f52a4f0178bb3"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"9f0a5c4fd35ed200f96767d5ba128894c18125dd","unresolved":false,"context_lines":[{"line_number":1035,"context_line":"      {{role.name}}AllNodesDeploymentHieradata: {get_attr: [{{role.name}}allNodesConfig, all_nodes_config_hieradata]}"},{"line_number":1036,"context_line":"      {{role.name}}DeploymentHieradata:"},{"line_number":1037,"context_line":"        map_merge:"},{"line_number":1038,"context_line":"          list_contat:"},{"line_number":1039,"context_line":"          - {get_attr: [{{role.name}}, config_datafiles]}"},{"line_number":1040,"context_line":"{%- endfor %}"},{"line_number":1041,"context_line":"      ServiceNetMapLower: {get_attr: [ServiceNetMap, service_net_map_lower]}"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"9fb8cfa7_0e1d86bc","line":1038,"updated":"2019-06-05 16:32:36.000000000","message":"typo: list_concat","commit_id":"bbf8d376e0aaf8d794cccf916ebadbcc7845e79f"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"6cbd8f0e12e1ad0f58e7d1fd774ed09701fa41cc","unresolved":false,"context_lines":[{"line_number":1035,"context_line":"      {{role.name}}AllNodesDeploymentHieradata: {get_attr: [{{role.name}}allNodesConfig, all_nodes_config_hieradata]}"},{"line_number":1036,"context_line":"      {{role.name}}DeploymentHieradata:"},{"line_number":1037,"context_line":"        map_merge:"},{"line_number":1038,"context_line":"          list_contat:"},{"line_number":1039,"context_line":"          - {get_attr: [{{role.name}}, config_datafiles]}"},{"line_number":1040,"context_line":"{%- endfor %}"},{"line_number":1041,"context_line":"      ServiceNetMapLower: {get_attr: [ServiceNetMap, service_net_map_lower]}"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"9fb8cfa7_51ad5f2f","line":1038,"in_reply_to":"9fb8cfa7_0e1d86bc","updated":"2019-06-05 17:22:01.000000000","message":"Done","commit_id":"bbf8d376e0aaf8d794cccf916ebadbcc7845e79f"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"9f0a5c4fd35ed200f96767d5ba128894c18125dd","unresolved":false,"context_lines":[{"line_number":1036,"context_line":"      {{role.name}}DeploymentHieradata:"},{"line_number":1037,"context_line":"        map_merge:"},{"line_number":1038,"context_line":"          list_contat:"},{"line_number":1039,"context_line":"          - {get_attr: [{{role.name}}, config_datafiles]}"},{"line_number":1040,"context_line":"{%- endfor %}"},{"line_number":1041,"context_line":"      ServiceNetMapLower: {get_attr: [ServiceNetMap, service_net_map_lower]}"},{"line_number":1042,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"9fb8cfa7_0e726612","line":1039,"updated":"2019-06-05 16:32:36.000000000","message":"you\u0027re calling get_attr on ResourceGroup. that returns a list already.\n\nsee: https://docs.openstack.org/heat/latest/template_guide/openstack.html#OS::Heat::ResourceGroup\n\nalso, this hieradata is different per server as it contains the fqdn. that\u0027s why it\u0027s within the ResourceGroup to begin with. your approach here is not really going to work at all.\n\nyou\u0027ll need to refactor the fqdn elements out into their hieradata items and/or move the \u003crole\u003eConfig resources out of the ResourceGroup.","commit_id":"bbf8d376e0aaf8d794cccf916ebadbcc7845e79f"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"6cbd8f0e12e1ad0f58e7d1fd774ed09701fa41cc","unresolved":false,"context_lines":[{"line_number":1036,"context_line":"      {{role.name}}DeploymentHieradata:"},{"line_number":1037,"context_line":"        map_merge:"},{"line_number":1038,"context_line":"          list_contat:"},{"line_number":1039,"context_line":"          - {get_attr: [{{role.name}}, config_datafiles]}"},{"line_number":1040,"context_line":"{%- endfor %}"},{"line_number":1041,"context_line":"      ServiceNetMapLower: {get_attr: [ServiceNetMap, service_net_map_lower]}"},{"line_number":1042,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"9fb8cfa7_b14cdb9e","line":1039,"in_reply_to":"9fb8cfa7_0e726612","updated":"2019-06-05 17:22:01.000000000","message":"\u003e you\u0027re calling get_attr on ResourceGroup. that returns a list already.\n \u003e \n \u003e see: https://docs.openstack.org/heat/latest/template_guide/openstack.html#OS::Heat::ResourceGroup\n \nOK so I just need to convert the list in a dictionary, probably using map_merge.\n\n \u003e also, this hieradata is different per server as it contains the\n \u003e fqdn. that\u0027s why it\u0027s within the ResourceGroup to begin with. your\n \u003e approach here is not really going to work at all.\n \u003e \n \u003e you\u0027ll need to refactor the fqdn elements out into their hieradata\n \u003e items and/or move the \u003crole\u003eConfig resources out of the\n \u003e ResourceGroup.\n\nNice catch. I\u0027ll look at it.","commit_id":"bbf8d376e0aaf8d794cccf916ebadbcc7845e79f"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"f2b3cbcb8488d3f8a6600b10262e8697992f2d5e","unresolved":false,"context_lines":[{"line_number":1036,"context_line":"      {{role.name}}DeploymentHieradata:"},{"line_number":1037,"context_line":"        map_merge:"},{"line_number":1038,"context_line":"          list_contat:"},{"line_number":1039,"context_line":"          - {get_attr: [{{role.name}}, config_datafiles]}"},{"line_number":1040,"context_line":"{%- endfor %}"},{"line_number":1041,"context_line":"      ServiceNetMapLower: {get_attr: [ServiceNetMap, service_net_map_lower]}"},{"line_number":1042,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"9fb8cfa7_814f0491","line":1039,"in_reply_to":"9fb8cfa7_b14cdb9e","updated":"2019-06-05 21:52:34.000000000","message":"WIP:\n\n* THT: https://review.opendev.org/663430\n* tripleo-common: https://review.opendev.org/663441","commit_id":"bbf8d376e0aaf8d794cccf916ebadbcc7845e79f"}],"puppet/role.role.j2.yaml":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"0520f91d1dc5629ddfba39fcedaa2b66d92a7409","unresolved":false,"context_lines":[{"line_number":681,"context_line":"          - server_not_blacklisted"},{"line_number":682,"context_line":"          - [\u0027CREATE\u0027, \u0027UPDATE\u0027]"},{"line_number":683,"context_line":"          - []"},{"line_number":684,"context_line":""},{"line_number":685,"context_line":"  # TODO(emilien) convert this resource to Ansible with the new"},{"line_number":686,"context_line":"  # tripleo-hieradata role created by https://review.opendev.org/#/c/659144"},{"line_number":687,"context_line":"  {{server_resource_name}}ConfigHierarchy:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bfb3d3c7_fddcbde4","line":684,"updated":"2019-05-31 13:59:39.000000000","message":"all of this is WIP and next patchset will use the new ansible role","commit_id":"65a2234b08bd83c1488f8a0648ea175b0f628773"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"f159eca2a090d7b1e277506d6d3fb5d41dab9f37","unresolved":false,"context_lines":[{"line_number":740,"context_line":"            fqdn_ctlplane: {get_attr: [NetHostMap, value, ctlplane, fqdn]}"},{"line_number":741,"context_line":"            fqdn_canonical: {get_attr: [NetHostMap, value, canonical, fqdn]}"},{"line_number":742,"context_line":""},{"line_number":743,"context_line":"  {{server_resource_name}}ConfigImpl:"},{"line_number":744,"context_line":"    type: OS::Heat::StructuredConfig"},{"line_number":745,"context_line":"    properties:"},{"line_number":746,"context_line":"      group: hiera"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"9fb8cfa7_e93591db","line":743,"updated":"2019-06-05 13:24:08.000000000","message":"this resource isn\u0027t used by anything. why did you move it to a separate resource?\n\nit appears that what you actually want to do is modify {{server_resource_name}}Config to join the value that you separated out into {{server_resource_name}}ConfigDatafiles into its own config.","commit_id":"b669f24ef3e7edabae8694c521f667b5773613f9"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"95c159faa14f0b0c442b5b2b9be842d769c13b7c","unresolved":false,"context_lines":[{"line_number":740,"context_line":"            fqdn_ctlplane: {get_attr: [NetHostMap, value, ctlplane, fqdn]}"},{"line_number":741,"context_line":"            fqdn_canonical: {get_attr: [NetHostMap, value, canonical, fqdn]}"},{"line_number":742,"context_line":""},{"line_number":743,"context_line":"  {{server_resource_name}}ConfigImpl:"},{"line_number":744,"context_line":"    type: OS::Heat::StructuredConfig"},{"line_number":745,"context_line":"    properties:"},{"line_number":746,"context_line":"      group: hiera"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"9fb8cfa7_099a656d","line":743,"in_reply_to":"9fb8cfa7_e93591db","updated":"2019-06-05 13:36:55.000000000","message":"Done","commit_id":"b669f24ef3e7edabae8694c521f667b5773613f9"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"f159eca2a090d7b1e277506d6d3fb5d41dab9f37","unresolved":false,"context_lines":[{"line_number":821,"context_line":"outputs:"},{"line_number":822,"context_line":"  config_hieradata:"},{"line_number":823,"context_line":"    description: The config in the full format with datafiles section."},{"line_number":824,"context_line":"    value: {get_attr: [{{server_resource_name}}ConfigDatafiles, value]}"},{"line_number":825,"context_line":"  ip_address:"},{"line_number":826,"context_line":"    description: IP address of the server in the ctlplane network"},{"line_number":827,"context_line":"    value: {get_attr: [{{server_resource_name}}, networks, ctlplane, 0]}"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"9fb8cfa7_a976b9a3","line":824,"updated":"2019-06-05 13:24:08.000000000","message":"this isn\u0027t all of the hieradata, it\u0027s just the datafiles section.","commit_id":"b669f24ef3e7edabae8694c521f667b5773613f9"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"95c159faa14f0b0c442b5b2b9be842d769c13b7c","unresolved":false,"context_lines":[{"line_number":821,"context_line":"outputs:"},{"line_number":822,"context_line":"  config_hieradata:"},{"line_number":823,"context_line":"    description: The config in the full format with datafiles section."},{"line_number":824,"context_line":"    value: {get_attr: [{{server_resource_name}}ConfigDatafiles, value]}"},{"line_number":825,"context_line":"  ip_address:"},{"line_number":826,"context_line":"    description: IP address of the server in the ctlplane network"},{"line_number":827,"context_line":"    value: {get_attr: [{{server_resource_name}}, networks, ctlplane, 0]}"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"9fb8cfa7_e99ef161","line":824,"in_reply_to":"9fb8cfa7_a976b9a3","updated":"2019-06-05 13:36:55.000000000","message":"Done","commit_id":"b669f24ef3e7edabae8694c521f667b5773613f9"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"c6b771ccef5e319a92a981b4f7813f9adeb10ac9","unresolved":false,"context_lines":[{"line_number":816,"context_line":"      type: json"},{"line_number":817,"context_line":"      value:"},{"line_number":818,"context_line":"        hieradata_host:"},{"line_number":819,"context_line":"          datafiles:"},{"line_number":820,"context_line":"            host_extraconfig:"},{"line_number":821,"context_line":"      {%- for network in networks %}"},{"line_number":822,"context_line":"      {%- if network.enabled|default(true) and network.name in role.networks|default([]) %}"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"9fb8cfa7_54f1b1cc","line":819,"updated":"2019-06-06 21:20:22.000000000","message":"AnsibleHostVars should have anything specific about hieradata.\n\nIt should just be a generic interface for setting host vars, and be able to be used for any var, whether it\u0027s related to hieradata or not.","commit_id":"01afd51248b032009019b44dde7389b09c85a9e0"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"50b09cad8c5cb0f447e197b5393ef62974686afe","unresolved":false,"context_lines":[{"line_number":816,"context_line":"      type: json"},{"line_number":817,"context_line":"      value:"},{"line_number":818,"context_line":"        hieradata_host:"},{"line_number":819,"context_line":"          datafiles:"},{"line_number":820,"context_line":"            host_extraconfig:"},{"line_number":821,"context_line":"      {%- for network in networks %}"},{"line_number":822,"context_line":"      {%- if network.enabled|default(true) and network.name in role.networks|default([]) %}"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"9fb8cfa7_f4ea25aa","line":819,"in_reply_to":"9fb8cfa7_54f1b1cc","updated":"2019-06-06 21:33:45.000000000","message":"nevermind, i think i see what you\u0027re doing.\n\nstill, why can\u0027t we just write out a file for this hiera like we do the other 2 deployments and avoid the use of the hieradata_variable functionality?","commit_id":"01afd51248b032009019b44dde7389b09c85a9e0"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"c433d0dfcbc4857149dfff39e1d858b195b1f272","unresolved":false,"context_lines":[{"line_number":669,"context_line":"            - {get_param: NetworkDeploymentActions}"},{"line_number":670,"context_line":"          - []"},{"line_number":671,"context_line":""},{"line_number":672,"context_line":"  {{server_resource_name}}Deployment:"},{"line_number":673,"context_line":"    type: OS::Heat::StructuredDeployment"},{"line_number":674,"context_line":"    depends_on: NetworkDeployment"},{"line_number":675,"context_line":"    properties:"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"9fb8cfa7_2b44c6b6","line":672,"updated":"2019-06-08 00:03:58.000000000","message":"we can delete this resource right?","commit_id":"6cba3e29c1c4a6ad06b08cd234783cc5040ca763"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"59080875a57f8635723661b1da7aa079ae5b80c7","unresolved":false,"context_lines":[{"line_number":669,"context_line":"            - {get_param: NetworkDeploymentActions}"},{"line_number":670,"context_line":"          - []"},{"line_number":671,"context_line":""},{"line_number":672,"context_line":"  {{server_resource_name}}Deployment:"},{"line_number":673,"context_line":"    type: OS::Heat::StructuredDeployment"},{"line_number":674,"context_line":"    depends_on: NetworkDeployment"},{"line_number":675,"context_line":"    properties:"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"9fb8cfa7_d58a4dbd","line":672,"in_reply_to":"9fb8cfa7_2b44c6b6","updated":"2019-06-10 21:18:18.000000000","message":"I don\u0027t think we can (yet) because {{server_resource_name}}Config is still a StructuredConfig, although I might be wrong. I was thinking about remove this resource in https://review.opendev.org/#/c/662562/ when we switch hiera resources to full ansible.","commit_id":"6cba3e29c1c4a6ad06b08cd234783cc5040ca763"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"c704a72953aabcbf9fd993959be3d39268061009","unresolved":false,"context_lines":[{"line_number":669,"context_line":"            - {get_param: NetworkDeploymentActions}"},{"line_number":670,"context_line":"          - []"},{"line_number":671,"context_line":""},{"line_number":672,"context_line":"  {{server_resource_name}}Deployment:"},{"line_number":673,"context_line":"    type: OS::Heat::StructuredDeployment"},{"line_number":674,"context_line":"    depends_on: NetworkDeployment"},{"line_number":675,"context_line":"    properties:"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"9fb8cfa7_b2b9dd15","line":672,"in_reply_to":"9fb8cfa7_a2f67462","updated":"2019-06-11 15:31:10.000000000","message":"I wanted to keep the 2 changes separated from each others.\nMy commit message will be fixed. Sorry for confusion.","commit_id":"6cba3e29c1c4a6ad06b08cd234783cc5040ca763"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"0ae4ffbb059b366d11317da74dc487c5978edd51","unresolved":false,"context_lines":[{"line_number":669,"context_line":"            - {get_param: NetworkDeploymentActions}"},{"line_number":670,"context_line":"          - []"},{"line_number":671,"context_line":""},{"line_number":672,"context_line":"  {{server_resource_name}}Deployment:"},{"line_number":673,"context_line":"    type: OS::Heat::StructuredDeployment"},{"line_number":674,"context_line":"    depends_on: NetworkDeployment"},{"line_number":675,"context_line":"    properties:"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"9fb8cfa7_e2422cab","line":672,"in_reply_to":"9fb8cfa7_d58a4dbd","updated":"2019-06-11 11:58:20.000000000","message":"this patch is just duplicating the work done by the Deployment, if you don\u0027t do it all in the same patch.\n\nCommit message isn\u0027t really accurate then as you\u0027re still using the Heat Deployment *and* ansible.\n\nWhy not do it all in the same patch?","commit_id":"6cba3e29c1c4a6ad06b08cd234783cc5040ca763"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"d69fc3996f7af12ad3dfbf14fd6a53a079510d29","unresolved":false,"context_lines":[{"line_number":669,"context_line":"            - {get_param: NetworkDeploymentActions}"},{"line_number":670,"context_line":"          - []"},{"line_number":671,"context_line":""},{"line_number":672,"context_line":"  {{server_resource_name}}Deployment:"},{"line_number":673,"context_line":"    type: OS::Heat::StructuredDeployment"},{"line_number":674,"context_line":"    depends_on: NetworkDeployment"},{"line_number":675,"context_line":"    properties:"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"9fb8cfa7_a2f67462","line":672,"in_reply_to":"9fb8cfa7_e2422cab","updated":"2019-06-11 12:07:14.000000000","message":"i think i see what you\u0027re doing now. still, {{server_resource_name}} is not fully migrated in this patch, which is why I was confused by the commit msg.","commit_id":"6cba3e29c1c4a6ad06b08cd234783cc5040ca763"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"c433d0dfcbc4857149dfff39e1d858b195b1f272","unresolved":false,"context_lines":[{"line_number":683,"context_line":"          - []"},{"line_number":684,"context_line":""},{"line_number":685,"context_line":"  {{server_resource_name}}Config:"},{"line_number":686,"context_line":"    type: OS::Heat::StructuredConfig"},{"line_number":687,"context_line":"    depends_on: {{server_resource_name}}ConfigDatafiles"},{"line_number":688,"context_line":"    properties:"},{"line_number":689,"context_line":"      group: hiera"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"9fb8cfa7_ab1196ae","line":686,"updated":"2019-06-08 00:03:58.000000000","message":"and this can just be a OS::Heat::Value now","commit_id":"6cba3e29c1c4a6ad06b08cd234783cc5040ca763"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"59080875a57f8635723661b1da7aa079ae5b80c7","unresolved":false,"context_lines":[{"line_number":683,"context_line":"          - []"},{"line_number":684,"context_line":""},{"line_number":685,"context_line":"  {{server_resource_name}}Config:"},{"line_number":686,"context_line":"    type: OS::Heat::StructuredConfig"},{"line_number":687,"context_line":"    depends_on: {{server_resource_name}}ConfigDatafiles"},{"line_number":688,"context_line":"    properties:"},{"line_number":689,"context_line":"      group: hiera"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"9fb8cfa7_35a2c94c","line":686,"in_reply_to":"9fb8cfa7_ab1196ae","updated":"2019-06-10 21:18:18.000000000","message":"I don\u0027t think we can yet, and it\u0027ll be possible to do so with https://review.opendev.org/#/c/662562/.\nMaybe I misunderstood something?","commit_id":"6cba3e29c1c4a6ad06b08cd234783cc5040ca763"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"046e5d4770369532497ba4e9419dd02cfc458e28","unresolved":false,"context_lines":[{"line_number":664,"context_line":"          - {get_param: {{role.name}}NetworkDeploymentActions}"},{"line_number":665,"context_line":"          - {get_param: NetworkDeploymentActions}"},{"line_number":666,"context_line":""},{"line_number":667,"context_line":"  {{server_resource_name}}Deployment:"},{"line_number":668,"context_line":"    type: OS::Heat::StructuredDeployment"},{"line_number":669,"context_line":"    depends_on: PreNetworkConfig"},{"line_number":670,"context_line":"    properties:"}],"source_content_type":"text/x-yaml","patch_set":41,"id":"9fb8cfa7_237173df","line":667,"updated":"2019-06-21 02:09:25.000000000","message":"the reason this patch passes CI is b/c this resource is still here. you\u0027re not actually using Ansible when you leave this deployment here because it overwrites the changes you actually made.\n\nIf you remove this, then this would fail CI, b/c net_ip_map also needs to be per host (probably why in the following patch where you do remove it, it fails CI).\n\nI think that needs to be fixed here since this patch is not right on it\u0027s own, and probably a good idea to also remove this resource here as well so it\u0027s actually tested.","commit_id":"017036555dbd57c2d69850b85c70ee77ba6b9fa9"}]}