)]}'
{"common/deploy-steps.j2":[{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"54f54130cf25d3c3c84fdd27d35a923e7cc9ddd6","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        - extraconfig"},{"line_number":148,"context_line":"        - service_names"},{"line_number":149,"context_line":"        - service_configs"},{"line_number":150,"context_line":"        - {{role.name.lower()}}"},{"line_number":151,"context_line":"        - bootstrap_node # provided by allNodesConfig"},{"line_number":152,"context_line":"        - all_nodes # provided by allNodesConfig"},{"line_number":153,"context_line":"        - vip_data # provided by allNodesConfig"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9fb8cfa7_4259b88b","line":150,"updated":"2019-06-11 12:04:06.000000000","message":"no role defined here","commit_id":"476c489457d10d616c3266c26eb159045ba40a71"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"17b12e8d3172b55b4b74362f9344ea8a36e991fc","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        - extraconfig"},{"line_number":148,"context_line":"        - service_names"},{"line_number":149,"context_line":"        - service_configs"},{"line_number":150,"context_line":"        - {{role.name.lower()}}"},{"line_number":151,"context_line":"        - bootstrap_node # provided by allNodesConfig"},{"line_number":152,"context_line":"        - all_nodes # provided by allNodesConfig"},{"line_number":153,"context_line":"        - vip_data # provided by allNodesConfig"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9fb8cfa7_d01569e6","line":150,"in_reply_to":"9fb8cfa7_4259b88b","updated":"2019-06-11 17:25:47.000000000","message":"done, thanks","commit_id":"476c489457d10d616c3266c26eb159045ba40a71"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"54f54130cf25d3c3c84fdd27d35a923e7cc9ddd6","unresolved":false,"context_lines":[{"line_number":389,"context_line":"              gather_facts: no"},{"line_number":390,"context_line":"              any_errors_fatal: yes"},{"line_number":391,"context_line":"              vars:"},{"line_number":392,"context_line":"                hieradata_files: {get_attr: [ConfigHierarchy, value]}"},{"line_number":393,"context_line":"              tasks:"},{"line_number":394,"context_line":"{%- for role in roles %}"},{"line_number":395,"context_line":"                - name: AllNodesDeployment hieradata"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9fb8cfa7_c24cc8c9","line":392,"updated":"2019-06-11 12:04:06.000000000","message":"can\u0027t use intrinsic functions this way inside a str_replace template. need to follow the pattern shown up around lines 300-313","commit_id":"476c489457d10d616c3266c26eb159045ba40a71"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"17b12e8d3172b55b4b74362f9344ea8a36e991fc","unresolved":false,"context_lines":[{"line_number":389,"context_line":"              gather_facts: no"},{"line_number":390,"context_line":"              any_errors_fatal: yes"},{"line_number":391,"context_line":"              vars:"},{"line_number":392,"context_line":"                hieradata_files: {get_attr: [ConfigHierarchy, value]}"},{"line_number":393,"context_line":"              tasks:"},{"line_number":394,"context_line":"{%- for role in roles %}"},{"line_number":395,"context_line":"                - name: AllNodesDeployment hieradata"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9fb8cfa7_70d4bd20","line":392,"in_reply_to":"9fb8cfa7_c24cc8c9","updated":"2019-06-11 17:25:47.000000000","message":"ack, thanks","commit_id":"476c489457d10d616c3266c26eb159045ba40a71"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"3333e0e6ca11168f557b3111ef12511677b426fe","unresolved":false,"context_lines":[{"line_number":178,"context_line":"resources:"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"{% for role in enabled_roles %}"},{"line_number":181,"context_line":"  ConfigHierarchy:"},{"line_number":182,"context_line":"    type: OS::Heat::Value"},{"line_number":183,"context_line":"    properties:"},{"line_number":184,"context_line":"      value:"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"9fb8cfa7_6b112b52","line":181,"updated":"2019-06-11 21:39:25.000000000","message":"this won\u0027t work with multiple roles b/c then you\u0027d have multiple resources with the same name","commit_id":"e6d9fd58dd743154278fa003d95043f401e3731d"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"ce249ef9d9c376fbbb986b64f8b483a74638d287","unresolved":false,"context_lines":[{"line_number":178,"context_line":"resources:"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"{% for role in enabled_roles %}"},{"line_number":181,"context_line":"  ConfigHierarchy:"},{"line_number":182,"context_line":"    type: OS::Heat::Value"},{"line_number":183,"context_line":"    properties:"},{"line_number":184,"context_line":"      value:"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"9fb8cfa7_bfac2fed","line":181,"in_reply_to":"9fb8cfa7_6b112b52","updated":"2019-06-12 13:42:15.000000000","message":"oh right, let me fix that","commit_id":"e6d9fd58dd743154278fa003d95043f401e3731d"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"0fec0563349fdd06c07b8d11621b4dfa0427e8dd","unresolved":false,"context_lines":[{"line_number":178,"context_line":"resources:"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"{% for role in enabled_roles %}"},{"line_number":181,"context_line":"  ConfigHierarchy:"},{"line_number":182,"context_line":"    type: OS::Heat::Value"},{"line_number":183,"context_line":"    properties:"},{"line_number":184,"context_line":"      value:"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"9fb8cfa7_1fbf7bd1","line":181,"in_reply_to":"9fb8cfa7_bfac2fed","updated":"2019-06-12 14:00:13.000000000","message":"Done","commit_id":"e6d9fd58dd743154278fa003d95043f401e3731d"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"3333e0e6ca11168f557b3111ef12511677b426fe","unresolved":false,"context_lines":[{"line_number":205,"context_line":"        - midonet_data #Optionally provided by AllNodesExtraConfig"},{"line_number":206,"context_line":"        - cisco_aci_data # Optionally provided by Controller/ComputeExtraConfigPre"},{"line_number":207,"context_line":"        # Special variable for upgrade"},{"line_number":208,"context_line":"        - upgrade"},{"line_number":209,"context_line":"{% endfor %}"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"  ExternalDeployTasks:"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"9fb8cfa7_2b17b347","line":208,"updated":"2019-06-11 21:39:25.000000000","message":"you lost the merge_behavior: deeper from this value.\n\ndid the changes you make the role handle setting that?","commit_id":"e6d9fd58dd743154278fa003d95043f401e3731d"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"ce249ef9d9c376fbbb986b64f8b483a74638d287","unresolved":false,"context_lines":[{"line_number":205,"context_line":"        - midonet_data #Optionally provided by AllNodesExtraConfig"},{"line_number":206,"context_line":"        - cisco_aci_data # Optionally provided by Controller/ComputeExtraConfigPre"},{"line_number":207,"context_line":"        # Special variable for upgrade"},{"line_number":208,"context_line":"        - upgrade"},{"line_number":209,"context_line":"{% endfor %}"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"  ExternalDeployTasks:"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"9fb8cfa7_9f6ccbce","line":208,"in_reply_to":"9fb8cfa7_2b17b347","updated":"2019-06-12 13:42:15.000000000","message":"I can re-add it but in my research this parameter does nothing. I\u0027ll re-add it in case I missed something.","commit_id":"e6d9fd58dd743154278fa003d95043f401e3731d"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"0fec0563349fdd06c07b8d11621b4dfa0427e8dd","unresolved":false,"context_lines":[{"line_number":205,"context_line":"        - midonet_data #Optionally provided by AllNodesExtraConfig"},{"line_number":206,"context_line":"        - cisco_aci_data # Optionally provided by Controller/ComputeExtraConfigPre"},{"line_number":207,"context_line":"        # Special variable for upgrade"},{"line_number":208,"context_line":"        - upgrade"},{"line_number":209,"context_line":"{% endfor %}"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"  ExternalDeployTasks:"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"9fb8cfa7_7f71d743","line":208,"in_reply_to":"9fb8cfa7_9f6ccbce","updated":"2019-06-12 14:00:13.000000000","message":"In fact the parameter isn\u0027t interpreted by the heat-agent and it\u0027s never in the config anyway, see this CI job in Stein:\nhttp://logs.openstack.org/04/657604/1/gate/tripleo-ci-centos-7-scenario001-standalone/8812a70/logs/undercloud/etc/puppet/hiera.yaml.txt.gz\n\nSo I think we can safely skip it.","commit_id":"e6d9fd58dd743154278fa003d95043f401e3731d"}],"overcloud.j2.yaml":[{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"091f9361567ddb6cb21c7201cebd08f7ac6258b9","unresolved":false,"context_lines":[{"line_number":1032,"context_line":"      {{role.name}}DeploymentHierarchy:"},{"line_number":1033,"context_line":"        map_merge:"},{"line_number":1034,"context_line":"          list_concat:"},{"line_number":1035,"context_line":"          - {get_attr: [{{role.name}}, config_hierarchy]}"},{"line_number":1036,"context_line":"      {{role.name}}PerHostHieradata:"},{"line_number":1037,"context_line":"        map_merge:"},{"line_number":1038,"context_line":"          list_concat:"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"9fb8cfa7_64e31aa6","line":1035,"updated":"2019-06-19 11:37:24.000000000","message":"here you end up with a list of lists instead of a list of dicts, so the map_merge is failing.\n\nExample:\n\nopenstack stack output show 4cda69e3-ff88-486b-b695-68986fcb3ea7 config_hierarchy -c output_value -f yaml\n\noutput_value:\n- - \u0027\"%{::uuid}\"\u0027\n  - host_extraconfig\n  - docker_puppet\n  - heat_config_%{::deploy_config_name}\n  - config_step\n  - controller_extraconfig\n  - extraconfig\n  - service_names\n  - service_configs\n  - controller\n  - bootstrap_node\n  - all_nodes\n  - vip_data\n  - net_ip_map\n  - \u0027\"%{::osfamily}\"\u0027\n  - neutron_bigswitch_data\n  - neutron_cisco_data\n  - cisco_n1kv_data\n  - midonet_data\n  - cisco_aci_data\n  - upgrade\n\nI\u0027m thinking you can just do a:\n\n      {{role.name}}DeploymentHierarchy:\n          {get_attr: [{{role.name}}, config_hierarchy, 0]}\n\nsince the hierarchy is the same for each node within a role.\n\nWe can also look at moving that resource outside the ResourceGroup since it\u0027s not node specific.\n\nI\u0027ll test a few different things.","commit_id":"88d55384bb17714964bebeb2e2a71486dc7a4155"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"ac465b510c072e1a5bb4a1f0056f0e867f5cbb86","unresolved":false,"context_lines":[{"line_number":1032,"context_line":"      {{role.name}}DeploymentHierarchy:"},{"line_number":1033,"context_line":"        map_merge:"},{"line_number":1034,"context_line":"          list_concat:"},{"line_number":1035,"context_line":"          - {get_attr: [{{role.name}}, config_hierarchy]}"},{"line_number":1036,"context_line":"      {{role.name}}PerHostHieradata:"},{"line_number":1037,"context_line":"        map_merge:"},{"line_number":1038,"context_line":"          list_concat:"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"9fb8cfa7_ef6b63ee","line":1035,"in_reply_to":"9fb8cfa7_64e31aa6","updated":"2019-06-19 21:27:24.000000000","message":"Let\u0027s go with your proposal now and improve later if needed.\nThanks","commit_id":"88d55384bb17714964bebeb2e2a71486dc7a4155"}],"puppet/role.role.j2.yaml":[{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"091f9361567ddb6cb21c7201cebd08f7ac6258b9","unresolved":false,"context_lines":[{"line_number":830,"context_line":"    value: {get_attr: [{{server_resource_name}}ConfigDatafiles, value]}"},{"line_number":831,"context_line":"  config_hierarchy:"},{"line_number":832,"context_line":"    description: The config hierarchy to lay down in /etc/puppet/hiera.yaml."},{"line_number":833,"context_line":"    value: {get_attr: [{{server_resource_name}}ConfigHierarchy, value]}"},{"line_number":834,"context_line":"  ip_address:"},{"line_number":835,"context_line":"    description: IP address of the server in the ctlplane network"},{"line_number":836,"context_line":"    value: {get_attr: [{{server_resource_name}}, networks, ctlplane, 0]}"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"9fb8cfa7_04125eb2","line":833,"updated":"2019-06-19 11:37:24.000000000","message":"this is a list","commit_id":"88d55384bb17714964bebeb2e2a71486dc7a4155"}]}