)]}'
{"common/deploy-steps.j2":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"fba3a9c6f19e960666f65baf602471507923906d","unresolved":false,"context_lines":[{"line_number":332,"context_line":"                docker_puppet_debug: DOCKER_PUPPET_DEBUG"},{"line_number":333,"context_line":"                docker_puppet_process_count: DOCKER_PUPPET_PROCESS_COUNT"},{"line_number":334,"context_line":"                docker_puppet_mount_host_puppet: DOCKER_PUPPET_MOUNT_HOST_PUPPET"},{"line_number":335,"context_line":"                EnablePackageInstall: {get_param: EnablePackageInstall}"},{"line_number":336,"context_line":"              tasks:"},{"line_number":337,"context_line":"                - name: Create /var/lib/container-puppet"},{"line_number":338,"context_line":"                  no_log: True"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"9fb8cfa7_fdbc41dd","line":335,"range":{"start_line":335,"start_character":50,"end_line":335,"end_character":70},"updated":"2019-06-07 10:41:31.000000000","message":"I believe EnablePackageInstall should be also added to the parameters (after the line #35)","commit_id":"1d03c7ed527f593a237f1da0d4a36902494a064c"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"fba3a9c6f19e960666f65baf602471507923906d","unresolved":false,"context_lines":[{"line_number":332,"context_line":"                docker_puppet_debug: DOCKER_PUPPET_DEBUG"},{"line_number":333,"context_line":"                docker_puppet_process_count: DOCKER_PUPPET_PROCESS_COUNT"},{"line_number":334,"context_line":"                docker_puppet_mount_host_puppet: DOCKER_PUPPET_MOUNT_HOST_PUPPET"},{"line_number":335,"context_line":"                EnablePackageInstall: {get_param: EnablePackageInstall}"},{"line_number":336,"context_line":"              tasks:"},{"line_number":337,"context_line":"                - name: Create /var/lib/container-puppet"},{"line_number":338,"context_line":"                  no_log: True"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"9fb8cfa7_bdb6c9f9","line":335,"range":{"start_line":335,"start_character":16,"end_line":335,"end_character":36},"updated":"2019-06-07 10:41:31.000000000","message":"please also follow the established naming rules, so that this becomes enable_package_install here. And use\n\nENABLE_PACKAGE_INSTALL: {get_param: EnablePackageInstall}\n\nthat should be added above, see #265-277","commit_id":"1d03c7ed527f593a237f1da0d4a36902494a064c"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"774619185284b8048b48ec3a8617f4b1a52e628e","unresolved":false,"context_lines":[{"line_number":332,"context_line":"                docker_puppet_debug: DOCKER_PUPPET_DEBUG"},{"line_number":333,"context_line":"                docker_puppet_process_count: DOCKER_PUPPET_PROCESS_COUNT"},{"line_number":334,"context_line":"                docker_puppet_mount_host_puppet: DOCKER_PUPPET_MOUNT_HOST_PUPPET"},{"line_number":335,"context_line":"                EnablePackageInstall: {get_param: EnablePackageInstall}"},{"line_number":336,"context_line":"              tasks:"},{"line_number":337,"context_line":"                - name: Create /var/lib/container-puppet"},{"line_number":338,"context_line":"                  no_log: True"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"9fb8cfa7_f5d52d44","line":335,"range":{"start_line":335,"start_character":16,"end_line":335,"end_character":36},"in_reply_to":"9fb8cfa7_bdb6c9f9","updated":"2019-06-07 20:36:46.000000000","message":"Done","commit_id":"1d03c7ed527f593a237f1da0d4a36902494a064c"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"774619185284b8048b48ec3a8617f4b1a52e628e","unresolved":false,"context_lines":[{"line_number":332,"context_line":"                docker_puppet_debug: DOCKER_PUPPET_DEBUG"},{"line_number":333,"context_line":"                docker_puppet_process_count: DOCKER_PUPPET_PROCESS_COUNT"},{"line_number":334,"context_line":"                docker_puppet_mount_host_puppet: DOCKER_PUPPET_MOUNT_HOST_PUPPET"},{"line_number":335,"context_line":"                EnablePackageInstall: {get_param: EnablePackageInstall}"},{"line_number":336,"context_line":"              tasks:"},{"line_number":337,"context_line":"                - name: Create /var/lib/container-puppet"},{"line_number":338,"context_line":"                  no_log: True"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"9fb8cfa7_95ccf1bc","line":335,"range":{"start_line":335,"start_character":50,"end_line":335,"end_character":70},"in_reply_to":"9fb8cfa7_fdbc41dd","updated":"2019-06-07 20:36:46.000000000","message":"Done","commit_id":"1d03c7ed527f593a237f1da0d4a36902494a064c"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"818b2efdcb2d55f7c665ece4ec0c1a3831523adb","unresolved":false,"context_lines":[{"line_number":332,"context_line":"                docker_puppet_debug: DOCKER_PUPPET_DEBUG"},{"line_number":333,"context_line":"                docker_puppet_process_count: DOCKER_PUPPET_PROCESS_COUNT"},{"line_number":334,"context_line":"                docker_puppet_mount_host_puppet: DOCKER_PUPPET_MOUNT_HOST_PUPPET"},{"line_number":335,"context_line":"                EnablePackageInstall: {get_param: EnablePackageInstall}"},{"line_number":336,"context_line":"              tasks:"},{"line_number":337,"context_line":"                - name: Create /var/lib/container-puppet"},{"line_number":338,"context_line":"                  no_log: True"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"9fb8cfa7_12933c51","line":335,"range":{"start_line":335,"start_character":50,"end_line":335,"end_character":70},"in_reply_to":"9fb8cfa7_fdbc41dd","updated":"2019-06-07 16:00:12.000000000","message":"This variable name is used within the package module shim (in review here https://review.opendev.org/#/c/662496/).  I will update this and the parent patch with the new variable name.","commit_id":"1d03c7ed527f593a237f1da0d4a36902494a064c"}]}