)]}'
{"environments/services-baremetal/neutron-ovn-ha.yaml":[{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"d6e01b380232a974a1f09a85d4cb32c89bfcd8f8","unresolved":false,"context_lines":[{"line_number":26,"context_line":"  NeutronServicePlugins: \u0027qos,ovn-router,trunk,segments\u0027"},{"line_number":27,"context_line":"  NeutronVniRanges: [\u00271:65536\u0027, ]"},{"line_number":28,"context_line":"  NeutronPluginExtensions: \"qos,port_security,dns\""},{"line_number":29,"context_line":"  NeutronEnableDVR: false"},{"line_number":30,"context_line":"  ComputeParameters:"},{"line_number":31,"context_line":"    NeutronBridgeMappings: \"\""},{"line_number":32,"context_line":"  ControllerParameters:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7faddb67_aca719bc","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":25},"updated":"2019-08-20 09:15:11.000000000","message":"We want DVR by default right? I think this is not right in this case and this is why you\u0027re adding a non-dvr environment file to explicitly disable it?","commit_id":"1177ee9c313b01b6f407a439e54211fb1cbaa654"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"40fb4e30c928e9243484d69c3de31ef3cb718399","unresolved":false,"context_lines":[{"line_number":26,"context_line":"  NeutronServicePlugins: \u0027qos,ovn-router,trunk,segments\u0027"},{"line_number":27,"context_line":"  NeutronVniRanges: [\u00271:65536\u0027, ]"},{"line_number":28,"context_line":"  NeutronPluginExtensions: \"qos,port_security,dns\""},{"line_number":29,"context_line":"  NeutronEnableDVR: false"},{"line_number":30,"context_line":"  ComputeParameters:"},{"line_number":31,"context_line":"    NeutronBridgeMappings: \"\""},{"line_number":32,"context_line":"  ControllerParameters:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7faddb67_0f03bf0e","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":25},"in_reply_to":"7faddb67_8cad7d32","updated":"2019-08-20 10:06:44.000000000","message":"For now there is a mess around files and naming.\nWe have:\n\n./environments/services-baremetal/neutron-ovn-ha.yaml\n./environments/services-baremetal/neutron-ovn-dvr-ha.yaml\n./environments/services/neutron-ovn-ha.yaml\n./environments/services/neutron-ovn-dvr-ha.yaml\n\nBecause of flipped DVR flag in Rocky the:\n./environments/services/neutron-ovn-ha.yaml\n./environments/services-baremetal/neutron-ovn-ha.yaml\nNow acts the same as DVR (but shouldn\u0027t).\n\nSo what we decided on IRC a few weeks ago is to drop those two in the next release and add deprecation note:\n./environments/services/neutron-ovn-ha.yaml\n./environments/services-baremetal/neutron-ovn-ha.yaml\n\nAnd add new templates that will have proper naming with DVR disabled explicitly:\n./environments/services-baremetal/neutron-ovn-non-dvr-ha.yaml\n./environments/services/neutron-ovn-non-dvr-ha.yaml","commit_id":"1177ee9c313b01b6f407a439e54211fb1cbaa654"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"dbf3460a50e2725fd07197e97691aa0e3abdbdbb","unresolved":false,"context_lines":[{"line_number":26,"context_line":"  NeutronServicePlugins: \u0027qos,ovn-router,trunk,segments\u0027"},{"line_number":27,"context_line":"  NeutronVniRanges: [\u00271:65536\u0027, ]"},{"line_number":28,"context_line":"  NeutronPluginExtensions: \"qos,port_security,dns\""},{"line_number":29,"context_line":"  NeutronEnableDVR: false"},{"line_number":30,"context_line":"  ComputeParameters:"},{"line_number":31,"context_line":"    NeutronBridgeMappings: \"\""},{"line_number":32,"context_line":"  ControllerParameters:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7faddb67_8cad7d32","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":25},"in_reply_to":"7faddb67_ac31595b","updated":"2019-08-20 09:57:49.000000000","message":"I mean, if we have dvr disabled here and then we create another template called \u0027non-dvr-....yaml\u0027 aren\u0027t we duplicating things?","commit_id":"1177ee9c313b01b6f407a439e54211fb1cbaa654"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"259abd45dd7e8bc1077bb3add2ac87785acad109","unresolved":false,"context_lines":[{"line_number":26,"context_line":"  NeutronServicePlugins: \u0027qos,ovn-router,trunk,segments\u0027"},{"line_number":27,"context_line":"  NeutronVniRanges: [\u00271:65536\u0027, ]"},{"line_number":28,"context_line":"  NeutronPluginExtensions: \"qos,port_security,dns\""},{"line_number":29,"context_line":"  NeutronEnableDVR: false"},{"line_number":30,"context_line":"  ComputeParameters:"},{"line_number":31,"context_line":"    NeutronBridgeMappings: \"\""},{"line_number":32,"context_line":"  ControllerParameters:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7faddb67_ac31595b","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":25},"in_reply_to":"7faddb67_aca719bc","updated":"2019-08-20 09:39:52.000000000","message":"DVR is set as default here:\nhttps://github.com/openstack/tripleo-heat-templates/blob/master/environments/services/neutron-ovn-dvr-ha.yaml#L29\nAnd the template name is neutron-ovn-dvr-ha.yaml.\n\nSo as we discussed on IRC we would like to have DVR in the template name.\nFor other templates we disable it (previous behavior).","commit_id":"1177ee9c313b01b6f407a439e54211fb1cbaa654"}],"environments/services-baremetal/neutron-ovn-non-dvr-ha.yaml":[{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"855f79e028d652bb7fc43c7a5cb96431ddc69b50","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"parameter_defaults:"},{"line_number":17,"context_line":"  NeutronMechanismDrivers: ovn"},{"line_number":18,"context_line":"  OVNVifType: ovs"},{"line_number":19,"context_line":"  OVNNeutronSyncMode: log"},{"line_number":20,"context_line":"  OVNQosDriver: ovn-qos"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9fb8cfa7_a0e1cc2c","line":17,"updated":"2019-06-21 16:51:07.000000000","message":"Now that OVN is the default, I wonder if we should reconsider adding things to environment files on a given release that are already the default in the heat templates. Having stuff duplicated is a bit of tech debt even if it isn\u0027t used by anyone and we need to be careful to keep everything in sync. Case in point, the default service and plugin extensions noted here are not the same as the defaults in the heat templates.","commit_id":"07f7292797932a9c72f5fc1b6e1580783c515c09"}],"environments/services/neutron-ovn-non-dvr-ha.yaml":[{"author":{"_account_id":11082,"name":"Kamil Sambor","email":"ksambor@redhat.com","username":"ksambor"},"change_message_id":"fccd19b436d932e2fccaef64677cd89fd0dfcd04","unresolved":false,"context_lines":[{"line_number":18,"context_line":"  OVNVifType: ovs"},{"line_number":19,"context_line":"  OVNNeutronSyncMode: log"},{"line_number":20,"context_line":"  OVNQosDriver: ovn-qos"},{"line_number":21,"context_line":"  OVNTunnelEncapType: geneve"},{"line_number":22,"context_line":"  NeutronTypeDrivers: \u0027geneve,vlan,flat\u0027"},{"line_number":23,"context_line":"  NeutronNetworkType: [\u0027geneve\u0027 , \u0027vlan\u0027, \u0027flat\u0027]"},{"line_number":24,"context_line":"  NeutronServicePlugins: \u0027qos,ovn-router,trunk\u0027"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fb8cfa7_cdc9a678","line":21,"updated":"2019-06-06 09:42:55.000000000","message":"we drop OVNTunnelEncapType, so it can be removed from this file","commit_id":"8a5893027c5c3a3f76a7a05e78441fbb609e1f06"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"65b406d17598d1e010e7ead75d4a5f1ca5946df4","unresolved":false,"context_lines":[{"line_number":18,"context_line":"  OVNVifType: ovs"},{"line_number":19,"context_line":"  OVNNeutronSyncMode: log"},{"line_number":20,"context_line":"  OVNQosDriver: ovn-qos"},{"line_number":21,"context_line":"  OVNTunnelEncapType: geneve"},{"line_number":22,"context_line":"  NeutronTypeDrivers: \u0027geneve,vlan,flat\u0027"},{"line_number":23,"context_line":"  NeutronNetworkType: [\u0027geneve\u0027 , \u0027vlan\u0027, \u0027flat\u0027]"},{"line_number":24,"context_line":"  NeutronServicePlugins: \u0027qos,ovn-router,trunk\u0027"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fb8cfa7_b298d974","line":21,"in_reply_to":"9fb8cfa7_cdc9a678","updated":"2019-06-13 05:52:27.000000000","message":"Done","commit_id":"8a5893027c5c3a3f76a7a05e78441fbb609e1f06"},{"author":{"_account_id":11082,"name":"Kamil Sambor","email":"ksambor@redhat.com","username":"ksambor"},"change_message_id":"fccd19b436d932e2fccaef64677cd89fd0dfcd04","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  OVNNeutronSyncMode: log"},{"line_number":20,"context_line":"  OVNQosDriver: ovn-qos"},{"line_number":21,"context_line":"  OVNTunnelEncapType: geneve"},{"line_number":22,"context_line":"  NeutronTypeDrivers: \u0027geneve,vlan,flat\u0027"},{"line_number":23,"context_line":"  NeutronNetworkType: [\u0027geneve\u0027 , \u0027vlan\u0027, \u0027flat\u0027]"},{"line_number":24,"context_line":"  NeutronServicePlugins: \u0027qos,ovn-router,trunk\u0027"},{"line_number":25,"context_line":"  NeutronVniRanges: [\u00271:65536\u0027, ]"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fb8cfa7_8d62ce3d","line":22,"updated":"2019-06-06 09:42:55.000000000","message":"this is default value","commit_id":"8a5893027c5c3a3f76a7a05e78441fbb609e1f06"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"65b406d17598d1e010e7ead75d4a5f1ca5946df4","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  OVNNeutronSyncMode: log"},{"line_number":20,"context_line":"  OVNQosDriver: ovn-qos"},{"line_number":21,"context_line":"  OVNTunnelEncapType: geneve"},{"line_number":22,"context_line":"  NeutronTypeDrivers: \u0027geneve,vlan,flat\u0027"},{"line_number":23,"context_line":"  NeutronNetworkType: [\u0027geneve\u0027 , \u0027vlan\u0027, \u0027flat\u0027]"},{"line_number":24,"context_line":"  NeutronServicePlugins: \u0027qos,ovn-router,trunk\u0027"},{"line_number":25,"context_line":"  NeutronVniRanges: [\u00271:65536\u0027, ]"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fb8cfa7_f2a09192","line":22,"in_reply_to":"9fb8cfa7_8d62ce3d","updated":"2019-06-13 05:52:27.000000000","message":"Done","commit_id":"8a5893027c5c3a3f76a7a05e78441fbb609e1f06"},{"author":{"_account_id":11082,"name":"Kamil Sambor","email":"ksambor@redhat.com","username":"ksambor"},"change_message_id":"fccd19b436d932e2fccaef64677cd89fd0dfcd04","unresolved":false,"context_lines":[{"line_number":20,"context_line":"  OVNQosDriver: ovn-qos"},{"line_number":21,"context_line":"  OVNTunnelEncapType: geneve"},{"line_number":22,"context_line":"  NeutronTypeDrivers: \u0027geneve,vlan,flat\u0027"},{"line_number":23,"context_line":"  NeutronNetworkType: [\u0027geneve\u0027 , \u0027vlan\u0027, \u0027flat\u0027]"},{"line_number":24,"context_line":"  NeutronServicePlugins: \u0027qos,ovn-router,trunk\u0027"},{"line_number":25,"context_line":"  NeutronVniRanges: [\u00271:65536\u0027, ]"},{"line_number":26,"context_line":"  NeutronPluginExtensions: \"qos,port_security,dns\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fb8cfa7_4d8376cd","line":23,"range":{"start_line":23,"start_character":9,"end_line":23,"end_character":10},"updated":"2019-06-06 09:42:55.000000000","message":"this is default","commit_id":"8a5893027c5c3a3f76a7a05e78441fbb609e1f06"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"65b406d17598d1e010e7ead75d4a5f1ca5946df4","unresolved":false,"context_lines":[{"line_number":20,"context_line":"  OVNQosDriver: ovn-qos"},{"line_number":21,"context_line":"  OVNTunnelEncapType: geneve"},{"line_number":22,"context_line":"  NeutronTypeDrivers: \u0027geneve,vlan,flat\u0027"},{"line_number":23,"context_line":"  NeutronNetworkType: [\u0027geneve\u0027 , \u0027vlan\u0027, \u0027flat\u0027]"},{"line_number":24,"context_line":"  NeutronServicePlugins: \u0027qos,ovn-router,trunk\u0027"},{"line_number":25,"context_line":"  NeutronVniRanges: [\u00271:65536\u0027, ]"},{"line_number":26,"context_line":"  NeutronPluginExtensions: \"qos,port_security,dns\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fb8cfa7_92ab5573","line":23,"range":{"start_line":23,"start_character":9,"end_line":23,"end_character":10},"in_reply_to":"9fb8cfa7_4d8376cd","updated":"2019-06-13 05:52:27.000000000","message":"Done","commit_id":"8a5893027c5c3a3f76a7a05e78441fbb609e1f06"},{"author":{"_account_id":11082,"name":"Kamil Sambor","email":"ksambor@redhat.com","username":"ksambor"},"change_message_id":"fccd19b436d932e2fccaef64677cd89fd0dfcd04","unresolved":false,"context_lines":[{"line_number":21,"context_line":"  OVNTunnelEncapType: geneve"},{"line_number":22,"context_line":"  NeutronTypeDrivers: \u0027geneve,vlan,flat\u0027"},{"line_number":23,"context_line":"  NeutronNetworkType: [\u0027geneve\u0027 , \u0027vlan\u0027, \u0027flat\u0027]"},{"line_number":24,"context_line":"  NeutronServicePlugins: \u0027qos,ovn-router,trunk\u0027"},{"line_number":25,"context_line":"  NeutronVniRanges: [\u00271:65536\u0027, ]"},{"line_number":26,"context_line":"  NeutronPluginExtensions: \"qos,port_security,dns\""},{"line_number":27,"context_line":"  NeutronRpcWorkers: 1"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fb8cfa7_2d68821f","line":24,"updated":"2019-06-06 09:42:55.000000000","message":"this is default value","commit_id":"8a5893027c5c3a3f76a7a05e78441fbb609e1f06"},{"author":{"_account_id":11082,"name":"Kamil Sambor","email":"ksambor@redhat.com","username":"ksambor"},"change_message_id":"fccd19b436d932e2fccaef64677cd89fd0dfcd04","unresolved":false,"context_lines":[{"line_number":22,"context_line":"  NeutronTypeDrivers: \u0027geneve,vlan,flat\u0027"},{"line_number":23,"context_line":"  NeutronNetworkType: [\u0027geneve\u0027 , \u0027vlan\u0027, \u0027flat\u0027]"},{"line_number":24,"context_line":"  NeutronServicePlugins: \u0027qos,ovn-router,trunk\u0027"},{"line_number":25,"context_line":"  NeutronVniRanges: [\u00271:65536\u0027, ]"},{"line_number":26,"context_line":"  NeutronPluginExtensions: \"qos,port_security,dns\""},{"line_number":27,"context_line":"  NeutronRpcWorkers: 1"},{"line_number":28,"context_line":"  NeutronEnableDVR: false"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fb8cfa7_0d56de5d","line":25,"updated":"2019-06-06 09:42:55.000000000","message":"this is default value","commit_id":"8a5893027c5c3a3f76a7a05e78441fbb609e1f06"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"65b406d17598d1e010e7ead75d4a5f1ca5946df4","unresolved":false,"context_lines":[{"line_number":22,"context_line":"  NeutronTypeDrivers: \u0027geneve,vlan,flat\u0027"},{"line_number":23,"context_line":"  NeutronNetworkType: [\u0027geneve\u0027 , \u0027vlan\u0027, \u0027flat\u0027]"},{"line_number":24,"context_line":"  NeutronServicePlugins: \u0027qos,ovn-router,trunk\u0027"},{"line_number":25,"context_line":"  NeutronVniRanges: [\u00271:65536\u0027, ]"},{"line_number":26,"context_line":"  NeutronPluginExtensions: \"qos,port_security,dns\""},{"line_number":27,"context_line":"  NeutronRpcWorkers: 1"},{"line_number":28,"context_line":"  NeutronEnableDVR: false"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fb8cfa7_52bb9dc3","line":25,"in_reply_to":"9fb8cfa7_0d56de5d","updated":"2019-06-13 05:52:27.000000000","message":"Done","commit_id":"8a5893027c5c3a3f76a7a05e78441fbb609e1f06"},{"author":{"_account_id":11082,"name":"Kamil Sambor","email":"ksambor@redhat.com","username":"ksambor"},"change_message_id":"fccd19b436d932e2fccaef64677cd89fd0dfcd04","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    OVNCMSOptions: \"enable-chassis-as-gw\""},{"line_number":33,"context_line":"  NetworkerParameters:"},{"line_number":34,"context_line":"    OVNCMSOptions: \"enable-chassis-as-gw\""},{"line_number":35,"context_line":"  OVNDnsServers: []"},{"line_number":36,"context_line":"  KernelIpNonLocalBind: 1"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fb8cfa7_6d119aac","line":35,"updated":"2019-06-06 09:42:55.000000000","message":"this is a default value so it can be removed","commit_id":"8a5893027c5c3a3f76a7a05e78441fbb609e1f06"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"65b406d17598d1e010e7ead75d4a5f1ca5946df4","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    OVNCMSOptions: \"enable-chassis-as-gw\""},{"line_number":33,"context_line":"  NetworkerParameters:"},{"line_number":34,"context_line":"    OVNCMSOptions: \"enable-chassis-as-gw\""},{"line_number":35,"context_line":"  OVNDnsServers: []"},{"line_number":36,"context_line":"  KernelIpNonLocalBind: 1"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fb8cfa7_72bee1b4","line":35,"in_reply_to":"9fb8cfa7_6d119aac","updated":"2019-06-13 05:52:27.000000000","message":"Done","commit_id":"8a5893027c5c3a3f76a7a05e78441fbb609e1f06"},{"author":{"_account_id":11082,"name":"Kamil Sambor","email":"ksambor@redhat.com","username":"ksambor"},"change_message_id":"fccd19b436d932e2fccaef64677cd89fd0dfcd04","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  NetworkerParameters:"},{"line_number":34,"context_line":"    OVNCMSOptions: \"enable-chassis-as-gw\""},{"line_number":35,"context_line":"  OVNDnsServers: []"},{"line_number":36,"context_line":"  KernelIpNonLocalBind: 1"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fb8cfa7_cd21a6fd","line":36,"updated":"2019-06-06 09:42:55.000000000","message":"this is also a default value so it can be removed","commit_id":"8a5893027c5c3a3f76a7a05e78441fbb609e1f06"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"65b406d17598d1e010e7ead75d4a5f1ca5946df4","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  NetworkerParameters:"},{"line_number":34,"context_line":"    OVNCMSOptions: \"enable-chassis-as-gw\""},{"line_number":35,"context_line":"  OVNDnsServers: []"},{"line_number":36,"context_line":"  KernelIpNonLocalBind: 1"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fb8cfa7_12b1a5e1","line":36,"in_reply_to":"9fb8cfa7_cd21a6fd","updated":"2019-06-13 05:52:27.000000000","message":"Done","commit_id":"8a5893027c5c3a3f76a7a05e78441fbb609e1f06"}]}