)]}'
{"deployment/nova/nova-compute-common-container-puppet.yaml":[{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"589c0bb8b40963f0b38382bfb1726a746cecefe5","unresolved":false,"context_lines":[{"line_number":60,"context_line":"              delegate_host: \"{{ groups[\u0027Compute\u0027][0] }}\""},{"line_number":61,"context_line":"            when:"},{"line_number":62,"context_line":"              - role_name|lower !\u003d \"undercloud\""},{"line_number":63,"context_line":"              - groups[\u0027Compute\u0027] is defined and (groups[\u0027Compute\u0027]|length\u003e0)"},{"line_number":64,"context_line":"          - name: Is undercloud?"},{"line_number":65,"context_line":"            set_fact:"},{"line_number":66,"context_line":"              delegate_host: \"{{ groups[\u0027Undercloud\u0027][0] }}\""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9fb8cfa7_3e8a61be","line":63,"range":{"start_line":63,"start_character":16,"end_line":63,"end_character":33},"updated":"2019-06-30 10:37:30.000000000","message":"in tripleo-ci-centos-7-containers-multinode scenario ComputeCount is set to 0 and ControllerServices modified to also have nova_compute/libvirt. so we should better check for nova_compute group as I had before instead of Compute group.","commit_id":"0b148cf534529809ddd6310b3bff2266112c72e3"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"39101d173db3e5f29fa05933f77b0c7c0bcaeb8f","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        content: { get_file: ../../container_config_scripts/nova_wait_for_compute_service.py }"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  nova_compute_common_deploy_steps_tasks:"},{"line_number":51,"context_line":"    description: Common host prep tasks for cinder-volume and cinder-backup services"},{"line_number":52,"context_line":"    value: \u0026nova_compute_common_deploy_steps_tasks"},{"line_number":53,"context_line":"      - when: step|int \u003d\u003d 5"},{"line_number":54,"context_line":"        block:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"9fb8cfa7_e76af97e","line":51,"range":{"start_line":51,"start_character":17,"end_line":51,"end_character":84},"updated":"2019-07-01 10:55:55.000000000","message":"nit","commit_id":"ebda94765b42285a603e8a0a5b55430af6b78258"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"e649728aeb78c5b68434941ae874ed198b02a929","unresolved":false,"context_lines":[{"line_number":63,"context_line":"              - groups[\u0027nova_compute\u0027] is defined and (groups[\u0027nova_compute\u0027]|length\u003e0)"},{"line_number":64,"context_line":"          - name: Is undercloud?"},{"line_number":65,"context_line":"            set_fact:"},{"line_number":66,"context_line":"              delegate_host: \"{{ groups[\u0027Undercloud\u0027][0] }}\""},{"line_number":67,"context_line":"            when:"},{"line_number":68,"context_line":"              - role_name|lower \u003d\u003d \"undercloud\""},{"line_number":69,"context_line":"          - name: Is standalone?"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"9fb8cfa7_c966e451","line":66,"range":{"start_line":66,"start_character":41,"end_line":66,"end_character":51},"updated":"2019-07-01 16:10:39.000000000","message":"here we could also use nova_ironic. the undercloud does not have a nova_compute service.","commit_id":"12ddc17c22617fb8fa10668434612dd49409a378"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"59e919a4f1ddf13928e4a481256feda1da92b16e","unresolved":false,"context_lines":[{"line_number":68,"context_line":"              - role_name|lower \u003d\u003d \"undercloud\""},{"line_number":69,"context_line":"          - name: Is standalone?"},{"line_number":70,"context_line":"            set_fact:"},{"line_number":71,"context_line":"              delegate_host: \"{{ groups[\u0027Standalone\u0027][0] }}\""},{"line_number":72,"context_line":"            when:"},{"line_number":73,"context_line":"              - role_name|lower \u003d\u003d \"standalone\""},{"line_number":74,"context_line":"          - name: Discovering nova hosts"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"9fb8cfa7_89dd4c42","line":71,"range":{"start_line":71,"start_character":41,"end_line":71,"end_character":51},"updated":"2019-07-01 15:51:27.000000000","message":"This is customizable I think. Won\u0027t this just get covered by groups[\u0027nova_compute\u0027] ?","commit_id":"12ddc17c22617fb8fa10668434612dd49409a378"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"e649728aeb78c5b68434941ae874ed198b02a929","unresolved":false,"context_lines":[{"line_number":68,"context_line":"              - role_name|lower \u003d\u003d \"undercloud\""},{"line_number":69,"context_line":"          - name: Is standalone?"},{"line_number":70,"context_line":"            set_fact:"},{"line_number":71,"context_line":"              delegate_host: \"{{ groups[\u0027Standalone\u0027][0] }}\""},{"line_number":72,"context_line":"            when:"},{"line_number":73,"context_line":"              - role_name|lower \u003d\u003d \"standalone\""},{"line_number":74,"context_line":"          - name: Discovering nova hosts"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"9fb8cfa7_493bd436","line":71,"range":{"start_line":71,"start_character":41,"end_line":71,"end_character":51},"in_reply_to":"9fb8cfa7_89dd4c42","updated":"2019-07-01 16:10:39.000000000","message":"yes, you are correct. since I switched back to nova_compute group for the overcloud, this should be covered. I\u0027ll remove the standalone check","commit_id":"12ddc17c22617fb8fa10668434612dd49409a378"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"4f0d5130ec0d288af8533a272693de1031b29db5","unresolved":false,"context_lines":[{"line_number":66,"context_line":"          - name: Discovering nova hosts"},{"line_number":67,"context_line":"            command: \"{{ container_cli }} exec nova_compute nova-manage cell_v2 discover_hosts --by-service\""},{"line_number":68,"context_line":"            become: true"},{"line_number":69,"context_line":"            changed_when: False"},{"line_number":70,"context_line":"            when:"},{"line_number":71,"context_line":"            - delegate_host is defined"},{"line_number":72,"context_line":"            - inventory_hostname \u003d\u003d delegate_host"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"7faddb67_74a9aadd","line":69,"range":{"start_line":69,"start_character":12,"end_line":69,"end_character":31},"updated":"2019-07-04 11:09:32.000000000","message":"nit: we could use --strict and make this more accurate. Right now exit code 0 means nothing went wrong, but it didn\u0027t necessarily discover hosts. With --strict, IIUC, it would mean hosts were discovered, 1 for no hosts discovered, 2 for error.","commit_id":"f8779e5023c7b5dd54dd879d4f5431ed4742e9e1"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"65e01baaf230ec1620ba6bd0842b5abdf661a298","unresolved":false,"context_lines":[{"line_number":66,"context_line":"          - name: Discovering nova hosts"},{"line_number":67,"context_line":"            command: \"{{ container_cli }} exec nova_compute nova-manage cell_v2 discover_hosts --by-service\""},{"line_number":68,"context_line":"            become: true"},{"line_number":69,"context_line":"            changed_when: False"},{"line_number":70,"context_line":"            when:"},{"line_number":71,"context_line":"            - delegate_host is defined"},{"line_number":72,"context_line":"            - inventory_hostname \u003d\u003d delegate_host"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"7faddb67_28abd1d6","line":69,"range":{"start_line":69,"start_character":12,"end_line":69,"end_character":31},"in_reply_to":"7faddb67_579ef007","updated":"2019-07-04 14:17:45.000000000","message":"Damn, those return codes aren\u0027t very helpful then","commit_id":"f8779e5023c7b5dd54dd879d4f5431ed4742e9e1"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"a30f269f94df23ace20d3e875e2d6e4270ae3e46","unresolved":false,"context_lines":[{"line_number":66,"context_line":"          - name: Discovering nova hosts"},{"line_number":67,"context_line":"            command: \"{{ container_cli }} exec nova_compute nova-manage cell_v2 discover_hosts --by-service\""},{"line_number":68,"context_line":"            become: true"},{"line_number":69,"context_line":"            changed_when: False"},{"line_number":70,"context_line":"            when:"},{"line_number":71,"context_line":"            - delegate_host is defined"},{"line_number":72,"context_line":"            - inventory_hostname \u003d\u003d delegate_host"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"7faddb67_579ef007","line":69,"range":{"start_line":69,"start_character":12,"end_line":69,"end_character":31},"in_reply_to":"7faddb67_74a9aadd","updated":"2019-07-04 12:29:14.000000000","message":"\u003e nit: we could use --strict and make this more accurate. Right now\n \u003e exit code 0 means nothing went wrong, but it didn\u0027t necessarily\n \u003e discover hosts. With --strict, IIUC, it would mean hosts were\n \u003e discovered, 1 for no hosts discovered, 2 for error.\n\nhosts discovered returns 0, only duplicate host mapping \nreturns 2. All other errors 1, like e.g. bad connection url\nor transport_url which make the nova-manage command to fail.\n\nSo we can not say\nfailed_when: result.rc \u003d\u003d 2\n2 would only catch one error, and \u003e\u003d1 is also not possible\nas 1 is ok for no hosts discovered, but can also be an issue.","commit_id":"f8779e5023c7b5dd54dd879d4f5431ed4742e9e1"}],"deployment/nova/nova-compute-container-puppet.yaml":[{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"eeebf1892aee3906c11741a4bbb8005e31283cc1","unresolved":false,"context_lines":[{"line_number":617,"context_line":"                      - KOLLA_CONFIG_STRATEGY\u003dCOPY_ALWAYS"},{"line_number":618,"context_line":"            - if:"},{"line_number":619,"context_line":"                - is_not_additional_cell"},{"line_number":620,"context_line":"                - nova_wait_for_compute_service:"},{"line_number":621,"context_line":"                    start_order: 4"},{"line_number":622,"context_line":"                    image: *nova_compute_image"},{"line_number":623,"context_line":"                    net: host"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9fb8cfa7_b407d71c","side":"PARENT","line":620,"range":{"start_line":620,"start_character":16,"end_line":620,"end_character":48},"updated":"2019-06-06 14:03:07.000000000","message":"I think we\u0027ll need to keep this to ensure there is something to discover","commit_id":"4125f125271d3df3ee3a1d74cc475533d23ff593"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"402125e9b235f7da30bb88191a123ea5f26bf4f7","unresolved":false,"context_lines":[{"line_number":617,"context_line":"                      - KOLLA_CONFIG_STRATEGY\u003dCOPY_ALWAYS"},{"line_number":618,"context_line":"            - if:"},{"line_number":619,"context_line":"                - is_not_additional_cell"},{"line_number":620,"context_line":"                - nova_wait_for_compute_service:"},{"line_number":621,"context_line":"                    start_order: 4"},{"line_number":622,"context_line":"                    image: *nova_compute_image"},{"line_number":623,"context_line":"                    net: host"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9fb8cfa7_8fecfe29","side":"PARENT","line":620,"range":{"start_line":620,"start_character":16,"end_line":620,"end_character":48},"in_reply_to":"9fb8cfa7_b407d71c","updated":"2019-06-06 14:11:47.000000000","message":"I had this initially and thought we have other services using step_5, so the compute services have enough time to come up, but probably better still wait here. it won\u0027t hurt. will do that","commit_id":"4125f125271d3df3ee3a1d74cc475533d23ff593"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"8a97e53e2a8c24ab47fb0cc14bb7915fc2be33ab","unresolved":false,"context_lines":[{"line_number":643,"context_line":"                - {}"},{"line_number":644,"context_line":"        step_5:"},{"line_number":645,"context_line":"          if:"},{"line_number":646,"context_line":"            - is_not_additional_cell"},{"line_number":647,"context_line":"            - nova_cell_v2_discover_hosts:"},{"line_number":648,"context_line":"                start_order: 0"},{"line_number":649,"context_line":"                image: *nova_compute_image"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9fb8cfa7_0533c0f7","side":"PARENT","line":646,"updated":"2019-06-11 20:28:56.000000000","message":"this logic is lost. was that intentional?","commit_id":"4125f125271d3df3ee3a1d74cc475533d23ff593"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"468c87fdff15c0a9e65e36cee00c7b4a4590ae84","unresolved":false,"context_lines":[{"line_number":643,"context_line":"                - {}"},{"line_number":644,"context_line":"        step_5:"},{"line_number":645,"context_line":"          if:"},{"line_number":646,"context_line":"            - is_not_additional_cell"},{"line_number":647,"context_line":"            - nova_cell_v2_discover_hosts:"},{"line_number":648,"context_line":"                start_order: 0"},{"line_number":649,"context_line":"                image: *nova_compute_image"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9fb8cfa7_b1dead0e","side":"PARENT","line":646,"in_reply_to":"9fb8cfa7_0533c0f7","updated":"2019-06-12 07:31:44.000000000","message":"yes, it won\u0027t hurt to run it. on initial cell creating it won\u0027t discover the nodes, as the cell needs to be created first on the controllers, but on subsequent scale out/down it would run the discovery.","commit_id":"4125f125271d3df3ee3a1d74cc475533d23ff593"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"97923a3319ddab44ce2864f14ec0ca77b7cb59f4","unresolved":false,"context_lines":[{"line_number":643,"context_line":"                - {}"},{"line_number":644,"context_line":"        step_5:"},{"line_number":645,"context_line":"          if:"},{"line_number":646,"context_line":"            - is_not_additional_cell"},{"line_number":647,"context_line":"            - nova_cell_v2_discover_hosts:"},{"line_number":648,"context_line":"                start_order: 0"},{"line_number":649,"context_line":"                image: *nova_compute_image"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9fb8cfa7_26fab842","side":"PARENT","line":646,"in_reply_to":"9fb8cfa7_b1dead0e","updated":"2019-06-24 21:23:59.000000000","message":"ok. can we get owalsh to review this patch as well","commit_id":"4125f125271d3df3ee3a1d74cc475533d23ff593"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"468c87fdff15c0a9e65e36cee00c7b4a4590ae84","unresolved":false,"context_lines":[{"line_number":817,"context_line":"          when:"},{"line_number":818,"context_line":"            - role_name|lower !\u003d \"undercloud\""},{"line_number":819,"context_line":"            - groups[\u0027nova_compute\u0027] is defined and (groups[\u0027nova_compute\u0027]|length\u003e0)"},{"line_number":820,"context_line":"        - name: Is undercloud?"},{"line_number":821,"context_line":"          set_fact:"},{"line_number":822,"context_line":"            delegate_host: \"localhost\""},{"line_number":823,"context_line":"          when:"},{"line_number":824,"context_line":"            - role_name|lower \u003d\u003d \"undercloud\""},{"line_number":825,"context_line":"        - name: Discovering nova hosts via {{ delegate_host }}"},{"line_number":826,"context_line":"          command: \"{{ container_cli }} exec nova_compute nova-manage cell_v2 discover_hosts --by-service\""},{"line_number":827,"context_line":"          become: true"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9fb8cfa7_71327560","line":824,"range":{"start_line":820,"start_character":0,"end_line":824,"end_character":45},"updated":"2019-06-12 07:31:44.000000000","message":"we could potentially remove this and always delegate to the overcloud as we don\u0027t have a nova-compute on the undercloud. we only have there the nova-ironic.","commit_id":"91f1a4b16d90784b73f4bed3aa8c742bd24d2c5e"}],"deployment/nova/nova-ironic-container-puppet.yaml":[{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"eeebf1892aee3906c11741a4bbb8005e31283cc1","unresolved":false,"context_lines":[{"line_number":186,"context_line":"          run_once: True"},{"line_number":187,"context_line":"          delegate_to: \"{{ groups[\u0027nova_compute\u0027][0] }}\""},{"line_number":188,"context_line":"          when:"},{"line_number":189,"context_line":"            - not is_undercloud|bool"},{"line_number":190,"context_line":"            - groups[\u0027nova_compute\u0027] is defined and (groups[\u0027nova_compute\u0027]|length\u003e0)"},{"line_number":191,"context_line":"        - name: Discovering nova hosts (undercloud)"},{"line_number":192,"context_line":"          command: \"{{ container_cli }} exec nova_compute nova-manage cell_v2 discover_hosts --by-service\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9fb8cfa7_d4292b9b","line":189,"range":{"start_line":189,"start_character":14,"end_line":189,"end_character":36},"updated":"2019-06-06 14:03:07.000000000","message":"why not run on the undercloud?","commit_id":"84df8af98f579fb9e8793b8e19c39fdaf0629c70"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"402125e9b235f7da30bb88191a123ea5f26bf4f7","unresolved":false,"context_lines":[{"line_number":186,"context_line":"          run_once: True"},{"line_number":187,"context_line":"          delegate_to: \"{{ groups[\u0027nova_compute\u0027][0] }}\""},{"line_number":188,"context_line":"          when:"},{"line_number":189,"context_line":"            - not is_undercloud|bool"},{"line_number":190,"context_line":"            - groups[\u0027nova_compute\u0027] is defined and (groups[\u0027nova_compute\u0027]|length\u003e0)"},{"line_number":191,"context_line":"        - name: Discovering nova hosts (undercloud)"},{"line_number":192,"context_line":"          command: \"{{ container_cli }} exec nova_compute nova-manage cell_v2 discover_hosts --by-service\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9fb8cfa7_6f60aaa6","line":189,"range":{"start_line":189,"start_character":14,"end_line":189,"end_character":36},"in_reply_to":"9fb8cfa7_d4292b9b","updated":"2019-06-06 14:11:47.000000000","message":"the undercloud is not part of the nova_compute group in the inventory. we fail here. the following step (if this is the undercloud) runs it there.","commit_id":"84df8af98f579fb9e8793b8e19c39fdaf0629c70"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"402125e9b235f7da30bb88191a123ea5f26bf4f7","unresolved":false,"context_lines":[{"line_number":187,"context_line":"          delegate_to: \"{{ groups[\u0027nova_compute\u0027][0] }}\""},{"line_number":188,"context_line":"          when:"},{"line_number":189,"context_line":"            - not is_undercloud|bool"},{"line_number":190,"context_line":"            - groups[\u0027nova_compute\u0027] is defined and (groups[\u0027nova_compute\u0027]|length\u003e0)"},{"line_number":191,"context_line":"        - name: Discovering nova hosts (undercloud)"},{"line_number":192,"context_line":"          command: \"{{ container_cli }} exec nova_compute nova-manage cell_v2 discover_hosts --by-service\""},{"line_number":193,"context_line":"          become: true"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9fb8cfa7_4f5da6e7","line":190,"range":{"start_line":190,"start_character":14,"end_line":190,"end_character":85},"updated":"2019-06-06 14:11:47.000000000","message":"we need this in case we don\u0027t deploy computes (e.g. split control plane)","commit_id":"84df8af98f579fb9e8793b8e19c39fdaf0629c70"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"8a97e53e2a8c24ab47fb0cc14bb7915fc2be33ab","unresolved":false,"context_lines":[{"line_number":208,"context_line":"          changed_when: False"},{"line_number":209,"context_line":"          run_once: True"},{"line_number":210,"context_line":"          delegate_to: \"{{ delegate_host }}\""},{"line_number":211,"context_line":"          when: delegate_host is defined"},{"line_number":212,"context_line":"      post_upgrade_tasks:"},{"line_number":213,"context_line":"        - when: step|int \u003d\u003d 1"},{"line_number":214,"context_line":"          import_role:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9fb8cfa7_c1011d08","line":211,"updated":"2019-06-11 20:28:56.000000000","message":"these tasks already run on the undercloud. you don\u0027t need a delegate_to.\n\nit\u0027s all a bit strange to me what you\u0027re trying to do as external_post_deploy_tasks is specifically for tasks that run on the undercloud.\n\ncan\u0027t we just always run the tasks from the undercloud?\n\nalso, why is this only in nova-ironic-container-puppet?","commit_id":"91f1a4b16d90784b73f4bed3aa8c742bd24d2c5e"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"738063681922afca3a7f3204a45dddd2606678b8","unresolved":false,"context_lines":[{"line_number":208,"context_line":"          changed_when: False"},{"line_number":209,"context_line":"          run_once: True"},{"line_number":210,"context_line":"          delegate_to: \"{{ delegate_host }}\""},{"line_number":211,"context_line":"          when: delegate_host is defined"},{"line_number":212,"context_line":"      post_upgrade_tasks:"},{"line_number":213,"context_line":"        - when: step|int \u003d\u003d 1"},{"line_number":214,"context_line":"          import_role:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9fb8cfa7_b77be678","line":211,"in_reply_to":"9fb8cfa7_52d4fd47","updated":"2019-06-28 12:12:09.000000000","message":"\u003e \u003e in that case, just use deploy_steps_tasks and it will do the\n \u003e right\n \u003e \u003e thing.\n \u003e \n \u003e perfect thx that\u0027s looks to be the right place.\n \u003e \n \u003e \u003e in the case of the undercloud deploy, the undercloud is the\n \u003e \u003e overcloud, so the tasks will run on the undercloud.\n \u003e \u003e\n \u003e \u003e in the case of the overcloud, it will run on the overcloud.\n \u003e \u003e\n \u003e \u003e in both cases, you can delegate to groups[\u0027nova_compute\u0027][0].\n\njust a note, the undercloud does not have a nova_compute group. So we still need the check and delegate to the [\u0027Undercloud\u0027][0]. \n\nsubmit the patch after some more tests.\n\n \u003e \u003e\n \u003e \u003e then is it possible to have the tasks in nova-compute-common-container-puppet.yaml?\n \u003e \n \u003e yes that should be possible. will update the patch later today.","commit_id":"91f1a4b16d90784b73f4bed3aa8c742bd24d2c5e"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"97923a3319ddab44ce2864f14ec0ca77b7cb59f4","unresolved":false,"context_lines":[{"line_number":208,"context_line":"          changed_when: False"},{"line_number":209,"context_line":"          run_once: True"},{"line_number":210,"context_line":"          delegate_to: \"{{ delegate_host }}\""},{"line_number":211,"context_line":"          when: delegate_host is defined"},{"line_number":212,"context_line":"      post_upgrade_tasks:"},{"line_number":213,"context_line":"        - when: step|int \u003d\u003d 1"},{"line_number":214,"context_line":"          import_role:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9fb8cfa7_a6e6a8af","line":211,"in_reply_to":"9fb8cfa7_718115fb","updated":"2019-06-24 21:23:59.000000000","message":"in that case, just use deploy_steps_tasks and it will do the right thing.\n\nin the case of the undercloud deploy, the undercloud is the overcloud, so the tasks will run on the undercloud.\n\nin the case of the overcloud, it will run on the overcloud.\n\nin both cases, you can delegate to groups[\u0027nova_compute\u0027][0].\n\nthen is it possible to have the tasks in nova-compute-common-container-puppet.yaml?","commit_id":"91f1a4b16d90784b73f4bed3aa8c742bd24d2c5e"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"8881f01e60aa68acd5639e25c4f53acba7ac8844","unresolved":false,"context_lines":[{"line_number":208,"context_line":"          changed_when: False"},{"line_number":209,"context_line":"          run_once: True"},{"line_number":210,"context_line":"          delegate_to: \"{{ delegate_host }}\""},{"line_number":211,"context_line":"          when: delegate_host is defined"},{"line_number":212,"context_line":"      post_upgrade_tasks:"},{"line_number":213,"context_line":"        - when: step|int \u003d\u003d 1"},{"line_number":214,"context_line":"          import_role:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9fb8cfa7_52d4fd47","line":211,"in_reply_to":"9fb8cfa7_a6e6a8af","updated":"2019-06-28 07:20:59.000000000","message":"\u003e in that case, just use deploy_steps_tasks and it will do the right\n \u003e thing.\n\nperfect thx that\u0027s looks to be the right place.\n\n \u003e in the case of the undercloud deploy, the undercloud is the\n \u003e overcloud, so the tasks will run on the undercloud.\n \u003e \n \u003e in the case of the overcloud, it will run on the overcloud.\n \u003e \n \u003e in both cases, you can delegate to groups[\u0027nova_compute\u0027][0].\n \u003e \n \u003e then is it possible to have the tasks in nova-compute-common-container-puppet.yaml?\n\nyes that should be possible. will update the patch later today.","commit_id":"91f1a4b16d90784b73f4bed3aa8c742bd24d2c5e"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"468c87fdff15c0a9e65e36cee00c7b4a4590ae84","unresolved":false,"context_lines":[{"line_number":208,"context_line":"          changed_when: False"},{"line_number":209,"context_line":"          run_once: True"},{"line_number":210,"context_line":"          delegate_to: \"{{ delegate_host }}\""},{"line_number":211,"context_line":"          when: delegate_host is defined"},{"line_number":212,"context_line":"      post_upgrade_tasks:"},{"line_number":213,"context_line":"        - when: step|int \u003d\u003d 1"},{"line_number":214,"context_line":"          import_role:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9fb8cfa7_718115fb","line":211,"in_reply_to":"9fb8cfa7_c1011d08","updated":"2019-06-12 07:31:44.000000000","message":"In general what we want to achieve is to run the discovery on a single node and also run it even if someone skips the deploy identifier or blacklists hosts. When the discovery was moved to the computes with [1], it was racy and failed when it was triggered on multiple computes at the same time. Therefore we moved it to run only on the bootstrap compute node and used the deploy identifier to make sure we run it on every deploy. But if one blacklists the compute boostrap node, or skips the deploy identifier it won\u0027t run. \n\nTherefore the idea was to run it as an external_post_deploy_task and delegate it either to the undercloud (if it is an undercloud deploy, or to the first compute if it is an overcloud deploy.\n\n* We need to delegate it as we need the nova.conf from undercloud or overcloud. Because of that we can not run it always on the undercloud\n\n* \u003e also, why is this only in nova-ironic-container-puppet ?\n\nsorry, don\u0027t understand that. The external_post_deploy_tasks in nova-compute-container-puppet.yaml and nova-ironic-container-puppet.yaml are the same.\n\n\n[1] https://github.com/openstack/tripleo-heat-templates/commit/d7704bbf56cc155884e233a816422aa6e721cda3#diff-f9fbae7caa7594d60063e6915d9f4990","commit_id":"91f1a4b16d90784b73f4bed3aa8c742bd24d2c5e"}]}