)]}'
{"deployment/neutron/kill-script":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"0da2ad598478ef3edd1dbd555f8f2b1169b9c632","unresolved":false,"context_lines":[{"line_number":4,"context_line":"# suffix."},{"line_number":5,"context_line":"exec 3\u003e\u00261 4\u003e\u00262"},{"line_number":6,"context_line":"trap \u0027exec 2\u003e\u00264 1\u003e\u00263\u0027 0 1 2 3"},{"line_number":7,"context_line":"exec 1\u003e\u003e/var/log/neutron/kill-script.log 2\u003e\u00261"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"# just so that we know when block starts"},{"line_number":10,"context_line":"date"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"9fb8cfa7_4572af7e","line":7,"range":{"start_line":7,"start_character":27,"end_line":7,"end_character":42},"updated":"2019-06-18 06:10:34.000000000","message":"we should add this to the collect logs for ci jobs","commit_id":"e7ab4509842c19636f8f77aa9d99e55f38caea99"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"2b5be66acf42cd206c22c6047a3b2032d20fc33c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"# suffix."},{"line_number":5,"context_line":"exec 3\u003e\u00261 4\u003e\u00262"},{"line_number":6,"context_line":"trap \u0027exec 2\u003e\u00264 1\u003e\u00263\u0027 0 1 2 3"},{"line_number":7,"context_line":"exec 1\u003e\u003e/var/log/neutron/kill-script.log 2\u003e\u00261"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"# just so that we know when block starts"},{"line_number":10,"context_line":"date"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"9fb8cfa7_a5ea8ba9","line":7,"range":{"start_line":7,"start_character":27,"end_line":7,"end_character":42},"in_reply_to":"9fb8cfa7_4572af7e","updated":"2019-06-18 06:32:24.000000000","message":"already taken care of, at least it should. That location is already scraped for logs.","commit_id":"e7ab4509842c19636f8f77aa9d99e55f38caea99"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"0da2ad598478ef3edd1dbd555f8f2b1169b9c632","unresolved":false,"context_lines":[{"line_number":10,"context_line":"date"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"SIG\u003d$1"},{"line_number":13,"context_line":"PID\u003d$2"},{"line_number":14,"context_line":"NETNS\u003d$(ip netns | awk \u0027{print $1}\u0027)"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"if [ \"x${NETNS}\" \u003d\u003d \"x\" ]; then"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"9fb8cfa7_c52c5f4c","line":13,"updated":"2019-06-18 06:10:34.000000000","message":"main question on first pass is where are we using this. e.g. on upgrades? is there somewhere else we are explicitly stopping containers?","commit_id":"e7ab4509842c19636f8f77aa9d99e55f38caea99"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"2b5be66acf42cd206c22c6047a3b2032d20fc33c","unresolved":false,"context_lines":[{"line_number":10,"context_line":"date"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"SIG\u003d$1"},{"line_number":13,"context_line":"PID\u003d$2"},{"line_number":14,"context_line":"NETNS\u003d$(ip netns | awk \u0027{print $1}\u0027)"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"if [ \"x${NETNS}\" \u003d\u003d \"x\" ]; then"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"9fb8cfa7_45f86f7b","line":13,"in_reply_to":"9fb8cfa7_c52c5f4c","updated":"2019-06-18 06:32:24.000000000","message":"not sure we actually stop any of the agent container on our own - those agents are managed directly by neutron.\n\nUntil now, neutron didn\u0027t know how to properly stop those containerized agents.\nA new feature was added to the code in order to take those \"kill scripts\", like the wrappers we have for the launch of those containers.\n\nDoes it answer your concerns?","commit_id":"e7ab4509842c19636f8f77aa9d99e55f38caea99"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"31208c5c30c634ff967d2d4115671a99ee27aad8","unresolved":false,"context_lines":[{"line_number":34,"context_line":"  echo \"No such PID: ${PID}\""},{"line_number":35,"context_line":"  date"},{"line_number":36,"context_line":"  exit 1"},{"line_number":37,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"9fb8cfa7_f5feda69","line":37,"updated":"2019-06-19 06:31:47.000000000","message":"went looking for some evidence in the tempest logs like we discussed yesterday but couldn\u0027t find it :) http://logs.openstack.org/28/663528/9/check/tripleo-ci-centos-7-standalone/8f72181/logs/undercloud/home/zuul/tempest/tempest.log.txt.gz","commit_id":"a1be8c63a4a9537587f6f7b2b0c57cc2557b915a"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"4077d26e56c4dd4ad07173933f5e07e4fce0916c","unresolved":false,"context_lines":[{"line_number":34,"context_line":"  echo \"No such PID: ${PID}\""},{"line_number":35,"context_line":"  date"},{"line_number":36,"context_line":"  exit 1"},{"line_number":37,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"9fb8cfa7_78e5ff37","line":37,"in_reply_to":"9fb8cfa7_7520aaf8","updated":"2019-06-19 07:11:28.000000000","message":"It is also visible in Neutron agent\u0027s logs, e.g. in http://logs.openstack.org/28/663528/9/check/tripleo-ci-centos-7-standalone/8f72181/logs/undercloud/var/log/containers/neutron/ovn-metadata-agent.log.txt.gz#_2019-06-19_01_04_23_965","commit_id":"a1be8c63a4a9537587f6f7b2b0c57cc2557b915a"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"3b1daa974042c7742bd1641e81dc56521f382ce2","unresolved":false,"context_lines":[{"line_number":34,"context_line":"  echo \"No such PID: ${PID}\""},{"line_number":35,"context_line":"  date"},{"line_number":36,"context_line":"  exit 1"},{"line_number":37,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"9fb8cfa7_7520aaf8","line":37,"in_reply_to":"9fb8cfa7_f5feda69","updated":"2019-06-19 06:36:03.000000000","message":"Check it there:\nhttp://logs.openstack.org/28/663528/9/check/tripleo-ci-centos-7-standalone/8f72181/logs/undercloud/var/log/containers/neutron/kill-script.log.txt.gz\n\nit does log things :D","commit_id":"a1be8c63a4a9537587f6f7b2b0c57cc2557b915a"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"c8c7ed466d1add9c27f4e04f7bd2151c18d925c1","unresolved":false,"context_lines":[{"line_number":20,"context_line":"  exit 1"},{"line_number":21,"context_line":"fi"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"CLI\u003d\"nsenter --net\u003d/run/netns/${NETNS} --preserve-credentials -m -t 1 podman\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"if [ -f /proc/$PID/cgroup ]; then"},{"line_number":26,"context_line":"  # Get container ID based on process cgroups"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"9fb8cfa7_029eb762","line":23,"range":{"start_line":23,"start_character":70,"end_line":23,"end_character":76},"updated":"2019-06-20 13:38:47.000000000","message":"Fun fact, we\u0027re still using docker with CentOS7 on the overcloud. This needs to be configurable based on container_cli","commit_id":"ff3021ffef22a7099a1fbe3dbae4a4708d6eef4d"}],"deployment/neutron/neutron-dhcp-container-puppet.yaml":[{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"dcf28c0c0ffcb47d8847ee049e9d5cf003bc2745","unresolved":false,"context_lines":[{"line_number":272,"context_line":"                path: /var/lib/neutron/kill_scripts"},{"line_number":273,"context_line":"            - name: create dhcp kill script"},{"line_number":274,"context_line":"              copy:"},{"line_number":275,"context_line":"                dest: /var/lib/neutron/kill_scripts/dhcp-kill"},{"line_number":276,"context_line":"                mode: 0755"},{"line_number":277,"context_line":"                content: {get_file: ./kill-script}"},{"line_number":278,"context_line":"      docker_config:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fb8cfa7_400edd8d","line":275,"range":{"start_line":275,"start_character":52,"end_line":275,"end_character":56},"updated":"2019-06-06 10:29:18.000000000","message":"Should be dnsmasq no?","commit_id":"9a93495165faf3a982c1f4d508ebef782ecf2898"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ecc07506b2ce2dc3dba3a5d6f656c8f0f3d2805a","unresolved":false,"context_lines":[{"line_number":274,"context_line":"              copy:"},{"line_number":275,"context_line":"                dest: /var/lib/neutron/kill_scripts/dnsmasq-kill"},{"line_number":276,"context_line":"                mode: 0755"},{"line_number":277,"context_line":"                content: {get_file: ./kill-script}"},{"line_number":278,"context_line":"      docker_config:"},{"line_number":279,"context_line":"        step_2:"},{"line_number":280,"context_line":"          create_dnsmasq_wrapper:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9fb8cfa7_8355ad1f","line":277,"updated":"2019-06-07 07:55:17.000000000","message":"sometimes, when enable_metadata_network is set to True (https://github.com/openstack/neutron/blob/master/neutron/conf/agent/dhcp.py#L59) also Haproxy service will be spawned and managed by dhcp agent.","commit_id":"28ba43d45dba183d03ba94c9b670fdd159991793"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"823b2e92f049a22ee43a3d6e0714cf71ba7cd40f","unresolved":false,"context_lines":[{"line_number":274,"context_line":"              copy:"},{"line_number":275,"context_line":"                dest: /var/lib/neutron/kill_scripts/dnsmasq-kill"},{"line_number":276,"context_line":"                mode: 0755"},{"line_number":277,"context_line":"                content: {get_file: ./kill-script}"},{"line_number":278,"context_line":"      docker_config:"},{"line_number":279,"context_line":"        step_2:"},{"line_number":280,"context_line":"          create_dnsmasq_wrapper:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9fb8cfa7_a217e151","line":277,"in_reply_to":"9fb8cfa7_51bbf60c","updated":"2019-06-18 05:30:45.000000000","message":"@Brent: is this something to set in t-h-t, or ruled directly in Neutron code? IMHO Neutron code would be best... Any thought?","commit_id":"28ba43d45dba183d03ba94c9b670fdd159991793"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"7eb1fed5e64227d4929143765a25f41195a1f0b5","unresolved":false,"context_lines":[{"line_number":274,"context_line":"              copy:"},{"line_number":275,"context_line":"                dest: /var/lib/neutron/kill_scripts/dnsmasq-kill"},{"line_number":276,"context_line":"                mode: 0755"},{"line_number":277,"context_line":"                content: {get_file: ./kill-script}"},{"line_number":278,"context_line":"      docker_config:"},{"line_number":279,"context_line":"        step_2:"},{"line_number":280,"context_line":"          create_dnsmasq_wrapper:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9fb8cfa7_51bbf60c","line":277,"in_reply_to":"9fb8cfa7_8355ad1f","updated":"2019-06-07 14:02:36.000000000","message":"A rule of thumb, there should be a kill script for every service where there is a NeutronEnable\u003cfoo\u003eWrapper set to true. Usually where there is a variable at all it will be \"true\" (Radvd is an exception) but if it is set to false for whatever reason (e.g. haproxy all of the sudden doesn\u0027t work in containers ) you want to avoid the kill script.","commit_id":"28ba43d45dba183d03ba94c9b670fdd159991793"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"ce98b7635d86edc1a5670d7582231dc13f4cefe0","unresolved":false,"context_lines":[{"line_number":274,"context_line":"              copy:"},{"line_number":275,"context_line":"                dest: /var/lib/neutron/kill_scripts/dnsmasq-kill"},{"line_number":276,"context_line":"                mode: 0755"},{"line_number":277,"context_line":"                content: {get_file: ./kill-script}"},{"line_number":278,"context_line":"      docker_config:"},{"line_number":279,"context_line":"        step_2:"},{"line_number":280,"context_line":"          create_dnsmasq_wrapper:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9fb8cfa7_8749878c","line":277,"in_reply_to":"9fb8cfa7_a217e151","updated":"2019-06-18 12:29:59.000000000","message":"I think this is deployer-domain kind of thing. Neutron really doesn\u0027t care. We already have the variables in place so you just need to add the conditional on the kill script generation. One example is radvd (in the l3 agent config) which currently doesn\u0027t support running in non-daemon mode so we cannot run it in a container by itself. Hopefully we will fix that and flip it to true at some point.\n\nHere\u0027s a thought while on the subject: maybe we should  deprecate the \"NeutronEnable\u003cX\u003eWrapper\" heat parameters. We don\u0027t test with them set to some other value than their defaults. They were initially added because of reasons but I don\u0027t think they apply anymore. If we were to do that, then unless we intend to backport, I don\u0027t think my comment about having kill scripts generated conditionally on the value of the heat parameters is as relevant. Thoughts?","commit_id":"28ba43d45dba183d03ba94c9b670fdd159991793"}],"deployment/neutron/neutron-l3-container-puppet.yaml":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ecc07506b2ce2dc3dba3a5d6f656c8f0f3d2805a","unresolved":false,"context_lines":[{"line_number":243,"context_line":"              copy:"},{"line_number":244,"context_line":"                dest: /var/lib/neutron/kill_scripts/keepalived-kill"},{"line_number":245,"context_line":"                mode: 0755"},{"line_number":246,"context_line":"                content: {get_file: ./kill-script}"},{"line_number":247,"context_line":"      docker_config:"},{"line_number":248,"context_line":"        step_2:"},{"line_number":249,"context_line":"          create_keepalived_wrapper:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9fb8cfa7_033f7dd6","line":246,"updated":"2019-06-07 07:55:17.000000000","message":"this container also can spawn Haproxy for providing metadata service to the instances","commit_id":"28ba43d45dba183d03ba94c9b670fdd159991793"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"af34678879149314ffde33986fac6d5e80fdf85a","unresolved":false,"context_lines":[{"line_number":253,"context_line":"                haproxy_wrapper_enabled: {get_param: NeutronEnableHaproxyDockerWrapper}"},{"line_number":254,"context_line":"                dibbler_wrapper_enabled: {get_param: NeutronEnableDibblerDockerWrapper}"},{"line_number":255,"context_line":"                radvd_wrapper_enabled: {get_param: NeutronEnableRadvdDockerWrapper}"},{"line_number":256,"context_line":"            - name: create kill_scripts directory within /var/lib/neutron"},{"line_number":257,"context_line":"              file:"},{"line_number":258,"context_line":"                state: directory"},{"line_number":259,"context_line":"                path: /var/lib/neutron/kill_scripts"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"9fb8cfa7_ee833b03","line":256,"range":{"start_line":256,"start_character":20,"end_line":256,"end_character":39},"updated":"2019-06-21 10:53:00.000000000","message":"so asked before but you pointed to the logs (i.e. that http://logs.openstack.org/28/663528/12/check/tripleo-ci-centos-7-standalone/000b0e5/logs/undercloud/var/log/containers/neutron/kill-script.log.txt.gz\n\nbut do we want to capture the generated kill script itself from /var/lib/neutron","commit_id":"aae5c166b79bc685aed1b55cce08ca6f60ccd400"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"828c9c507b49f371b82e2529b686cc11c17c5d07","unresolved":false,"context_lines":[{"line_number":253,"context_line":"                haproxy_wrapper_enabled: {get_param: NeutronEnableHaproxyDockerWrapper}"},{"line_number":254,"context_line":"                dibbler_wrapper_enabled: {get_param: NeutronEnableDibblerDockerWrapper}"},{"line_number":255,"context_line":"                radvd_wrapper_enabled: {get_param: NeutronEnableRadvdDockerWrapper}"},{"line_number":256,"context_line":"            - name: create kill_scripts directory within /var/lib/neutron"},{"line_number":257,"context_line":"              file:"},{"line_number":258,"context_line":"                state: directory"},{"line_number":259,"context_line":"                path: /var/lib/neutron/kill_scripts"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"9fb8cfa7_8e1cffc1","line":256,"range":{"start_line":256,"start_character":20,"end_line":256,"end_character":39},"in_reply_to":"9fb8cfa7_ee833b03","updated":"2019-06-21 11:07:55.000000000","message":"hmmm. Do we already capture the wrapper that start the agent? If no, same question, especially since the kill-script is in the same location :).","commit_id":"aae5c166b79bc685aed1b55cce08ca6f60ccd400"}],"deployment/ovn/ovn-metadata-container-puppet.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"31208c5c30c634ff967d2d4115671a99ee27aad8","unresolved":false,"context_lines":[{"line_number":217,"context_line":"            - name: create kill_scripts directory within /var/lib/neutron"},{"line_number":218,"context_line":"              file:"},{"line_number":219,"context_line":"                state: directory"},{"line_number":220,"context_line":"                path: /var/lib/neutron/kill_scripts"},{"line_number":221,"context_line":"            - name: create haproxy kill script"},{"line_number":222,"context_line":"              when: haproxy_wrapper_enabled|bool"},{"line_number":223,"context_line":"              copy:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9fb8cfa7_d5ccf662","line":220,"updated":"2019-06-19 06:31:47.000000000","message":"do we want to grab these at http://logs.openstack.org/28/663528/9/check/tripleo-ci-centos-7-standalone/8f72181/logs/undercloud/var/lib/ (collect logs)\n\nhttps://opendev.org/openstack/tripleo-ci/src/commit/160c52d3fcbcf42e75156e2070ecad09b2ca7c39/toci-quickstart/config/collect-logs.yml#L9","commit_id":"a1be8c63a4a9537587f6f7b2b0c57cc2557b915a"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"af34678879149314ffde33986fac6d5e80fdf85a","unresolved":false,"context_lines":[{"line_number":217,"context_line":"            - name: create kill_scripts directory within /var/lib/neutron"},{"line_number":218,"context_line":"              file:"},{"line_number":219,"context_line":"                state: directory"},{"line_number":220,"context_line":"                path: /var/lib/neutron/kill_scripts"},{"line_number":221,"context_line":"            - name: create haproxy kill script"},{"line_number":222,"context_line":"              when: haproxy_wrapper_enabled|bool"},{"line_number":223,"context_line":"              copy:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9fb8cfa7_6ef0abca","line":220,"in_reply_to":"9fb8cfa7_3578f2f6","updated":"2019-06-21 10:53:00.000000000","message":"i meant the actual kill script itself not the output","commit_id":"a1be8c63a4a9537587f6f7b2b0c57cc2557b915a"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"3b1daa974042c7742bd1641e81dc56521f382ce2","unresolved":false,"context_lines":[{"line_number":217,"context_line":"            - name: create kill_scripts directory within /var/lib/neutron"},{"line_number":218,"context_line":"              file:"},{"line_number":219,"context_line":"                state: directory"},{"line_number":220,"context_line":"                path: /var/lib/neutron/kill_scripts"},{"line_number":221,"context_line":"            - name: create haproxy kill script"},{"line_number":222,"context_line":"              when: haproxy_wrapper_enabled|bool"},{"line_number":223,"context_line":"              copy:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9fb8cfa7_3578f2f6","line":220,"in_reply_to":"9fb8cfa7_d5ccf662","updated":"2019-06-19 06:36:03.000000000","message":"well, it\u0027s already present:\nhttp://logs.openstack.org/28/663528/9/check/tripleo-ci-centos-7-standalone/8f72181/logs/undercloud/var/log/containers/neutron/kill-script.log.txt.gz","commit_id":"a1be8c63a4a9537587f6f7b2b0c57cc2557b915a"}]}