)]}'
{"deployment/ceph-ansible/ceph-base.yaml":[{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"604c7ad5b091dfa330fdf03cc8903ac7dfffc1c8","unresolved":false,"context_lines":[{"line_number":462,"context_line":"                  - ireallymeanit: \"yes\""},{"line_number":463,"context_line":"                    fetch_directory: \"{{playbook_dir}}/ceph-ansible/fetch_dir\""},{"line_number":464,"context_line":"                    container_binary: {get_param: ContainerCli}"},{"line_number":465,"context_line":"                    handler_health_mon_check_retries: {get_param: CephMonCheckRetry}"},{"line_number":466,"context_line":"                    handler_health_mon_check_delay: {get_param: CephMonCheckDelay}"},{"line_number":467,"context_line":"            - name: generate ceph-ansible extra vars"},{"line_number":468,"context_line":"              copy:"},{"line_number":469,"context_line":"                dest: \"{{playbook_dir}}/ceph-ansible/extra_vars.yml\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fb8cfa7_72337cf7","line":466,"range":{"start_line":465,"start_character":0,"end_line":466,"end_character":82},"updated":"2019-06-10 16:02:48.000000000","message":"Should we just set higher defaults here but not make it overridable on lines 56-63? \n\nWe should have a consistent pattern and the moment we are documenting that users can override these values. If we just need better defaults can we code better defaults here but let the user override?\n\nhttps://github.com/ceph/ceph-ansible/blob/master/group_vars/all.yml.sample#L440-L442","commit_id":"e226a2cf4ebdc6e02790916c3801a8ab0b489727"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"550265d1c9b804880e33cee64490dcb800344d50","unresolved":false,"context_lines":[{"line_number":462,"context_line":"                  - ireallymeanit: \"yes\""},{"line_number":463,"context_line":"                    fetch_directory: \"{{playbook_dir}}/ceph-ansible/fetch_dir\""},{"line_number":464,"context_line":"                    container_binary: {get_param: ContainerCli}"},{"line_number":465,"context_line":"                    handler_health_mon_check_retries: {get_param: CephMonCheckRetry}"},{"line_number":466,"context_line":"                    handler_health_mon_check_delay: {get_param: CephMonCheckDelay}"},{"line_number":467,"context_line":"            - name: generate ceph-ansible extra vars"},{"line_number":468,"context_line":"              copy:"},{"line_number":469,"context_line":"                dest: \"{{playbook_dir}}/ceph-ansible/extra_vars.yml\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fb8cfa7_9245d045","line":466,"range":{"start_line":465,"start_character":0,"end_line":466,"end_character":82},"in_reply_to":"9fb8cfa7_72337cf7","updated":"2019-06-10 16:04:03.000000000","message":"yeah if it is a matter of picking a better default I\u0027d put it in ceph-ansible as well\n\nfor director users it\u0027s still possible to override them via CephAnsibleExtraConfig","commit_id":"e226a2cf4ebdc6e02790916c3801a8ab0b489727"}]}