)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"62667859209aeb281b8cf7729aebee748b3b9796","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2019-07-03 12:18:25 +1000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Raise the default ulimit of max locked memory for nova containers"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I6d68431fd3c66c9496a36d3cfa9c2efe57e2ed99"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9fb8cfa7_bf1e22b9","line":8,"updated":"2019-07-03 06:51:30.000000000","message":"cool story bro \n\ne.g. copy paste from the release note like \" Increase the default memlock to 64MiB via ``DockerNovaComputeUlimit``. \"\n \nbut really \u0027why do we need this in our life\u0027 please? (i see in the release note you mention nova_cell_v2_discover_hosts as \u0027needing  this\u0027 ... does it go reeealy slow? does it explode? etc)","commit_id":"9f4a487d5d25b57c35b70eed565a4549bf0c91d4"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"3b1994db281057801046bdc52e3fde10b5ded8d0","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2019-07-03 12:18:25 +1000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Raise the default ulimit of max locked memory for nova containers"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I6d68431fd3c66c9496a36d3cfa9c2efe57e2ed99"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7faddb67_952d4eaa","line":8,"in_reply_to":"9fb8cfa7_bf1e22b9","updated":"2019-07-03 22:19:05.000000000","message":"Done","commit_id":"9f4a487d5d25b57c35b70eed565a4549bf0c91d4"}],"deployment/nova/nova-compute-container-puppet.yaml":[{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"93031bc65d9e1dc5fcde1edf1c58761164625305","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    description: The container image to use for the nova_libvirt config_volume"},{"line_number":12,"context_line":"    type: string"},{"line_number":13,"context_line":"  DockerNovaComputeUlimit:"},{"line_number":14,"context_line":"    default: [\u0027nofile\u003d131072\u0027, \u0027memlock\u003d67108864\u0027]"},{"line_number":15,"context_line":"    description: ulimit for Nova Compute Container"},{"line_number":16,"context_line":"    type: comma_delimited_list"},{"line_number":17,"context_line":"  NovaComputeLoggingSource:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fb8cfa7_18e14c2b","line":14,"updated":"2019-06-20 22:51:22.000000000","message":"This probably needs a release note.\n\nbut I want to check the direction before I wrote that\n\nwithout this the default is 16KiB, this bumps it to 64MiB, which is a big jump but not terrible with the size of today\u0027s systems","commit_id":"4bff167f9b0c4685d3c690203ad5845f69dd3990"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"986f208f559474942e1de451cdb98cd803dd8f90","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    description: The container image to use for the nova_libvirt config_volume"},{"line_number":12,"context_line":"    type: string"},{"line_number":13,"context_line":"  DockerNovaComputeUlimit:"},{"line_number":14,"context_line":"    default: [\u0027nofile\u003d131072\u0027, \u0027memlock\u003d67108864\u0027]"},{"line_number":15,"context_line":"    description: ulimit for Nova Compute Container"},{"line_number":16,"context_line":"    type: comma_delimited_list"},{"line_number":17,"context_line":"  NovaComputeLoggingSource:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7faddb67_10aba9d6","line":14,"range":{"start_line":14,"start_character":40,"end_line":14,"end_character":48},"updated":"2019-07-04 04:08:17.000000000","message":"shouldn\u0027t this be 65536 as in commit message u mentioned u want to set to 64Mib? as i can see 16Mib(max locked memory       (kbytes, -l) 16384) is the default, can u cross check again.\n\nhttps://www.manpagez.com/man/1/ulimit/","commit_id":"6ce5989e49eb64cdf1bc13b8a27cdb0674ee0e23"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"86143ed2e55b64d01a5187735c782bb3dc413692","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    description: The container image to use for the nova_libvirt config_volume"},{"line_number":12,"context_line":"    type: string"},{"line_number":13,"context_line":"  DockerNovaComputeUlimit:"},{"line_number":14,"context_line":"    default: [\u0027nofile\u003d131072\u0027, \u0027memlock\u003d67108864\u0027]"},{"line_number":15,"context_line":"    description: ulimit for Nova Compute Container"},{"line_number":16,"context_line":"    type: comma_delimited_list"},{"line_number":17,"context_line":"  NovaComputeLoggingSource:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7faddb67_2621cba0","line":14,"range":{"start_line":14,"start_character":40,"end_line":14,"end_character":48},"in_reply_to":"7faddb67_10aba9d6","updated":"2019-07-04 07:07:57.000000000","message":"so i checked this when i first looked and to be clear that is in bytes, i hope ;) cos then its 67108864/1024/1024 \u003d\u003d 64 MB\n\nbut indeed ulimit -a on a box i have expresses it in kbytes.\n\n@tony can you confirm you need to pass bytes here? \n\n[EDIT]: hmm looks like it might be KB at least hound [1] gave up that\n https://opendev.org/openstack/tripleo-heat-templates/src/branch/master/releasenotes/notes/nova_compute_nofile-0427e49cc8ae70a6.yaml\n https://opendev.org/openstack/tripleo-heat-templates/src/branch/master/releasenotes/notes/add_params_to_configure_ulimit-2359aa058da58054.yaml \n\n[1] http://codesearch.openstack.org/?q\u003dDockerNovaComputeUlimit","commit_id":"6ce5989e49eb64cdf1bc13b8a27cdb0674ee0e23"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"aa4336006e4cd5caf9fb805cc859ed147ed4bc3b","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    description: The container image to use for the nova_libvirt config_volume"},{"line_number":12,"context_line":"    type: string"},{"line_number":13,"context_line":"  DockerNovaComputeUlimit:"},{"line_number":14,"context_line":"    default: [\u0027nofile\u003d131072\u0027, \u0027memlock\u003d67108864\u0027]"},{"line_number":15,"context_line":"    description: ulimit for Nova Compute Container"},{"line_number":16,"context_line":"    type: comma_delimited_list"},{"line_number":17,"context_line":"  NovaComputeLoggingSource:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7faddb67_74d751c1","line":14,"range":{"start_line":14,"start_character":40,"end_line":14,"end_character":48},"in_reply_to":"7faddb67_2621cba0","updated":"2019-07-05 22:37:57.000000000","message":"The units shown in the shell via ulimit -a are made human readable.  The values we pass here are bytes as that\u0027s what\u0027s used by the CRI (docker/podman) sadly neither actually has any docs and I can\u0027t find the appropriate code while on my phone :(","commit_id":"6ce5989e49eb64cdf1bc13b8a27cdb0674ee0e23"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"8527097f8c1a823cfcc81c54b51e3a51338766ef","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    description: The container image to use for the nova_libvirt config_volume"},{"line_number":12,"context_line":"    type: string"},{"line_number":13,"context_line":"  DockerNovaComputeUlimit:"},{"line_number":14,"context_line":"    default: [\u0027nofile\u003d131072\u0027, \u0027memlock\u003d67108864\u0027]"},{"line_number":15,"context_line":"    description: ulimit for Nova Compute Container"},{"line_number":16,"context_line":"    type: comma_delimited_list"},{"line_number":17,"context_line":"  NovaComputeLoggingSource:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7faddb67_1ed15355","line":14,"range":{"start_line":14,"start_character":40,"end_line":14,"end_character":48},"in_reply_to":"7faddb67_74d751c1","updated":"2019-07-08 07:28:12.000000000","message":"@Thanks tony for confirming. I rechecked by creating a container and it reflects that podman/docker assumes number passed is bytes.\n\nJFI, in my TripleO setup default was 64 KB instead of 64 Mb in both undercloud/overcloud.","commit_id":"6ce5989e49eb64cdf1bc13b8a27cdb0674ee0e23"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"99f732fa762ab13a1d503dcb86ebbf0fed6e56ae","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    description: The container image to use for the nova_libvirt config_volume"},{"line_number":12,"context_line":"    type: string"},{"line_number":13,"context_line":"  DockerNovaComputeUlimit:"},{"line_number":14,"context_line":"    default: [\u0027nofile\u003d131072\u0027, \u0027memlock\u003d67108864\u0027]"},{"line_number":15,"context_line":"    description: ulimit for Nova Compute Container"},{"line_number":16,"context_line":"    type: comma_delimited_list"},{"line_number":17,"context_line":"  NovaComputeLoggingSource:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7faddb67_3b1461a0","line":14,"range":{"start_line":14,"start_character":40,"end_line":14,"end_character":48},"in_reply_to":"7faddb67_74d751c1","updated":"2019-07-08 06:41:36.000000000","message":"ack thanks will revote","commit_id":"6ce5989e49eb64cdf1bc13b8a27cdb0674ee0e23"}],"releasenotes/notes/nova-memlock-increase-066ed22764ed3ce1.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"62667859209aeb281b8cf7729aebee748b3b9796","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Certain nova containers require more locked memory that the default limit of 16KiB."},{"line_number":5,"context_line":"    Increase the default memlock to 64MiB via ``DockerNovaComputeUlimit``."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    As this is only a maximum limit and not a pre-allocatiosn this will not"},{"line_number":8,"context_line":"    increase the memory requirements for all nova containers.  To date the only"},{"line_number":9,"context_line":"    container to require this is nova_cell_v2_discover_hosts which is short lived. "}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9fb8cfa7_9f16bea7","line":7,"range":{"start_line":7,"start_character":59,"end_line":7,"end_character":61},"updated":"2019-07-03 06:51:30.000000000","message":"s","commit_id":"9f4a487d5d25b57c35b70eed565a4549bf0c91d4"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"62667859209aeb281b8cf7729aebee748b3b9796","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    As this is only a maximum limit and not a pre-allocatiosn this will not"},{"line_number":8,"context_line":"    increase the memory requirements for all nova containers.  To date the only"},{"line_number":9,"context_line":"    container to require this is nova_cell_v2_discover_hosts which is short lived. "}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9fb8cfa7_bf45c2b6","line":9,"updated":"2019-07-03 06:51:30.000000000","message":"whitespace","commit_id":"9f4a487d5d25b57c35b70eed565a4549bf0c91d4"}]}