)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"ecec22e90e6d39fc614184a09fe3fbcb01c2acdf","unresolved":false,"context_lines":[{"line_number":14,"context_line":"parameters needed to deploy the ceph-dashboard via"},{"line_number":15,"context_line":"ceph-ansible related roles."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Depends-On: https://review.opendev.org/669212"},{"line_number":18,"context_line":"Implements: blueprint ceph-dashboard"},{"line_number":19,"context_line":"Change-Id: I1d31cd99823686986cdbd3ac1df184e9457a361e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":26,"id":"7faddb67_399eb763","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":45},"updated":"2019-07-05 17:17:27.000000000","message":"Please change this to:\n\nDepends-On: I56d103f3b3696393b0a630446e8b55fd18a0164e\n\nBecause of:\n\nhttp://lists.openstack.org/pipermail/openstack-dev/2018-February/127516.html","commit_id":"0e46c864dfa938c60e1d7381a25443a17061b949"}],"ci/environments/scenario001-standalone.yaml":[{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"c98ebb929c83c9c5b3d3631167b5decd7d2163fc","unresolved":false,"context_lines":[{"line_number":88,"context_line":"  CephAdminKey: \u0027AQDLOh1VgEp6FRAAFzT7Zw+Y9V6JJExQAsRnRQ\u003d\u003d\u0027"},{"line_number":89,"context_line":"  CephClientKey: \u0027AQC+vYNXgDAgAhAAc8UoYt+OTz5uhV7ItLdwUw\u003d\u003d\u0027"},{"line_number":90,"context_line":"  CephAnsiblePlaybookVerbosity: 1"},{"line_number":91,"context_line":"  EnableCephDashboard: true"},{"line_number":92,"context_line":"  CephAnsibleEnvironmentVariables:"},{"line_number":93,"context_line":"    ANSIBLE_SSH_RETRIES: \u00274\u0027"},{"line_number":94,"context_line":"    DEFAULT_FORKS: \u00273\u0027"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"7faddb67_35601a33","line":91,"updated":"2019-07-03 22:22:42.000000000","message":"thanks, let\u0027s see how 001 standalone works with dashboard.","commit_id":"09e1f2a3dde8e085123b4cb6218edc178757ef98"}],"deployment/ceph-ansible/ceph-base.yaml":[{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"f624ef3748151db9ad8a3af318a1e53ed731dfbd","unresolved":false,"context_lines":[{"line_number":231,"context_line":"            expression: $.data.rightSplit(\u0027:\u0027, 1)[1]"},{"line_number":232,"context_line":"            data: {get_param: DockerCephDaemonImage}"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"  CephBaseAnsibleVars:"},{"line_number":235,"context_line":"    type: OS::Heat::Value"},{"line_number":236,"context_line":"    properties:"},{"line_number":237,"context_line":"      type: json"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9fb8cfa7_aa6446e6","line":234,"updated":"2019-06-21 20:19:08.000000000","message":"Maybe we can replace the lineinfile in ceph-dashboard.yaml and just have a line like this here?\n\ndashboard_enabled: {get_param: DashboardEnable}","commit_id":"1a347e617d282868ded0b88bab0a9d9844f10e4a"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"a73e4fdb41e91b866045ebea124719e7a2fa739f","unresolved":false,"context_lines":[{"line_number":377,"context_line":"            - {get_param: CephIPv6}"},{"line_number":378,"context_line":"            - ipv6"},{"line_number":379,"context_line":"            - ipv4"},{"line_number":380,"context_line":"          dashboard_enabled: {get_param: DashboardEnable}"},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"outputs:"},{"line_number":383,"context_line":"  role_data:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9fb8cfa7_d7626c3e","line":380,"updated":"2019-06-24 17:12:47.000000000","message":"I think this shouldn\u0027t be needed?","commit_id":"2e0f310ddf638261f367a23d922dadc528df52e2"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"a4aefa169f5ca75200f361e345308cad7cb1d5be","unresolved":false,"context_lines":[{"line_number":377,"context_line":"            - {get_param: CephIPv6}"},{"line_number":378,"context_line":"            - ipv6"},{"line_number":379,"context_line":"            - ipv4"},{"line_number":380,"context_line":"          dashboard_enabled: {get_param: DashboardEnable}"},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"outputs:"},{"line_number":383,"context_line":"  role_data:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9fb8cfa7_3a8c0dd6","line":380,"in_reply_to":"9fb8cfa7_d7626c3e","updated":"2019-06-24 18:10:00.000000000","message":"Hi Giulio,\n\nI want to share the background on where it came from. \n\nOriginally we wanted to get dashboard_enabled into ceph-ansible/group_vars/all.yml without doing a file update [1] but instead adding it to CephBaseAnsibleVars. The parameter defaults to false unless we deploy with -e \tenvironments/ceph-ansible/ceph-dashboard.yaml which then causes it to get passed as true [2].\n\nAre you saying that dashboard_enabled shouldn\u0027t be in ansible/group_vars/all.yml or that we should get it into that file a different way?\n\n\n[1] https://review.opendev.org/#/c/666578/4/deployment/ceph-ansible/ceph-dashboard.yaml@168\n\n[2] https://review.opendev.org/#/c/666578/6/deployment/ceph-ansible/ceph-dashboard.yaml@107","commit_id":"2e0f310ddf638261f367a23d922dadc528df52e2"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"d51f144057f5bccc230c47f5a0a5f39502798574","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    description: CLI tool used to manage containers."},{"line_number":54,"context_line":"    constraints:"},{"line_number":55,"context_line":"      - allowed_values: [\u0027docker\u0027, \u0027podman\u0027]"},{"line_number":56,"context_line":"  DashboardEnable:"},{"line_number":57,"context_line":"    type: boolean"},{"line_number":58,"context_line":"    default: false"},{"line_number":59,"context_line":"    description: Parameter used to trigger the dashboard deployment."}],"source_content_type":"text/x-yaml","patch_set":27,"id":"7faddb67_a62a428d","line":56,"updated":"2019-07-10 17:42:04.000000000","message":"I don\u0027t understand why there are separate DashboardEnable and EnableCephDashboard parameters. The logic in ceph-mgr.yaml could be eliminated, as it only serves to make the two parameter values equal.\n\nAlso, as I\u0027ll note in ceph-mgr.yaml, I think CephEnableDashboard helps maintain the CephXXX THT parameter namespace convention.","commit_id":"9abe89c4321454c54f2c121969310f5f03c998dd"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"14403953d3e6303ded006a45dd66b2219fa280a3","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    description: CLI tool used to manage containers."},{"line_number":54,"context_line":"    constraints:"},{"line_number":55,"context_line":"      - allowed_values: [\u0027docker\u0027, \u0027podman\u0027]"},{"line_number":56,"context_line":"  DashboardEnable:"},{"line_number":57,"context_line":"    type: boolean"},{"line_number":58,"context_line":"    default: false"},{"line_number":59,"context_line":"    description: Parameter used to trigger the dashboard deployment."}],"source_content_type":"text/x-yaml","patch_set":27,"id":"7faddb67_2cf04cfe","line":56,"in_reply_to":"7faddb67_a62a428d","updated":"2019-07-12 14:30:41.000000000","message":"Good catch, I\u0027m testing the scenario removing from ceph-mgr.yaml this parameter (and moving to the right naming convention)","commit_id":"9abe89c4321454c54f2c121969310f5f03c998dd"}],"deployment/ceph-ansible/ceph-dashboard.yaml":[{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"9579dd52f2ceae48eb46aad4d8d26b27ead6f681","unresolved":false,"context_lines":[{"line_number":164,"context_line":"                  - { file: \u0027dashboard\u0027, var: \u0027{{ ceph_ansible_group_vars_dashboard }}\u0027 }"},{"line_number":165,"context_line":"                  - { file: \u0027grafanas\u0027, var: \u0027{{ ceph_ansible_group_vars_grafana }}\u0027 }"},{"line_number":166,"context_line":"                  - { file: \u0027prometheus\u0027, var: \u0027{{ ceph_ansible_group_vars_prometheus }}\u0027 }"},{"line_number":167,"context_line":"              - name: set the enable boolean to the global vars"},{"line_number":168,"context_line":"                lineinfile:"},{"line_number":169,"context_line":"                  path: \"{{playbook_dir}}/ceph-ansible/group_vars/all.yml\""},{"line_number":170,"context_line":"                  line: \"dashboard_enabled: true\""},{"line_number":171,"context_line":"                  insertafter: EOF"},{"line_number":172,"context_line":"      external_update_tasks: {get_attr: [CephBase, role_data, external_update_tasks]}"},{"line_number":173,"context_line":"      external_upgrade_tasks: {get_attr: [CephBase, role_data, external_upgrade_tasks]}"},{"line_number":174,"context_line":"      config_settings:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9fb8cfa7_cfeaf6d6","line":171,"range":{"start_line":167,"start_character":14,"end_line":171,"end_character":34},"updated":"2019-06-21 08:25:56.000000000","message":"I\u0027m not sure these lines need to stay here or it\u0027s better to handle this section in ceph-base.yaml.\n\nBasically from ceph-ansible point of view we have many roles that need to be executed to deploy the dashboard; each role, of course, has its own parameters, so here we have two sets of variables:\n1. \"dashboard_enabled: true\", needed in group_vars/all.yml; it triggers the execution of the dashboard deployment playbooks (in site-container.yaml.sample), so it\u0027s a global variable we need to set when the \" -e /usr/share/openstack-tripleo-heat-templates/environments/ceph-ansible/ceph-dashboard.yaml\" is added;\n\n2. grafana, prometheus+alertmanager, dashboard (mgr role): we have 3 roles involved here and we need to set these variables according to the playbook role they belong to","commit_id":"71eaa929a3df009e8c5031053319f8e567323de4"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"f5b4eef935008fea466a0b4f5d9d166f3030bdcc","unresolved":false,"context_lines":[{"line_number":164,"context_line":"                  - { file: \u0027dashboard\u0027, var: \u0027{{ ceph_ansible_group_vars_dashboard }}\u0027 }"},{"line_number":165,"context_line":"                  - { file: \u0027grafanas\u0027, var: \u0027{{ ceph_ansible_group_vars_grafana }}\u0027 }"},{"line_number":166,"context_line":"                  - { file: \u0027prometheus\u0027, var: \u0027{{ ceph_ansible_group_vars_prometheus }}\u0027 }"},{"line_number":167,"context_line":"              - name: set the enable boolean to the global vars"},{"line_number":168,"context_line":"                lineinfile:"},{"line_number":169,"context_line":"                  path: \"{{playbook_dir}}/ceph-ansible/group_vars/all.yml\""},{"line_number":170,"context_line":"                  line: \"dashboard_enabled: true\""},{"line_number":171,"context_line":"                  insertafter: EOF"},{"line_number":172,"context_line":"      external_update_tasks: {get_attr: [CephBase, role_data, external_update_tasks]}"},{"line_number":173,"context_line":"      external_upgrade_tasks: {get_attr: [CephBase, role_data, external_upgrade_tasks]}"},{"line_number":174,"context_line":"      config_settings:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9fb8cfa7_fa8211c8","line":171,"range":{"start_line":167,"start_character":14,"end_line":171,"end_character":34},"in_reply_to":"9fb8cfa7_cfeaf6d6","updated":"2019-06-21 15:27:07.000000000","message":"We know all.yml will exist because on line 94 we include the resource to create it so it should be safe. It would be safer if we had a way to get it into the map before we wrote it to the file though. Perhaps add it as a new property on line 103 and default it to false in your update to ceph-base.yaml but then hard code the pass of true to it on line 103 in this file. It\u0027s worth a shot. \n\nIt\u0027s on the border of nit picky, but seems a little safer.","commit_id":"71eaa929a3df009e8c5031053319f8e567323de4"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"fa30b3cdc9c580c7f77bb563f7672f6975473a49","unresolved":false,"context_lines":[{"line_number":164,"context_line":"                  - { file: \u0027dashboard\u0027, var: \u0027{{ ceph_ansible_group_vars_dashboard }}\u0027 }"},{"line_number":165,"context_line":"                  - { file: \u0027grafanas\u0027, var: \u0027{{ ceph_ansible_group_vars_grafana }}\u0027 }"},{"line_number":166,"context_line":"                  - { file: \u0027prometheus\u0027, var: \u0027{{ ceph_ansible_group_vars_prometheus }}\u0027 }"},{"line_number":167,"context_line":"              - name: set the enable boolean to the global vars"},{"line_number":168,"context_line":"                lineinfile:"},{"line_number":169,"context_line":"                  path: \"{{playbook_dir}}/ceph-ansible/group_vars/all.yml\""},{"line_number":170,"context_line":"                  line: \"dashboard_enabled: true\""},{"line_number":171,"context_line":"                  insertafter: EOF"},{"line_number":172,"context_line":"      external_update_tasks: {get_attr: [CephBase, role_data, external_update_tasks]}"},{"line_number":173,"context_line":"      external_upgrade_tasks: {get_attr: [CephBase, role_data, external_upgrade_tasks]}"},{"line_number":174,"context_line":"      config_settings:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9fb8cfa7_b4d58db9","line":171,"range":{"start_line":167,"start_character":14,"end_line":171,"end_character":34},"in_reply_to":"9fb8cfa7_fa8211c8","updated":"2019-06-21 18:37:40.000000000","message":"Agree with you, having a resource that exists in the map is safer than the string injected in the global variables.\nI\u0027ll try to reflect this in the next patchset.","commit_id":"71eaa929a3df009e8c5031053319f8e567323de4"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"f624ef3748151db9ad8a3af318a1e53ed731dfbd","unresolved":false,"context_lines":[{"line_number":104,"context_line":"      EndpointMap: {get_param: EndpointMap}"},{"line_number":105,"context_line":"      RoleName: {get_param: RoleName}"},{"line_number":106,"context_line":"      RoleParameters: {get_param: RoleParameters}"},{"line_number":107,"context_line":"      DashboardEnable: true"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"  CephGlobalAnsibleVars:"},{"line_number":110,"context_line":"    type: OS::Heat::Value"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9fb8cfa7_77a63756","line":107,"updated":"2019-06-21 20:19:08.000000000","message":"I see","commit_id":"1a347e617d282868ded0b88bab0a9d9844f10e4a"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"40cc9d714080fa8ae77ad1cc034875921d1a2f47","unresolved":false,"context_lines":[{"line_number":176,"context_line":"                  - { file: \u0027dashboard\u0027, var: \u0027{{ ceph_ansible_group_vars_dashboard }}\u0027 }"},{"line_number":177,"context_line":"                  - { file: \u0027grafanas\u0027, var: \u0027{{ ceph_ansible_group_vars_grafana }}\u0027 }"},{"line_number":178,"context_line":"                  - { file: \u0027prometheus\u0027, var: \u0027{{ ceph_ansible_group_vars_prometheus }}\u0027 }"},{"line_number":179,"context_line":"              - name: set the dashboard_enabled boolean as ceph-ansible global var"},{"line_number":180,"context_line":"                lineinfile:"},{"line_number":181,"context_line":"                  path: \"{{playbook_dir}}/ceph-ansible/group_vars/all.yml\""},{"line_number":182,"context_line":"                  line: \"{{ceph_ansible_group_vars_all|to_nice_yaml}}\""},{"line_number":183,"context_line":"                  insertafter: EOF"},{"line_number":184,"context_line":"      external_update_tasks: {get_attr: [CephBase, role_data, external_update_tasks]}"},{"line_number":185,"context_line":"      external_upgrade_tasks: {get_attr: [CephBase, role_data, external_upgrade_tasks]}"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9fb8cfa7_caa41a0b","line":182,"range":{"start_line":179,"start_character":0,"end_line":182,"end_character":70},"updated":"2019-06-21 20:20:51.000000000","message":"Want to see if you can remove this and merge it into CephBaseAnsibleVars in ceph-base.yaml instead? Merging data structures should be safer than file overwrites. Thks","commit_id":"1a347e617d282868ded0b88bab0a9d9844f10e4a"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"a73e4fdb41e91b866045ebea124719e7a2fa739f","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    description: Mapping of service endpoint -\u003e protocol. Typically set"},{"line_number":31,"context_line":"                 via parameter_defaults in the resource registry."},{"line_number":32,"context_line":"    type: json"},{"line_number":33,"context_line":"  DashboardEnable:"},{"line_number":34,"context_line":"    type: boolean"},{"line_number":35,"context_line":"    default: false"},{"line_number":36,"context_line":"    description: Parameter used to trigger the dashboard deployment."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9fb8cfa7_7753806c","line":33,"updated":"2019-06-24 17:12:47.000000000","message":"I think can be removed","commit_id":"2e0f310ddf638261f367a23d922dadc528df52e2"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"a4aefa169f5ca75200f361e345308cad7cb1d5be","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    description: Mapping of service endpoint -\u003e protocol. Typically set"},{"line_number":31,"context_line":"                 via parameter_defaults in the resource registry."},{"line_number":32,"context_line":"    type: json"},{"line_number":33,"context_line":"  DashboardEnable:"},{"line_number":34,"context_line":"    type: boolean"},{"line_number":35,"context_line":"    default: false"},{"line_number":36,"context_line":"    description: Parameter used to trigger the dashboard deployment."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9fb8cfa7_7a74c5cf","line":33,"in_reply_to":"9fb8cfa7_7753806c","updated":"2019-06-24 18:10:00.000000000","message":"+1 if it\u0027s going to be in ceph-base.yaml instead","commit_id":"2e0f310ddf638261f367a23d922dadc528df52e2"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"3f98f379268e5706b196e2fdbf63427d11ffe96b","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    description: Mapping of service endpoint -\u003e protocol. Typically set"},{"line_number":31,"context_line":"                 via parameter_defaults in the resource registry."},{"line_number":32,"context_line":"    type: json"},{"line_number":33,"context_line":"  DashboardEnable:"},{"line_number":34,"context_line":"    type: boolean"},{"line_number":35,"context_line":"    default: false"},{"line_number":36,"context_line":"    description: Parameter used to trigger the dashboard deployment."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9fb8cfa7_99af3e29","line":33,"in_reply_to":"9fb8cfa7_7a74c5cf","updated":"2019-06-25 07:35:08.000000000","message":"Agree, as we have this parameter in ceph-base I think we can remove this. We also know that since this template is added this parameter should be true by default, so yes, fully agree to remove it.","commit_id":"2e0f310ddf638261f367a23d922dadc528df52e2"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"a73e4fdb41e91b866045ebea124719e7a2fa739f","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    description: Admin password for the dashboard service"},{"line_number":44,"context_line":"    type: string"},{"line_number":45,"context_line":"    hidden: true"},{"line_number":46,"context_line":"  DashboardCrt:"},{"line_number":47,"context_line":"    default: \u0027\u0027"},{"line_number":48,"context_line":"    description: Dashboard SSL Certificate"},{"line_number":49,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9fb8cfa7_f7cc5036","line":46,"updated":"2019-06-24 17:12:47.000000000","message":"maybe we should reuse the httpd certificates for this?","commit_id":"2e0f310ddf638261f367a23d922dadc528df52e2"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"3f98f379268e5706b196e2fdbf63427d11ffe96b","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    description: Admin password for the dashboard service"},{"line_number":44,"context_line":"    type: string"},{"line_number":45,"context_line":"    hidden: true"},{"line_number":46,"context_line":"  DashboardCrt:"},{"line_number":47,"context_line":"    default: \u0027\u0027"},{"line_number":48,"context_line":"    description: Dashboard SSL Certificate"},{"line_number":49,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9fb8cfa7_b969e2f8","line":46,"in_reply_to":"9fb8cfa7_1a7d89b1","updated":"2019-06-25 07:35:08.000000000","message":"We can default with the httpd certificates: with this new design we expose grafana to the end users, so I think we can default the httpd certs for grafana-server as well","commit_id":"2e0f310ddf638261f367a23d922dadc528df52e2"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"a4aefa169f5ca75200f361e345308cad7cb1d5be","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    description: Admin password for the dashboard service"},{"line_number":44,"context_line":"    type: string"},{"line_number":45,"context_line":"    hidden: true"},{"line_number":46,"context_line":"  DashboardCrt:"},{"line_number":47,"context_line":"    default: \u0027\u0027"},{"line_number":48,"context_line":"    description: Dashboard SSL Certificate"},{"line_number":49,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9fb8cfa7_1a7d89b1","line":46,"in_reply_to":"9fb8cfa7_f7cc5036","updated":"2019-06-24 18:10:00.000000000","message":"or default to using the existing httpd certs?","commit_id":"2e0f310ddf638261f367a23d922dadc528df52e2"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"a73e4fdb41e91b866045ebea124719e7a2fa739f","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    default: \u0027\u0027"},{"line_number":52,"context_line":"    description: Dashboard SSL Certificate Key"},{"line_number":53,"context_line":"    type: string"},{"line_number":54,"context_line":"  DashboardRgwApiHost:"},{"line_number":55,"context_line":"    default: \u0027\u0027"},{"line_number":56,"context_line":"    description: Dashboard API host"},{"line_number":57,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9fb8cfa7_17e1e49b","line":54,"updated":"2019-06-24 17:12:47.000000000","message":"is this supposed to be the RGW endpoint?","commit_id":"2e0f310ddf638261f367a23d922dadc528df52e2"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"3f98f379268e5706b196e2fdbf63427d11ffe96b","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    default: \u0027\u0027"},{"line_number":52,"context_line":"    description: Dashboard SSL Certificate Key"},{"line_number":53,"context_line":"    type: string"},{"line_number":54,"context_line":"  DashboardRgwApiHost:"},{"line_number":55,"context_line":"    default: \u0027\u0027"},{"line_number":56,"context_line":"    description: Dashboard API host"},{"line_number":57,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9fb8cfa7_3956522c","line":54,"in_reply_to":"9fb8cfa7_17e1e49b","updated":"2019-06-25 07:35:08.000000000","message":"yes","commit_id":"2e0f310ddf638261f367a23d922dadc528df52e2"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"a73e4fdb41e91b866045ebea124719e7a2fa739f","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    description: \u003e"},{"line_number":83,"context_line":"      List of plugins to enable on the grafana container"},{"line_number":84,"context_line":"  GrafanaContainerImage:"},{"line_number":85,"context_line":"    default: \u0027grafana/grafana:latest\u0027"},{"line_number":86,"context_line":"    description: Grafana container image"},{"line_number":87,"context_line":"    type: string"},{"line_number":88,"context_line":"  PrometheusContainerImage:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9fb8cfa7_f7c3f0eb","line":85,"updated":"2019-06-24 17:12:47.000000000","message":"not sure which images we should pick for these","commit_id":"2e0f310ddf638261f367a23d922dadc528df52e2"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"a4aefa169f5ca75200f361e345308cad7cb1d5be","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    description: \u003e"},{"line_number":83,"context_line":"      List of plugins to enable on the grafana container"},{"line_number":84,"context_line":"  GrafanaContainerImage:"},{"line_number":85,"context_line":"    default: \u0027grafana/grafana:latest\u0027"},{"line_number":86,"context_line":"    description: Grafana container image"},{"line_number":87,"context_line":"    type: string"},{"line_number":88,"context_line":"  PrometheusContainerImage:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9fb8cfa7_9d05f312","line":85,"in_reply_to":"9fb8cfa7_f7c3f0eb","updated":"2019-06-24 18:10:00.000000000","message":"I think we\u0027ll need to hook these images into the existing workflow for container image management. Maybe this change will need a depends-on to a review to tripleo-common which might need a depends-on to python-tripleoclient.\n\nhttps://docs.openstack.org/tripleo-docs/latest/install/advanced_deployment/container_image_prepare.html","commit_id":"2e0f310ddf638261f367a23d922dadc528df52e2"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"a73e4fdb41e91b866045ebea124719e7a2fa739f","unresolved":false,"context_lines":[{"line_number":104,"context_line":"      EndpointMap: {get_param: EndpointMap}"},{"line_number":105,"context_line":"      RoleName: {get_param: RoleName}"},{"line_number":106,"context_line":"      RoleParameters: {get_param: RoleParameters}"},{"line_number":107,"context_line":"      DashboardEnable: true"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"  CephDashboardAnsibleVars:"},{"line_number":110,"context_line":"    type: OS::Heat::Value"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9fb8cfa7_f79a1012","line":107,"updated":"2019-06-24 17:12:47.000000000","message":"I think can be removed as well","commit_id":"2e0f310ddf638261f367a23d922dadc528df52e2"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"a4aefa169f5ca75200f361e345308cad7cb1d5be","unresolved":false,"context_lines":[{"line_number":104,"context_line":"      EndpointMap: {get_param: EndpointMap}"},{"line_number":105,"context_line":"      RoleName: {get_param: RoleName}"},{"line_number":106,"context_line":"      RoleParameters: {get_param: RoleParameters}"},{"line_number":107,"context_line":"      DashboardEnable: true"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"  CephDashboardAnsibleVars:"},{"line_number":110,"context_line":"    type: OS::Heat::Value"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9fb8cfa7_fa519537","line":107,"in_reply_to":"9fb8cfa7_f79a1012","updated":"2019-06-24 18:10:00.000000000","message":"I have a comment on this in ceph-base.yaml. Perhaps we can figure it out under the discussion there?","commit_id":"2e0f310ddf638261f367a23d922dadc528df52e2"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"3f98f379268e5706b196e2fdbf63427d11ffe96b","unresolved":false,"context_lines":[{"line_number":104,"context_line":"      EndpointMap: {get_param: EndpointMap}"},{"line_number":105,"context_line":"      RoleName: {get_param: RoleName}"},{"line_number":106,"context_line":"      RoleParameters: {get_param: RoleParameters}"},{"line_number":107,"context_line":"      DashboardEnable: true"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"  CephDashboardAnsibleVars:"},{"line_number":110,"context_line":"    type: OS::Heat::Value"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9fb8cfa7_79604a02","line":107,"in_reply_to":"9fb8cfa7_fa519537","updated":"2019-06-25 07:35:08.000000000","message":"This is something we cannot remove here because we need to set to True this value (on all.yaml, file that is built on ceph-base), only if this template is added. That value from a pure ceph-ansible point of view will trigger the execution of the roles (three roles) involved in the dashboard deployment.","commit_id":"2e0f310ddf638261f367a23d922dadc528df52e2"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"a73e4fdb41e91b866045ebea124719e7a2fa739f","unresolved":false,"context_lines":[{"line_number":166,"context_line":"                  content: \"{{item.var|to_nice_yaml}}\""},{"line_number":167,"context_line":"                with_items:"},{"line_number":168,"context_line":"                  - { file: \u0027dashboard\u0027, var: \u0027{{ ceph_ansible_group_vars_dashboard }}\u0027 }"},{"line_number":169,"context_line":"                  - { file: \u0027grafanas\u0027, var: \u0027{{ ceph_ansible_group_vars_grafana }}\u0027 }"},{"line_number":170,"context_line":"                  - { file: \u0027prometheus\u0027, var: \u0027{{ ceph_ansible_group_vars_prometheus }}\u0027 }"},{"line_number":171,"context_line":"      external_update_tasks: {get_attr: [CephBase, role_data, external_update_tasks]}"},{"line_number":172,"context_line":"      external_upgrade_tasks: {get_attr: [CephBase, role_data, external_upgrade_tasks]}"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9fb8cfa7_da285187","line":169,"updated":"2019-06-24 17:12:47.000000000","message":"should this be grafana?","commit_id":"2e0f310ddf638261f367a23d922dadc528df52e2"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"856f88bf033a339f37bf307342faf352d622568b","unresolved":false,"context_lines":[{"line_number":166,"context_line":"                  content: \"{{item.var|to_nice_yaml}}\""},{"line_number":167,"context_line":"                with_items:"},{"line_number":168,"context_line":"                  - { file: \u0027dashboard\u0027, var: \u0027{{ ceph_ansible_group_vars_dashboard }}\u0027 }"},{"line_number":169,"context_line":"                  - { file: \u0027grafanas\u0027, var: \u0027{{ ceph_ansible_group_vars_grafana }}\u0027 }"},{"line_number":170,"context_line":"                  - { file: \u0027prometheus\u0027, var: \u0027{{ ceph_ansible_group_vars_prometheus }}\u0027 }"},{"line_number":171,"context_line":"      external_update_tasks: {get_attr: [CephBase, role_data, external_update_tasks]}"},{"line_number":172,"context_line":"      external_upgrade_tasks: {get_attr: [CephBase, role_data, external_upgrade_tasks]}"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9fb8cfa7_947e2517","line":169,"in_reply_to":"9fb8cfa7_da285187","updated":"2019-06-25 08:25:00.000000000","message":"actually as per [1] grafanas is correct, dashboard is wrong, but it\u0027s not a real issue anymore because I have a new PatchSet in which I removed all this section.\n\n[1] https://github.com/ceph/ceph-ansible/blob/master/generate_group_vars_sample.sh#L74","commit_id":"2e0f310ddf638261f367a23d922dadc528df52e2"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"6acd338e9fedeb6b13103456c357f23bb24e6faf","unresolved":false,"context_lines":[{"line_number":31,"context_line":"                 via parameter_defaults in the resource registry."},{"line_number":32,"context_line":"    type: json"},{"line_number":33,"context_line":"  DashboardAdminUser:"},{"line_number":34,"context_line":"    default: \u0027\u0027"},{"line_number":35,"context_line":"    description: Admin user for the dashboard service"},{"line_number":36,"context_line":"    type: string"},{"line_number":37,"context_line":"  DashboardAdminPassword:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9fb8cfa7_caa156f9","line":34,"updated":"2019-06-25 10:35:05.000000000","message":"maybe this should have a default","commit_id":"b24f3cff6801700b2e1451e1c34cc4e64f790b61"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"33a74d541e91662a891ee65bbc9840b927dfe5a0","unresolved":false,"context_lines":[{"line_number":31,"context_line":"                 via parameter_defaults in the resource registry."},{"line_number":32,"context_line":"    type: json"},{"line_number":33,"context_line":"  DashboardAdminUser:"},{"line_number":34,"context_line":"    default: \u0027\u0027"},{"line_number":35,"context_line":"    description: Admin user for the dashboard service"},{"line_number":36,"context_line":"    type: string"},{"line_number":37,"context_line":"  DashboardAdminPassword:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9fb8cfa7_69b5d731","line":34,"in_reply_to":"9fb8cfa7_caa156f9","updated":"2019-06-25 12:45:46.000000000","message":"+1","commit_id":"b24f3cff6801700b2e1451e1c34cc4e64f790b61"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"6acd338e9fedeb6b13103456c357f23bb24e6faf","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    description: Admin user for the dashboard service"},{"line_number":36,"context_line":"    type: string"},{"line_number":37,"context_line":"  DashboardAdminPassword:"},{"line_number":38,"context_line":"    default: \u0027\u0027"},{"line_number":39,"context_line":"    description: Admin password for the dashboard service"},{"line_number":40,"context_line":"    type: string"},{"line_number":41,"context_line":"    hidden: true"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9fb8cfa7_2aa112f9","line":38,"updated":"2019-06-25 10:35:05.000000000","message":"this should not have a default and we should generate it instead","commit_id":"b24f3cff6801700b2e1451e1c34cc4e64f790b61"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"33a74d541e91662a891ee65bbc9840b927dfe5a0","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    description: Admin user for the dashboard service"},{"line_number":36,"context_line":"    type: string"},{"line_number":37,"context_line":"  DashboardAdminPassword:"},{"line_number":38,"context_line":"    default: \u0027\u0027"},{"line_number":39,"context_line":"    description: Admin password for the dashboard service"},{"line_number":40,"context_line":"    type: string"},{"line_number":41,"context_line":"    hidden: true"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9fb8cfa7_498a536a","line":38,"in_reply_to":"9fb8cfa7_2aa112f9","updated":"2019-06-25 12:45:46.000000000","message":"Good catch: I will generate it using OS:Heat:Random","commit_id":"b24f3cff6801700b2e1451e1c34cc4e64f790b61"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"6acd338e9fedeb6b13103456c357f23bb24e6faf","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    type: string"},{"line_number":41,"context_line":"    hidden: true"},{"line_number":42,"context_line":"  DashboardCrt:"},{"line_number":43,"context_line":"    default: \u0027\u0027"},{"line_number":44,"context_line":"    description: Dashboard SSL Certificate"},{"line_number":45,"context_line":"    type: string"},{"line_number":46,"context_line":"  DashboardKey:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9fb8cfa7_4ab56631","line":43,"updated":"2019-06-25 10:35:05.000000000","message":"we should probably use what gets provisioned on the nodes basing on EnableInternalTLS","commit_id":"b24f3cff6801700b2e1451e1c34cc4e64f790b61"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"33a74d541e91662a891ee65bbc9840b927dfe5a0","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    type: string"},{"line_number":41,"context_line":"    hidden: true"},{"line_number":42,"context_line":"  DashboardCrt:"},{"line_number":43,"context_line":"    default: \u0027\u0027"},{"line_number":44,"context_line":"    description: Dashboard SSL Certificate"},{"line_number":45,"context_line":"    type: string"},{"line_number":46,"context_line":"  DashboardKey:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9fb8cfa7_e9ef871a","line":43,"in_reply_to":"9fb8cfa7_4ab56631","updated":"2019-06-25 12:45:46.000000000","message":"As per [1] and after making a code introspection on ceph-ansible, I think this parameter is strictly related to the dashboard mgr module [2] and it can be moved on the mgr service.\n\n[1] https://github.com/ceph/ceph-ansible/blob/master/site-container.yml.sample#L565\n\n[2] https://github.com/ceph/ceph-ansible/tree/master/roles/ceph-dashboard/tasks","commit_id":"b24f3cff6801700b2e1451e1c34cc4e64f790b61"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"6acd338e9fedeb6b13103456c357f23bb24e6faf","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    description: Dashboard SSL Certificate Key"},{"line_number":49,"context_line":"    type: string"},{"line_number":50,"context_line":"  DashboardRgwApiHost:"},{"line_number":51,"context_line":"    default: \u0027\u0027"},{"line_number":52,"context_line":"    description: Dashboard API host"},{"line_number":53,"context_line":"    type: string"},{"line_number":54,"context_line":"  DashboardRgwApiPort:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9fb8cfa7_6ab2aa4b","line":51,"updated":"2019-06-25 10:35:05.000000000","message":"this is generated via endpoint_map and we should consume that in the template","commit_id":"b24f3cff6801700b2e1451e1c34cc4e64f790b61"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"33a74d541e91662a891ee65bbc9840b927dfe5a0","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    description: Dashboard SSL Certificate Key"},{"line_number":49,"context_line":"    type: string"},{"line_number":50,"context_line":"  DashboardRgwApiHost:"},{"line_number":51,"context_line":"    default: \u0027\u0027"},{"line_number":52,"context_line":"    description: Dashboard API host"},{"line_number":53,"context_line":"    type: string"},{"line_number":54,"context_line":"  DashboardRgwApiPort:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9fb8cfa7_09f53bed","line":51,"in_reply_to":"9fb8cfa7_6ab2aa4b","updated":"2019-06-25 12:45:46.000000000","message":"ditto","commit_id":"b24f3cff6801700b2e1451e1c34cc4e64f790b61"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"6acd338e9fedeb6b13103456c357f23bb24e6faf","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    description: Dashboard API port"},{"line_number":57,"context_line":"    type: string"},{"line_number":58,"context_line":"  GrafanaAdminUser:"},{"line_number":59,"context_line":"    default: \u0027\u0027"},{"line_number":60,"context_line":"    description: Admin user for the grafana component"},{"line_number":61,"context_line":"    type: string"},{"line_number":62,"context_line":"  GrafanaAdminPassword:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9fb8cfa7_0a852e5a","line":59,"updated":"2019-06-25 10:35:05.000000000","message":"IMHO like DashboardAdmin and DashboardPassword","commit_id":"b24f3cff6801700b2e1451e1c34cc4e64f790b61"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"33a74d541e91662a891ee65bbc9840b927dfe5a0","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    description: Dashboard API port"},{"line_number":57,"context_line":"    type: string"},{"line_number":58,"context_line":"  GrafanaAdminUser:"},{"line_number":59,"context_line":"    default: \u0027\u0027"},{"line_number":60,"context_line":"    description: Admin user for the grafana component"},{"line_number":61,"context_line":"    type: string"},{"line_number":62,"context_line":"  GrafanaAdminPassword:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9fb8cfa7_c9dac376","line":59,"in_reply_to":"9fb8cfa7_0a852e5a","updated":"2019-06-25 12:45:46.000000000","message":"+1 on having a default and a password random generation","commit_id":"b24f3cff6801700b2e1451e1c34cc4e64f790b61"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"e5ccfb8a99c483e24cc45e740b2f5deec8b2dd9b","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    default: \u0027admin\u0027"},{"line_number":35,"context_line":"    description: Admin user for the grafana component"},{"line_number":36,"context_line":"    type: string"},{"line_number":37,"context_line":"  GrafanaCrt:"},{"line_number":38,"context_line":"    default: \u0027\u0027"},{"line_number":39,"context_line":"    description: Dashboard SSL Certificate"},{"line_number":40,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9fb8cfa7_9de72113","line":37,"updated":"2019-06-25 16:37:31.000000000","message":"these should be removed and automatically set by the templates basing on EnableInternalTLS, not provided by the user","commit_id":"16659853d19b9d21e2dd9d4f08e6092ce3ca8202"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"e5ccfb8a99c483e24cc45e740b2f5deec8b2dd9b","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    description: \u003e"},{"line_number":49,"context_line":"      List of plugins to enable on the grafana container"},{"line_number":50,"context_line":"  GrafanaContainerImage:"},{"line_number":51,"context_line":"    default: \u0027grafana/grafana:latest\u0027"},{"line_number":52,"context_line":"    description: Grafana container image"},{"line_number":53,"context_line":"    type: string"},{"line_number":54,"context_line":"  GrafanaDashboardsPath:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9fb8cfa7_3dc2b55a","line":51,"updated":"2019-06-25 16:37:31.000000000","message":"*ContainerImage parameters should not have a default and be set via tripleo-common, via [1]\n\n1. https://github.com/openstack/tripleo-common/blob/master/container-images/overcloud_containers.yaml.j2","commit_id":"16659853d19b9d21e2dd9d4f08e6092ce3ca8202"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"1d186fd396f86d8a637379007268c9863db8b0c6","unresolved":false,"context_lines":[{"line_number":78,"context_line":"      EndpointMap: {get_param: EndpointMap}"},{"line_number":79,"context_line":"      RoleName: {get_param: RoleName}"},{"line_number":80,"context_line":"      RoleParameters: {get_param: RoleParameters}"},{"line_number":81,"context_line":"      DashboardEnable: true"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"  GrafanaAdminPassword:"},{"line_number":84,"context_line":"    type: OS::TripleO::RandomString"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9fb8cfa7_d805a711","line":81,"updated":"2019-06-25 17:00:14.000000000","message":"move to ceph-mgr.yaml","commit_id":"16659853d19b9d21e2dd9d4f08e6092ce3ca8202"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"4295c8488f5e2a40df583da7a12067b5ef203396","unresolved":false,"context_lines":[{"line_number":78,"context_line":"      EndpointMap: {get_param: EndpointMap}"},{"line_number":79,"context_line":"      RoleName: {get_param: RoleName}"},{"line_number":80,"context_line":"      RoleParameters: {get_param: RoleParameters}"},{"line_number":81,"context_line":"      DashboardEnable: true"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"  GrafanaAdminPassword:"},{"line_number":84,"context_line":"    type: OS::TripleO::RandomString"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9fb8cfa7_782fdb87","line":81,"in_reply_to":"9fb8cfa7_d805a711","updated":"2019-06-25 17:03:35.000000000","message":"or just remove it entirely","commit_id":"16659853d19b9d21e2dd9d4f08e6092ce3ca8202"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"e5ccfb8a99c483e24cc45e740b2f5deec8b2dd9b","unresolved":false,"context_lines":[{"line_number":80,"context_line":"      RoleParameters: {get_param: RoleParameters}"},{"line_number":81,"context_line":"      DashboardEnable: true"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"  GrafanaAdminPassword:"},{"line_number":84,"context_line":"    type: OS::TripleO::RandomString"},{"line_number":85,"context_line":"    properties:"},{"line_number":86,"context_line":"      length: 10"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9fb8cfa7_7d158de4","line":83,"updated":"2019-06-25 16:37:31.000000000","message":"if it is user-facing, better to build this via tripleo-common like [1]\n\n1. https://github.com/openstack/tripleo-common/blob/master/tripleo_common/utils/passwords.py#L36","commit_id":"16659853d19b9d21e2dd9d4f08e6092ce3ca8202"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"1d186fd396f86d8a637379007268c9863db8b0c6","unresolved":false,"context_lines":[{"line_number":103,"context_line":"  role_data:"},{"line_number":104,"context_line":"    description: Role data for the Ceph Dashboard service."},{"line_number":105,"context_line":"    value:"},{"line_number":106,"context_line":"      service_name: ceph_dashboard"},{"line_number":107,"context_line":"      upgrade_tasks: []"},{"line_number":108,"context_line":"      puppet_config:"},{"line_number":109,"context_line":"        config_image: \u0027\u0027"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9fb8cfa7_bd2225b8","line":106,"updated":"2019-06-25 17:00:14.000000000","message":"ceph_graphana-server","commit_id":"16659853d19b9d21e2dd9d4f08e6092ce3ca8202"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"acaec6976aae3f09e6d89dd616295efb6dc73f9a","unresolved":false,"context_lines":[{"line_number":103,"context_line":"  role_data:"},{"line_number":104,"context_line":"    description: Role data for the Ceph Dashboard service."},{"line_number":105,"context_line":"    value:"},{"line_number":106,"context_line":"      service_name: ceph_dashboard"},{"line_number":107,"context_line":"      upgrade_tasks: []"},{"line_number":108,"context_line":"      puppet_config:"},{"line_number":109,"context_line":"        config_image: \u0027\u0027"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9fb8cfa7_58b53731","line":106,"in_reply_to":"9fb8cfa7_bd2225b8","updated":"2019-06-25 17:09:02.000000000","message":"check https://github.com/openstack/tripleo-common/blob/master/tripleo_common/inventory.py#L291-L301","commit_id":"16659853d19b9d21e2dd9d4f08e6092ce3ca8202"}],"deployment/ceph-ansible/ceph-grafana.yaml":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"665d95153423ce39383381559fa7a8381b9193e3","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    description: \u003e"},{"line_number":45,"context_line":"      List of plugins to enable on the grafana container"},{"line_number":46,"context_line":"  GrafanaContainerImage:"},{"line_number":47,"context_line":"    default: \u0027grafana/grafana:latest\u0027"},{"line_number":48,"context_line":"    description: Grafana container image"},{"line_number":49,"context_line":"    type: string"},{"line_number":50,"context_line":"  GrafanaDashboardsPath:"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"9fb8cfa7_df6d63cc","line":47,"updated":"2019-06-27 14:36:04.000000000","message":"remove this default","commit_id":"9350bb41b2ac4ee7b11406d7313f6911bfbf9377"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"665d95153423ce39383381559fa7a8381b9193e3","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    description: Grafana container image"},{"line_number":49,"context_line":"    type: string"},{"line_number":50,"context_line":"  GrafanaDashboardsPath:"},{"line_number":51,"context_line":"    description: ceph dashboards templates built for grafana"},{"line_number":52,"context_line":"    type: string"},{"line_number":53,"context_line":"  GrafanaDataSource:"},{"line_number":54,"context_line":"    default: \u0027Dashboard\u0027"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"9fb8cfa7_9f6b6bb5","line":51,"updated":"2019-06-27 14:36:04.000000000","message":"I think this needs a default?","commit_id":"9350bb41b2ac4ee7b11406d7313f6911bfbf9377"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"665d95153423ce39383381559fa7a8381b9193e3","unresolved":false,"context_lines":[{"line_number":113,"context_line":"                  ceph_ansible_group_vars_dashboard: {get_attr: [CephDashboardAnsibleVars, value, vars]}"},{"line_number":114,"context_line":"              - name: generate all the ceph-ansible roles vars"},{"line_number":115,"context_line":"                blockinfile:"},{"line_number":116,"context_line":"                  path: \"{{playbook_dir}}/ceph-ansible/group_vars/mgrs.yml\""},{"line_number":117,"context_line":"                  block: \"{{ceph_ansible_group_vars_dashboard|to_nice_yaml}}\""},{"line_number":118,"context_line":"                  insertafter: EOF"},{"line_number":119,"context_line":"      external_update_tasks: {get_attr: [CephBase, role_data, external_update_tasks]}"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"9fb8cfa7_7f8a3764","line":116,"updated":"2019-06-27 14:36:04.000000000","message":"I think these variables should not go in mgrs.yaml but some in grafanas.yaml , some in prometheuss.yaml , some in node-exportes.yaml \n\nMaybe we should split the above DashboardAnsibleVars in as many resources and dump the content of each into a different .yaml ?","commit_id":"9350bb41b2ac4ee7b11406d7313f6911bfbf9377"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"59168fef7777f95770311ca8eed629598e2868bc","unresolved":false,"context_lines":[{"line_number":113,"context_line":"                  ceph_ansible_group_vars_dashboard: {get_attr: [CephDashboardAnsibleVars, value, vars]}"},{"line_number":114,"context_line":"              - name: generate all the ceph-ansible roles vars"},{"line_number":115,"context_line":"                blockinfile:"},{"line_number":116,"context_line":"                  path: \"{{playbook_dir}}/ceph-ansible/group_vars/mgrs.yml\""},{"line_number":117,"context_line":"                  block: \"{{ceph_ansible_group_vars_dashboard|to_nice_yaml}}\""},{"line_number":118,"context_line":"                  insertafter: EOF"},{"line_number":119,"context_line":"      external_update_tasks: {get_attr: [CephBase, role_data, external_update_tasks]}"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"9fb8cfa7_9f57eb58","line":116,"in_reply_to":"9fb8cfa7_7f8a3764","updated":"2019-06-27 14:58:09.000000000","message":"Yeah, I see your point and it was what I made in the very first PatchSet. \nThen I realized ceph-ansible collects the group_var variables per hostgroup (not using a per role approach) and this forced me to make the change (see https://review.opendev.org/#/c/666578/5/deployment/ceph-ansible/ceph-dashboard.yaml).\nAs now we have the \u0027grafana-server\u0027 inventory group, we can make a s/mgrs/grafana-server/ to collect the variables","commit_id":"9350bb41b2ac4ee7b11406d7313f6911bfbf9377"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"ed746e6ce35a8983042b28bc7c35d3fddaf4c9cf","unresolved":false,"context_lines":[{"line_number":1,"context_line":"heat_template_version: rocky"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"description: \u003e"},{"line_number":4,"context_line":"  Ceph Dashboard service."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"parameters:"},{"line_number":7,"context_line":"  ServiceData:"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"9fb8cfa7_0ba08bf3","line":4,"updated":"2019-06-28 16:11:33.000000000","message":"Grafana","commit_id":"be7f47c4d755ff67236bf5db73bc6e6d3d3c1e52"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"9d1007336b393db8c1c24d9e42e45b712dda1cf9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"heat_template_version: rocky"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"description: \u003e"},{"line_number":4,"context_line":"  Ceph Dashboard service."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"parameters:"},{"line_number":7,"context_line":"  ServiceData:"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"9fb8cfa7_d3d76eed","line":4,"in_reply_to":"9fb8cfa7_0ba08bf3","updated":"2019-07-02 12:13:40.000000000","message":"we could fix that in a follow up review","commit_id":"be7f47c4d755ff67236bf5db73bc6e6d3d3c1e52"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"b01acfae1cf68f340103e9713b6833864da033cf","unresolved":false,"context_lines":[{"line_number":1,"context_line":"heat_template_version: rocky"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"description: \u003e"},{"line_number":4,"context_line":"  Ceph Dashboard service."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"parameters:"},{"line_number":7,"context_line":"  ServiceData:"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"9fb8cfa7_8237424e","line":4,"in_reply_to":"9fb8cfa7_d3d76eed","updated":"2019-07-03 12:48:59.000000000","message":"Agree, I\u0027ll fix this in the next (tls) review set","commit_id":"be7f47c4d755ff67236bf5db73bc6e6d3d3c1e52"},{"author":{"_account_id":14270,"name":"Dimitri Savineau","email":"dsavinea@redhat.com","username":"dsavineau"},"change_message_id":"c10eac40a4a09e7a873a0b2fd49d184b51130047","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        map_merge:"},{"line_number":122,"context_line":"        - tripleo::ceph_dashboard::firewall_rules:"},{"line_number":123,"context_line":"            \u0027123 ceph_dashboard\u0027:"},{"line_number":124,"context_line":"              dport: [3000,9090,9093,9094,9100]"},{"line_number":125,"context_line":"              proto: tcp"},{"line_number":126,"context_line":"              action: accept"},{"line_number":127,"context_line":"        - {}"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"7faddb67_8c7f0014","line":124,"updated":"2019-07-12 14:46:50.000000000","message":"This will open the port 9100 (node-exporter) only on the controller nodes when the service is deployed on all ceph nodes.","commit_id":"fa6e11f9d5d7a030026f80ebca1a3d61adb4f1be"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"11c886339b13b0ac2f705877ed039d081b80db77","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        map_merge:"},{"line_number":122,"context_line":"        - tripleo::ceph_dashboard::firewall_rules:"},{"line_number":123,"context_line":"            \u0027123 ceph_dashboard\u0027:"},{"line_number":124,"context_line":"              dport: [3000,9090,9093,9094,9100]"},{"line_number":125,"context_line":"              proto: tcp"},{"line_number":126,"context_line":"              action: accept"},{"line_number":127,"context_line":"        - {}"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"7faddb67_ec37944c","line":124,"in_reply_to":"7faddb67_8c7f0014","updated":"2019-07-12 15:00:31.000000000","message":"true, we need to open this port on all the other nodes (e.g. OS::TripleO::Services::CephOSD and all the other services). Noted for the next PS","commit_id":"fa6e11f9d5d7a030026f80ebca1a3d61adb4f1be"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"50b9bb24ef62fdfda8ce1817fc267dc0fc19d31f","unresolved":false,"context_lines":[{"line_number":123,"context_line":"            \u0027123 ceph_dashboard\u0027:"},{"line_number":124,"context_line":"              dport: [3000,9090,9093,9094,9100]"},{"line_number":125,"context_line":"              proto: tcp"},{"line_number":126,"context_line":"              action: accept"},{"line_number":127,"context_line":"        - {}"}],"source_content_type":"text/x-yaml","patch_set":39,"id":"7faddb67_fef13e02","line":126,"updated":"2019-07-17 13:42:35.000000000","message":"So as mentioned at the PTG, we need to limit this to a specific network (not the public one).  So maybe the ctlplane network?","commit_id":"9994dae119a38f9cfc590b1f6a0e8eb7bdfa9a39"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"90b6cc2da149d2b6f5571d8ddf3ee808f2fdf1b5","unresolved":false,"context_lines":[{"line_number":123,"context_line":"            \u0027123 ceph_dashboard\u0027:"},{"line_number":124,"context_line":"              dport: [3000,9090,9093,9094,9100]"},{"line_number":125,"context_line":"              proto: tcp"},{"line_number":126,"context_line":"              action: accept"},{"line_number":127,"context_line":"        - {}"}],"source_content_type":"text/x-yaml","patch_set":39,"id":"7faddb67_1edf7a3a","line":126,"in_reply_to":"7faddb67_5e6652c3","updated":"2019-07-17 13:49:09.000000000","message":"yes, I think the best move is to remove proto/action","commit_id":"9994dae119a38f9cfc590b1f6a0e8eb7bdfa9a39"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"beb8c70b62b87285e92d3aff1211d7077441cba4","unresolved":false,"context_lines":[{"line_number":123,"context_line":"            \u0027123 ceph_dashboard\u0027:"},{"line_number":124,"context_line":"              dport: [3000,9090,9093,9094,9100]"},{"line_number":125,"context_line":"              proto: tcp"},{"line_number":126,"context_line":"              action: accept"},{"line_number":127,"context_line":"        - {}"}],"source_content_type":"text/x-yaml","patch_set":39,"id":"7faddb67_5e6652c3","line":126,"in_reply_to":"7faddb67_fef13e02","updated":"2019-07-17 13:44:55.000000000","message":"maybe best is to remove action and proto entirely?","commit_id":"9994dae119a38f9cfc590b1f6a0e8eb7bdfa9a39"}],"deployment/ceph-ansible/ceph-mds.yaml":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"0e81ca238f380be60854ffa3e88c4921f0e22d19","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        - tripleo::ceph_mds::firewall_rules:"},{"line_number":140,"context_line":"            \u0027112 ceph_mds\u0027:"},{"line_number":141,"context_line":"              dport:"},{"line_number":142,"context_line":"              - \u00276800-7300\u0027"},{"line_number":143,"context_line":"              - if:"},{"line_number":144,"context_line":"                  - dashboard_enabled"},{"line_number":145,"context_line":"                  - \u00279100\u0027"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"7faddb67_fd47194b","line":142,"updated":"2019-07-16 12:31:08.000000000","message":"we could try list_concat here instead","commit_id":"dc5af394987e8d121be05e2b4cefbf9b32fc02dd"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"0e81ca238f380be60854ffa3e88c4921f0e22d19","unresolved":false,"context_lines":[{"line_number":143,"context_line":"              - if:"},{"line_number":144,"context_line":"                  - dashboard_enabled"},{"line_number":145,"context_line":"                  - \u00279100\u0027"},{"line_number":146,"context_line":"                  - \u0027\u0027"},{"line_number":147,"context_line":"        - {}"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"7faddb67_3d42913f","line":146,"updated":"2019-07-16 12:31:08.000000000","message":"or ~ here","commit_id":"dc5af394987e8d121be05e2b4cefbf9b32fc02dd"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"ef5ee4b7d2c3ef36bdea850f8099cd3ec683adea","unresolved":false,"context_lines":[{"line_number":143,"context_line":"              - if:"},{"line_number":144,"context_line":"                  - dashboard_enabled"},{"line_number":145,"context_line":"                  - \u00279100\u0027"},{"line_number":146,"context_line":"                  - \u0027\u0027"},{"line_number":147,"context_line":"        - {}"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"7faddb67_64b7063c","line":146,"in_reply_to":"7faddb67_3d42913f","updated":"2019-07-17 00:42:14.000000000","message":"Yeah, it chokes on the \u0027\u0027. Here\u0027s my thought:\n\n        - tripleo::ceph_mds::firewall_rules:\n            \u0027112 ceph_mds\u0027:\n              dport:\n                list_concat:\n                  - - \u00276800-7300\u0027\n                  - if:\n                    - dashboard_enabled\n                    - - \u00279100\u0027\n                    - []","commit_id":"dc5af394987e8d121be05e2b4cefbf9b32fc02dd"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"cba0b9320f995764b3893ad5cc1e859f843402db","unresolved":false,"context_lines":[{"line_number":143,"context_line":"              - if:"},{"line_number":144,"context_line":"                  - dashboard_enabled"},{"line_number":145,"context_line":"                  - \u00279100\u0027"},{"line_number":146,"context_line":"                  - \u0027\u0027"},{"line_number":147,"context_line":"        - {}"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"7faddb67_529bac16","line":146,"in_reply_to":"7faddb67_64b7063c","updated":"2019-07-17 07:02:56.000000000","message":"Thanks for the suggestion.\nI think the ~ doesn\u0027t work (it will be translated in null value) and the list_concat seems the way to solve this issue.\nI want to see the CI execution to see how it behaves with this form.","commit_id":"dc5af394987e8d121be05e2b4cefbf9b32fc02dd"}],"deployment/ceph-ansible/ceph-mgr.yaml":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"ac7ff9b00fd71202d09d823cc773e11c6d1439f2","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    description: Mapping of service endpoint -\u003e protocol. Typically set"},{"line_number":31,"context_line":"                 via parameter_defaults in the resource registry."},{"line_number":32,"context_line":"    type: json"},{"line_number":33,"context_line":"  DashboardCrt:"},{"line_number":34,"context_line":"    default: \u0027\u0027"},{"line_number":35,"context_line":"    description: Dashboard SSL Certificate"},{"line_number":36,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9fb8cfa7_fd109d02","line":33,"updated":"2019-06-25 16:33:06.000000000","message":"should be removed","commit_id":"16659853d19b9d21e2dd9d4f08e6092ce3ca8202"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"ac7ff9b00fd71202d09d823cc773e11c6d1439f2","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    default: \u0027\u0027"},{"line_number":35,"context_line":"    description: Dashboard SSL Certificate"},{"line_number":36,"context_line":"    type: string"},{"line_number":37,"context_line":"  DashboardKey:"},{"line_number":38,"context_line":"    default: \u0027\u0027"},{"line_number":39,"context_line":"    description: Dashboard SSL Certificate Key"},{"line_number":40,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9fb8cfa7_bdf6a5d6","line":37,"updated":"2019-06-25 16:33:06.000000000","message":"remove as well","commit_id":"16659853d19b9d21e2dd9d4f08e6092ce3ca8202"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"ac7ff9b00fd71202d09d823cc773e11c6d1439f2","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    default: \u0027\u0027"},{"line_number":39,"context_line":"    description: Dashboard SSL Certificate Key"},{"line_number":40,"context_line":"    type: string"},{"line_number":41,"context_line":"  DashboardRgwApiHost:"},{"line_number":42,"context_line":"    default: \u0027\u0027"},{"line_number":43,"context_line":"    description: Dashboard API host"},{"line_number":44,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9fb8cfa7_dda119f9","line":41,"updated":"2019-06-25 16:33:06.000000000","message":"should be removed","commit_id":"16659853d19b9d21e2dd9d4f08e6092ce3ca8202"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"ac7ff9b00fd71202d09d823cc773e11c6d1439f2","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    default: \u0027\u0027"},{"line_number":43,"context_line":"    description: Dashboard API host"},{"line_number":44,"context_line":"    type: string"},{"line_number":45,"context_line":"  DashboardRgwApiPort:"},{"line_number":46,"context_line":"    default: \u0027\u0027"},{"line_number":47,"context_line":"    description: Dashboard API port"},{"line_number":48,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9fb8cfa7_fda65d0f","line":45,"updated":"2019-06-25 16:33:06.000000000","message":"remove as well","commit_id":"16659853d19b9d21e2dd9d4f08e6092ce3ca8202"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"ac7ff9b00fd71202d09d823cc773e11c6d1439f2","unresolved":false,"context_lines":[{"line_number":64,"context_line":"      type: json"},{"line_number":65,"context_line":"      value:"},{"line_number":66,"context_line":"        vars:"},{"line_number":67,"context_line":"          ceph_mgr_docker_extra_env: \u0027-e MGR_DASHBOARD\u003d0\u0027"},{"line_number":68,"context_line":"          dashboard_crt: {get_param: DashboardCrt}"},{"line_number":69,"context_line":"          dashboard_key: {get_param: DashboardKey}"},{"line_number":70,"context_line":"          dashboard_rgw_api_host: {get_param: [EndpointMap, CephRgwPublic, host]}"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9fb8cfa7_bdac65ed","line":67,"updated":"2019-06-25 16:33:06.000000000","message":"is this still useful?","commit_id":"16659853d19b9d21e2dd9d4f08e6092ce3ca8202"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"ac7ff9b00fd71202d09d823cc773e11c6d1439f2","unresolved":false,"context_lines":[{"line_number":65,"context_line":"      value:"},{"line_number":66,"context_line":"        vars:"},{"line_number":67,"context_line":"          ceph_mgr_docker_extra_env: \u0027-e MGR_DASHBOARD\u003d0\u0027"},{"line_number":68,"context_line":"          dashboard_crt: {get_param: DashboardCrt}"},{"line_number":69,"context_line":"          dashboard_key: {get_param: DashboardKey}"},{"line_number":70,"context_line":"          dashboard_rgw_api_host: {get_param: [EndpointMap, CephRgwPublic, host]}"},{"line_number":71,"context_line":"          dashboard_rgw_api_port: {get_param: [EndpointMap, CephRgwPublic, port]}"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9fb8cfa7_5dff69aa","line":68,"updated":"2019-06-25 16:33:06.000000000","message":"these should be set like in [1] basing on EnableInternalTLS bool\n\n1. https://github.com/openstack/tripleo-heat-templates/blob/master/deployment/apache/apache-baremetal-puppet.j2.yaml#L109-L120","commit_id":"16659853d19b9d21e2dd9d4f08e6092ce3ca8202"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"ac7ff9b00fd71202d09d823cc773e11c6d1439f2","unresolved":false,"context_lines":[{"line_number":67,"context_line":"          ceph_mgr_docker_extra_env: \u0027-e MGR_DASHBOARD\u003d0\u0027"},{"line_number":68,"context_line":"          dashboard_crt: {get_param: DashboardCrt}"},{"line_number":69,"context_line":"          dashboard_key: {get_param: DashboardKey}"},{"line_number":70,"context_line":"          dashboard_rgw_api_host: {get_param: [EndpointMap, CephRgwPublic, host]}"},{"line_number":71,"context_line":"          dashboard_rgw_api_port: {get_param: [EndpointMap, CephRgwPublic, port]}"},{"line_number":72,"context_line":"          dashboard_rgw_api_no_ssl_verify: false"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9fb8cfa7_3def151f","line":70,"updated":"2019-06-25 16:33:06.000000000","message":"probably best to use the internal endpoint","commit_id":"16659853d19b9d21e2dd9d4f08e6092ce3ca8202"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"ac7ff9b00fd71202d09d823cc773e11c6d1439f2","unresolved":false,"context_lines":[{"line_number":68,"context_line":"          dashboard_crt: {get_param: DashboardCrt}"},{"line_number":69,"context_line":"          dashboard_key: {get_param: DashboardKey}"},{"line_number":70,"context_line":"          dashboard_rgw_api_host: {get_param: [EndpointMap, CephRgwPublic, host]}"},{"line_number":71,"context_line":"          dashboard_rgw_api_port: {get_param: [EndpointMap, CephRgwPublic, port]}"},{"line_number":72,"context_line":"          dashboard_rgw_api_no_ssl_verify: false"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"outputs:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9fb8cfa7_fd7f3d63","line":71,"updated":"2019-06-25 16:33:06.000000000","message":"needs dashboard_rgw_api_scheme too {get_param: [EndpointMap, CephRgwPublic, protocol]} ... but honestly it would be best to have _url in ceph-ansible which overrides them all","commit_id":"16659853d19b9d21e2dd9d4f08e6092ce3ca8202"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"eddf08b4d8b23d2c7d1bbd5d692679e8580567b7","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    default: false"},{"line_number":35,"context_line":"    description: Parameter used by ceph-ansible to deploy grafana"},{"line_number":36,"context_line":"    type: boolean"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"resources:"},{"line_number":40,"context_line":"  CephBase:"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"9fb8cfa7_471f7307","line":37,"updated":"2019-06-27 10:55:40.000000000","message":"Maybe add CephDashboardAdminPassword as well","commit_id":"b0f3f5774aedea3661f7486d3c6046004c854425"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"f0c3970d02ae29a521d88a34adba4074d72a08bf","unresolved":false,"context_lines":[{"line_number":61,"context_line":"          #dashboard_key: {get_param: DashboardKey}"},{"line_number":62,"context_line":"          dashboard_rgw_api_host: {get_param: [EndpointMap, CephRgwInternal, host]}"},{"line_number":63,"context_line":"          dashboard_rgw_api_port: {get_param: [EndpointMap, CephRgwInternal, port]}"},{"line_number":64,"context_line":"          dashboard_rgw_api_scheme: {get_param: [EndpointMap, CephRgwPublic, protocol]}"},{"line_number":65,"context_line":"          dashboard_rgw_api_no_ssl_verify: false"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"outputs:"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"9fb8cfa7_e746a750","line":64,"updated":"2019-06-27 10:51:34.000000000","message":"CephRgwInternal","commit_id":"b0f3f5774aedea3661f7486d3c6046004c854425"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"d51f144057f5bccc230c47f5a0a5f39502798574","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    description: Mapping of service endpoint -\u003e protocol. Typically set"},{"line_number":31,"context_line":"                 via parameter_defaults in the resource registry."},{"line_number":32,"context_line":"    type: json"},{"line_number":33,"context_line":"  EnableCephDashboard:"},{"line_number":34,"context_line":"    default: false"},{"line_number":35,"context_line":"    description: Parameter used by ceph-ansible to deploy grafana"},{"line_number":36,"context_line":"    type: boolean"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"7faddb67_6151940e","line":33,"updated":"2019-07-10 17:42:04.000000000","message":"Maybe CephEnableDashboard","commit_id":"9abe89c4321454c54f2c121969310f5f03c998dd"},{"author":{"_account_id":14270,"name":"Dimitri Savineau","email":"dsavinea@redhat.com","username":"dsavineau"},"change_message_id":"c10eac40a4a09e7a873a0b2fd49d184b51130047","unresolved":false,"context_lines":[{"line_number":60,"context_line":"          ceph_mgr_docker_extra_env: \u0027-e MGR_DASHBOARD\u003d0\u0027"},{"line_number":61,"context_line":"          dashboard_admin_user: {get_param: CephDashboardAdminUser}"},{"line_number":62,"context_line":"          dashboard_admin_password: {get_param: CephDashboardAdminPassword}"},{"line_number":63,"context_line":"          dashboard_rgw_api_host: {get_param: [EndpointMap, CephRgwInternal, host]}"},{"line_number":64,"context_line":"          dashboard_rgw_api_port: {get_param: [EndpointMap, CephRgwInternal, port]}"},{"line_number":65,"context_line":"          dashboard_rgw_api_scheme: {get_param: [EndpointMap, CephRgwInternal, protocol]}"},{"line_number":66,"context_line":"          dashboard_rgw_api_no_ssl_verify: false"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"7faddb67_4caa6871","line":63,"updated":"2019-07-12 14:46:50.000000000","message":"does {get_param: [EndpointMap, CephRgwInternal, host]} always return a value even if the RGW isn\u0027t enabled ?","commit_id":"fa6e11f9d5d7a030026f80ebca1a3d61adb4f1be"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"11c886339b13b0ac2f705877ed039d081b80db77","unresolved":false,"context_lines":[{"line_number":60,"context_line":"          ceph_mgr_docker_extra_env: \u0027-e MGR_DASHBOARD\u003d0\u0027"},{"line_number":61,"context_line":"          dashboard_admin_user: {get_param: CephDashboardAdminUser}"},{"line_number":62,"context_line":"          dashboard_admin_password: {get_param: CephDashboardAdminPassword}"},{"line_number":63,"context_line":"          dashboard_rgw_api_host: {get_param: [EndpointMap, CephRgwInternal, host]}"},{"line_number":64,"context_line":"          dashboard_rgw_api_port: {get_param: [EndpointMap, CephRgwInternal, port]}"},{"line_number":65,"context_line":"          dashboard_rgw_api_scheme: {get_param: [EndpointMap, CephRgwInternal, protocol]}"},{"line_number":66,"context_line":"          dashboard_rgw_api_no_ssl_verify: false"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"7faddb67_2cf7ec61","line":63,"in_reply_to":"7faddb67_4caa6871","updated":"2019-07-12 15:00:31.000000000","message":"I think so because I see [1] and [2]\n\n[1] https://github.com/openstack/tripleo-heat-templates/blob/master/network/service_net_map.j2.yaml#L82\n\n[2] https://github.com/openstack/tripleo-heat-templates/blob/2aaf52e5efad9db7617a1782149b7fc692c37c03/network/endpoints/endpoint_map.yaml#L29","commit_id":"fa6e11f9d5d7a030026f80ebca1a3d61adb4f1be"}],"deployment/ceph-ansible/ceph-osd.yaml":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"80f818dab07624b9c46e96d92fbd721c6d1afad0","unresolved":false,"context_lines":[{"line_number":94,"context_line":"            \u0027111 ceph_osd\u0027:"},{"line_number":95,"context_line":"              dport:"},{"line_number":96,"context_line":"              - \u00276800-7300\u0027"},{"line_number":97,"context_line":"              - \u00279100\u0027"},{"line_number":98,"context_line":"        - {}"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"7faddb67_5432d85f","line":97,"updated":"2019-07-15 15:02:58.000000000","message":"capture in ceph-osd.yaml also \"CephEnableDashboard\" then try something like this https://review.opendev.org/#/c/666291/1/deployment/ceph-ansible/ceph-rgw.yaml","commit_id":"6df05579a77926e7e09ce36625dac6a9dd255e1d"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"477c2c758bd5ee3045ddb5bc11d6fde356604a1f","unresolved":false,"context_lines":[{"line_number":94,"context_line":"            \u0027111 ceph_osd\u0027:"},{"line_number":95,"context_line":"              dport:"},{"line_number":96,"context_line":"              - \u00276800-7300\u0027"},{"line_number":97,"context_line":"              - \u00279100\u0027"},{"line_number":98,"context_line":"        - {}"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"7faddb67_0e2c41aa","line":97,"in_reply_to":"7faddb67_5432d85f","updated":"2019-07-16 08:10:08.000000000","message":"Thanks for the hint, I will add the condition here and in the involved services using the ceph-rgw.yaml approach.","commit_id":"6df05579a77926e7e09ce36625dac6a9dd255e1d"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"549cafe7ddaa983627ecd112a818c100379763f4","unresolved":false,"context_lines":[{"line_number":104,"context_line":"              - if:"},{"line_number":105,"context_line":"                  - dashboard_enabled"},{"line_number":106,"context_line":"                  - \u00279100\u0027"},{"line_number":107,"context_line":"                  - \u0027\u0027"},{"line_number":108,"context_line":"        - {}"}],"source_content_type":"text/x-yaml","patch_set":33,"id":"7faddb67_31d5e0e5","line":107,"updated":"2019-07-16 08:43:05.000000000","message":"This condition make us able to add the node-exporter port only if we have the CephEnableDashboard \u003d\u003d True","commit_id":"33fe2e7d75c37c769d5b504c65226fcccec8db86"}],"environments/ceph-ansible/ceph-dashboard.yaml":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"e1c58b724421e94873c63a8a62dee521a5301cc8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"resource_registry:"},{"line_number":2,"context_line":"  OS::TripleO::Services::CephDashboard: ../../deployment/ceph-ansible/ceph-dashboard.yaml"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9fb8cfa7_d81e075e","line":2,"updated":"2019-06-25 17:01:47.000000000","message":"resource_registry:\n  OS::TripleO::Services::CephGraphana: ...\n\nparameter_defaults:\n  EnableCephDashboard: true","commit_id":"16659853d19b9d21e2dd9d4f08e6092ce3ca8202"}],"roles/CephAll.yaml":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"d51f144057f5bccc230c47f5a0a5f39502798574","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    - OS::TripleO::Services::CACerts"},{"line_number":20,"context_line":"    - OS::TripleO::Services::CephMds"},{"line_number":21,"context_line":"    - OS::TripleO::Services::CephMgr"},{"line_number":22,"context_line":"    - OS::TripleO::Services::CephGrafana"},{"line_number":23,"context_line":"    - OS::TripleO::Services::CephMon"},{"line_number":24,"context_line":"    - OS::TripleO::Services::CephRbdMirror"},{"line_number":25,"context_line":"    - OS::TripleO::Services::CephRgw"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"7faddb67_61d67452","line":22,"updated":"2019-07-10 17:42:04.000000000","message":"nit: the original goal was that lists like this would be sorted alphabetically.","commit_id":"9abe89c4321454c54f2c121969310f5f03c998dd"}],"roles/ControllerOpenstack.yaml":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"d51f144057f5bccc230c47f5a0a5f39502798574","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    - OS::TripleO::Services::CephExternal"},{"line_number":43,"context_line":"    - OS::TripleO::Services::CephMds"},{"line_number":44,"context_line":"    - OS::TripleO::Services::CephMgr"},{"line_number":45,"context_line":"    - OS::TripleO::Services::CephGrafana"},{"line_number":46,"context_line":"    - OS::TripleO::Services::CephMon"},{"line_number":47,"context_line":"    - OS::TripleO::Services::CephRbdMirror"},{"line_number":48,"context_line":"    - OS::TripleO::Services::CephRgw"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"7faddb67_8155b0c8","line":45,"updated":"2019-07-10 17:42:04.000000000","message":"nit: not sorted alphabetically\n\nSee other role files in this patch (I won\u0027t add a comment to each of them).","commit_id":"9abe89c4321454c54f2c121969310f5f03c998dd"}]}