)]}'
{"deployment/swift/swift-proxy-container-puppet.yaml":[{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"aae91385fafbfd80a59c5051fe514e9a0cf0272f","unresolved":false,"context_lines":[{"line_number":492,"context_line":"          file:"},{"line_number":493,"context_line":"            path: /var/log/containers/swift"},{"line_number":494,"context_line":"            state: absent"},{"line_number":495,"context_line":"          when: swift_log_link.stat.islnk is defined and swift_log_link.stat.islnk"},{"line_number":496,"context_line":"      metadata_settings:"},{"line_number":497,"context_line":"        get_attr: [TLSProxyBase, role_data, metadata_settings]"},{"line_number":498,"context_line":"      post_upgrade_tasks:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fb8cfa7_fccdf62f","line":495,"range":{"start_line":495,"start_character":57,"end_line":495,"end_character":82},"updated":"2019-06-26 05:28:47.000000000","message":"maybe add |bool ?","commit_id":"6f2877d986fd329777a1fb1bd8c0546cf23237cb"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"29d564c9157236457f88d431ec45d10abefd8bb2","unresolved":false,"context_lines":[{"line_number":492,"context_line":"          file:"},{"line_number":493,"context_line":"            path: /var/log/containers/swift"},{"line_number":494,"context_line":"            state: absent"},{"line_number":495,"context_line":"          when: swift_log_link.stat.islnk is defined and swift_log_link.stat.islnk"},{"line_number":496,"context_line":"      metadata_settings:"},{"line_number":497,"context_line":"        get_attr: [TLSProxyBase, role_data, metadata_settings]"},{"line_number":498,"context_line":"      post_upgrade_tasks:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fb8cfa7_edfbfdba","line":495,"range":{"start_line":495,"start_character":57,"end_line":495,"end_character":82},"in_reply_to":"9fb8cfa7_27aff62a","updated":"2019-06-26 13:19:15.000000000","message":"i don\u0027t think |bool is necessary for the internals of the stat stuff. It\u0027s different when it\u0027s user input but something like islnk should always already be a boolean. also is a cherry pick :D","commit_id":"6f2877d986fd329777a1fb1bd8c0546cf23237cb"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"4e4902ee70e4155ad0c18a8f352b3e07dd148a9c","unresolved":false,"context_lines":[{"line_number":492,"context_line":"          file:"},{"line_number":493,"context_line":"            path: /var/log/containers/swift"},{"line_number":494,"context_line":"            state: absent"},{"line_number":495,"context_line":"          when: swift_log_link.stat.islnk is defined and swift_log_link.stat.islnk"},{"line_number":496,"context_line":"      metadata_settings:"},{"line_number":497,"context_line":"        get_attr: [TLSProxyBase, role_data, metadata_settings]"},{"line_number":498,"context_line":"      post_upgrade_tasks:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fb8cfa7_27aff62a","line":495,"range":{"start_line":495,"start_character":57,"end_line":495,"end_character":82},"in_reply_to":"9fb8cfa7_47e30ad9","updated":"2019-06-26 12:20:23.000000000","message":"Just to understand, irrespective of whether it\u0027s a backport or not why do we need filter as it\u0027s always going to come out True/False from stats module? It\u0027s not var (can be interpreted as string) we define ourselves, or I\u0027m missing something else here?","commit_id":"6f2877d986fd329777a1fb1bd8c0546cf23237cb"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"cc577e7622af1ee8fb872766e461f097c11fbad4","unresolved":false,"context_lines":[{"line_number":492,"context_line":"          file:"},{"line_number":493,"context_line":"            path: /var/log/containers/swift"},{"line_number":494,"context_line":"            state: absent"},{"line_number":495,"context_line":"          when: swift_log_link.stat.islnk is defined and swift_log_link.stat.islnk"},{"line_number":496,"context_line":"      metadata_settings:"},{"line_number":497,"context_line":"        get_attr: [TLSProxyBase, role_data, metadata_settings]"},{"line_number":498,"context_line":"      post_upgrade_tasks:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fb8cfa7_47e30ad9","line":495,"range":{"start_line":495,"start_character":57,"end_line":495,"end_character":82},"in_reply_to":"9fb8cfa7_9c015a09","updated":"2019-06-26 12:02:13.000000000","message":"it\u0027s a backport, we should apply what we did on master.","commit_id":"6f2877d986fd329777a1fb1bd8c0546cf23237cb"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"c73313c07a0e58bc84ff1c8f8dd116ea63c2aaac","unresolved":false,"context_lines":[{"line_number":492,"context_line":"          file:"},{"line_number":493,"context_line":"            path: /var/log/containers/swift"},{"line_number":494,"context_line":"            state: absent"},{"line_number":495,"context_line":"          when: swift_log_link.stat.islnk is defined and swift_log_link.stat.islnk"},{"line_number":496,"context_line":"      metadata_settings:"},{"line_number":497,"context_line":"        get_attr: [TLSProxyBase, role_data, metadata_settings]"},{"line_number":498,"context_line":"      post_upgrade_tasks:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fb8cfa7_9c015a09","line":495,"range":{"start_line":495,"start_character":57,"end_line":495,"end_character":82},"in_reply_to":"9fb8cfa7_fccdf62f","updated":"2019-06-26 05:43:45.000000000","message":"Don\u0027t know a lot about ansible. But I don\u0027t see why use the boolean filter here.\n\nNeither I see it in the stat module examples.\n\nhttps://docs.ansible.com/ansible/latest/modules/stat_module.html","commit_id":"6f2877d986fd329777a1fb1bd8c0546cf23237cb"}],"deployment/swift/swift-storage-container-puppet.yaml":[{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"aae91385fafbfd80a59c5051fe514e9a0cf0272f","unresolved":false,"context_lines":[{"line_number":656,"context_line":"          file:"},{"line_number":657,"context_line":"            path: /var/log/containers/swift"},{"line_number":658,"context_line":"            state: absent"},{"line_number":659,"context_line":"          when: swift_log_link.stat.islnk is defined and swift_log_link.stat.islnk"},{"line_number":660,"context_line":"      post_upgrade_tasks:"},{"line_number":661,"context_line":"        - when: step|int \u003d\u003d 1"},{"line_number":662,"context_line":"          import_role:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fb8cfa7_bcdbfeea","line":659,"range":{"start_line":659,"start_character":57,"end_line":659,"end_character":82},"updated":"2019-06-26 05:28:47.000000000","message":"maybe add |bool ?","commit_id":"6f2877d986fd329777a1fb1bd8c0546cf23237cb"}]}