)]}'
{"common/container-puppet.py":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"c393db88698fb50176b87d1e074727dcfa684d53","unresolved":false,"context_lines":[{"line_number":419,"context_line":"                \u0027--volume\u0027, \u0027%s:/var/lib/config-data/:rw\u0027 % config_volume_prefix,"},{"line_number":420,"context_line":"                # meh facter caching"},{"line_number":421,"context_line":"                \u0027--volume\u0027, \u0027/var/lib/container-puppet/puppetlabs/facter.conf:/etc/puppetlabs/facter/facter.conf:ro\u0027,"},{"line_number":422,"context_line":"                \u0027--volume\u0027, \u0027/var/lib/container-puppet/puppetlabs/:/opt/puppetlabs/:shared\u0027,"},{"line_number":423,"context_line":"                # Syslog socket for puppet logs"},{"line_number":424,"context_line":"                \u0027--volume\u0027, \u0027/dev/log:/dev/log:rw\u0027]"},{"line_number":425,"context_line":"        if privileged:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_812ae9e4","line":422,"updated":"2019-07-04 08:35:02.000000000","message":"I think this won\u0027t work for the multiple writes in parallel, which is possible when configuring multiple services at the same time?","commit_id":"561f123c9c669f15d5607cc8e6c0b82db484686a"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"b909d6df87da9fe7b648b4e60e3a19e0c23ab6d1","unresolved":false,"context_lines":[{"line_number":419,"context_line":"                \u0027--volume\u0027, \u0027%s:/var/lib/config-data/:rw\u0027 % config_volume_prefix,"},{"line_number":420,"context_line":"                # meh facter caching"},{"line_number":421,"context_line":"                \u0027--volume\u0027, \u0027/var/lib/container-puppet/puppetlabs/facter.conf:/etc/puppetlabs/facter/facter.conf:ro\u0027,"},{"line_number":422,"context_line":"                \u0027--volume\u0027, \u0027/var/lib/container-puppet/puppetlabs/:/opt/puppetlabs/:shared\u0027,"},{"line_number":423,"context_line":"                # Syslog socket for puppet logs"},{"line_number":424,"context_line":"                \u0027--volume\u0027, \u0027/dev/log:/dev/log:rw\u0027]"},{"line_number":425,"context_line":"        if privileged:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_9340d137","line":422,"in_reply_to":"7faddb67_812ae9e4","updated":"2019-07-08 16:41:59.000000000","message":"In theory it shouldn\u0027t be writing out because it should be cached already. I need to test this","commit_id":"561f123c9c669f15d5607cc8e6c0b82db484686a"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"a9b7907a7831b5990c105306ca8c828f67d187c0","unresolved":false,"context_lines":[{"line_number":419,"context_line":"                \u0027--volume\u0027, \u0027%s:/var/lib/config-data/:rw\u0027 % config_volume_prefix,"},{"line_number":420,"context_line":"                # facter caching"},{"line_number":421,"context_line":"                \u0027--volume\u0027, \u0027/var/lib/container-puppet/puppetlabs/facter.conf:/etc/puppetlabs/facter/facter.conf:ro\u0027,"},{"line_number":422,"context_line":"                \u0027--volume\u0027, \u0027/var/lib/container-puppet/puppetlabs/:/opt/puppetlabs/:shared\u0027,"},{"line_number":423,"context_line":"                # Syslog socket for puppet logs"},{"line_number":424,"context_line":"                \u0027--volume\u0027, \u0027/dev/log:/dev/log:rw\u0027]"},{"line_number":425,"context_line":"        if privileged:"}],"source_content_type":"text/x-python","patch_set":8,"id":"7faddb67_8915999e","line":422,"updated":"2019-07-15 14:28:25.000000000","message":"I\u0027m still not sure how would that work with concurrent execution. This doesn\u0027t look safe.","commit_id":"3d04ee3a92c0d204608ea2e796dc42e402ed6388"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"42af30f5e4a53d7695d1078225b6a2a41d6957c0","unresolved":false,"context_lines":[{"line_number":419,"context_line":"                \u0027--volume\u0027, \u0027%s:/var/lib/config-data/:rw\u0027 % config_volume_prefix,"},{"line_number":420,"context_line":"                # facter caching"},{"line_number":421,"context_line":"                \u0027--volume\u0027, \u0027/var/lib/container-puppet/puppetlabs/facter.conf:/etc/puppetlabs/facter/facter.conf:ro\u0027,"},{"line_number":422,"context_line":"                \u0027--volume\u0027, \u0027/var/lib/container-puppet/puppetlabs/:/opt/puppetlabs/:shared\u0027,"},{"line_number":423,"context_line":"                # Syslog socket for puppet logs"},{"line_number":424,"context_line":"                \u0027--volume\u0027, \u0027/dev/log:/dev/log:rw\u0027]"},{"line_number":425,"context_line":"        if privileged:"}],"source_content_type":"text/x-python","patch_set":8,"id":"7faddb67_2f26e516","line":422,"in_reply_to":"7faddb67_14b3009a","updated":"2019-07-15 15:43:27.000000000","message":"With :ro it looks much better indeed. Although I have a question, where will be the place for puppet to populate its contents for the 1st time?..","commit_id":"3d04ee3a92c0d204608ea2e796dc42e402ed6388"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"9615834544bf95b02852d28998dd5c3097ce5994","unresolved":false,"context_lines":[{"line_number":419,"context_line":"                \u0027--volume\u0027, \u0027%s:/var/lib/config-data/:rw\u0027 % config_volume_prefix,"},{"line_number":420,"context_line":"                # facter caching"},{"line_number":421,"context_line":"                \u0027--volume\u0027, \u0027/var/lib/container-puppet/puppetlabs/facter.conf:/etc/puppetlabs/facter/facter.conf:ro\u0027,"},{"line_number":422,"context_line":"                \u0027--volume\u0027, \u0027/var/lib/container-puppet/puppetlabs/:/opt/puppetlabs/:shared\u0027,"},{"line_number":423,"context_line":"                # Syslog socket for puppet logs"},{"line_number":424,"context_line":"                \u0027--volume\u0027, \u0027/dev/log:/dev/log:rw\u0027]"},{"line_number":425,"context_line":"        if privileged:"}],"source_content_type":"text/x-python","patch_set":8,"id":"7faddb67_e953ed37","line":422,"in_reply_to":"7faddb67_8915999e","updated":"2019-07-15 14:38:08.000000000","message":"why?  So in theory, there should be no updates for 8 hours due to the configured ttls. However if we do have the possibility where the files themselves might be touched though it\u0027s mostly a truncate/replace action. We could try dropping the shared options but it currently doesn\u0027t appear to have any affect.","commit_id":"3d04ee3a92c0d204608ea2e796dc42e402ed6388"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"a43f08f8d99d129b6ac2ff5809c33ca283620ad2","unresolved":false,"context_lines":[{"line_number":419,"context_line":"                \u0027--volume\u0027, \u0027%s:/var/lib/config-data/:rw\u0027 % config_volume_prefix,"},{"line_number":420,"context_line":"                # facter caching"},{"line_number":421,"context_line":"                \u0027--volume\u0027, \u0027/var/lib/container-puppet/puppetlabs/facter.conf:/etc/puppetlabs/facter/facter.conf:ro\u0027,"},{"line_number":422,"context_line":"                \u0027--volume\u0027, \u0027/var/lib/container-puppet/puppetlabs/:/opt/puppetlabs/:shared\u0027,"},{"line_number":423,"context_line":"                # Syslog socket for puppet logs"},{"line_number":424,"context_line":"                \u0027--volume\u0027, \u0027/dev/log:/dev/log:rw\u0027]"},{"line_number":425,"context_line":"        if privileged:"}],"source_content_type":"text/x-python","patch_set":8,"id":"7faddb67_f470a40a","line":422,"in_reply_to":"7faddb67_e953ed37","updated":"2019-07-15 15:08:36.000000000","message":"but we have a setting that controls the level of parallelism for the container-puppet tool executed for the containers config step X. If we start a more than one of it at once (which is that we normally do, but temporarily disabled MP cuz of podman issues IIRC) for the first time those will generate the puppet facts cache simultaneously and corrupting its shared /opt storage, isn\u0027t it?","commit_id":"3d04ee3a92c0d204608ea2e796dc42e402ed6388"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"ca9a0b887828b3bfb7f04412423f84e3ed1e5ad1","unresolved":false,"context_lines":[{"line_number":419,"context_line":"                \u0027--volume\u0027, \u0027%s:/var/lib/config-data/:rw\u0027 % config_volume_prefix,"},{"line_number":420,"context_line":"                # facter caching"},{"line_number":421,"context_line":"                \u0027--volume\u0027, \u0027/var/lib/container-puppet/puppetlabs/facter.conf:/etc/puppetlabs/facter/facter.conf:ro\u0027,"},{"line_number":422,"context_line":"                \u0027--volume\u0027, \u0027/var/lib/container-puppet/puppetlabs/:/opt/puppetlabs/:shared\u0027,"},{"line_number":423,"context_line":"                # Syslog socket for puppet logs"},{"line_number":424,"context_line":"                \u0027--volume\u0027, \u0027/dev/log:/dev/log:rw\u0027]"},{"line_number":425,"context_line":"        if privileged:"}],"source_content_type":"text/x-python","patch_set":8,"id":"7faddb67_14b3009a","line":422,"in_reply_to":"7faddb67_f470a40a","updated":"2019-07-15 15:11:21.000000000","message":"shouldn\u0027t but i can try switching to :ro i guess","commit_id":"3d04ee3a92c0d204608ea2e796dc42e402ed6388"}],"common/deploy-steps-tasks.yaml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"d6cdef4836fc1cc96c3bdcea54cd35be78ac4bcd","unresolved":false,"context_lines":[{"line_number":427,"context_line":""},{"line_number":428,"context_line":"    - name: Create puppet caching structures"},{"line_number":429,"context_line":"      file:"},{"line_number":430,"context_line":"        path: /var/lib/container-puppet/puppetlabs"},{"line_number":431,"context_line":"        state: directory"},{"line_number":432,"context_line":"        setype: svirt_sandbox_file_t"},{"line_number":433,"context_line":"        selevel: s0"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7faddb67_f2123f58","line":430,"updated":"2019-07-10 08:52:21.000000000","message":"don\u0027t we need to purge that path later as well?","commit_id":"3d04ee3a92c0d204608ea2e796dc42e402ed6388"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"f46383f366429c95e0a46fd9f6a2847966dcce0a","unresolved":false,"context_lines":[{"line_number":427,"context_line":""},{"line_number":428,"context_line":"    - name: Create puppet caching structures"},{"line_number":429,"context_line":"      file:"},{"line_number":430,"context_line":"        path: /var/lib/container-puppet/puppetlabs"},{"line_number":431,"context_line":"        state: directory"},{"line_number":432,"context_line":"        setype: svirt_sandbox_file_t"},{"line_number":433,"context_line":"        selevel: s0"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7faddb67_78938dfb","line":430,"in_reply_to":"7faddb67_f2123f58","updated":"2019-07-10 14:27:16.000000000","message":"No, because we rsync over the results on L461. So we\u0027ll overwrite it with the newly generated facts each time.  /opt/puppetlabs/facter will contain freshly generated facts each iteration of the container-puppet.py execution. We copy them into /var/lib/container-puppet/puppetlabs which gets mounted into the containers after we generate the new facts (L455).","commit_id":"3d04ee3a92c0d204608ea2e796dc42e402ed6388"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"1096380925e3065ff7b576502e4177ebf40621f6","unresolved":false,"context_lines":[{"line_number":451,"context_line":"      tags:"},{"line_number":452,"context_line":"        - container_config"},{"line_number":453,"context_line":"        - container_config_tasks"},{"line_number":454,"context_line":"    - name: Cleanup facter cache if exists"},{"line_number":455,"context_line":"      file:"},{"line_number":456,"context_line":"        path: /opt/puppetlabs/facter"},{"line_number":457,"context_line":"        state: absent"},{"line_number":458,"context_line":"      ignore_errors: True"},{"line_number":459,"context_line":"      tags:"},{"line_number":460,"context_line":"        - container_config"},{"line_number":461,"context_line":"        - container_config_tasks"},{"line_number":462,"context_line":"    - name: Pre-cache facts"},{"line_number":463,"context_line":"      command: facter --config /var/lib/container-puppet/puppetlabs/facter.conf"},{"line_number":464,"context_line":"      no_log: True"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"7faddb67_d42b2892","line":461,"range":{"start_line":454,"start_character":0,"end_line":461,"end_character":32},"updated":"2019-07-15 15:15:43.000000000","message":"I moved this up to handle the case of a deployment failure would result in stale facts on subsequent runs","commit_id":"1254ebf5dc152f0101dd5001dc907ccfcff2d805"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"7e64a7aa0fd50099a0e28d62fced66dbcc476b27","unresolved":false,"context_lines":[{"line_number":460,"context_line":"        - container_config"},{"line_number":461,"context_line":"        - container_config_tasks"},{"line_number":462,"context_line":"    - name: Pre-cache facts"},{"line_number":463,"context_line":"      command: facter --config /var/lib/container-puppet/puppetlabs/facter.conf"},{"line_number":464,"context_line":"      no_log: True"},{"line_number":465,"context_line":"      ignore_errors: True"},{"line_number":466,"context_line":"      tags:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"7faddb67_612cf101","line":463,"updated":"2019-07-15 16:30:46.000000000","message":"The data gets populated up front out of the containers here.","commit_id":"1254ebf5dc152f0101dd5001dc907ccfcff2d805"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"7e64a7aa0fd50099a0e28d62fced66dbcc476b27","unresolved":false,"context_lines":[{"line_number":469,"context_line":"    - name: Sync cached facts"},{"line_number":470,"context_line":"      synchronize:"},{"line_number":471,"context_line":"        src: /opt/puppetlabs/"},{"line_number":472,"context_line":"        dest: /var/lib/container-puppet/puppetlabs/"},{"line_number":473,"context_line":"      delegate_to: \"{{ inventory_hostname }}\""},{"line_number":474,"context_line":"      tags:"},{"line_number":475,"context_line":"        - container_config"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"7faddb67_8131ed5c","line":472,"updated":"2019-07-15 16:30:46.000000000","message":"Then it\u0027s copied to the part that\u0027s mounted (now ro) into the containers","commit_id":"1254ebf5dc152f0101dd5001dc907ccfcff2d805"}],"common/deploy-steps.j2":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"fa6fa3a31809756c2e65b5cb221c4f023e3f0368","unresolved":false,"context_lines":[{"line_number":485,"context_line":"                          ttls: ["},{"line_number":486,"context_line":"                            { \"networking\" : 1 hour },"},{"line_number":487,"context_line":"                          ]"},{"line_number":488,"context_line":"                        }"},{"line_number":489,"context_line":"                - name: Write container-puppet.py"},{"line_number":490,"context_line":"                  no_log: True"},{"line_number":491,"context_line":"                  copy: src\u003ddocker_puppet_script.yaml dest\u003d/var/lib/container-puppet/container-puppet.py force\u003dyes mode\u003d0600"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"7faddb67_3bb6cbdb","line":488,"updated":"2019-07-04 01:09:39.000000000","message":"TODO: maybe preload puppet facts outside of the containers in a single puppet facts execution","commit_id":"240ad7502f4d3db95d464fc9adf041d1d9f8c170"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"1fc1ead0ae73f5a4dbbe1b128201babcd36c0a6a","unresolved":false,"context_lines":[{"line_number":499,"context_line":"                    no_log: True"},{"line_number":500,"context_line":"                    ignore_errors: True"},{"line_number":501,"context_line":"                  - name: Sync cached facts"},{"line_number":502,"context_line":"                    command: rsync -ar /opt/puppetlabs/ /var/lib/container-puppet/puppetlabs/"},{"line_number":503,"context_line":"                    no_log: True"},{"line_number":504,"context_line":"                - name: Write container-puppet.py"},{"line_number":505,"context_line":"                  no_log: True"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"7faddb67_83bbc6e3","line":502,"range":{"start_line":502,"start_character":20,"end_line":502,"end_character":27},"updated":"2019-07-04 15:29:51.000000000","message":"I guess it would be nice to use \"synchronize\" module","commit_id":"561f123c9c669f15d5607cc8e6c0b82db484686a"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"b909d6df87da9fe7b648b4e60e3a19e0c23ab6d1","unresolved":false,"context_lines":[{"line_number":499,"context_line":"                    no_log: True"},{"line_number":500,"context_line":"                    ignore_errors: True"},{"line_number":501,"context_line":"                  - name: Sync cached facts"},{"line_number":502,"context_line":"                    command: rsync -ar /opt/puppetlabs/ /var/lib/container-puppet/puppetlabs/"},{"line_number":503,"context_line":"                    no_log: True"},{"line_number":504,"context_line":"                - name: Write container-puppet.py"},{"line_number":505,"context_line":"                  no_log: True"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"7faddb67_332d5d95","line":502,"range":{"start_line":502,"start_character":20,"end_line":502,"end_character":27},"in_reply_to":"7faddb67_83bbc6e3","updated":"2019-07-08 16:41:59.000000000","message":"I looked at that one but wasn\u0027t sure if it would remove things from the destination. I\u0027ll have to test it out","commit_id":"561f123c9c669f15d5607cc8e6c0b82db484686a"}]}