)]}'
{"deployment/aodh/aodh-api-container-puppet.yaml":[{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"10ed850f43a585a990edfd1fed6ae8f3e17a62a6","unresolved":false,"context_lines":[{"line_number":240,"context_line":"          vars:"},{"line_number":241,"context_line":"            containers_to_rm:"},{"line_number":242,"context_line":"              - aodh_api"},{"line_number":243,"context_line":"      external_upgrade_tasks:"},{"line_number":244,"context_line":"        - when:"},{"line_number":245,"context_line":"            - step|int \u003d\u003d 1"},{"line_number":246,"context_line":"          tags:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7faddb67_c106a121","line":243,"updated":"2019-07-04 08:45:30.000000000","message":"The tasks are missing delegate_to -- this would be stopping the services on undercloud, not overcloud.","commit_id":"f46548252aefc46f30a65f34fe9a530f6d268e70"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"bbff0b372fc870bc8ca4e7629902211bf3f85f94","unresolved":false,"context_lines":[{"line_number":52,"context_line":"      e.g. { aodh-context_is_admin: { key: context_is_admin, value: \u0027role:admin\u0027 } }"},{"line_number":53,"context_line":"    default: {}"},{"line_number":54,"context_line":"    type: json"},{"line_number":55,"context_line":"  ContainerCli:"},{"line_number":56,"context_line":"    type: string"},{"line_number":57,"context_line":"    default: \u0027podman\u0027"},{"line_number":58,"context_line":"    description: CLI tool used to manage containers."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7faddb67_4114caa0","line":55,"updated":"2019-07-08 10:45:06.000000000","message":"I don\u0027t get why do we need to import the ContainerCli heat parameter in all the templates to be used in the external_upgrade_tasks if we are already doing it at playbook level with the \"container_cli\" parameter, you can see it in the job logs: http://logs.openstack.org/95/669095/7/check/tripleo-ci-centos-7-containerized-undercloud-upgrades/8463d79/logs/undercloud/home/zuul/undercloud-ansible-FfzuUs/external_upgrade_steps_playbook.yaml.txt.gz \nor in the code: https://github.com/openstack/tripleo-heat-templates/blob/master/common/deploy-steps.j2#L1175","commit_id":"d668b733f39c9abb8064fd60a63da24b0c6065f5"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"bbff0b372fc870bc8ca4e7629902211bf3f85f94","unresolved":false,"context_lines":[{"line_number":260,"context_line":"              import_role:"},{"line_number":261,"context_line":"                name: tripleo-container-stop"},{"line_number":262,"context_line":"              vars:"},{"line_number":263,"context_line":"                container_cli: {get_param: ContainerCli}"},{"line_number":264,"context_line":"                containers_to_stop:"},{"line_number":265,"context_line":"                  - aodh_api"},{"line_number":266,"context_line":"      fast_forward_upgrade_tasks:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7faddb67_c1275a12","line":263,"updated":"2019-07-08 10:45:06.000000000","message":"in line with the previous comment, if you do:\n\nvars:\n  container_cli: \"{{ container_cli }}\" \n\nshould work, shuoldn\u0027t it? Maybe changing the tripleo-container-stop role parameter \"container_cli\" to avoid confusion? As both, the playbook level and the role level one are named the same way.","commit_id":"d668b733f39c9abb8064fd60a63da24b0c6065f5"}],"deployment/database/mysql-pacemaker-puppet.yaml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"89352e9e976830b8709dab5d9d80832c71adea1d","unresolved":false,"context_lines":[{"line_number":586,"context_line":"        - vars:"},{"line_number":587,"context_line":"            mysql_upgrade_transfer: {get_param: MysqlUpgradeTransfer}"},{"line_number":588,"context_line":"          when:"},{"line_number":589,"context_line":"            - step|int \u003d\u003d 2"},{"line_number":590,"context_line":"            - mysql_upgrade_transfer"},{"line_number":591,"context_line":"          tags:"},{"line_number":592,"context_line":"            - never"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7faddb67_01a2799b","line":589,"updated":"2019-07-04 08:29:25.000000000","message":"the remnants use the step 1, mind please explaining this change in the commit msg?","commit_id":"f46548252aefc46f30a65f34fe9a530f6d268e70"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"2ed043db357af1130afe9351ff6237f1e21802aa","unresolved":false,"context_lines":[{"line_number":591,"context_line":"          tags:"},{"line_number":592,"context_line":"            - never"},{"line_number":593,"context_line":"            - system_upgrade_transfer_data"},{"line_number":594,"context_line":"            - system_upgrade_stop_services"},{"line_number":595,"context_line":"          block:"},{"line_number":596,"context_line":"            - name: Disable mysql"},{"line_number":597,"context_line":"              become: true"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7faddb67_685ea9e7","line":594,"range":{"start_line":594,"start_character":0,"end_line":594,"end_character":42},"updated":"2019-07-04 14:24:45.000000000","message":"I think we only want this tag on \"Disable mysql\" but not on \"Transfer mysql data\".","commit_id":"f46548252aefc46f30a65f34fe9a530f6d268e70"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"c3f6d0e8efcc042d336e2c3141ba9a0d874eea76","unresolved":false,"context_lines":[{"line_number":599,"context_line":"        - vars:"},{"line_number":600,"context_line":"            mysql_upgrade_transfer: {get_param: MysqlUpgradeTransfer}"},{"line_number":601,"context_line":"          when:"},{"line_number":602,"context_line":"            - step|int \u003d\u003d 2"},{"line_number":603,"context_line":"            - mysql_upgrade_transfer"},{"line_number":604,"context_line":"          tags:"},{"line_number":605,"context_line":"            - never"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7faddb67_adb105e4","line":602,"updated":"2019-07-05 13:10:18.000000000","message":"This could have an issue, if you execute \"external-upgrade --tags system_upgrade_transfer_data\" then we\u0027ll transfer the data without stopping the mysql sevice. Which could cause race conditions.","commit_id":"cb3d94216fdf847510c3fd0d8853ec462ccb3650"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"bbff0b372fc870bc8ca4e7629902211bf3f85f94","unresolved":false,"context_lines":[{"line_number":590,"context_line":"            - mysql_upgrade_transfer"},{"line_number":591,"context_line":"          tags:"},{"line_number":592,"context_line":"            - never"},{"line_number":593,"context_line":"            - system_upgrade_stop_services"},{"line_number":594,"context_line":"          block:"},{"line_number":595,"context_line":"            - name: Disable mysql"},{"line_number":596,"context_line":"              become: true"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7faddb67_4c1f216c","line":593,"updated":"2019-07-08 10:45:06.000000000","message":"I still don\u0027t understand why do we need to include an extra step to stop the services. What was the issue with using only one tag \"system_upgrade_transfer_data\" ? The way this is approached will imply stopping the services twice, iiuc:\n\n1- openstack overcloud external-upgrade run \\\n    --tags system_upgrade_stop_services \\\n    --limit ControllerOpenstack,Database,Messaging\n  \n This step will stop the services for all the controllers in which the service is running and the mysql service\n\n2- openstack overcloud external-upgrade run \\\n    --tags system_upgrade_transfer_data \\\n    --limit ControllerOpenstack,Database,Messaging\n\n This step will stop again all the services, as the rest of services contain both tags:\ntags:\n - never\n - system_upgrade_stop_services\n - system_upgrade_transfer_data\n\nand perform the database transfer for this service.\n\nWhy can\u0027t we have then only one tag for all the services?\n\ntags:\n - never\n - system_upgrade_transfer_data\n\nIs it to allow re-running the services stopping if anything went wrong?","commit_id":"d668b733f39c9abb8064fd60a63da24b0c6065f5"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"92cc852dc9443bef3b15eff9b22da3c0cebd0d88","unresolved":false,"context_lines":[{"line_number":590,"context_line":"            - mysql_upgrade_transfer"},{"line_number":591,"context_line":"          tags:"},{"line_number":592,"context_line":"            - never"},{"line_number":593,"context_line":"            - system_upgrade_stop_services"},{"line_number":594,"context_line":"          block:"},{"line_number":595,"context_line":"            - name: Disable mysql"},{"line_number":596,"context_line":"              become: true"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7faddb67_e7b146e3","line":593,"updated":"2019-07-08 11:27:08.000000000","message":"We should have both `system_upgrade_transfer_data` and `system_upgrade_stop_services` here i think. We want to make sure that when we run the data transfer, the services will get stopped, but we don\u0027t want this to apply vice versa.","commit_id":"08d1156fccc6c94d6f065e2be5a7699a0285ef1f"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"b852ec6a0015311eef6bd91533da76b577f3fb7f","unresolved":false,"context_lines":[{"line_number":590,"context_line":"            - mysql_upgrade_transfer"},{"line_number":591,"context_line":"          tags:"},{"line_number":592,"context_line":"            - never"},{"line_number":593,"context_line":"            - system_upgrade_stop_services"},{"line_number":594,"context_line":"          block:"},{"line_number":595,"context_line":"            - name: Disable mysql"},{"line_number":596,"context_line":"              become: true"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7faddb67_e7e626e9","line":593,"in_reply_to":"7faddb67_e7b146e3","updated":"2019-07-08 11:27:50.000000000","message":"(i didn\u0027t check the whole patch yet, will do so asap)","commit_id":"08d1156fccc6c94d6f065e2be5a7699a0285ef1f"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"1e5e625e4a8f818385388bcee0e94bebc77d2420","unresolved":false,"context_lines":[{"line_number":595,"context_line":"          block:"},{"line_number":596,"context_line":"            - name: Disable mysql"},{"line_number":597,"context_line":"              become: true"},{"line_number":598,"context_line":"              command: /usr/sbin/pcs resource disable galera-bundle --wait"},{"line_number":599,"context_line":"              delegate_to: \"{{hostvars[groups[\u0027overcloud\u0027][0]][\u0027mysql_short_node_names\u0027][1]}}\""},{"line_number":600,"context_line":"        - vars:"},{"line_number":601,"context_line":"            mysql_upgrade_transfer: {get_param: MysqlUpgradeTransfer}"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"7faddb67_6f040f4b","line":598,"range":{"start_line":598,"start_character":14,"end_line":598,"end_character":74},"updated":"2019-07-11 11:17:57.000000000","message":"Just putting here the comment from IRC: i think we should remove this galera stop, and stop the full pcmk cluster instead (in the pacemaker service yaml, not here). If we just stop galera and not the rest, we may still face issues of something trying to interconnect between the new and old servers i think.","commit_id":"caf2fc772ecf0221c97cde6e7744b6e0848e5bde"}],"deployment/database/redis-container-puppet.yaml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"89352e9e976830b8709dab5d9d80832c71adea1d","unresolved":false,"context_lines":[{"line_number":266,"context_line":"                      - - if:"},{"line_number":267,"context_line":"                            - internal_tls_enabled"},{"line_number":268,"context_line":"                            - - redis_tls_proxy"},{"line_number":269,"context_line":"                            - null"},{"line_number":270,"context_line":"      post_upgrade_tasks:"},{"line_number":271,"context_line":"        - when: step|int \u003d\u003d 1"},{"line_number":272,"context_line":"          import_role:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7faddb67_a193654f","line":269,"range":{"start_line":269,"start_character":30,"end_line":269,"end_character":34},"updated":"2019-07-04 08:29:25.000000000","message":"shouldn\u0027t this be [] to concat with?..","commit_id":"f46548252aefc46f30a65f34fe9a530f6d268e70"}],"deployment/iscsid/iscsid-container-puppet.yaml":[{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"8722c894e844e79c662ed7d782494365c38917d3","unresolved":false,"context_lines":[{"line_number":128,"context_line":"          vars:"},{"line_number":129,"context_line":"            containers_to_rm:"},{"line_number":130,"context_line":"              - iscsid"},{"line_number":131,"context_line":"      external_upgrade_tasks:"},{"line_number":132,"context_line":"        - when:"},{"line_number":133,"context_line":"            - step|int \u003d\u003d 1"},{"line_number":134,"context_line":"          tags:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7faddb67_c86c7d9e","line":131,"updated":"2019-07-04 14:25:16.000000000","message":"And i probably wouldn\u0027t stop this one either.","commit_id":"f46548252aefc46f30a65f34fe9a530f6d268e70"}],"deployment/neutron/neutron-l3-container-puppet.yaml":[{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"10ed850f43a585a990edfd1fed6ae8f3e17a62a6","unresolved":false,"context_lines":[{"line_number":399,"context_line":"              vars:"},{"line_number":400,"context_line":"                container_cli: {get_param: ContainerCli}"},{"line_number":401,"context_line":"                containers_to_stop:"},{"line_number":402,"context_line":"                  - neutron_l3_agent"},{"line_number":403,"context_line":"      fast_forward_upgrade_tasks:"},{"line_number":404,"context_line":"        - when:"},{"line_number":405,"context_line":"            - step|int \u003d\u003d 0"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7faddb67_e17cfdb6","line":402,"updated":"2019-07-04 08:45:30.000000000","message":"We want to keep the Neutron agents running i think. I\u0027m not sure if all of them, but at least L3 and OVS agent. I\u0027d keep all of them running unless/until we discover we shouldn\u0027t. In other words, for now i\u0027d only stop Neutron API.","commit_id":"f46548252aefc46f30a65f34fe9a530f6d268e70"}],"deployment/swift/swift-storage-container-puppet.yaml":[{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"2ed043db357af1130afe9351ff6237f1e21802aa","unresolved":false,"context_lines":[{"line_number":677,"context_line":"              - swift_object_server"},{"line_number":678,"context_line":"              - swift_object_updater"},{"line_number":679,"context_line":"              - swift_rsync"},{"line_number":680,"context_line":"      external_upgrade_tasks:"},{"line_number":681,"context_line":"        - when:"},{"line_number":682,"context_line":"            - step|int \u003d\u003d 1"},{"line_number":683,"context_line":"          tags:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7faddb67_28d99182","line":680,"updated":"2019-07-04 14:24:45.000000000","message":"We probably shouldn\u0027t stop these, Swift should be able to continue working in a mixed-version manner, so the services will be stopped only when we take the particular node for OS upgrade.","commit_id":"f46548252aefc46f30a65f34fe9a530f6d268e70"}]}