)]}'
{"common/container-puppet.py":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"7c117bf393966fc94342ad586b5bf5a8323cd55e","unresolved":false,"context_lines":[{"line_number":342,"context_line":"            # Also make a copy of files modified during puppet run"},{"line_number":343,"context_line":"            echo \"Gathering files modified after $(stat -c \u0027%y\u0027 $origin_of_time)\""},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"            # Purge obsoleted contents to maintain a fresh and filtered mirror"},{"line_number":346,"context_line":"            # Protect from purging all of the generated configs,"},{"line_number":347,"context_line":"            # if cempty onfig_volume produced an empty name"},{"line_number":348,"context_line":"            rm -rf /var/lib/config-data/puppet-generated/${NAME:-ignore_me}"},{"line_number":349,"context_line":"            mkdir -p /var/lib/config-data/puppet-generated/${NAME}"},{"line_number":350,"context_line":"            rsync -a -R -0 --delay-updates --delete-after --delete $exclude_files \\"},{"line_number":351,"context_line":"                          --files-from\u003d\u003c(find $rsync_srcs -newer $origin_of_time -not -path \u0027/etc/puppet*\u0027 -print0) \\"}],"source_content_type":"text/x-python","patch_set":13,"id":"7faddb67_e7a103ab","line":348,"range":{"start_line":345,"start_character":12,"end_line":348,"end_character":75},"updated":"2019-07-11 13:58:58.000000000","message":"this seems also removes more than the framework expects :/\n\nmy local testing shows kolla bootstrap now fails on missing *.so files for keystone container","commit_id":"e431af99cc9c6620bcffb2214fae4aceca16c2ca"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"9819214dd4b685318a8715d16b11eadaa91aa1b0","unresolved":false,"context_lines":[{"line_number":274,"context_line":"        cp -dR /tmp/puppet-etc/* /etc/puppet"},{"line_number":275,"context_line":"        rm -Rf /etc/puppet/ssl # not in use and causes permission errors"},{"line_number":276,"context_line":"        echo \"{\\\\\"step\\\\\": $STEP}\" \u003e /etc/puppet/hieradata/docker_puppet.json"},{"line_number":277,"context_line":"        TAGS\u003d\"--skip_tags service\""},{"line_number":278,"context_line":"        if [ -n \"$PUPPET_TAGS\" ]; then"},{"line_number":279,"context_line":"            TAGS\u003d\"--tags \\\"$PUPPET_TAGS\\\" ${TAGS}\""},{"line_number":280,"context_line":"        fi"}],"source_content_type":"text/x-python","patch_set":16,"id":"7faddb67_d0cfbb53","line":277,"updated":"2019-07-15 08:10:19.000000000","message":"not sure if it works at all. There are \"Notice: /Stage[main]/Apache::Service/Service[httpd]: Triggered \u0027refresh\u0027\" messages logged for my dev env","commit_id":"b8ef44b64b00e8595a98f47f45a62844b8dd99b2"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"481d7db40ba0d99c5be845a6c0b8db71c0f0cd7c","unresolved":false,"context_lines":[{"line_number":274,"context_line":"        cp -dR /tmp/puppet-etc/* /etc/puppet"},{"line_number":275,"context_line":"        rm -Rf /etc/puppet/ssl # not in use and causes permission errors"},{"line_number":276,"context_line":"        echo \"{\\\\\"step\\\\\": $STEP}\" \u003e /etc/puppet/hieradata/docker_puppet.json"},{"line_number":277,"context_line":"        TAGS\u003d\"--skip_tags service\""},{"line_number":278,"context_line":"        if [ -n \"$PUPPET_TAGS\" ]; then"},{"line_number":279,"context_line":"            TAGS\u003d\"--tags \\\"$PUPPET_TAGS\\\" ${TAGS}\""},{"line_number":280,"context_line":"        fi"}],"source_content_type":"text/x-python","patch_set":16,"id":"7faddb67_302deffd","line":277,"in_reply_to":"7faddb67_d0cfbb53","updated":"2019-07-15 08:12:32.000000000","message":"nevermind, it skips the service[\u0027httpd\u0027] with this change.\nThe problem is this also skips more than expected - some keystone foo@service resources","commit_id":"b8ef44b64b00e8595a98f47f45a62844b8dd99b2"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"5f0db83360ed7d9d91eba82ab30547c37ac9c6c4","unresolved":false,"context_lines":[{"line_number":419,"context_line":""},{"line_number":420,"context_line":"    with tempfile.NamedTemporaryFile() as tmp_man:"},{"line_number":421,"context_line":"        with open(tmp_man.name, \u0027w\u0027) as man_file:"},{"line_number":422,"context_line":"            man_file.write(\u0027include ::tripleo::packages\\n\u0027)"},{"line_number":423,"context_line":"            man_file.write(manifest)"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"        uname \u003d RUNNER.unique_container_name(\u0027container-puppet-%s\u0027 %"}],"source_content_type":"text/x-python","patch_set":22,"id":"7faddb67_6286fabb","line":422,"updated":"2019-07-18 14:27:27.000000000","message":"I\u0027m wondering if we should noop_resource(\u0027service\u0027) here as a global. Is there ever a reason for us to use the service resource in container generation? I don\u0027t think we use systemd anywhere so I don\u0027t think it\u0027d work","commit_id":"06214e299ed62afa83ef47b79e1c94c3ef61c856"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"d88bb615920bb9f42d2224d768ae6ff012efb311","unresolved":false,"context_lines":[{"line_number":419,"context_line":""},{"line_number":420,"context_line":"    with tempfile.NamedTemporaryFile() as tmp_man:"},{"line_number":421,"context_line":"        with open(tmp_man.name, \u0027w\u0027) as man_file:"},{"line_number":422,"context_line":"            man_file.write(\u0027include ::tripleo::packages\\n\u0027)"},{"line_number":423,"context_line":"            man_file.write(manifest)"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"        uname \u003d RUNNER.unique_container_name(\u0027container-puppet-%s\u0027 %"}],"source_content_type":"text/x-python","patch_set":22,"id":"7faddb67_3610364e","line":422,"in_reply_to":"7faddb67_53b6248c","updated":"2019-07-19 13:33:16.000000000","message":"ugh... meant the step #1","commit_id":"06214e299ed62afa83ef47b79e1c94c3ef61c856"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"5adeb162d8daa51e9078b9b5e64c05f33863ed1f","unresolved":false,"context_lines":[{"line_number":419,"context_line":""},{"line_number":420,"context_line":"    with tempfile.NamedTemporaryFile() as tmp_man:"},{"line_number":421,"context_line":"        with open(tmp_man.name, \u0027w\u0027) as man_file:"},{"line_number":422,"context_line":"            man_file.write(\u0027include ::tripleo::packages\\n\u0027)"},{"line_number":423,"context_line":"            man_file.write(manifest)"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"        uname \u003d RUNNER.unique_container_name(\u0027container-puppet-%s\u0027 %"}],"source_content_type":"text/x-python","patch_set":22,"id":"7faddb67_f3d390ff","line":422,"in_reply_to":"7faddb67_6286fabb","updated":"2019-07-19 13:12:34.000000000","message":"Done","commit_id":"06214e299ed62afa83ef47b79e1c94c3ef61c856"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"fef6c0a7f6c6409c5e72296c62787bde9bc6fc7b","unresolved":false,"context_lines":[{"line_number":419,"context_line":""},{"line_number":420,"context_line":"    with tempfile.NamedTemporaryFile() as tmp_man:"},{"line_number":421,"context_line":"        with open(tmp_man.name, \u0027w\u0027) as man_file:"},{"line_number":422,"context_line":"            man_file.write(\u0027include ::tripleo::packages\\n\u0027)"},{"line_number":423,"context_line":"            man_file.write(manifest)"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"        uname \u003d RUNNER.unique_container_name(\u0027container-puppet-%s\u0027 %"}],"source_content_type":"text/x-python","patch_set":22,"id":"7faddb67_6510444f","line":422,"in_reply_to":"7faddb67_6286fabb","updated":"2019-07-18 14:35:19.000000000","message":"I tried that earlier, that didn\u0027t take any effekt for some reason... I will try it again, with the most recent revision.","commit_id":"06214e299ed62afa83ef47b79e1c94c3ef61c856"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"48786e538200f9e085e2c5b86747c5bc5efc09fd","unresolved":false,"context_lines":[{"line_number":419,"context_line":""},{"line_number":420,"context_line":"    with tempfile.NamedTemporaryFile() as tmp_man:"},{"line_number":421,"context_line":"        with open(tmp_man.name, \u0027w\u0027) as man_file:"},{"line_number":422,"context_line":"            man_file.write(\u0027include ::tripleo::packages\\n\u0027)"},{"line_number":423,"context_line":"            man_file.write(manifest)"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"        uname \u003d RUNNER.unique_container_name(\u0027container-puppet-%s\u0027 %"}],"source_content_type":"text/x-python","patch_set":22,"id":"7faddb67_53b6248c","line":422,"in_reply_to":"7faddb67_f3d390ff","updated":"2019-07-19 13:26:09.000000000","message":"@Alex, let\u0027s see what CI shows for that. My local testing shows a suspicious Error: Function lookup() did not find a value for the name \u0027service_names\u0027 for container-puppet-neutron at step 6","commit_id":"06214e299ed62afa83ef47b79e1c94c3ef61c856"},{"author":{"_account_id":20778,"name":"Damien Ciabrini","email":"dciabrin@redhat.com","username":"dciabrin"},"change_message_id":"774abd5ee3d138d9fcee92d636d73e0fe7de7a9a","unresolved":false,"context_lines":[{"line_number":373,"context_line":"            puppet_generated_path\u003d/var/lib/config-data/puppet-generated/${NAME}"},{"line_number":374,"context_line":"            mkdir -p ${puppet_generated_path}"},{"line_number":375,"context_line":"            echo \"Ensuring the removed config files are also purged in ${puppet_generated_path}:\""},{"line_number":376,"context_line":"            cat /tmp/files_to_purge | sort"},{"line_number":377,"context_line":"            cat /tmp/files_to_purge | xargs -n1 -r -I{} \\"},{"line_number":378,"context_line":"                bash -c \"test -f ${puppet_generated_path}/{} \u0026\u0026 rm -f ${puppet_generated_path}/{}\""},{"line_number":379,"context_line":"            exec 5\u003e\u00261"}],"source_content_type":"text/x-python","patch_set":24,"id":"7faddb67_de5b7e84","line":376,"updated":"2019-07-29 11:51:43.000000000","message":"this line is probably a leftover?","commit_id":"3408241174d5da019fc9f950d569ecc9e564d489"},{"author":{"_account_id":20778,"name":"Damien Ciabrini","email":"dciabrin@redhat.com","username":"dciabrin"},"change_message_id":"4f5977b8e4cb97e93721107d7db5b65c358ebe97","unresolved":false,"context_lines":[{"line_number":373,"context_line":"            puppet_generated_path\u003d/var/lib/config-data/puppet-generated/${NAME}"},{"line_number":374,"context_line":"            mkdir -p ${puppet_generated_path}"},{"line_number":375,"context_line":"            echo \"Ensuring the removed config files are also purged in ${puppet_generated_path}:\""},{"line_number":376,"context_line":"            cat /tmp/files_to_purge | sort"},{"line_number":377,"context_line":"            cat /tmp/files_to_purge | xargs -n1 -r -I{} \\"},{"line_number":378,"context_line":"                bash -c \"test -f ${puppet_generated_path}/{} \u0026\u0026 rm -f ${puppet_generated_path}/{}\""},{"line_number":379,"context_line":"            exec 5\u003e\u00261"}],"source_content_type":"text/x-python","patch_set":24,"id":"7faddb67_9e7666d8","line":376,"in_reply_to":"7faddb67_1e9596e4","updated":"2019-07-29 12:02:09.000000000","message":"oh I see, ack","commit_id":"3408241174d5da019fc9f950d569ecc9e564d489"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"9b079779a9b76d301ca152dadf6f1b294b4e789f","unresolved":false,"context_lines":[{"line_number":373,"context_line":"            puppet_generated_path\u003d/var/lib/config-data/puppet-generated/${NAME}"},{"line_number":374,"context_line":"            mkdir -p ${puppet_generated_path}"},{"line_number":375,"context_line":"            echo \"Ensuring the removed config files are also purged in ${puppet_generated_path}:\""},{"line_number":376,"context_line":"            cat /tmp/files_to_purge | sort"},{"line_number":377,"context_line":"            cat /tmp/files_to_purge | xargs -n1 -r -I{} \\"},{"line_number":378,"context_line":"                bash -c \"test -f ${puppet_generated_path}/{} \u0026\u0026 rm -f ${puppet_generated_path}/{}\""},{"line_number":379,"context_line":"            exec 5\u003e\u00261"}],"source_content_type":"text/x-python","patch_set":24,"id":"7faddb67_1e9596e4","line":376,"in_reply_to":"7faddb67_de5b7e84","updated":"2019-07-29 11:57:57.000000000","message":"that was intended for the debug purposes and have it sorted for niceness","commit_id":"3408241174d5da019fc9f950d569ecc9e564d489"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"86443eb3130041796aefaee4229c3444354b0fa0","unresolved":false,"context_lines":[{"line_number":358,"context_line":"                fi"},{"line_number":359,"context_line":"            done"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"            echo \"Evaluating config files to be removed for the $NAME configuration\""},{"line_number":362,"context_line":"            rsync -av -R --dry-run --delete-after $exclude_files $rsync_srcs ${conf_data_path} |\\"},{"line_number":363,"context_line":"                awk \u0027/^deleting/ {print $2}\u0027 \u003e /tmp/files_to_purge"},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"            echo \"Rsyncing config files from ${rsync_srcs} into ${conf_data_path}\""},{"line_number":366,"context_line":"            rsync -a $verbosity -R --delay-updates --delete-after $exclude_files $rsync_srcs ${conf_data_path}"},{"line_number":367,"context_line":""},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"            # Also make a copy of files modified during puppet run"},{"line_number":370,"context_line":"            echo \"Gathering files modified after $(stat -c \u0027%y\u0027 $origin_of_time)\""},{"line_number":371,"context_line":""},{"line_number":372,"context_line":"            # Purge obsoleted contents to maintain a fresh and filtered mirror"},{"line_number":373,"context_line":"            puppet_generated_path\u003d/var/lib/config-data/puppet-generated/${NAME}"},{"line_number":374,"context_line":"            mkdir -p ${puppet_generated_path}"},{"line_number":375,"context_line":"            echo \"Ensuring the removed config files are also purged in ${puppet_generated_path}:\""},{"line_number":376,"context_line":"            cat /tmp/files_to_purge | sort"},{"line_number":377,"context_line":"            cat /tmp/files_to_purge | xargs -n1 -r -I{} \\"},{"line_number":378,"context_line":"                bash -c \"test -f ${puppet_generated_path}/{} \u0026\u0026 rm -f ${puppet_generated_path}/{}\""},{"line_number":379,"context_line":"            exec 5\u003e\u00261"},{"line_number":380,"context_line":"            exec 1\u003e/tmp/files_from"},{"line_number":381,"context_line":"            find $rsync_srcs -newer $origin_of_time -not -path \u0027/etc/puppet*\u0027 -print0"}],"source_content_type":"text/x-python","patch_set":24,"id":"7faddb67_a03bfcc5","line":378,"range":{"start_line":361,"start_character":0,"end_line":378,"end_character":98},"updated":"2019-07-29 12:13:29.000000000","message":"I think we don\u0027t need that complexity, and unsafe /tmp/foo | xargs pipes. rm -rf just works as well","commit_id":"3408241174d5da019fc9f950d569ecc9e564d489"}],"deployment/aodh/aodh-api-container-puppet.yaml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"24ab20b3cf46297448ac88a8cde60c4892049c3e","unresolved":false,"context_lines":[{"line_number":137,"context_line":"      puppet_config:"},{"line_number":138,"context_line":"        config_volume: aodh"},{"line_number":139,"context_line":"        # NOTE(bogdando): puppetlabs-apache uses exec to ensure the modules config dir"},{"line_number":140,"context_line":"        puppet_tags: aodh_api_paste_ini,aodh_config,exec"},{"line_number":141,"context_line":"        step_config:"},{"line_number":142,"context_line":"          list_join:"},{"line_number":143,"context_line":"            - \"\\n\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7faddb67_75f09d91","line":140,"updated":"2019-07-08 15:45:37.000000000","message":"or shall I hack this into puppet-tripleo apache profile to create /etc/httpd/conf.modules.d instead of making those execs all around invoked via the original apache module?","commit_id":"f2fb42315de93b82349a80d506d5bc012a5e9439"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"9b6e83a98bf5874ba759c084c1e87a5d5028a672","unresolved":false,"context_lines":[{"line_number":137,"context_line":"      puppet_config:"},{"line_number":138,"context_line":"        config_volume: aodh"},{"line_number":139,"context_line":"        # NOTE(bogdando): puppetlabs-apache uses exec to ensure the modules config dir"},{"line_number":140,"context_line":"        puppet_tags: aodh_api_paste_ini,aodh_config,exec"},{"line_number":141,"context_line":"        step_config:"},{"line_number":142,"context_line":"          list_join:"},{"line_number":143,"context_line":"            - \"\\n\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7faddb67_5521e1fa","line":140,"in_reply_to":"7faddb67_75f09d91","updated":"2019-07-08 15:48:03.000000000","message":"I mean there might be also not so much \"container friendly\" unrelated execs elsewhere. Would it be safe to add the exec tag then?","commit_id":"f2fb42315de93b82349a80d506d5bc012a5e9439"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"bf669839abb23275ea6b5d36d3bdbbe8476ef189","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        step_config:"},{"line_number":141,"context_line":"          list_join:"},{"line_number":142,"context_line":"            - \"\\n\""},{"line_number":143,"context_line":"            - - \"include tripleo::profile::base::apache\""},{"line_number":144,"context_line":"              - \"include tripleo::profile::base::aodh::api\""},{"line_number":145,"context_line":"              - {get_attr: [MySQLClient, role_data, step_config]}"},{"line_number":146,"context_line":"        config_image: {get_param: ContainerAodhConfigImage}"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"7faddb67_fa5466cc","line":143,"updated":"2019-07-09 15:20:09.000000000","message":"I want to check these just dumb simple, w/o complicated if{...} logic, like it is defined for this particular case in puppet-tripleo https://opendev.org/openstack/puppet-tripleo/src/branch/master/manifests/profile/base/aodh/api.pp#L82","commit_id":"e9a65b00d9faf11c13a0c952ca2eceba0cea8f46"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"5efb7bfa5c20af234e257e3b34c722d977575894","unresolved":false,"context_lines":[{"line_number":224,"context_line":"        step_3:"},{"line_number":225,"context_line":"          config_volume: \u0027aodh\u0027"},{"line_number":226,"context_line":"          step_config: |"},{"line_number":227,"context_line":"            noop_resource(\u0027service\u0027)"},{"line_number":228,"context_line":"            include ::tripleo::profile::base::apache"},{"line_number":229,"context_line":"          config_image: *aodh_config_image"},{"line_number":230,"context_line":"      host_prep_tasks:"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"7faddb67_9825ac0b","line":227,"updated":"2019-07-18 13:56:56.000000000","message":"This likely should be a global thing? Were the services getting triggered via the tags?","commit_id":"06214e299ed62afa83ef47b79e1c94c3ef61c856"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"467bcc305499410f720b311c84270365434537b3","unresolved":false,"context_lines":[{"line_number":224,"context_line":"        step_3:"},{"line_number":225,"context_line":"          config_volume: \u0027aodh\u0027"},{"line_number":226,"context_line":"          step_config: |"},{"line_number":227,"context_line":"            noop_resource(\u0027service\u0027)"},{"line_number":228,"context_line":"            include ::tripleo::profile::base::apache"},{"line_number":229,"context_line":"          config_image: *aodh_config_image"},{"line_number":230,"context_line":"      host_prep_tasks:"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"7faddb67_22a6c2ac","line":227,"in_reply_to":"7faddb67_9825ac0b","updated":"2019-07-18 14:23:00.000000000","message":"I tried that hard to make it global, with --skip_tags and noop_resource(), but there was problems with keystone provider resources named foo@service being skipped as well.\n\nSee CI jobs for the earlier revisions http://logs.openstack.org/78/669178/16/check/tripleo-ci-fedora-28-standalone/9595b54/logs/undercloud/var/log/extra/podman/containers/container-puppet-keystone_init_tasks/stdout.log.txt.gz\n\nTrying to solve this for the container-puppet.py centrally failed hard as well. So puppet_config steps did not play nicely for me, when I added the global tag apache alongside --skip_tags service. Nor noop_resource worked at all for my local testing of the container-puppet.py central approach.\n\nThis revision is the only working version I ended up with after the week of pain :)","commit_id":"06214e299ed62afa83ef47b79e1c94c3ef61c856"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"c91a5334fe4a2673f70f6f15827246aad341533d","unresolved":false,"context_lines":[{"line_number":224,"context_line":"        step_3:"},{"line_number":225,"context_line":"          config_volume: \u0027aodh\u0027"},{"line_number":226,"context_line":"          step_config: |"},{"line_number":227,"context_line":"            noop_resource(\u0027service\u0027)"},{"line_number":228,"context_line":"            include ::tripleo::profile::base::apache"},{"line_number":229,"context_line":"          config_image: *aodh_config_image"},{"line_number":230,"context_line":"      host_prep_tasks:"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"7faddb67_62535a6c","line":227,"in_reply_to":"7faddb67_9825ac0b","updated":"2019-07-18 14:24:45.000000000","message":"but once you\u0027re asking, that\u0027s puppetlabs apache module that triggers Service[httpd] actions","commit_id":"06214e299ed62afa83ef47b79e1c94c3ef61c856"},{"author":{"_account_id":20778,"name":"Damien Ciabrini","email":"dciabrin@redhat.com","username":"dciabrin"},"change_message_id":"774abd5ee3d138d9fcee92d636d73e0fe7de7a9a","unresolved":false,"context_lines":[{"line_number":205,"context_line":"                -"},{"line_number":206,"context_line":"                  - /var/lib/kolla/config_files/aodh_api.json:/var/lib/kolla/config_files/config.json:ro"},{"line_number":207,"context_line":"                  - /var/lib/config-data/puppet-generated/aodh/:/var/lib/kolla/config_files/src:ro"},{"line_number":208,"context_line":"                  - /var/lib/config-data/aodh/etc/httpd/:/var/lib/kolla/config_files/etc/httpd/:ro"},{"line_number":209,"context_line":"                  - /var/log/containers/aodh:/var/log/aodh"},{"line_number":210,"context_line":"                  - /var/log/containers/httpd/aodh-api:/var/log/httpd"},{"line_number":211,"context_line":"                  -"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"7faddb67_fe851ad0","line":208,"updated":"2019-07-29 11:51:43.000000000","message":"I think we want to bind-mount /var/lib/config-data/puppet-generated instead","commit_id":"3408241174d5da019fc9f950d569ecc9e564d489"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"a73f7404751d953c048a5bb8edbf0a3726f69ecb","unresolved":false,"context_lines":[{"line_number":205,"context_line":"                -"},{"line_number":206,"context_line":"                  - /var/lib/kolla/config_files/aodh_api.json:/var/lib/kolla/config_files/config.json:ro"},{"line_number":207,"context_line":"                  - /var/lib/config-data/puppet-generated/aodh/:/var/lib/kolla/config_files/src:ro"},{"line_number":208,"context_line":"                  - /var/lib/config-data/aodh/etc/httpd/:/var/lib/kolla/config_files/etc/httpd/:ro"},{"line_number":209,"context_line":"                  - /var/log/containers/aodh:/var/log/aodh"},{"line_number":210,"context_line":"                  - /var/log/containers/httpd/aodh-api:/var/log/httpd"},{"line_number":211,"context_line":"                  -"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"7faddb67_46e6e046","line":208,"in_reply_to":"7faddb67_5e922ef8","updated":"2019-07-29 14:13:02.000000000","message":"apparently, we cannot. See 2019-07-29 12:59:24 |     \"stderr: Error: error checking path \\\"/var/lib/config-data/puppet-generated/glance_api/etc/httpd/\\\": stat /var/lib/config-data/puppet-generated/glance_api/etc/httpd/: no such file or directory\",  in the CI job logs.\n\nThose puppet-generated/foo vs foo provide really poor experience and hard to follow. So I would prefer to leave this the way it works (c) ;(","commit_id":"3408241174d5da019fc9f950d569ecc9e564d489"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"9b079779a9b76d301ca152dadf6f1b294b4e789f","unresolved":false,"context_lines":[{"line_number":205,"context_line":"                -"},{"line_number":206,"context_line":"                  - /var/lib/kolla/config_files/aodh_api.json:/var/lib/kolla/config_files/config.json:ro"},{"line_number":207,"context_line":"                  - /var/lib/config-data/puppet-generated/aodh/:/var/lib/kolla/config_files/src:ro"},{"line_number":208,"context_line":"                  - /var/lib/config-data/aodh/etc/httpd/:/var/lib/kolla/config_files/etc/httpd/:ro"},{"line_number":209,"context_line":"                  - /var/log/containers/aodh:/var/log/aodh"},{"line_number":210,"context_line":"                  - /var/log/containers/httpd/aodh-api:/var/log/httpd"},{"line_number":211,"context_line":"                  -"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"7faddb67_5e922ef8","line":208,"in_reply_to":"7faddb67_fe851ad0","updated":"2019-07-29 11:57:57.000000000","message":"originally, where was a \"disconnect\" for those paths, which is also a subject of this patch fixes. I think you\u0027re right, and we could safely switch it now that it seems get fixed.\nLet\u0027s see.","commit_id":"3408241174d5da019fc9f950d569ecc9e564d489"}],"deployment/keystone/keystone-container-puppet.yaml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"23441472fddd9aa2b0d1e4da327884c07bf31af9","unresolved":false,"context_lines":[{"line_number":731,"context_line":"              test: /openstack/healthcheck"},{"line_number":732,"context_line":"            volumes:"},{"line_number":733,"context_line":"              list_concat:"},{"line_number":734,"context_line":"                - *keystone_volumes"},{"line_number":735,"context_line":"                - /var/lib/config-data/keystone/etc/httpd/conf.modules.d/:/var/lib/kolla/config_files/etc/httpd/conf.modules.d/:ro"},{"line_number":736,"context_line":"            environment:"},{"line_number":737,"context_line":"              - KOLLA_CONFIG_STRATEGY\u003dCOPY_ALWAYS"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7faddb67_84d157d0","line":734,"updated":"2019-07-09 14:19:06.000000000","message":"doesn\u0027t work that way :(","commit_id":"e18287a4eda108c3a24a022a5edf675c94da3103"}]}