)]}'
{"deployment/nova/nova-api-container-puppet.yaml":[{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"4ca000b574daa1f13b2e52b8aee37b9a2e5a57e6","unresolved":false,"context_lines":[{"line_number":435,"context_line":"          tags:"},{"line_number":436,"context_line":"            - opendev-validation"},{"line_number":437,"context_line":"            - opensdev-validation-nova"},{"line_number":438,"context_line":"          command: \"{{ container_cli }} exec nova-api /openstack/healthcheck\""},{"line_number":439,"context_line":"      host_prep_tasks: {get_attr: [NovaApiLogging, host_prep_tasks]}"},{"line_number":440,"context_line":"      upgrade_tasks:"},{"line_number":441,"context_line":"        - when: step|int \u003d\u003d 0"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7faddb67_2c4d0572","line":438,"range":{"start_line":438,"start_character":49,"end_line":438,"end_character":50},"updated":"2019-07-08 09:37:36.000000000","message":"_ instead of -","commit_id":"73bd5859b51b0e88f4d3b2a0bbe9ed13b2c8276c"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"256ace44666f7f011dfdffb16c5da2ff3cd554ce","unresolved":false,"context_lines":[{"line_number":434,"context_line":"          when: step|int \u003d\u003d 5"},{"line_number":435,"context_line":"          tags:"},{"line_number":436,"context_line":"            - opendev-validation"},{"line_number":437,"context_line":"            - opensdev-validation-nova"},{"line_number":438,"context_line":"          command: \"{{ container_cli }} exec nova_api /openstack/healthcheck\""},{"line_number":439,"context_line":"      host_prep_tasks: {get_attr: [NovaApiLogging, host_prep_tasks]}"},{"line_number":440,"context_line":"      upgrade_tasks:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_0cefe984","line":437,"range":{"start_line":437,"start_character":18,"end_line":437,"end_character":19},"updated":"2019-07-08 10:25:42.000000000","message":"typo?","commit_id":"c02027344ffbc2562c296a0d76aedc0092a48546"}],"deployment/nova/nova-compute-container-puppet.yaml":[{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"4ca000b574daa1f13b2e52b8aee37b9a2e5a57e6","unresolved":false,"context_lines":[{"line_number":743,"context_line":"          tags:"},{"line_number":744,"context_line":"            - opendev-validation"},{"line_number":745,"context_line":"            - opensdev-validation-nova"},{"line_number":746,"context_line":"          command: \"{{ container_cli }} exec nova-compute /openstack/healthcheck\""},{"line_number":747,"context_line":"      host_prep_tasks:"},{"line_number":748,"context_line":"        list_concat:"},{"line_number":749,"context_line":"        - {get_attr: [NovaLogging, host_prep_tasks]}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7faddb67_6c4a1d56","line":746,"range":{"start_line":746,"start_character":49,"end_line":746,"end_character":50},"updated":"2019-07-08 09:37:36.000000000","message":"_ instead of -","commit_id":"73bd5859b51b0e88f4d3b2a0bbe9ed13b2c8276c"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"256ace44666f7f011dfdffb16c5da2ff3cd554ce","unresolved":false,"context_lines":[{"line_number":742,"context_line":"          when: step|int \u003d\u003d 5"},{"line_number":743,"context_line":"          tags:"},{"line_number":744,"context_line":"            - opendev-validation"},{"line_number":745,"context_line":"            - opensdev-validation-nova"},{"line_number":746,"context_line":"          command: \"{{ container_cli }} exec nova_compute /openstack/healthcheck\""},{"line_number":747,"context_line":"      host_prep_tasks:"},{"line_number":748,"context_line":"        list_concat:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_ac033542","line":745,"range":{"start_line":745,"start_character":18,"end_line":745,"end_character":19},"updated":"2019-07-08 10:25:42.000000000","message":"here too?","commit_id":"c02027344ffbc2562c296a0d76aedc0092a48546"}],"deployment/nova/nova-conductor-container-puppet.yaml":[{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"4ca000b574daa1f13b2e52b8aee37b9a2e5a57e6","unresolved":false,"context_lines":[{"line_number":197,"context_line":"          tags:"},{"line_number":198,"context_line":"            - opendev-validation"},{"line_number":199,"context_line":"            - opendev-validation-nova"},{"line_number":200,"context_line":"          command: \"{{ container_cli }} exec nova-conductor /openstack/healthcheck\""},{"line_number":201,"context_line":"      host_prep_tasks:"},{"line_number":202,"context_line":"        list_concat:"},{"line_number":203,"context_line":"          - {get_attr: [NovaLogging, host_prep_tasks]}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7faddb67_8c47594c","line":200,"range":{"start_line":200,"start_character":49,"end_line":200,"end_character":50},"updated":"2019-07-08 09:37:36.000000000","message":"_ instead of -","commit_id":"73bd5859b51b0e88f4d3b2a0bbe9ed13b2c8276c"}],"deployment/nova/nova-metadata-container-puppet.yaml":[{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"4ca000b574daa1f13b2e52b8aee37b9a2e5a57e6","unresolved":false,"context_lines":[{"line_number":259,"context_line":"          tags:"},{"line_number":260,"context_line":"            - opendev-validation"},{"line_number":261,"context_line":"            - opensdev-validation-nova"},{"line_number":262,"context_line":"          command: \"{{ container_cli }} exec nova-metadata /openstack/healthcheck\""},{"line_number":263,"context_line":"      host_prep_tasks: {get_attr: [NovaMetadataLogging, host_prep_tasks]}"},{"line_number":264,"context_line":"      post_upgrade_tasks:"},{"line_number":265,"context_line":"        - when: step|int \u003d\u003d 1"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7faddb67_0c75a995","line":262,"range":{"start_line":262,"start_character":49,"end_line":262,"end_character":50},"updated":"2019-07-08 09:37:36.000000000","message":"_ instead of -","commit_id":"73bd5859b51b0e88f4d3b2a0bbe9ed13b2c8276c"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"256ace44666f7f011dfdffb16c5da2ff3cd554ce","unresolved":false,"context_lines":[{"line_number":258,"context_line":"          when: step|int \u003d\u003d 5"},{"line_number":259,"context_line":"          tags:"},{"line_number":260,"context_line":"            - opendev-validation"},{"line_number":261,"context_line":"            - opensdev-validation-nova"},{"line_number":262,"context_line":"          command: \"{{ container_cli }} exec nova_metadata /openstack/healthcheck\""},{"line_number":263,"context_line":"      host_prep_tasks: {get_attr: [NovaMetadataLogging, host_prep_tasks]}"},{"line_number":264,"context_line":"      post_upgrade_tasks:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_6cfd3d39","line":261,"range":{"start_line":261,"start_character":18,"end_line":261,"end_character":19},"updated":"2019-07-08 10:25:42.000000000","message":"and here","commit_id":"c02027344ffbc2562c296a0d76aedc0092a48546"}],"deployment/nova/nova-migration-target-container-puppet.yaml":[{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"4ca000b574daa1f13b2e52b8aee37b9a2e5a57e6","unresolved":false,"context_lines":[{"line_number":157,"context_line":"          tags:"},{"line_number":158,"context_line":"            - opendev-validation"},{"line_number":159,"context_line":"            - opendev-validation-nova"},{"line_number":160,"context_line":"          command: \"{{ container_cli }} exec nova-compute /openstack/healthcheck\""},{"line_number":161,"context_line":"      post_upgrade_tasks:"},{"line_number":162,"context_line":"        - when: step|int \u003d\u003d 1"},{"line_number":163,"context_line":"          import_role:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7faddb67_8c60b9d0","line":160,"range":{"start_line":160,"start_character":49,"end_line":160,"end_character":50},"updated":"2019-07-08 09:37:36.000000000","message":"_ instead of -","commit_id":"73bd5859b51b0e88f4d3b2a0bbe9ed13b2c8276c"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"de86c1f6afda265d07de1e75056d9ccc451c5280","unresolved":false,"context_lines":[{"line_number":179,"context_line":"            - opendev-validation-nova"},{"line_number":180,"context_line":"          command:"},{"line_number":181,"context_line":"            str_replace:"},{"line_number":182,"context_line":"              template: \"{{ container_cli }} exec nova_compute HEALTHCHECK\""},{"line_number":183,"context_line":"              params:"},{"line_number":184,"context_line":"                HEALTHCHECK: {get_attr: [ContainersCommon, healthcheck_rpc_port, test]}"},{"line_number":185,"context_line":"      post_upgrade_tasks:"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"7faddb67_416f4627","line":182,"range":{"start_line":182,"start_character":50,"end_line":182,"end_character":62},"updated":"2019-08-05 09:58:25.000000000","message":"don\u0027t we want to verify the nova_migration container here?\nIt runs the sshd on 2022, here we check again the \nnova_compute service which we already check in [1]\n\n[1] https://review.opendev.org/#/c/669605/13/deployment/nova/nova-compute-container-puppet.yaml","commit_id":"85595d8db3f4a9699aaae622cec02269ecf5ac6a"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"8d3fa1c827f17201b70b065ff002f63204b0f72f","unresolved":false,"context_lines":[{"line_number":179,"context_line":"            - opendev-validation-nova"},{"line_number":180,"context_line":"          command:"},{"line_number":181,"context_line":"            str_replace:"},{"line_number":182,"context_line":"              template: \"{{ container_cli }} exec nova_migration_target HEALTHCHECK\""},{"line_number":183,"context_line":"              params:"},{"line_number":184,"context_line":"                HEALTHCHECK: {get_attr: [ContainersCommon, healthcheck_rpc_port, test]}"},{"line_number":185,"context_line":"      post_upgrade_tasks:"},{"line_number":186,"context_line":"        - when: step|int \u003d\u003d 1"},{"line_number":187,"context_line":"          import_role:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"7faddb67_421e530c","line":184,"range":{"start_line":182,"start_character":72,"end_line":184,"end_character":87},"updated":"2019-08-06 09:41:36.000000000","message":"this is the wrong port passed to the healthcheck. I don\u0027t think we should pass any for the sshd here. We can just check for the default 2022. If we want to pass one it should be DockerNovaMigrationSshdPort","commit_id":"67bfdfa514b89cf7d92dbc9beb17a0c1fb479b0b"}],"deployment/nova/nova-scheduler-container-puppet.yaml":[{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"4ca000b574daa1f13b2e52b8aee37b9a2e5a57e6","unresolved":false,"context_lines":[{"line_number":186,"context_line":"          tags:"},{"line_number":187,"context_line":"            - opendev-validation"},{"line_number":188,"context_line":"            - opendev-validation-nova"},{"line_number":189,"context_line":"          command: \"{{ container_cli }} exec nova-scheduler /openstack/healthcheck\""},{"line_number":190,"context_line":"      host_prep_tasks:"},{"line_number":191,"context_line":"        list_concat:"},{"line_number":192,"context_line":"          - {get_attr: [NovaLogging, host_prep_tasks]}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7faddb67_2c9bc5c9","line":189,"range":{"start_line":189,"start_character":49,"end_line":189,"end_character":50},"updated":"2019-07-08 09:37:36.000000000","message":"_ instead of -","commit_id":"73bd5859b51b0e88f4d3b2a0bbe9ed13b2c8276c"}],"deployment/nova/nova-vnc-proxy-container-puppet.yaml":[{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"4ca000b574daa1f13b2e52b8aee37b9a2e5a57e6","unresolved":false,"context_lines":[{"line_number":290,"context_line":"          tags:"},{"line_number":291,"context_line":"            - opendev-validation"},{"line_number":292,"context_line":"            - opendev-validation-nova"},{"line_number":293,"context_line":"          command: \"{{ container_cli }} exec nova-vnc-proxy /openstack/healthcheck\""},{"line_number":294,"context_line":"      host_prep_tasks: {get_attr: [NovaLogging, host_prep_tasks]}"},{"line_number":295,"context_line":"      fast_forward_upgrade_tasks:"},{"line_number":296,"context_line":"        - when:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7faddb67_eca4cd0a","line":293,"range":{"start_line":293,"start_character":49,"end_line":293,"end_character":50},"updated":"2019-07-08 09:37:36.000000000","message":"_ instead of -","commit_id":"73bd5859b51b0e88f4d3b2a0bbe9ed13b2c8276c"}]}