)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"b1c062d96919abfa84588f5fe508be0451c90a57","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Kamil Sambor \u003cksambor@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-07-16 08:56:10 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add posibilities to set ovn-remote-probe-interval"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"For some deployments the default ovn-remove-probe-interval"},{"line_number":10,"context_line":"of 5000ms. Now it is extendet by default to 1 min and it"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7faddb67_aba15f48","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":16},"updated":"2019-07-16 07:10:35.000000000","message":"nit: possibilities\nor  \u0027Add the ability to configure ovn-remote-probe-interval\u0027\n\nIf you want to explain what this parameter is, it\u0027s the inactivity probe interval of the JSON session from ovn-controller to the OVN SB database.","commit_id":"b731264528c72392dde80486454db0e2ca26cc17"},{"author":{"_account_id":11082,"name":"Kamil Sambor","email":"ksambor@redhat.com","username":"ksambor"},"change_message_id":"b59742719d6c6a8e8024f103ebfed8c20668f93f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Kamil Sambor \u003cksambor@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-07-16 08:56:10 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add posibilities to set ovn-remote-probe-interval"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"For some deployments the default ovn-remove-probe-interval"},{"line_number":10,"context_line":"of 5000ms. Now it is extendet by default to 1 min and it"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7faddb67_eec20559","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":16},"in_reply_to":"7faddb67_aba15f48","updated":"2019-07-16 07:38:46.000000000","message":"Done","commit_id":"b731264528c72392dde80486454db0e2ca26cc17"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"b1c062d96919abfa84588f5fe508be0451c90a57","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add posibilities to set ovn-remote-probe-interval"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"For some deployments the default ovn-remove-probe-interval"},{"line_number":10,"context_line":"of 5000ms. Now it is extendet by default to 1 min and it"},{"line_number":11,"context_line":"is configurable now."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7faddb67_4b26abd0","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":20},"updated":"2019-07-16 07:10:35.000000000","message":"Right now, in TripleO setups, because this parameter is not configurable, I\u0027d say that not some but all deployments have a default value of 5 seconds. The rationale behind this patch it is because 5s may not be sufficient in loaded systems or during high control-plane activity spikes, leading to unnecessary reconnections to OVSDB server.","commit_id":"b731264528c72392dde80486454db0e2ca26cc17"},{"author":{"_account_id":11082,"name":"Kamil Sambor","email":"ksambor@redhat.com","username":"ksambor"},"change_message_id":"b59742719d6c6a8e8024f103ebfed8c20668f93f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add posibilities to set ovn-remote-probe-interval"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"For some deployments the default ovn-remove-probe-interval"},{"line_number":10,"context_line":"of 5000ms. Now it is extendet by default to 1 min and it"},{"line_number":11,"context_line":"is configurable now."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7faddb67_aeb88de4","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":20},"in_reply_to":"7faddb67_4b26abd0","updated":"2019-07-16 07:38:46.000000000","message":"Done","commit_id":"b731264528c72392dde80486454db0e2ca26cc17"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"b1c062d96919abfa84588f5fe508be0451c90a57","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add posibilities to set ovn-remote-probe-interval"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"For some deployments the default ovn-remove-probe-interval"},{"line_number":10,"context_line":"of 5000ms. Now it is extendet by default to 1 min and it"},{"line_number":11,"context_line":"is configurable now."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Depends-On: https://review.opendev.org/#/c/670861/"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7faddb67_6b2367be","line":10,"range":{"start_line":10,"start_character":21,"end_line":10,"end_character":29},"updated":"2019-07-16 07:10:35.000000000","message":"nit: extended","commit_id":"b731264528c72392dde80486454db0e2ca26cc17"},{"author":{"_account_id":11082,"name":"Kamil Sambor","email":"ksambor@redhat.com","username":"ksambor"},"change_message_id":"b59742719d6c6a8e8024f103ebfed8c20668f93f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add posibilities to set ovn-remote-probe-interval"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"For some deployments the default ovn-remove-probe-interval"},{"line_number":10,"context_line":"of 5000ms. Now it is extendet by default to 1 min and it"},{"line_number":11,"context_line":"is configurable now."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Depends-On: https://review.opendev.org/#/c/670861/"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7faddb67_4ed1d922","line":10,"range":{"start_line":10,"start_character":21,"end_line":10,"end_character":29},"in_reply_to":"7faddb67_6b2367be","updated":"2019-07-16 07:38:46.000000000","message":"Done","commit_id":"b731264528c72392dde80486454db0e2ca26cc17"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"f666a1fe284cb9716fddca2cd081f5758d2396f9","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add the ability to configure ovn-remote-probe-interval"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This parameter set inactive probe interval of the JSON"},{"line_number":10,"context_line":"session from ovn-controller to the OVN SB database."},{"line_number":11,"context_line":"By default this it is 5ms which not be sufficient in"},{"line_number":12,"context_line":"loaded systems or during high control-plane activity spikes,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7faddb67_2e4a5dab","line":9,"range":{"start_line":9,"start_character":15,"end_line":9,"end_character":18},"updated":"2019-07-16 07:57:00.000000000","message":"sets","commit_id":"e798a94b9c6f8a77b66ead6c4540a82c42794a06"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"f666a1fe284cb9716fddca2cd081f5758d2396f9","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This parameter set inactive probe interval of the JSON"},{"line_number":10,"context_line":"session from ovn-controller to the OVN SB database."},{"line_number":11,"context_line":"By default this it is 5ms which not be sufficient in"},{"line_number":12,"context_line":"loaded systems or during high control-plane activity spikes,"},{"line_number":13,"context_line":"leading to unnecessary reconnections to OVSDB server."},{"line_number":14,"context_line":"Now it is extended by default to 1 min and it"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7faddb67_6e54d553","line":11,"range":{"start_line":11,"start_character":22,"end_line":11,"end_character":25},"updated":"2019-07-16 07:57:00.000000000","message":"5s or 5000ms","commit_id":"e798a94b9c6f8a77b66ead6c4540a82c42794a06"}],"deployment/ovn/ovn-controller-container-puppet.yaml":[{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"0b4b3e88a2042c39d5eaa030a34522b8a9a62abd","unresolved":false,"context_lines":[{"line_number":77,"context_line":"  OVNRemoteProbeInterval:"},{"line_number":78,"context_line":"    description: Probe interval in ms"},{"line_number":79,"context_line":"    type: string"},{"line_number":80,"context_line":"    default: \"60000\""},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"conditions:"},{"line_number":83,"context_line":"  force_config_drive:  {equals: [{get_param: OVNMetadataEnabled}, false]}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7faddb67_bd7a01ee","line":80,"updated":"2019-07-16 13:05:28.000000000","message":"As per comment in related puppet patch, I always get a bit apprehensive when I see numbers as strings. If it needs to be a string on the puppet side, would we be better off using a number here and doing a conversion on the puppet side?","commit_id":"eede29ede21fa9fd523648322eaef24b4c96435e"},{"author":{"_account_id":11082,"name":"Kamil Sambor","email":"ksambor@redhat.com","username":"ksambor"},"change_message_id":"8fab56d5bc95e2a50fb552abe66883094f2b5041","unresolved":false,"context_lines":[{"line_number":77,"context_line":"  OVNRemoteProbeInterval:"},{"line_number":78,"context_line":"    description: Probe interval in ms"},{"line_number":79,"context_line":"    type: string"},{"line_number":80,"context_line":"    default: \"60000\""},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"conditions:"},{"line_number":83,"context_line":"  force_config_drive:  {equals: [{get_param: OVNMetadataEnabled}, false]}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7faddb67_0f5e7811","line":80,"in_reply_to":"7faddb67_bd7a01ee","updated":"2019-07-16 13:26:26.000000000","message":"Yeah, converting on puppet side sounds more resonable than number as string","commit_id":"eede29ede21fa9fd523648322eaef24b4c96435e"}],"releasenotes/notes/ovn_remote_probe_interval-023b3fa671f88101.yaml":[{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"696eb099556653ad62b74d3d01f9c163e6277c82","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    For some deployments the default ovn-remove-probe-interval of 5000ms."},{"line_number":5,"context_line":"    Now it is extendet by default to 1 min and it is configurable by"},{"line_number":6,"context_line":"    tripleo heat template param OVNRemoteProbeInterval."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_6b0cc740","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":24},"updated":"2019-07-16 07:13:12.000000000","message":"I\u0027d update the reno based on my comments on the commit message.","commit_id":"b731264528c72392dde80486454db0e2ca26cc17"},{"author":{"_account_id":11082,"name":"Kamil Sambor","email":"ksambor@redhat.com","username":"ksambor"},"change_message_id":"b59742719d6c6a8e8024f103ebfed8c20668f93f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    For some deployments the default ovn-remove-probe-interval of 5000ms."},{"line_number":5,"context_line":"    Now it is extendet by default to 1 min and it is configurable by"},{"line_number":6,"context_line":"    tripleo heat template param OVNRemoteProbeInterval."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_0ec76166","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":24},"in_reply_to":"7faddb67_6b0cc740","updated":"2019-07-16 07:38:46.000000000","message":"Done","commit_id":"b731264528c72392dde80486454db0e2ca26cc17"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"696eb099556653ad62b74d3d01f9c163e6277c82","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    For some deployments the default ovn-remove-probe-interval of 5000ms."},{"line_number":5,"context_line":"    Now it is extendet by default to 1 min and it is configurable by"},{"line_number":6,"context_line":"    tripleo heat template param OVNRemoteProbeInterval."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_0b051314","line":5,"range":{"start_line":5,"start_character":14,"end_line":5,"end_character":22},"updated":"2019-07-16 07:13:12.000000000","message":"ditto","commit_id":"b731264528c72392dde80486454db0e2ca26cc17"},{"author":{"_account_id":11082,"name":"Kamil Sambor","email":"ksambor@redhat.com","username":"ksambor"},"change_message_id":"b59742719d6c6a8e8024f103ebfed8c20668f93f","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    For some deployments the default ovn-remove-probe-interval of 5000ms."},{"line_number":5,"context_line":"    Now it is extendet by default to 1 min and it is configurable by"},{"line_number":6,"context_line":"    tripleo heat template param OVNRemoteProbeInterval."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_2ec49d5e","line":5,"range":{"start_line":5,"start_character":14,"end_line":5,"end_character":22},"in_reply_to":"7faddb67_0b051314","updated":"2019-07-16 07:38:46.000000000","message":"Done","commit_id":"b731264528c72392dde80486454db0e2ca26cc17"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"696eb099556653ad62b74d3d01f9c163e6277c82","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    For some deployments the default ovn-remove-probe-interval of 5000ms."},{"line_number":5,"context_line":"    Now it is extendet by default to 1 min and it is configurable by"},{"line_number":6,"context_line":"    tripleo heat template param OVNRemoteProbeInterval."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_2b024f0c","line":6,"range":{"start_line":6,"start_character":4,"end_line":6,"end_character":11},"updated":"2019-07-16 07:13:12.000000000","message":"TripleO? I don\u0027t know... :)","commit_id":"b731264528c72392dde80486454db0e2ca26cc17"},{"author":{"_account_id":11082,"name":"Kamil Sambor","email":"ksambor@redhat.com","username":"ksambor"},"change_message_id":"b59742719d6c6a8e8024f103ebfed8c20668f93f","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    For some deployments the default ovn-remove-probe-interval of 5000ms."},{"line_number":5,"context_line":"    Now it is extendet by default to 1 min and it is configurable by"},{"line_number":6,"context_line":"    tripleo heat template param OVNRemoteProbeInterval."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_cea2a9ae","line":6,"range":{"start_line":6,"start_character":4,"end_line":6,"end_character":11},"in_reply_to":"7faddb67_2b024f0c","updated":"2019-07-16 07:38:46.000000000","message":"Done","commit_id":"b731264528c72392dde80486454db0e2ca26cc17"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"bb56213fae43cab58b6982f856d170cc5349cea7","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    This parameter set inactive probe interval of the JSON session"},{"line_number":5,"context_line":"    from ovn-controller to the OVN SB database. By default this it"},{"line_number":6,"context_line":"    is 5ms which not be sufficient in loaded systems or during high"},{"line_number":7,"context_line":"    control-plane activity spikes, leading to unnecessary reconnections"},{"line_number":8,"context_line":"    to OVSDB server. Now it is extended by default to 1 min and it is"},{"line_number":9,"context_line":"    configurable by param OVNRemoteProbeInterval."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7faddb67_4edc79e3","line":6,"range":{"start_line":6,"start_character":7,"end_line":6,"end_character":10},"updated":"2019-07-16 07:57:42.000000000","message":"5s or 5000ms","commit_id":"e798a94b9c6f8a77b66ead6c4540a82c42794a06"}]}