)]}'
{"environments/neutron-ml2-bigswitch.yaml":[{"author":{"_account_id":28026,"name":"Weifan Fu","email":"weifan.fu@bigswitch.com","username":"wfu-bsn"},"change_message_id":"0ffa663f6210ab86537a8311b6f8edee168f37ad","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  # These parameters are role specific."},{"line_number":20,"context_line":"  # Required to fill in for controllers:"},{"line_number":21,"context_line":"  ControllerNeutronBigswitchRestproxyServers:"},{"line_number":22,"context_line":"  ControllerNeutronBigswitchRestproxyServerAuth:"},{"line_number":23,"context_line":"  ControllerNeutronBigswitchAgentEnabled: true"},{"line_number":24,"context_line":"  ControllerNeutronBigswitchLLDPEnabled: false"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_29430244","line":22,"updated":"2019-07-18 23:42:03.000000000","message":"Refactoring issue: Some fields here does not match puppet/services/neutron-plugin-ml2-bigswitch-container-puppet.yaml","commit_id":"e38c567d4065ae47fd8cfc47e596547702af9150"},{"author":{"_account_id":28026,"name":"Weifan Fu","email":"weifan.fu@bigswitch.com","username":"wfu-bsn"},"change_message_id":"0ffa663f6210ab86537a8311b6f8edee168f37ad","unresolved":false,"context_lines":[{"line_number":21,"context_line":"  ControllerNeutronBigswitchRestproxyServers:"},{"line_number":22,"context_line":"  ControllerNeutronBigswitchRestproxyServerAuth:"},{"line_number":23,"context_line":"  ControllerNeutronBigswitchAgentEnabled: true"},{"line_number":24,"context_line":"  ControllerNeutronBigswitchLLDPEnabled: false"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"  # Required to fill in for computes:"},{"line_number":27,"context_line":"  ComputeNeutronBigswitchAgentEnabled: false"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_35204cf7","line":24,"updated":"2019-07-18 23:42:03.000000000","message":"default true is better. for compute, it can be false for compute in p+v mode, but is always true for controller, unless customers want do do some weird stuffs.","commit_id":"e38c567d4065ae47fd8cfc47e596547702af9150"}],"overcloud-resource-registry-puppet.j2.yaml":[{"author":{"_account_id":28026,"name":"Weifan Fu","email":"weifan.fu@bigswitch.com","username":"wfu-bsn"},"change_message_id":"0ffa663f6210ab86537a8311b6f8edee168f37ad","unresolved":false,"context_lines":[{"line_number":174,"context_line":"  OS::TripleO::Services::ComputeNeutronCorePlugin: docker/services/neutron-plugin-ml2.yaml"},{"line_number":175,"context_line":"  OS::TripleO::Services::ComputeNeutronCorePluginNuage: puppet/services/neutron-compute-plugin-nuage.yaml"},{"line_number":176,"context_line":"  # Neutron Core Plugin Vendors (these typically override NeutronCorePlugin)"},{"line_number":177,"context_line":"  OS::TripleO::Services::NeutronCorePluginBigswitch: deployment/neutron/neutron-plugin-ml2-bigswitch-container-puppet.yaml"},{"line_number":178,"context_line":"  OS::TripleO::Services::NeutronCorePluginML2OVN: puppet/services/neutron-plugin-ml2-ovn.yaml"},{"line_number":179,"context_line":"  OS::TripleO::Services::NeutronCorePluginPlumgrid: puppet/services/neutron-plugin-plumgrid.yaml"},{"line_number":180,"context_line":"  OS::TripleO::Services::NeutronCorePluginNuage: puppet/services/neutron-plugin-nuage.yaml"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_15343092","line":177,"updated":"2019-07-18 23:42:03.000000000","message":"this path is incorrect and causes not found error, should it be\n\npuppet/services/neutron-plugin-ml2-bigswitch-container-puppet.yaml\n\n?","commit_id":"e38c567d4065ae47fd8cfc47e596547702af9150"}],"puppet/services/neutron-bigswitch-agent.yaml":[{"author":{"_account_id":28026,"name":"Weifan Fu","email":"weifan.fu@bigswitch.com","username":"wfu-bsn"},"change_message_id":"0ffa663f6210ab86537a8311b6f8edee168f37ad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7faddb67_f5339412","updated":"2019-07-18 23:42:03.000000000","message":"There is a reference to this file in environments/docker.yaml L5\n\nI removed the reference, and it seemed to be fine.","commit_id":"e38c567d4065ae47fd8cfc47e596547702af9150"}],"puppet/services/neutron-plugin-ml2-bigswitch-container-puppet.yaml":[{"author":{"_account_id":28026,"name":"Weifan Fu","email":"weifan.fu@bigswitch.com","username":"wfu-bsn"},"change_message_id":"0ffa663f6210ab86537a8311b6f8edee168f37ad","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    description: Mapping of service endpoint -\u003e protocol. Typically set"},{"line_number":31,"context_line":"                 via parameter_defaults in the resource registry."},{"line_number":32,"context_line":"    type: json"},{"line_number":33,"context_line":"  ContainerNeutronConfigImage:"},{"line_number":34,"context_line":"    description: The container image to use for the neutron config_volume"},{"line_number":35,"context_line":"    type: string"},{"line_number":36,"context_line":"  NeutronBigswitchAgentEnabled:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_a0a398ff","line":33,"updated":"2019-07-18 23:42:03.000000000","message":"Can this be called DockerNeutronConfigImage? (So it remain the same as our existing templates.)","commit_id":"e38c567d4065ae47fd8cfc47e596547702af9150"},{"author":{"_account_id":28026,"name":"Weifan Fu","email":"weifan.fu@bigswitch.com","username":"wfu-bsn"},"change_message_id":"0ffa663f6210ab86537a8311b6f8edee168f37ad","unresolved":false,"context_lines":[{"line_number":95,"context_line":"      value:"},{"line_number":96,"context_line":"        map_replace:"},{"line_number":97,"context_line":"          - map_replace:"},{"line_number":98,"context_line":"            - bsn_agent_enabled: NeutronBigswitchAgentEnabled"},{"line_number":99,"context_line":"              bsn_lldp_enabled: NeutronBigswitchLLDPEnabled"},{"line_number":100,"context_line":"              bsn_restproxy_servers: NeutronBigswitchRestproxyServers"},{"line_number":101,"context_line":"              bsn_restproxy_server_auth: NeutronBigswitchRestproxyServerAuth"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_e9488a5c","line":98,"updated":"2019-07-18 23:42:03.000000000","message":"Some field here does not match environments/neutron-ml2-bigswitch.yaml","commit_id":"e38c567d4065ae47fd8cfc47e596547702af9150"},{"author":{"_account_id":28026,"name":"Weifan Fu","email":"weifan.fu@bigswitch.com","username":"wfu-bsn"},"change_message_id":"0ffa663f6210ab86537a8311b6f8edee168f37ad","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    value:"},{"line_number":123,"context_line":"      service_name: neutron_bigswitch_agent"},{"line_number":124,"context_line":"      host_prep_tasks:"},{"line_number":125,"context_line":"        - name: Install Bigswitch dependencies"},{"line_number":126,"context_line":"          package:"},{"line_number":127,"context_line":"            name:"},{"line_number":128,"context_line":"              - python2-networking-bigswitch"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_772236bb","line":125,"updated":"2019-07-18 23:42:03.000000000","message":"Installation of those packages are either done via modification of overcloud images, or modification of neutron/horizon images. So this installation is not needed. There is no harm for the Enable and Start to stay here though.\n\nWe can improve this workflow in the future.","commit_id":"e38c567d4065ae47fd8cfc47e596547702af9150"},{"author":{"_account_id":28026,"name":"Weifan Fu","email":"weifan.fu@bigswitch.com","username":"wfu-bsn"},"change_message_id":"0ffa663f6210ab86537a8311b6f8edee168f37ad","unresolved":false,"context_lines":[{"line_number":143,"context_line":"          when: {get_attr: [RoleParametersValue, value, bsn_agent_enabled]}"},{"line_number":144,"context_line":"      config_settings:"},{"line_number":145,"context_line":"        map_merge:"},{"line_number":146,"context_line":"          - get_attr: [NeutronMl2Base, role_data, config_settings]"},{"line_number":147,"context_line":"          - neutron::plugins::ml2::bigswitch::restproxy::auth_tenant: service"},{"line_number":148,"context_line":"            neutron::plugins::ml2::bigswitch::restproxy::auto_sync_on_failure: {get_param: NeutronBigswitchRestproxyAutoSyncOnFailure}"},{"line_number":149,"context_line":"            neutron::plugins::ml2::bigswitch::restproxy::consistency_interval: {get_param: NeutronBigswitchRestproxyConsistencyInterval}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_29154240","line":146,"updated":"2019-07-18 23:42:03.000000000","message":"Some configs are not output correctly due to the config filed here not matching neutron-ml2-bigswitch.yaml","commit_id":"e38c567d4065ae47fd8cfc47e596547702af9150"}]}