)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"0f1495eebb666f7619768b39ab65f796d8630e71","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Kevin Carter \u003ckecarter@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-07-23 13:31:35 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Convert THT file to use new role"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The THT file has been converted to use a newly created role found within"},{"line_number":10,"context_line":"TripleO-Ansible. The THT process will now run all tasks through the role"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7faddb67_ba8f24cb","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":32},"updated":"2019-08-06 20:40:05.000000000","message":"That\u0027s very generic. What do you think about renaming it?\n\n\"Configure time using tripleo-ansible time role\"","commit_id":"d7e88b153f26b3a94ab1db20f1b8b07f267d0b52"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"13356fed315e2ccb04a3866266d9d9e45812c9af","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Kevin Carter \u003ckecarter@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-07-23 13:31:35 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Convert THT file to use new role"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The THT file has been converted to use a newly created role found within"},{"line_number":10,"context_line":"TripleO-Ansible. The THT process will now run all tasks through the role"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7faddb67_cd5b481f","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":32},"in_reply_to":"7faddb67_ba8f24cb","updated":"2019-08-06 20:46:54.000000000","message":"Done","commit_id":"d7e88b153f26b3a94ab1db20f1b8b07f267d0b52"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"c05b4dc648be7c588dc48eae16a5a0688e96a0a4","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Story: 2006028"},{"line_number":14,"context_line":"Task: 34657"},{"line_number":15,"context_line":"Depends-On: Ic6d7462d82c9811e95aedf90b7a9d92700f2ebe3"},{"line_number":16,"context_line":"Change-Id: I36c71508570c165982af557e2cb55b87880c3e8d"},{"line_number":17,"context_line":"Signed-off-by: Kevin Carter \u003ckecarter@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7faddb67_303c5ae0","line":15,"updated":"2019-08-12 16:19:10.000000000","message":"This is the firewall change?","commit_id":"fe4261c77e1b694fa51f59d7bc66fe0532efc911"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"08b533ba7fa1613513743e284c7f3ddbce627810","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Story: 2006028"},{"line_number":14,"context_line":"Task: 34657"},{"line_number":15,"context_line":"Depends-On: Ic6d7462d82c9811e95aedf90b7a9d92700f2ebe3"},{"line_number":16,"context_line":"Change-Id: I36c71508570c165982af557e2cb55b87880c3e8d"},{"line_number":17,"context_line":"Signed-off-by: Kevin Carter \u003ckecarter@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7faddb67_6456262d","line":15,"in_reply_to":"7faddb67_303c5ae0","updated":"2019-08-19 17:48:29.000000000","message":"Yes, this change requires access to the firewall role: https://review.opendev.org/#/c/671166/6/deployment/time/ptp-baremetal-ansible.yaml@80\n\nI am rebasing this change on the WIP firewall change-over review, which will cover this in greater depth.","commit_id":"fe4261c77e1b694fa51f59d7bc66fe0532efc911"}],"deployment/time/ptp-baremetal-ansible.yaml":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"3d303e5d7db5ed9392807d59730fcadf497bafa9","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    description: Timezone role using composable services."},{"line_number":59,"context_line":"    value:"},{"line_number":60,"context_line":"      service_name: ptp"},{"line_number":61,"context_line":"      host_prep_tasks:"},{"line_number":62,"context_line":"        - name: Set interface fact"},{"line_number":63,"context_line":"          set_fact:"},{"line_number":64,"context_line":"            tripleo_ptp_interface: {get_param: PtpInterface}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7faddb67_6381f54d","line":61,"updated":"2019-08-07 15:03:20.000000000","message":"would it make sense to keep the firewall rules as well, until we migrate them all to an ansible role, to preserve feature parity?","commit_id":"5b4dd85d1c1f92126e5759ee2a5d8ca423c2dc67"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"cd057c84ab0591af2afc7563fcfbe541893adcad","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    description: Timezone role using composable services."},{"line_number":59,"context_line":"    value:"},{"line_number":60,"context_line":"      service_name: ptp"},{"line_number":61,"context_line":"      host_prep_tasks:"},{"line_number":62,"context_line":"        - name: Set interface fact"},{"line_number":63,"context_line":"          set_fact:"},{"line_number":64,"context_line":"            tripleo_ptp_interface: {get_param: PtpInterface}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7faddb67_830751ca","line":61,"in_reply_to":"7faddb67_6381f54d","updated":"2019-08-07 15:10:55.000000000","message":"I will create a firewall role and have this change depend on that.","commit_id":"5b4dd85d1c1f92126e5759ee2a5d8ca423c2dc67"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"c82777ef90a429c72653d828f86d8e0c299412a1","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    description: Timezone role using composable services."},{"line_number":59,"context_line":"    value:"},{"line_number":60,"context_line":"      service_name: ptp"},{"line_number":61,"context_line":"      host_prep_tasks:"},{"line_number":62,"context_line":"        - name: Set interface fact"},{"line_number":63,"context_line":"          set_fact:"},{"line_number":64,"context_line":"            tripleo_ptp_interface: {get_param: PtpInterface}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7faddb67_e3fcfab6","line":61,"in_reply_to":"7faddb67_830751ca","updated":"2019-08-08 04:30:51.000000000","message":"Done","commit_id":"5b4dd85d1c1f92126e5759ee2a5d8ca423c2dc67"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"3d303e5d7db5ed9392807d59730fcadf497bafa9","unresolved":false,"context_lines":[{"line_number":73,"context_line":"            tripleo_ptp_transport: {get_param: PtpMessageTransport}"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"      upgrade_tasks:"},{"line_number":76,"context_line":"        - name: Run ntp stop"},{"line_number":77,"context_line":"          include_role:"},{"line_number":78,"context_line":"            name: tripleo-ptp"},{"line_number":79,"context_line":"            tasks_from: tripleo_ntp_stop.yml"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7faddb67_a347ed4c","line":76,"updated":"2019-08-07 15:03:20.000000000","message":"not sure if it is worth keeping the validations tasks here, so that on upgrade people can run those selectively ... or if we can use same tag in the role and get to the same result","commit_id":"5b4dd85d1c1f92126e5759ee2a5d8ca423c2dc67"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"c82777ef90a429c72653d828f86d8e0c299412a1","unresolved":false,"context_lines":[{"line_number":73,"context_line":"            tripleo_ptp_transport: {get_param: PtpMessageTransport}"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"      upgrade_tasks:"},{"line_number":76,"context_line":"        - name: Run ntp stop"},{"line_number":77,"context_line":"          include_role:"},{"line_number":78,"context_line":"            name: tripleo-ptp"},{"line_number":79,"context_line":"            tasks_from: tripleo_ntp_stop.yml"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7faddb67_832bc631","line":76,"in_reply_to":"7faddb67_036e0196","updated":"2019-08-08 04:30:51.000000000","message":"Done","commit_id":"5b4dd85d1c1f92126e5759ee2a5d8ca423c2dc67"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"cd057c84ab0591af2afc7563fcfbe541893adcad","unresolved":false,"context_lines":[{"line_number":73,"context_line":"            tripleo_ptp_transport: {get_param: PtpMessageTransport}"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"      upgrade_tasks:"},{"line_number":76,"context_line":"        - name: Run ntp stop"},{"line_number":77,"context_line":"          include_role:"},{"line_number":78,"context_line":"            name: tripleo-ptp"},{"line_number":79,"context_line":"            tasks_from: tripleo_ntp_stop.yml"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7faddb67_036e0196","line":76,"in_reply_to":"7faddb67_a347ed4c","updated":"2019-08-07 15:10:55.000000000","message":"adding to the role.","commit_id":"5b4dd85d1c1f92126e5759ee2a5d8ca423c2dc67"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"47b138cb7be27f005a1343ef39a5173889d26ef6","unresolved":false,"context_lines":[{"line_number":100,"context_line":"            set -o pipefail"},{"line_number":101,"context_line":"            if systemctl is-enabled ntpd; then"},{"line_number":102,"context_line":"              /usr/bin/systemctl show \u0027ntpd\u0027 --property ActiveState | grep \u0027\\bactive\\b\u0027"},{"line_number":103,"context_line":"            fi"},{"line_number":104,"context_line":"          tags:"},{"line_number":105,"context_line":"            - validation"},{"line_number":106,"context_line":"          when:"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"3fa7e38b_54f403cf","line":103,"updated":"2019-11-20 17:51:45.000000000","message":"I wonder if we need to add chrony bits here","commit_id":"22b85a063fa751d9832dd300f1112bc8efabd034"}],"deployment/time/timezone-baremetal-ansible.yaml":[{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"0f1495eebb666f7619768b39ab65f796d8630e71","unresolved":false,"context_lines":[{"line_number":69,"context_line":"          vars:"},{"line_number":70,"context_line":"            tripleo_timezone: {get_param: TimeZone}"},{"line_number":71,"context_line":"            tripleo_ptp_slave_mode: {get_param: PtpSlaveMode}"},{"line_number":72,"context_line":"            tripleo_ptp_interfaces: [\"{{ tripleo_ptp_interface }}\"]"},{"line_number":73,"context_line":"            tripleo_ptp_transport: {get_param: PtpMessageTransport}"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"      upgrade_tasks:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_fab27c93","line":72,"range":{"start_line":72,"start_character":36,"end_line":72,"end_character":67},"updated":"2019-08-06 20:40:05.000000000","message":"I assume you\u0027re setting a fact since you want to pass a list here.","commit_id":"d7e88b153f26b3a94ab1db20f1b8b07f267d0b52"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"8966efc3cb0b52e0bc6c0df03b6dd4397098318d","unresolved":false,"context_lines":[{"line_number":69,"context_line":"          vars:"},{"line_number":70,"context_line":"            tripleo_timezone: {get_param: TimeZone}"},{"line_number":71,"context_line":"            tripleo_ptp_slave_mode: {get_param: PtpSlaveMode}"},{"line_number":72,"context_line":"            tripleo_ptp_interfaces: [\"{{ tripleo_ptp_interface }}\"]"},{"line_number":73,"context_line":"            tripleo_ptp_transport: {get_param: PtpMessageTransport}"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"      upgrade_tasks:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_6d77b4a1","line":72,"range":{"start_line":72,"start_character":36,"end_line":72,"end_character":67},"in_reply_to":"7faddb67_fab27c93","updated":"2019-08-06 20:46:38.000000000","message":"yes, I am setting this as a list when the role is include. At this point we only support the one interface, however in the future we will be able to add additional ptp interfaces should we choose.\n\nWhile I could set the fact as a list on line 64, I didn\u0027t want to mess with the heat `get_param` and thought it better to set the interface as a string within the ansible fact, and define the needed variable as a list. In that way I\u0027m not worrying about data-types and unexpected returns from heat.","commit_id":"d7e88b153f26b3a94ab1db20f1b8b07f267d0b52"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"7cd783539b7ad167fe6186c2980d3564e7b98871","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        - name: Run time role"},{"line_number":67,"context_line":"          include_role:"},{"line_number":68,"context_line":"            name: tripleo-time"},{"line_number":69,"context_line":"          vars:"},{"line_number":70,"context_line":"            tripleo_timezone: {get_param: TimeZone}"},{"line_number":71,"context_line":"            tripleo_ptp_slave_mode: {get_param: PtpSlaveMode}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7faddb67_6dea540f","line":68,"updated":"2019-08-06 20:49:40.000000000","message":"Wait why is the timezone mixed with ptp support?  Those should be independent of each other","commit_id":"8db630bc5bc4fee0706732924017c5c3d6fe8e89"}]}