)]}'
{"environments/network-isolation-no-tunneling.j2.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"8b8fa4220b6f47b62e8cb61aa6fd105f3bb3e155","unresolved":false,"context_lines":[{"line_number":29,"context_line":"{%-     if role.networks is mapping %}"},{"line_number":30,"context_line":"{%-         set _role_networks \u003d [] %}"},{"line_number":31,"context_line":"{%-         for key, val in role.networks.items() %}"},{"line_number":32,"context_line":"{%-             set _ \u003d _role_networks.append(key) %}"},{"line_number":33,"context_line":"{%-         endfor %}"},{"line_number":34,"context_line":"{%-     else %}"},{"line_number":35,"context_line":"{%-         set _role_networks \u003d role.networks %}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7faddb67_a59d6a67","line":32,"range":{"start_line":32,"start_character":20,"end_line":32,"end_character":21},"updated":"2019-07-26 07:15:33.000000000","message":"i guess this is some jinja magic/shorthand for \n\nset _role_networks \u003d _role_networks.append(key)\n\napologies if this is \u0027well known\u0027 and I\u0027m really not a jinja expert but I would question the value of using the shorthand vs readability/maintainability of this code when someone looks at it 6 months from now","commit_id":"8833c2da2dcd7c78282d0d5494bb6280f03dd115"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"201e37a290e69556886e483b6919034c6fc67c68","unresolved":false,"context_lines":[{"line_number":29,"context_line":"{%-     if role.networks is mapping %}"},{"line_number":30,"context_line":"{%-         set _role_networks \u003d [] %}"},{"line_number":31,"context_line":"{%-         for key, val in role.networks.items() %}"},{"line_number":32,"context_line":"{%-             set _ \u003d _role_networks.append(key) %}"},{"line_number":33,"context_line":"{%-         endfor %}"},{"line_number":34,"context_line":"{%-     else %}"},{"line_number":35,"context_line":"{%-         set _role_networks \u003d role.networks %}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7faddb67_946e4294","line":32,"range":{"start_line":32,"start_character":20,"end_line":32,"end_character":21},"in_reply_to":"7faddb67_79ef1a87","updated":"2019-07-29 15:33:00.000000000","message":"Another clumsy way of doing that is \n\n{% if foo.append(\u00271\u0027) %}{% endif %}\n\n:)","commit_id":"8833c2da2dcd7c78282d0d5494bb6280f03dd115"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"492434c9ec622564c4db86be7b8cfd7d8dd239fb","unresolved":false,"context_lines":[{"line_number":29,"context_line":"{%-     if role.networks is mapping %}"},{"line_number":30,"context_line":"{%-         set _role_networks \u003d [] %}"},{"line_number":31,"context_line":"{%-         for key, val in role.networks.items() %}"},{"line_number":32,"context_line":"{%-             set _ \u003d _role_networks.append(key) %}"},{"line_number":33,"context_line":"{%-         endfor %}"},{"line_number":34,"context_line":"{%-     else %}"},{"line_number":35,"context_line":"{%-         set _role_networks \u003d role.networks %}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7faddb67_79ef1a87","line":32,"range":{"start_line":32,"start_character":20,"end_line":32,"end_character":21},"in_reply_to":"7faddb67_a59d6a67","updated":"2019-07-26 15:35:57.000000000","message":"IDK if it\u0027s something specifically documented, however, the \"_\" variable is like python in that its just an unused variable. Prior to this change we were setting \"_role_networks\" to None on ever round because `append` does not have a return value.\n\n    \u003e\u003e\u003e o \u003d []\n    \u003e\u003e\u003e x \u003d o.append(1)\n    \u003e\u003e\u003e o\n    [1]\n    \u003e\u003e\u003e type(x)\n    \u003ctype \u0027NoneType\u0027\u003e","commit_id":"8833c2da2dcd7c78282d0d5494bb6280f03dd115"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"3d903ed02f5919f3306f94dfc2f14cc2b19ed057","unresolved":false,"context_lines":[{"line_number":29,"context_line":"{%-     if role.networks is mapping %}"},{"line_number":30,"context_line":"{%-         set _role_networks \u003d [] %}"},{"line_number":31,"context_line":"{%-         for key, val in role.networks.items() %}"},{"line_number":32,"context_line":"{%-             set _ \u003d _role_networks.append(key) %}"},{"line_number":33,"context_line":"{%-         endfor %}"},{"line_number":34,"context_line":"{%-     else %}"},{"line_number":35,"context_line":"{%-         set _role_networks \u003d role.networks %}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7faddb67_c5a666ac","line":32,"range":{"start_line":32,"start_character":20,"end_line":32,"end_character":21},"in_reply_to":"7faddb67_a59d6a67","updated":"2019-07-26 07:18:44.000000000","message":"since we\u0027re here :D any good recommendations about where i can go and find out about that \"set _\" magic http://jinja.pocoo.org/docs/2.10/templates/ can\u0027t find it there","commit_id":"8833c2da2dcd7c78282d0d5494bb6280f03dd115"}],"environments/network-isolation.j2.yaml":[{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"2acfa69f45bdd592a2ba752cdf5a9d0a18f60205","unresolved":false,"context_lines":[{"line_number":24,"context_line":"{#-                    networks map (new schema) and network list (old schema). #}"},{"line_number":25,"context_line":"{%-     if role.networks is mapping %}"},{"line_number":26,"context_line":"{%-         set _role_networks \u003d [] %}"},{"line_number":27,"context_line":"{%-         for key,val in role.networks.items() %}"},{"line_number":28,"context_line":"{%-             set _ \u003d _role_networks.append(key) %}"},{"line_number":29,"context_line":"{%-         endfor %}"},{"line_number":30,"context_line":"{%-     else %}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_e449398b","line":27,"range":{"start_line":27,"start_character":16,"end_line":27,"end_character":23},"updated":"2019-07-25 04:55:56.000000000","message":"you didn\u0027t add the space - intended?","commit_id":"ff0e5c72f08b98d7c4d09b1a70621abb1a669129"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"3ac3031cb585aec50a6ae4577360c2344ec44156","unresolved":false,"context_lines":[{"line_number":24,"context_line":"{#-                    networks map (new schema) and network list (old schema). #}"},{"line_number":25,"context_line":"{%-     if role.networks is mapping %}"},{"line_number":26,"context_line":"{%-         set _role_networks \u003d [] %}"},{"line_number":27,"context_line":"{%-         for key,val in role.networks.items() %}"},{"line_number":28,"context_line":"{%-             set _ \u003d _role_networks.append(key) %}"},{"line_number":29,"context_line":"{%-         endfor %}"},{"line_number":30,"context_line":"{%-     else %}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_f890f697","line":27,"range":{"start_line":27,"start_character":16,"end_line":27,"end_character":23},"in_reply_to":"7faddb67_e449398b","updated":"2019-07-25 15:17:58.000000000","message":"Done","commit_id":"ff0e5c72f08b98d7c4d09b1a70621abb1a669129"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"4f293fb39211d1351e1bb306a5b0170ea41cd01b","unresolved":false,"context_lines":[{"line_number":24,"context_line":"{#-                    networks map (new schema) and network list (old schema). #}"},{"line_number":25,"context_line":"{%-     if role.networks is mapping %}"},{"line_number":26,"context_line":"{%-         set _role_networks \u003d [] %}"},{"line_number":27,"context_line":"{%-         for key,val in role.networks.items() %}"},{"line_number":28,"context_line":"{%-             set _ \u003d _role_networks.append(key) %}"},{"line_number":29,"context_line":"{%-         endfor %}"},{"line_number":30,"context_line":"{%-     else %}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_158d9bd2","line":27,"range":{"start_line":27,"start_character":16,"end_line":27,"end_character":23},"in_reply_to":"7faddb67_e449398b","updated":"2019-07-25 15:04:47.000000000","message":"Nope, just missed. Updating now.","commit_id":"ff0e5c72f08b98d7c4d09b1a70621abb1a669129"}],"network/config/2-linux-bonds-vlans/role.role.j2.yaml":[{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"2acfa69f45bdd592a2ba752cdf5a9d0a18f60205","unresolved":false,"context_lines":[{"line_number":3,"context_line":"{#-                networks map (new schema) and network list (old schema). #}"},{"line_number":4,"context_line":"{%- if role.networks is mapping %}"},{"line_number":5,"context_line":"{%-     set _role_networks \u003d [] %}"},{"line_number":6,"context_line":"{%-     for key,val in role.networks.items() %}"},{"line_number":7,"context_line":"{%-         set _role_networks \u003d _role_networks.append(key) %}"},{"line_number":8,"context_line":"{%-     endfor %}"},{"line_number":9,"context_line":"{%- else %}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_44584d55","line":6,"range":{"start_line":6,"start_character":12,"end_line":6,"end_character":19},"updated":"2019-07-25 04:55:56.000000000","message":"same here","commit_id":"ff0e5c72f08b98d7c4d09b1a70621abb1a669129"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"3ac3031cb585aec50a6ae4577360c2344ec44156","unresolved":false,"context_lines":[{"line_number":3,"context_line":"{#-                networks map (new schema) and network list (old schema). #}"},{"line_number":4,"context_line":"{%- if role.networks is mapping %}"},{"line_number":5,"context_line":"{%-     set _role_networks \u003d [] %}"},{"line_number":6,"context_line":"{%-     for key,val in role.networks.items() %}"},{"line_number":7,"context_line":"{%-         set _role_networks \u003d _role_networks.append(key) %}"},{"line_number":8,"context_line":"{%-     endfor %}"},{"line_number":9,"context_line":"{%- else %}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_d8ebba0f","line":6,"range":{"start_line":6,"start_character":12,"end_line":6,"end_character":19},"in_reply_to":"7faddb67_44584d55","updated":"2019-07-25 15:17:58.000000000","message":"Done","commit_id":"ff0e5c72f08b98d7c4d09b1a70621abb1a669129"}],"network/config/bond-with-vlans/role.role.j2.yaml":[{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"2acfa69f45bdd592a2ba752cdf5a9d0a18f60205","unresolved":false,"context_lines":[{"line_number":3,"context_line":"{#-                networks map (new schema) and network list (old schema). #}"},{"line_number":4,"context_line":"{%- if role.networks is mapping %}"},{"line_number":5,"context_line":"{%-     set _role_networks \u003d [] %}"},{"line_number":6,"context_line":"{%-     for key,val in role.networks.items() %}"},{"line_number":7,"context_line":"{%-         set _role_networks \u003d _role_networks.append(key) %}"},{"line_number":8,"context_line":"{%-     endfor %}"},{"line_number":9,"context_line":"{%- else %}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_6455491d","line":6,"range":{"start_line":6,"start_character":12,"end_line":6,"end_character":19},"updated":"2019-07-25 04:55:56.000000000","message":"ditto","commit_id":"ff0e5c72f08b98d7c4d09b1a70621abb1a669129"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"3ac3031cb585aec50a6ae4577360c2344ec44156","unresolved":false,"context_lines":[{"line_number":3,"context_line":"{#-                networks map (new schema) and network list (old schema). #}"},{"line_number":4,"context_line":"{%- if role.networks is mapping %}"},{"line_number":5,"context_line":"{%-     set _role_networks \u003d [] %}"},{"line_number":6,"context_line":"{%-     for key,val in role.networks.items() %}"},{"line_number":7,"context_line":"{%-         set _role_networks \u003d _role_networks.append(key) %}"},{"line_number":8,"context_line":"{%-     endfor %}"},{"line_number":9,"context_line":"{%- else %}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_78f2c608","line":6,"range":{"start_line":6,"start_character":12,"end_line":6,"end_character":19},"in_reply_to":"7faddb67_6455491d","updated":"2019-07-25 15:17:58.000000000","message":"Done","commit_id":"ff0e5c72f08b98d7c4d09b1a70621abb1a669129"}],"network/config/multiple-nics/role.role.j2.yaml":[{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"2acfa69f45bdd592a2ba752cdf5a9d0a18f60205","unresolved":false,"context_lines":[{"line_number":3,"context_line":"{#-                networks map (new schema) and network list (old schema). #}"},{"line_number":4,"context_line":"{%- if role.networks is mapping %}"},{"line_number":5,"context_line":"{%-     set _role_networks \u003d [] %}"},{"line_number":6,"context_line":"{%-     for key,val in role.networks.items() %}"},{"line_number":7,"context_line":"{%-         set _role_networks \u003d _role_networks.append(key) %}"},{"line_number":8,"context_line":"{%-     endfor %}"},{"line_number":9,"context_line":"{%- else %}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_04301507","line":6,"range":{"start_line":6,"start_character":12,"end_line":6,"end_character":19},"updated":"2019-07-25 04:55:56.000000000","message":"ditto","commit_id":"ff0e5c72f08b98d7c4d09b1a70621abb1a669129"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"3ac3031cb585aec50a6ae4577360c2344ec44156","unresolved":false,"context_lines":[{"line_number":3,"context_line":"{#-                networks map (new schema) and network list (old schema). #}"},{"line_number":4,"context_line":"{%- if role.networks is mapping %}"},{"line_number":5,"context_line":"{%-     set _role_networks \u003d [] %}"},{"line_number":6,"context_line":"{%-     for key,val in role.networks.items() %}"},{"line_number":7,"context_line":"{%-         set _role_networks \u003d _role_networks.append(key) %}"},{"line_number":8,"context_line":"{%-     endfor %}"},{"line_number":9,"context_line":"{%- else %}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_98f542f0","line":6,"range":{"start_line":6,"start_character":12,"end_line":6,"end_character":19},"in_reply_to":"7faddb67_04301507","updated":"2019-07-25 15:17:58.000000000","message":"Done","commit_id":"ff0e5c72f08b98d7c4d09b1a70621abb1a669129"}],"network/config/single-nic-linux-bridge-vlans/role.role.j2.yaml":[{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"2acfa69f45bdd592a2ba752cdf5a9d0a18f60205","unresolved":false,"context_lines":[{"line_number":3,"context_line":"{#-                networks map (new schema) and network list (old schema). #}"},{"line_number":4,"context_line":"{%- if role.networks is mapping %}"},{"line_number":5,"context_line":"{%-     set _role_networks \u003d [] %}"},{"line_number":6,"context_line":"{%-     for key,val in role.networks.items() %}"},{"line_number":7,"context_line":"{%-         set _role_networks \u003d _role_networks.append(key) %}"},{"line_number":8,"context_line":"{%-     endfor %}"},{"line_number":9,"context_line":"{%- else %}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_243511f8","line":6,"range":{"start_line":6,"start_character":12,"end_line":6,"end_character":19},"updated":"2019-07-25 04:55:56.000000000","message":"ditto","commit_id":"ff0e5c72f08b98d7c4d09b1a70621abb1a669129"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"3ac3031cb585aec50a6ae4577360c2344ec44156","unresolved":false,"context_lines":[{"line_number":3,"context_line":"{#-                networks map (new schema) and network list (old schema). #}"},{"line_number":4,"context_line":"{%- if role.networks is mapping %}"},{"line_number":5,"context_line":"{%-     set _role_networks \u003d [] %}"},{"line_number":6,"context_line":"{%-     for key,val in role.networks.items() %}"},{"line_number":7,"context_line":"{%-         set _role_networks \u003d _role_networks.append(key) %}"},{"line_number":8,"context_line":"{%-     endfor %}"},{"line_number":9,"context_line":"{%- else %}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_38dc4e73","line":6,"range":{"start_line":6,"start_character":12,"end_line":6,"end_character":19},"in_reply_to":"7faddb67_243511f8","updated":"2019-07-25 15:17:58.000000000","message":"Done","commit_id":"ff0e5c72f08b98d7c4d09b1a70621abb1a669129"}],"network/config/single-nic-vlans/role.role.j2.yaml":[{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"2acfa69f45bdd592a2ba752cdf5a9d0a18f60205","unresolved":false,"context_lines":[{"line_number":3,"context_line":"{#-                networks map (new schema) and network list (old schema). #}"},{"line_number":4,"context_line":"{%- if role.networks is mapping %}"},{"line_number":5,"context_line":"{%-     set _role_networks \u003d [] %}"},{"line_number":6,"context_line":"{%-     for key,val in role.networks.items() %}"},{"line_number":7,"context_line":"{%-         set _role_networks \u003d _role_networks.append(key) %}"},{"line_number":8,"context_line":"{%-     endfor %}"},{"line_number":9,"context_line":"{%- else %}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_e43e19d9","line":6,"range":{"start_line":6,"start_character":12,"end_line":6,"end_character":19},"updated":"2019-07-25 04:55:56.000000000","message":"ditto","commit_id":"ff0e5c72f08b98d7c4d09b1a70621abb1a669129"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"3ac3031cb585aec50a6ae4577360c2344ec44156","unresolved":false,"context_lines":[{"line_number":3,"context_line":"{#-                networks map (new schema) and network list (old schema). #}"},{"line_number":4,"context_line":"{%- if role.networks is mapping %}"},{"line_number":5,"context_line":"{%-     set _role_networks \u003d [] %}"},{"line_number":6,"context_line":"{%-     for key,val in role.networks.items() %}"},{"line_number":7,"context_line":"{%-         set _role_networks \u003d _role_networks.append(key) %}"},{"line_number":8,"context_line":"{%-     endfor %}"},{"line_number":9,"context_line":"{%- else %}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_58d7ca50","line":6,"range":{"start_line":6,"start_character":12,"end_line":6,"end_character":19},"in_reply_to":"7faddb67_e43e19d9","updated":"2019-07-25 15:17:58.000000000","message":"Done","commit_id":"ff0e5c72f08b98d7c4d09b1a70621abb1a669129"}]}