)]}'
{"deployment/glance/glance-api-container-puppet.yaml":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"df24ccb2ee38271c4cb215ef7766cebcdb9b8eef","unresolved":false,"context_lines":[{"line_number":381,"context_line":"              dest: \"/\""},{"line_number":382,"context_line":"              merge: true"},{"line_number":383,"context_line":"              preserve_properties: true"},{"line_number":384,"context_line":"            - source: \"/var/lib/kolla/config_files/src-original/glance-api-ansible.conf\""},{"line_number":385,"context_line":"              dest: \"/etc/glance/\""},{"line_number":386,"context_line":"              merge: true"},{"line_number":387,"context_line":"              preserve_properties: false"},{"line_number":388,"context_line":"              owner: \"glance:glance\""},{"line_number":389,"context_line":"              perm: \"0644\""},{"line_number":390,"context_line":"            - source: \"/var/lib/kolla/config_files/src-original/glance-image-import-ansible.conf\""},{"line_number":391,"context_line":"              dest: \"/etc/glance/\""},{"line_number":392,"context_line":"              merge: true"},{"line_number":393,"context_line":"              preserve_properties: false"},{"line_number":394,"context_line":"              owner: \"glance:glance\""},{"line_number":395,"context_line":"              perm: \"0644\""},{"line_number":396,"context_line":"            - source: \"/var/lib/kolla/config_files/src-original/glance-swift-ansible.conf\""},{"line_number":397,"context_line":"              dest: \"/etc/glance/\""},{"line_number":398,"context_line":"              merge: true"},{"line_number":399,"context_line":"              preserve_properties: false"},{"line_number":400,"context_line":"              owner: \"glance:glance\""},{"line_number":401,"context_line":"              perm: \"0644\""},{"line_number":402,"context_line":"            - source: \"/var/lib/kolla/config_files/src-ceph/\""},{"line_number":403,"context_line":"              dest: \"/etc/ceph/\""},{"line_number":404,"context_line":"              merge: true"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"7faddb67_fd6c0f37","line":401,"range":{"start_line":384,"start_character":0,"end_line":401,"end_character":26},"updated":"2019-07-31 19:24:04.000000000","message":"this could be simplified by:\n\n              - source: \"/var/lib/kolla/config_files/src-original/*-ansible.conf\"\n                dest: \"/etc/glance/\"\n                merge: true\n                preserve_properties: false\n                owner: \"glance:glance\"\n                perm: \"0644\"","commit_id":"df3090156fd39fe0ff230c6babe72b587b84ff6f"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"bdb222d22ea5c86e2a459dc05bcd83734593829c","unresolved":false,"context_lines":[{"line_number":430,"context_line":"        step_2:"},{"line_number":431,"context_line":"          map_merge:"},{"line_number":432,"context_line":"            - {get_attr: [GlanceLogging, docker_config, step_2]}"},{"line_number":433,"context_line":"            - glance_api_get_original_cfg:"},{"line_number":434,"context_line":"                image: \u0026glance_api_image {get_param: ContainerGlanceApiImage}"},{"line_number":435,"context_line":"                net: none"},{"line_number":436,"context_line":"                privileged: true"},{"line_number":437,"context_line":"                detach: false"},{"line_number":438,"context_line":"                user: root"},{"line_number":439,"context_line":"                command: [\u0027/bin/bash\u0027, \u0027-c\u0027, \u0027cp -r /etc/glance/glance-api.conf /var/lib/kolla/config_files/src-original/glance-api-original.conf\u0027]"},{"line_number":440,"context_line":"                volumes:"},{"line_number":441,"context_line":"                  list_concat:"},{"line_number":442,"context_line":"                    - {get_attr: [ContainersCommon, volumes]}"},{"line_number":443,"context_line":"                    -"},{"line_number":444,"context_line":"                      - /var/lib/kolla/config_files/glance_api.json:/var/lib/kolla/config_files/config.json"},{"line_number":445,"context_line":"                      - /var/lib/config-data/ansible-generated/glance_api/:/var/lib/kolla/config_files/src-original:rw"},{"line_number":446,"context_line":"                environment:"},{"line_number":447,"context_line":"                  - KOLLA_CONFIG_STRATEGY\u003dCOPY_ALWAYS"},{"line_number":448,"context_line":"            - glance_image_import_get_original_cfg:"},{"line_number":449,"context_line":"                image: \u0026glance_api_image {get_param: ContainerGlanceApiImage}"},{"line_number":450,"context_line":"                net: none"},{"line_number":451,"context_line":"                privileged: true"},{"line_number":452,"context_line":"                detach: false"},{"line_number":453,"context_line":"                user: root"},{"line_number":454,"context_line":"                command: [\u0027/bin/bash\u0027, \u0027-c\u0027, \u0027cp -r /etc/glance/glance-image-import.conf /var/lib/kolla/config_files/src-original/glance-image-import-original.conf\u0027]"},{"line_number":455,"context_line":"                volumes:"},{"line_number":456,"context_line":"                  list_concat:"},{"line_number":457,"context_line":"                    - {get_attr: [ContainersCommon, volumes]}"},{"line_number":458,"context_line":"                    -"},{"line_number":459,"context_line":"                      - /var/lib/kolla/config_files/glance_api.json:/var/lib/kolla/config_files/config.json"},{"line_number":460,"context_line":"                      - /var/lib/config-data/ansible-generated/glance_api/:/var/lib/kolla/config_files/src-original:rw"},{"line_number":461,"context_line":"                environment:"},{"line_number":462,"context_line":"                  - KOLLA_CONFIG_STRATEGY\u003dCOPY_ALWAYS"},{"line_number":463,"context_line":"            - glance_swift_get_original_cfg:"},{"line_number":464,"context_line":"                image: \u0026glance_api_image {get_param: ContainerGlanceApiImage}"},{"line_number":465,"context_line":"                net: none"},{"line_number":466,"context_line":"                privileged: true"},{"line_number":467,"context_line":"                detach: false"},{"line_number":468,"context_line":"                user: root"},{"line_number":469,"context_line":"                command: [\u0027/bin/bash\u0027, \u0027-c\u0027, \u0027cp -r /etc/glance/glance-swift.conf /var/lib/kolla/config_files/src-original/glance-swift-original.conf\u0027]"},{"line_number":470,"context_line":"                volumes:"},{"line_number":471,"context_line":"                  list_concat:"},{"line_number":472,"context_line":"                    - {get_attr: [ContainersCommon, volumes]}"},{"line_number":473,"context_line":"                    -"},{"line_number":474,"context_line":"                      - /var/lib/kolla/config_files/glance_api.json:/var/lib/kolla/config_files/config.json"},{"line_number":475,"context_line":"                      - /var/lib/config-data/ansible-generated/glance_api/:/var/lib/kolla/config_files/src-original:rw"},{"line_number":476,"context_line":"                environment:"},{"line_number":477,"context_line":"                  - KOLLA_CONFIG_STRATEGY\u003dCOPY_ALWAYS"},{"line_number":478,"context_line":"        step_3:"},{"line_number":479,"context_line":"          glance_api_db_sync:"},{"line_number":480,"context_line":"            image: *glance_api_image"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"7faddb67_3d586788","line":477,"range":{"start_line":433,"start_character":0,"end_line":477,"end_character":53},"updated":"2019-07-31 19:25:12.000000000","message":"I did 3 containers so each of them is \"atomic\" and do one thing; we could also have one container but doing one command in a bash loop to copy \u0026 rename.","commit_id":"df3090156fd39fe0ff230c6babe72b587b84ff6f"}]}
