)]}'
{"deployment/deprecated/kernel/kernel-baremetal-puppet.yaml":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"b50cae8ca19a88211b865292fd5b9c56d6322cfa","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    default: 1024"},{"line_number":73,"context_line":"    description: Configures sysctl fs.inotify.max_user_instances key"},{"line_number":74,"context_line":"    type: number"},{"line_number":75,"context_line":"  ExtraKernelModules:"},{"line_number":76,"context_line":"    default: {}"},{"line_number":77,"context_line":"    description: Hash of extra Kernel modules to load."},{"line_number":78,"context_line":"    type: json"},{"line_number":79,"context_line":"    tags:"},{"line_number":80,"context_line":"      - role_specific"},{"line_number":81,"context_line":"  ExtraSysctlSettings:"},{"line_number":82,"context_line":"    default: {}"},{"line_number":83,"context_line":"    description: Hash of extra sysctl settings to apply."},{"line_number":84,"context_line":"    type: json"},{"line_number":85,"context_line":"    tags:"},{"line_number":86,"context_line":"      - role_specific"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"conditions:"},{"line_number":89,"context_line":"  ipv6_disabled: {equals: [{get_param: KernelDisableIPv6}, 1]}"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"resources:"},{"line_number":92,"context_line":"  # Merging role-specific parameters (RoleParameters) with the default parameters."},{"line_number":93,"context_line":"  # RoleParameters will have the precedence over the default parameters."},{"line_number":94,"context_line":"  RoleParametersValue:"},{"line_number":95,"context_line":"    type: OS::Heat::Value"},{"line_number":96,"context_line":"    properties:"},{"line_number":97,"context_line":"      type: json"},{"line_number":98,"context_line":"      value:"},{"line_number":99,"context_line":"        map_replace:"},{"line_number":100,"context_line":"          - map_replace:"},{"line_number":101,"context_line":"            - extra_kernel_modules: ExtraKernelModules"},{"line_number":102,"context_line":"              extra_sysctl_settings: ExtraSysctlSettings"},{"line_number":103,"context_line":"            - values: {get_param: [RoleParameters]}"},{"line_number":104,"context_line":"          - values:"},{"line_number":105,"context_line":"              ExtraKernelModules: {get_param: ExtraKernelModules}"},{"line_number":106,"context_line":"              ExtraSysctlSettings: {get_param: ExtraSysctlSettings}"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"outputs:"},{"line_number":109,"context_line":"  role_data:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_6d29f487","line":106,"range":{"start_line":75,"start_character":0,"end_line":106,"end_character":67},"updated":"2019-08-06 20:44:25.000000000","message":"I think we\u0027ve lost the role specific nature of these in the ansible version.","commit_id":"291066de9b98222baab2a60434f236c874e11064"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"b50cae8ca19a88211b865292fd5b9c56d6322cfa","unresolved":false,"context_lines":[{"line_number":116,"context_line":"          - ipv6_disabled"},{"line_number":117,"context_line":"          - \u0027127.0.0.1\u0027"},{"line_number":118,"context_line":"          - \u0027localhost\u0027"},{"line_number":119,"context_line":"        kernel_modules:"},{"line_number":120,"context_line":"          map_merge:"},{"line_number":121,"context_line":"            - nf_conntrack: {}"},{"line_number":122,"context_line":"            - {get_attr: [RoleParametersValue, value, extra_kernel_modules]}"},{"line_number":123,"context_line":"        sysctl_settings:"},{"line_number":124,"context_line":"          map_merge:"},{"line_number":125,"context_line":"            - net.ipv4.tcp_keepalive_intvl:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_ad328cf0","line":122,"range":{"start_line":119,"start_character":0,"end_line":122,"end_character":76},"updated":"2019-08-06 20:44:25.000000000","message":"Also where is this in the ansible version?","commit_id":"291066de9b98222baab2a60434f236c874e11064"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"728778b7fdade93f3d39514776edfa6009dc55d9","unresolved":false,"context_lines":[{"line_number":116,"context_line":"          - ipv6_disabled"},{"line_number":117,"context_line":"          - \u0027127.0.0.1\u0027"},{"line_number":118,"context_line":"          - \u0027localhost\u0027"},{"line_number":119,"context_line":"        kernel_modules:"},{"line_number":120,"context_line":"          map_merge:"},{"line_number":121,"context_line":"            - nf_conntrack: {}"},{"line_number":122,"context_line":"            - {get_attr: [RoleParametersValue, value, extra_kernel_modules]}"},{"line_number":123,"context_line":"        sysctl_settings:"},{"line_number":124,"context_line":"          map_merge:"},{"line_number":125,"context_line":"            - net.ipv4.tcp_keepalive_intvl:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_a645c9b5","line":122,"range":{"start_line":119,"start_character":0,"end_line":122,"end_character":76},"in_reply_to":"7faddb67_0b94e889","updated":"2019-08-07 01:17:32.000000000","message":"Done","commit_id":"291066de9b98222baab2a60434f236c874e11064"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"7c7efafad4a2d7446dd9f8c55ad46875a57d3982","unresolved":false,"context_lines":[{"line_number":116,"context_line":"          - ipv6_disabled"},{"line_number":117,"context_line":"          - \u0027127.0.0.1\u0027"},{"line_number":118,"context_line":"          - \u0027localhost\u0027"},{"line_number":119,"context_line":"        kernel_modules:"},{"line_number":120,"context_line":"          map_merge:"},{"line_number":121,"context_line":"            - nf_conntrack: {}"},{"line_number":122,"context_line":"            - {get_attr: [RoleParametersValue, value, extra_kernel_modules]}"},{"line_number":123,"context_line":"        sysctl_settings:"},{"line_number":124,"context_line":"          map_merge:"},{"line_number":125,"context_line":"            - net.ipv4.tcp_keepalive_intvl:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_0b94e889","line":122,"range":{"start_line":119,"start_character":0,"end_line":122,"end_character":76},"in_reply_to":"7faddb67_2b1f645b","updated":"2019-08-06 23:14:17.000000000","message":"Ok that works. I think we still need the RoleParametersValue thing though","commit_id":"291066de9b98222baab2a60434f236c874e11064"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"b7f661c12486c007cd1d65c9b106ff75519ec0e4","unresolved":false,"context_lines":[{"line_number":116,"context_line":"          - ipv6_disabled"},{"line_number":117,"context_line":"          - \u0027127.0.0.1\u0027"},{"line_number":118,"context_line":"          - \u0027localhost\u0027"},{"line_number":119,"context_line":"        kernel_modules:"},{"line_number":120,"context_line":"          map_merge:"},{"line_number":121,"context_line":"            - nf_conntrack: {}"},{"line_number":122,"context_line":"            - {get_attr: [RoleParametersValue, value, extra_kernel_modules]}"},{"line_number":123,"context_line":"        sysctl_settings:"},{"line_number":124,"context_line":"          map_merge:"},{"line_number":125,"context_line":"            - net.ipv4.tcp_keepalive_intvl:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_2b1f645b","line":122,"range":{"start_line":119,"start_character":0,"end_line":122,"end_character":76},"in_reply_to":"7faddb67_ad328cf0","updated":"2019-08-06 23:08:48.000000000","message":"This parameter is here https://review.opendev.org/#/c/674060/2/deployment/kernel/kernel-baremetal-ansible.yaml@97 \n\nWhich I believe should provide for the same interface.\n\nThe \"nf_conntrack\" default is now contained within the role, as found here - https://review.opendev.org/#/c/674054/5/tripleo_ansible/roles/tripleo-kernel/vars/main.yml@19","commit_id":"291066de9b98222baab2a60434f236c874e11064"}]}