)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"93a1e50255d4a4f5e4dac61a56e0dac27c7c414b","unresolved":false,"context_lines":[{"line_number":11,"context_line":"  - add networking-mlnx package to neutron_server and nova_compute"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Depends-On: Ib7d9b4a3dd360911eb500e820cb129c6463900ed"},{"line_number":14,"context_line":"Depends-On: If57c34bd5c3aee3e5b1f1c7b3703fd544ce498da"},{"line_number":15,"context_line":"Depends-On: I31fd5223ce528c4fe0ee0fe1b8f7ed8cdf38a796"},{"line_number":16,"context_line":"Depends-On: Ibd817a4a34ee2944ee86b4a47e7621637d258da3"},{"line_number":17,"context_line":"Change-Id: Iee636c6d0d52bd17148c93f797d01cf69906802e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7faddb67_04bd6701","line":14,"updated":"2019-08-27 13:40:51.000000000","message":"This one is currently stuck in kolla, so we can\u0027t land this patch","commit_id":"7aed0efc7769dc960c53fc7581fe71371802d130"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"73abdf3ae77890d8b82b0d57a2f5b47f2ade206b","unresolved":false,"context_lines":[{"line_number":11,"context_line":"  - add networking-mlnx package to neutron_server and nova_compute"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Depends-On: Ib7d9b4a3dd360911eb500e820cb129c6463900ed"},{"line_number":14,"context_line":"Depends-On: If57c34bd5c3aee3e5b1f1c7b3703fd544ce498da"},{"line_number":15,"context_line":"Depends-On: I31fd5223ce528c4fe0ee0fe1b8f7ed8cdf38a796"},{"line_number":16,"context_line":"Depends-On: Ibd817a4a34ee2944ee86b4a47e7621637d258da3"},{"line_number":17,"context_line":"Change-Id: Iee636c6d0d52bd17148c93f797d01cf69906802e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5faad753_5d5a3a4f","line":14,"in_reply_to":"7faddb67_04bd6701","updated":"2019-09-11 13:58:30.000000000","message":"dropping the dependency for now in order to merge this patch, it will not break anything.","commit_id":"7aed0efc7769dc960c53fc7581fe71371802d130"}],"deployment/neutron/neutron-mlnx-agent-container-puppet.yaml":[{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"e8a4b96424283706f493b500ee2b3d3094e5cf07","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        get_attr: [NeutronBase, role_data, metadata_settings]"},{"line_number":212,"context_line":"      upgrade_tasks: []"},{"line_number":213,"context_line":"      post_upgrade_tasks:"},{"line_number":214,"context_line":"        - when: step|int \u003d\u003d 1"},{"line_number":215,"context_line":"          import_role:"},{"line_number":216,"context_line":"            name: tripleo-docker-rm"},{"line_number":217,"context_line":"          vars:"},{"line_number":218,"context_line":"            containers_to_rm:"},{"line_number":219,"context_line":"              - neutron_mlnx_agent"},{"line_number":220,"context_line":"              - eswitchd"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5faad753_9a8998cb","line":220,"range":{"start_line":214,"start_character":0,"end_line":220,"end_character":24},"updated":"2019-09-11 13:22:43.000000000","message":"This task is required during the migration of docker to podman. Is there any other case for this removal? As this is targetted for Train, which will be podman based, this step is not required, unless i miss something.","commit_id":"698e5e8051de061696264554ec40c2bfe29b3062"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"73abdf3ae77890d8b82b0d57a2f5b47f2ade206b","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        get_attr: [NeutronBase, role_data, metadata_settings]"},{"line_number":212,"context_line":"      upgrade_tasks: []"},{"line_number":213,"context_line":"      post_upgrade_tasks:"},{"line_number":214,"context_line":"        - when: step|int \u003d\u003d 1"},{"line_number":215,"context_line":"          import_role:"},{"line_number":216,"context_line":"            name: tripleo-docker-rm"},{"line_number":217,"context_line":"          vars:"},{"line_number":218,"context_line":"            containers_to_rm:"},{"line_number":219,"context_line":"              - neutron_mlnx_agent"},{"line_number":220,"context_line":"              - eswitchd"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5faad753_3dcbbe1e","line":220,"range":{"start_line":214,"start_character":0,"end_line":220,"end_character":24},"in_reply_to":"5faad753_9a8998cb","updated":"2019-09-11 13:58:30.000000000","message":"No other case is intended, will remove those lines.","commit_id":"698e5e8051de061696264554ec40c2bfe29b3062"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"41e671891936a978143e212795140c18b53a0a7b","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    default: 2"},{"line_number":52,"context_line":"    description: The number of seconds the agent will wait between"},{"line_number":53,"context_line":"                 polling for local device changes"},{"line_number":54,"context_line":"    type: number"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"resources:"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3fa7e38b_68d15b23","line":54,"updated":"2019-09-24 03:56:47.000000000","message":"Add tags \u0027role_specific\u0027 as the parameter is merged specific to a role.","commit_id":"b77fd2aee7652def628469c35083b46bbba5e37d"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"8237d95518aa37daff60ba5621388c4fc33b86fe","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    default: 2"},{"line_number":52,"context_line":"    description: The number of seconds the agent will wait between"},{"line_number":53,"context_line":"                 polling for local device changes"},{"line_number":54,"context_line":"    type: number"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"resources:"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3fa7e38b_8a612408","line":54,"in_reply_to":"3fa7e38b_68d15b23","updated":"2019-09-24 13:51:01.000000000","message":"Done","commit_id":"b77fd2aee7652def628469c35083b46bbba5e37d"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"41e671891936a978143e212795140c18b53a0a7b","unresolved":false,"context_lines":[{"line_number":212,"context_line":"                  - /sys/class/net:/sys/class/net:rw"},{"line_number":213,"context_line":"            environment:"},{"line_number":214,"context_line":"              - KOLLA_CONFIG_STRATEGY\u003dCOPY_ALWAYS"},{"line_number":215,"context_line":"      step_config: |"},{"line_number":216,"context_line":"        include ::tripleo::profile::base::neutron::plugins::ml2"},{"line_number":217,"context_line":"      metadata_settings:"},{"line_number":218,"context_line":"        get_attr: [NeutronBase, role_data, metadata_settings]"},{"line_number":219,"context_line":"      upgrade_tasks: []"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3fa7e38b_0891c74e","line":216,"range":{"start_line":215,"start_character":6,"end_line":216,"end_character":63},"updated":"2019-09-24 03:56:47.000000000","message":"This section is not required, as the puppet will be applied using the puppet_config (which is configured above).","commit_id":"b77fd2aee7652def628469c35083b46bbba5e37d"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"4567d864389bb9e9fab89e220464cdba975b2437","unresolved":false,"context_lines":[{"line_number":212,"context_line":"                  - /sys/class/net:/sys/class/net:rw"},{"line_number":213,"context_line":"            environment:"},{"line_number":214,"context_line":"              - KOLLA_CONFIG_STRATEGY\u003dCOPY_ALWAYS"},{"line_number":215,"context_line":"      step_config: |"},{"line_number":216,"context_line":"        include ::tripleo::profile::base::neutron::plugins::ml2"},{"line_number":217,"context_line":"      metadata_settings:"},{"line_number":218,"context_line":"        get_attr: [NeutronBase, role_data, metadata_settings]"},{"line_number":219,"context_line":"      upgrade_tasks: []"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3fa7e38b_be0c66ec","line":216,"range":{"start_line":215,"start_character":6,"end_line":216,"end_character":63},"in_reply_to":"3fa7e38b_0891c74e","updated":"2019-09-24 09:56:09.000000000","message":"Done","commit_id":"b77fd2aee7652def628469c35083b46bbba5e37d"}],"environments/services/neutron-mlnx-agent.yaml":[{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"cf3ab1f0ea7e63c86746009b0d616ad03a4e7309","unresolved":false,"context_lines":[{"line_number":6,"context_line":"parameter_defaults:"},{"line_number":7,"context_line":"  NeutronMechanismDrivers: [\u0027mlnx_infiniband\u0027,\u0027openvswitch\u0027]"},{"line_number":8,"context_line":"  NeutronPhysicalDevMappings: [\u0027datacentre:ib0\u0027]"},{"line_number":9,"context_line":"  NovaSchedulerDefaultFilters: [\u0027RetryFilter\u0027,\u0027AvailabilityZoneFilter\u0027,\u0027ComputeFilter\u0027,\u0027ComputeCapabilitiesFilter\u0027,\u0027ImagePropertiesFilter\u0027,\u0027ServerGroupAntiAffinityFilter\u0027,\u0027ServerGroupAffinityFilter\u0027,\u0027PciPassthroughFilter\u0027]"},{"line_number":10,"context_line":"  NovaSchedulerAvailableFilters: [\"nova.scheduler.filters.all_filters\",\"nova.scheduler.filters.pci_passthrough_filter.PciPassthroughFilter\"]"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"  NovaPCIPassthrough:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7faddb67_82b0cbdd","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":222},"updated":"2019-09-05 17:57:20.000000000","message":"you are missing NUMATopologyFilter","commit_id":"7aed0efc7769dc960c53fc7581fe71371802d130"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"f2447c8203fb4012e4bc111121e17b6ba7a3d4cb","unresolved":false,"context_lines":[{"line_number":6,"context_line":"parameter_defaults:"},{"line_number":7,"context_line":"  NeutronMechanismDrivers: [\u0027mlnx_infiniband\u0027,\u0027openvswitch\u0027]"},{"line_number":8,"context_line":"  NeutronPhysicalDevMappings: [\u0027datacentre:ib0\u0027]"},{"line_number":9,"context_line":"  NovaSchedulerDefaultFilters: [\u0027RetryFilter\u0027,\u0027AvailabilityZoneFilter\u0027,\u0027ComputeFilter\u0027,\u0027ComputeCapabilitiesFilter\u0027,\u0027ImagePropertiesFilter\u0027,\u0027ServerGroupAntiAffinityFilter\u0027,\u0027ServerGroupAffinityFilter\u0027,\u0027PciPassthroughFilter\u0027]"},{"line_number":10,"context_line":"  NovaSchedulerAvailableFilters: [\"nova.scheduler.filters.all_filters\",\"nova.scheduler.filters.pci_passthrough_filter.PciPassthroughFilter\"]"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"  NovaPCIPassthrough:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5faad753_4894f644","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":222},"in_reply_to":"7faddb67_82b0cbdd","updated":"2019-09-09 07:26:21.000000000","message":"Done","commit_id":"7aed0efc7769dc960c53fc7581fe71371802d130"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"41e671891936a978143e212795140c18b53a0a7b","unresolved":false,"context_lines":[{"line_number":16,"context_line":"  ComputeSriovParameters:"},{"line_number":17,"context_line":"    # Kernel arguments for ComputeSriov node"},{"line_number":18,"context_line":"    KernelArgs: \"intel_iommu\u003don iommu\u003dpt\""},{"line_number":19,"context_line":"    TunedProfileName: \"throughput-performance\""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3fa7e38b_e8b9cbcb","line":19,"range":{"start_line":19,"start_character":23,"end_line":19,"end_character":45},"updated":"2019-09-24 03:56:47.000000000","message":"Can we remove this? The SR-IOV role already has the default as cpu-parititioning profile, which is recommeded NFV deployments (refer roles/ComputeSriov.yaml file for the default value).","commit_id":"b77fd2aee7652def628469c35083b46bbba5e37d"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"4567d864389bb9e9fab89e220464cdba975b2437","unresolved":false,"context_lines":[{"line_number":16,"context_line":"  ComputeSriovParameters:"},{"line_number":17,"context_line":"    # Kernel arguments for ComputeSriov node"},{"line_number":18,"context_line":"    KernelArgs: \"intel_iommu\u003don iommu\u003dpt\""},{"line_number":19,"context_line":"    TunedProfileName: \"throughput-performance\""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3fa7e38b_7e234e57","line":19,"range":{"start_line":19,"start_character":23,"end_line":19,"end_character":45},"in_reply_to":"3fa7e38b_e8b9cbcb","updated":"2019-09-24 09:56:09.000000000","message":"Done","commit_id":"b77fd2aee7652def628469c35083b46bbba5e37d"}]}