)]}'
{"deployment/ceph-ansible/ceph-grafana.yaml":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"4565b350eda7990c85e1cd4eb5c7d4761d39b514","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    default: false"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"conditions:"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"  internal_tls_enabled: {equals: [{get_param: EnableInternalTLS}, true]}"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"resources:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7faddb67_d5abc6d4","line":71,"updated":"2019-08-07 11:00:04.000000000","message":"i think the newline here is unnecessary","commit_id":"661db0663215c5b3c28bcf5b126d895e569c3b9c"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"b88f63b2a9948cede5c2373e37a31219f4a1728d","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    default: false"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"conditions:"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"  internal_tls_enabled: {equals: [{get_param: EnableInternalTLS}, true]}"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"resources:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7faddb67_c06782b7","line":71,"in_reply_to":"7faddb67_d5abc6d4","updated":"2019-08-07 12:02:02.000000000","message":"yes, unwanted newline","commit_id":"661db0663215c5b3c28bcf5b126d895e569c3b9c"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"322e52e3087d95f7689e8cea2a10dbd94b252dad","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        if:"},{"line_number":130,"context_line":"        - internal_tls_enabled"},{"line_number":131,"context_line":"        - generate_service_certificates: true"},{"line_number":132,"context_line":"          ceph_grafana-server_certificate_specs:"},{"line_number":133,"context_line":"            service_certificate: \u0027/etc/pki/tls/certs/ceph_grafana.crt\u0027"},{"line_number":134,"context_line":"            service_key: \u0027/etc/pki/tls/private/ceph_grafana.key\u0027"},{"line_number":135,"context_line":"            hostname:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7faddb67_d5cd065f","line":132,"updated":"2019-08-07 11:16:29.000000000","message":"this needs to match the name you gave on puppet. if you want puppet to reference this correctly (from the variable name) you need to use only underscores.","commit_id":"661db0663215c5b3c28bcf5b126d895e569c3b9c"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"b88f63b2a9948cede5c2373e37a31219f4a1728d","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        if:"},{"line_number":130,"context_line":"        - internal_tls_enabled"},{"line_number":131,"context_line":"        - generate_service_certificates: true"},{"line_number":132,"context_line":"          ceph_grafana-server_certificate_specs:"},{"line_number":133,"context_line":"            service_certificate: \u0027/etc/pki/tls/certs/ceph_grafana.crt\u0027"},{"line_number":134,"context_line":"            service_key: \u0027/etc/pki/tls/private/ceph_grafana.key\u0027"},{"line_number":135,"context_line":"            hostname:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7faddb67_605d6eeb","line":132,"in_reply_to":"7faddb67_d5cd065f","updated":"2019-08-07 12:02:02.000000000","message":"right, so according to the puppet name we will have:\n\ns/ceph_grafana-server_certificate_specs/ceph_grafana_certificate_specs/","commit_id":"661db0663215c5b3c28bcf5b126d895e569c3b9c"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"4565b350eda7990c85e1cd4eb5c7d4761d39b514","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        - internal_tls_enabled"},{"line_number":131,"context_line":"        - generate_service_certificates: true"},{"line_number":132,"context_line":"          ceph_grafana-server_certificate_specs:"},{"line_number":133,"context_line":"            service_certificate: \u0027/etc/pki/tls/certs/ceph_grafana.crt\u0027"},{"line_number":134,"context_line":"            service_key: \u0027/etc/pki/tls/private/ceph_grafana.key\u0027"},{"line_number":135,"context_line":"            hostname:"},{"line_number":136,"context_line":"              str_replace:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7faddb67_552b5632","line":133,"updated":"2019-08-07 11:00:04.000000000","message":"we need to pass this path to ceph-ansible as grafana_crt","commit_id":"661db0663215c5b3c28bcf5b126d895e569c3b9c"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"b88f63b2a9948cede5c2373e37a31219f4a1728d","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        - internal_tls_enabled"},{"line_number":131,"context_line":"        - generate_service_certificates: true"},{"line_number":132,"context_line":"          ceph_grafana-server_certificate_specs:"},{"line_number":133,"context_line":"            service_certificate: \u0027/etc/pki/tls/certs/ceph_grafana.crt\u0027"},{"line_number":134,"context_line":"            service_key: \u0027/etc/pki/tls/private/ceph_grafana.key\u0027"},{"line_number":135,"context_line":"            hostname:"},{"line_number":136,"context_line":"              str_replace:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7faddb67_40df123a","line":133,"in_reply_to":"7faddb67_552b5632","updated":"2019-08-07 12:02:02.000000000","message":"yes, this is the next step. \nI think I need this variable here and I can manipulate it, right? Or are you saying to replace this variable with \"grafana_crt\"?","commit_id":"661db0663215c5b3c28bcf5b126d895e569c3b9c"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"4565b350eda7990c85e1cd4eb5c7d4761d39b514","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        - generate_service_certificates: true"},{"line_number":132,"context_line":"          ceph_grafana-server_certificate_specs:"},{"line_number":133,"context_line":"            service_certificate: \u0027/etc/pki/tls/certs/ceph_grafana.crt\u0027"},{"line_number":134,"context_line":"            service_key: \u0027/etc/pki/tls/private/ceph_grafana.key\u0027"},{"line_number":135,"context_line":"            hostname:"},{"line_number":136,"context_line":"              str_replace:"},{"line_number":137,"context_line":"                template: \"%{hiera(\u0027fqdn_NETWORK\u0027)}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7faddb67_7530d29f","line":134,"updated":"2019-08-07 11:00:04.000000000","message":"we need to pass this path to ceph-ansible as grafana_key","commit_id":"661db0663215c5b3c28bcf5b126d895e569c3b9c"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"b88f63b2a9948cede5c2373e37a31219f4a1728d","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        - generate_service_certificates: true"},{"line_number":132,"context_line":"          ceph_grafana-server_certificate_specs:"},{"line_number":133,"context_line":"            service_certificate: \u0027/etc/pki/tls/certs/ceph_grafana.crt\u0027"},{"line_number":134,"context_line":"            service_key: \u0027/etc/pki/tls/private/ceph_grafana.key\u0027"},{"line_number":135,"context_line":"            hostname:"},{"line_number":136,"context_line":"              str_replace:"},{"line_number":137,"context_line":"                template: \"%{hiera(\u0027fqdn_NETWORK\u0027)}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7faddb67_00e11afd","line":134,"in_reply_to":"7faddb67_7530d29f","updated":"2019-08-07 12:02:02.000000000","message":"ditto","commit_id":"661db0663215c5b3c28bcf5b126d895e569c3b9c"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"322e52e3087d95f7689e8cea2a10dbd94b252dad","unresolved":false,"context_lines":[{"line_number":139,"context_line":"                  NETWORK: {get_param: [ServiceNetMap, CephGrafanaNetwork]}"},{"line_number":140,"context_line":"            principal:"},{"line_number":141,"context_line":"              str_replace:"},{"line_number":142,"context_line":"                template: \"ceph_grafana/%{hiera(\u0027fqdn_NETWORK\u0027)}\""},{"line_number":143,"context_line":"                params:"},{"line_number":144,"context_line":"                  NETWORK: {get_param: [ServiceNetMap, CephGrafanaNetwork]}"},{"line_number":145,"context_line":"        - {}"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7faddb67_15fdde6d","line":142,"range":{"start_line":142,"start_character":27,"end_line":142,"end_character":39},"updated":"2019-08-07 11:16:29.000000000","message":"ceph_graphana is the service principal, and it needs to match the metadata_settings that you\u0027re setting up here.","commit_id":"661db0663215c5b3c28bcf5b126d895e569c3b9c"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"b88f63b2a9948cede5c2373e37a31219f4a1728d","unresolved":false,"context_lines":[{"line_number":139,"context_line":"                  NETWORK: {get_param: [ServiceNetMap, CephGrafanaNetwork]}"},{"line_number":140,"context_line":"            principal:"},{"line_number":141,"context_line":"              str_replace:"},{"line_number":142,"context_line":"                template: \"ceph_grafana/%{hiera(\u0027fqdn_NETWORK\u0027)}\""},{"line_number":143,"context_line":"                params:"},{"line_number":144,"context_line":"                  NETWORK: {get_param: [ServiceNetMap, CephGrafanaNetwork]}"},{"line_number":145,"context_line":"        - {}"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7faddb67_80be6ad2","line":142,"range":{"start_line":142,"start_character":27,"end_line":142,"end_character":39},"in_reply_to":"7faddb67_15fdde6d","updated":"2019-08-07 12:02:02.000000000","message":"ok thanks, so I\u0027m going to change the metadata_settings \"service\" to match this one","commit_id":"661db0663215c5b3c28bcf5b126d895e569c3b9c"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"322e52e3087d95f7689e8cea2a10dbd94b252dad","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        if:"},{"line_number":153,"context_line":"        - internal_tls_enabled"},{"line_number":154,"context_line":"        -"},{"line_number":155,"context_line":"          - service: ceph_grafana-server"},{"line_number":156,"context_line":"            network: {get_param: [ServiceNetMap, CephGrafanaNetwork]}"},{"line_number":157,"context_line":"            type: vip"},{"line_number":158,"context_line":"        - null"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7faddb67_35025a71","line":155,"updated":"2019-08-07 11:16:29.000000000","message":"the name here needs to match the service principal.","commit_id":"661db0663215c5b3c28bcf5b126d895e569c3b9c"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"b88f63b2a9948cede5c2373e37a31219f4a1728d","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        if:"},{"line_number":153,"context_line":"        - internal_tls_enabled"},{"line_number":154,"context_line":"        -"},{"line_number":155,"context_line":"          - service: ceph_grafana-server"},{"line_number":156,"context_line":"            network: {get_param: [ServiceNetMap, CephGrafanaNetwork]}"},{"line_number":157,"context_line":"            type: vip"},{"line_number":158,"context_line":"        - null"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7faddb67_a0ffe6a9","line":155,"in_reply_to":"7faddb67_35025a71","updated":"2019-08-07 12:02:02.000000000","message":"sure, like done before we will have:\n\ns/ceph_grafana-server/ceph_grafana/","commit_id":"661db0663215c5b3c28bcf5b126d895e569c3b9c"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"4565b350eda7990c85e1cd4eb5c7d4761d39b514","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        -"},{"line_number":155,"context_line":"          - service: ceph_grafana-server"},{"line_number":156,"context_line":"            network: {get_param: [ServiceNetMap, CephGrafanaNetwork]}"},{"line_number":157,"context_line":"            type: vip"},{"line_number":158,"context_line":"        - null"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7faddb67_f591229c","line":157,"updated":"2019-08-07 11:00:04.000000000","message":"I think this should be \"node\"","commit_id":"661db0663215c5b3c28bcf5b126d895e569c3b9c"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"322e52e3087d95f7689e8cea2a10dbd94b252dad","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        -"},{"line_number":155,"context_line":"          - service: ceph_grafana-server"},{"line_number":156,"context_line":"            network: {get_param: [ServiceNetMap, CephGrafanaNetwork]}"},{"line_number":157,"context_line":"            type: vip"},{"line_number":158,"context_line":"        - null"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7faddb67_551116af","line":157,"in_reply_to":"7faddb67_f591229c","updated":"2019-08-07 11:16:29.000000000","message":"It all depends on the networking for this service; but most likely it\u0027ll be node.\n\n\"vip\" is used for services that have an elastic IP (or virtual IP), that are normally accessed via it. e.g. mysql, haproxy, redis.\n\nnode is for hosts that listen on the host\u0027s ip address in a specific network (not the VIP).","commit_id":"661db0663215c5b3c28bcf5b126d895e569c3b9c"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"1dce24673bc85ebd6c4c6f60dbd06d18d99c57dd","unresolved":false,"context_lines":[{"line_number":96,"context_line":"          grafana_port: 3100"},{"line_number":97,"context_line":"          prometheus_container_image: {get_param: PrometheusContainerImage}"},{"line_number":98,"context_line":"          alertmanager_container_image: {get_param: AlertManagerContainerImage}"},{"line_number":99,"context_line":"          node_exporter_container_image: {get_param: NodeExporterContainerImage}"},{"line_number":100,"context_line":"outputs:"},{"line_number":101,"context_line":"  role_data:"},{"line_number":102,"context_line":"    description: Role data for the Ceph Dashboard service."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7faddb67_7b9d23ba","line":99,"updated":"2019-08-07 12:37:05.000000000","message":"you can add here:\n\n  grafana_crt\n  grafana_key\n\nand set these to the paths below (l132, l133)","commit_id":"545e6e2656aa42bfd6d1f41b3b32ce308aa87467"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"50a6ec258aacce85f62703fb297471a887d2c80e","unresolved":false,"context_lines":[{"line_number":142,"context_line":"              str_replace:"},{"line_number":143,"context_line":"                template: \"ceph_grafana/%{hiera(\u0027fqdn_NETWORK\u0027)}\""},{"line_number":144,"context_line":"                params:"},{"line_number":145,"context_line":"                  NETWORK: {get_param: [ServiceNetMap, CephGrafanaNetwork]}"},{"line_number":146,"context_line":"        - {}"},{"line_number":147,"context_line":"        map_merge:"},{"line_number":148,"context_line":"        - tripleo::ceph_dashboard::firewall_rules:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7faddb67_fdd3d65d","line":145,"updated":"2019-08-14 10:38:08.000000000","message":"what about the post save command? what happens when the certificate gets renewed?","commit_id":"f44bfdfba57751fb0cc82dfa45bc451a2f87063c"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"c26254eeca8032c565267ecc2dd35fd7ed716710","unresolved":false,"context_lines":[{"line_number":142,"context_line":"              str_replace:"},{"line_number":143,"context_line":"                template: \"ceph_grafana/%{hiera(\u0027fqdn_NETWORK\u0027)}\""},{"line_number":144,"context_line":"                params:"},{"line_number":145,"context_line":"                  NETWORK: {get_param: [ServiceNetMap, CephGrafanaNetwork]}"},{"line_number":146,"context_line":"        - {}"},{"line_number":147,"context_line":"        map_merge:"},{"line_number":148,"context_line":"        - tripleo::ceph_dashboard::firewall_rules:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7faddb67_00868566","line":145,"in_reply_to":"7faddb67_fdd3d65d","updated":"2019-08-14 11:43:30.000000000","message":"Hi,\nwhen the certificate gets renewed I think we need the following:\n\npostsave_cmd: \"/usr/bin/certmonger-grafana-refresh.sh\"\n\nthat basically performs a restart of the grafana container.\nWe need to put that script on puppet-tripleo project, so I think I will make this change in the next PS and I will add a \"Depends-On\" to the puppet-tripleo change to include the script.\n\nThanks for the review!","commit_id":"f44bfdfba57751fb0cc82dfa45bc451a2f87063c"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"6b827e09aa5c7cdcdd5362a3a255be6ddd86693a","unresolved":false,"context_lines":[{"line_number":143,"context_line":"                template: \"ceph_grafana/%{hiera(\u0027fqdn_NETWORK\u0027)}\""},{"line_number":144,"context_line":"                params:"},{"line_number":145,"context_line":"                  NETWORK: {get_param: [ServiceNetMap, CephGrafanaNetwork]}"},{"line_number":146,"context_line":"            postsave_cmd: \"/usr/bin/certmonger-grafana-refresh.sh\""},{"line_number":147,"context_line":"        - {}"},{"line_number":148,"context_line":"        map_merge:"},{"line_number":149,"context_line":"        - tripleo::ceph_dashboard::firewall_rules:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7faddb67_80fd953c","line":146,"updated":"2019-08-14 12:20:09.000000000","message":"maybe we could use a systemd restart here","commit_id":"948edb977b2183e68f33cf01f23efb9a147af7f3"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"140073c7d8a92aec7588718056575d043b752fd7","unresolved":false,"context_lines":[{"line_number":143,"context_line":"                template: \"ceph_grafana/%{hiera(\u0027fqdn_NETWORK\u0027)}\""},{"line_number":144,"context_line":"                params:"},{"line_number":145,"context_line":"                  NETWORK: {get_param: [ServiceNetMap, CephGrafanaNetwork]}"},{"line_number":146,"context_line":"            postsave_cmd: \"/usr/bin/certmonger-grafana-refresh.sh\""},{"line_number":147,"context_line":"        - {}"},{"line_number":148,"context_line":"        map_merge:"},{"line_number":149,"context_line":"        - tripleo::ceph_dashboard::firewall_rules:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7faddb67_d95f07e3","line":146,"in_reply_to":"7faddb67_3b4e5638","updated":"2019-08-14 15:52:32.000000000","message":"I\u0027ll try to do some testing, but I\u0027m not sure we\u0027ll able to find an appropriate env. I\u0027ll follow-up in the next days, and thanks for the reviews!","commit_id":"948edb977b2183e68f33cf01f23efb9a147af7f3"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"914b5077e8c10015efe8ffbe9fdb314c8ffbe712","unresolved":false,"context_lines":[{"line_number":143,"context_line":"                template: \"ceph_grafana/%{hiera(\u0027fqdn_NETWORK\u0027)}\""},{"line_number":144,"context_line":"                params:"},{"line_number":145,"context_line":"                  NETWORK: {get_param: [ServiceNetMap, CephGrafanaNetwork]}"},{"line_number":146,"context_line":"            postsave_cmd: \"/usr/bin/certmonger-grafana-refresh.sh\""},{"line_number":147,"context_line":"        - {}"},{"line_number":148,"context_line":"        map_merge:"},{"line_number":149,"context_line":"        - tripleo::ceph_dashboard::firewall_rules:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7faddb67_db82a252","line":146,"in_reply_to":"7faddb67_80fd953c","updated":"2019-08-14 12:37:42.000000000","message":"Not sure if we can run the command inline, but I think it\u0027s possible to trigger the systemd unit restart here, at least we can try.","commit_id":"948edb977b2183e68f33cf01f23efb9a147af7f3"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"085571de8be8354faad819ba3f74dbfc3cb68104","unresolved":false,"context_lines":[{"line_number":143,"context_line":"                template: \"ceph_grafana/%{hiera(\u0027fqdn_NETWORK\u0027)}\""},{"line_number":144,"context_line":"                params:"},{"line_number":145,"context_line":"                  NETWORK: {get_param: [ServiceNetMap, CephGrafanaNetwork]}"},{"line_number":146,"context_line":"            postsave_cmd: \"/usr/bin/certmonger-grafana-refresh.sh\""},{"line_number":147,"context_line":"        - {}"},{"line_number":148,"context_line":"        map_merge:"},{"line_number":149,"context_line":"        - tripleo::ceph_dashboard::firewall_rules:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7faddb67_7bf28ee5","line":146,"in_reply_to":"7faddb67_db82a252","updated":"2019-08-14 12:43:11.000000000","message":"I suggest to leave the .sh call right now. We can follow the pattern seen with the other OSP services and we can change this later.\nGiulio wdyt?","commit_id":"948edb977b2183e68f33cf01f23efb9a147af7f3"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"e85ca1f6f024d8a9b186e16fa700534076e0df76","unresolved":false,"context_lines":[{"line_number":143,"context_line":"                template: \"ceph_grafana/%{hiera(\u0027fqdn_NETWORK\u0027)}\""},{"line_number":144,"context_line":"                params:"},{"line_number":145,"context_line":"                  NETWORK: {get_param: [ServiceNetMap, CephGrafanaNetwork]}"},{"line_number":146,"context_line":"            postsave_cmd: \"/usr/bin/certmonger-grafana-refresh.sh\""},{"line_number":147,"context_line":"        - {}"},{"line_number":148,"context_line":"        map_merge:"},{"line_number":149,"context_line":"        - tripleo::ceph_dashboard::firewall_rules:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7faddb67_1b6cba9a","line":146,"in_reply_to":"7faddb67_db82a252","updated":"2019-08-14 12:42:12.000000000","message":"ack, let\u0027s do that then","commit_id":"948edb977b2183e68f33cf01f23efb9a147af7f3"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"a66511634a85052705cd40c6f7c69d8da6301c97","unresolved":false,"context_lines":[{"line_number":143,"context_line":"                template: \"ceph_grafana/%{hiera(\u0027fqdn_NETWORK\u0027)}\""},{"line_number":144,"context_line":"                params:"},{"line_number":145,"context_line":"                  NETWORK: {get_param: [ServiceNetMap, CephGrafanaNetwork]}"},{"line_number":146,"context_line":"            postsave_cmd: \"/usr/bin/certmonger-grafana-refresh.sh\""},{"line_number":147,"context_line":"        - {}"},{"line_number":148,"context_line":"        map_merge:"},{"line_number":149,"context_line":"        - tripleo::ceph_dashboard::firewall_rules:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7faddb67_3b4e5638","line":146,"in_reply_to":"7faddb67_db82a252","updated":"2019-08-14 12:44:08.000000000","message":"alright, that works for me. Any chance you can give it a try and let me know the results of your testing?","commit_id":"948edb977b2183e68f33cf01f23efb9a147af7f3"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"a0afdb807dc883b1c32e6dbfdd60e822e1c17530","unresolved":false,"context_lines":[{"line_number":118,"context_line":"              - name: set ceph-ansible group vars"},{"line_number":119,"context_line":"                set_fact:"},{"line_number":120,"context_line":"                  ceph_ansible_group_vars_grafana:"},{"line_number":121,"context_line":"                    if:"},{"line_number":122,"context_line":"                    - internal_tls_enabled"},{"line_number":123,"context_line":"                    - yaql:"},{"line_number":124,"context_line":"                        data:"},{"line_number":125,"context_line":"                          default:"},{"line_number":126,"context_line":"                            map_merge:"},{"line_number":127,"context_line":"                            - {get_attr: [CephGrafanaAnsibleVars, value, vars]}"},{"line_number":128,"context_line":"                          certmap:"},{"line_number":129,"context_line":"                            grafana_crt: \u0027/etc/pki/tls/certs/ceph_grafana.crt\u0027"},{"line_number":130,"context_line":"                            grafana_key: \u0027/etc/pki/tls/private/ceph_grafana.key\u0027"},{"line_number":131,"context_line":"                        expression: $.data.default.mergeWith($.data.certmap)"},{"line_number":132,"context_line":"                    - {get_attr: [CephGrafanaAnsibleVars, value, vars]}"},{"line_number":133,"context_line":"              - name: generate ceph-ansible grafana-server group vars"},{"line_number":134,"context_line":"                copy:"},{"line_number":135,"context_line":"                  dest: \"{{playbook_dir}}/ceph-ansible/group_vars/grafana-server.yml\""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"7faddb67_b0d655f2","line":132,"range":{"start_line":121,"start_character":19,"end_line":132,"end_character":71},"updated":"2019-08-22 16:01:53.000000000","message":"In our ci job internal_tls_enabled \u003d\u003d false and I don\u0027t see the two grafana_{cert,key} variables as expected [1]\n\n[1] https://12942841482e92c0cd55-0acfe5e696fda6aec28b6c718c3c4841.ssl.cf1.rackcdn.com/674556/13/check/tripleo-ci-centos-7-scenario001-standalone/d957dce/logs/undercloud/home/zuul/undercloud-ansible-sJqhxi/ceph-ansible/group_vars/grafana-server.yml.txt.gz","commit_id":"13f2c6a91e68fa2d61179930450642d775238b6f"}]}