)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"a5b3740549835e2ab988b69b0d63132f91a5ac32","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is now a prerequisite so that we can run external update with"},{"line_number":10,"context_line":"--tags parameter and manage to execute some of those external tasks."},{"line_number":11,"context_line":"This was probably caused by a a bump in Ansible version or some refactoring"},{"line_number":12,"context_line":"in t-h-t."},{"line_number":13,"context_line":"The commit [0] inserted the same always tags into the external_upgrade_tasks,"},{"line_number":14,"context_line":"however it was missed for the external_update_tasks. At the same task,"},{"line_number":15,"context_line":"this patch syncs the variables content we pass into external_update_tasks"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7faddb67_f86a4feb","line":12,"range":{"start_line":11,"start_character":0,"end_line":12,"end_character":9},"updated":"2019-08-09 09:39:31.000000000","message":"This is due to the switch to \"include_tasks\" because of the depreciation of \"include\" in ansible.  Those two statements don\u0027t have the same behavior regarding tags.","commit_id":"1c08fefd091403b1db51b4eeeea5d1907766a3ee"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"d22e7ef8aed6cf67b2c392f5de595527affa6893","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is now a prerequisite so that we can run external update with"},{"line_number":10,"context_line":"--tags parameter and manage to execute some of those external tasks."},{"line_number":11,"context_line":"This was probably caused by a a bump in Ansible version or some refactoring"},{"line_number":12,"context_line":"in t-h-t."},{"line_number":13,"context_line":"The commit [0] inserted the same always tags into the external_upgrade_tasks,"},{"line_number":14,"context_line":"however it was missed for the external_update_tasks. At the same task,"},{"line_number":15,"context_line":"this patch syncs the variables content we pass into external_update_tasks"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7faddb67_bb53716c","line":12,"range":{"start_line":11,"start_character":0,"end_line":12,"end_character":9},"in_reply_to":"7faddb67_f86a4feb","updated":"2019-08-09 10:04:11.000000000","message":"Import_tasks was used for non looping statement (static) during the migration, while \"include_tasks\" was used for looping statement (dynamic).\n\nThe solution for include_tasks is to append the always tag as seen https://github.com/ansible/ansible/issues/30882#issuecomment-380596557","commit_id":"1c08fefd091403b1db51b4eeeea5d1907766a3ee"}],"common/deploy-steps.j2":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"9d4c6f669e25a0d9367ff9bdf2f0d93d5fb09c5d","unresolved":false,"context_lines":[{"line_number":981,"context_line":"              any_errors_fatal: yes"},{"line_number":982,"context_line":"              become: false"},{"line_number":983,"context_line":"              vars:"},{"line_number":984,"context_line":"                # Explicit ansible_python_interpreter to allow connecting"},{"line_number":985,"context_line":"                # to different OS releases (EL7/8) while using delegate_to."},{"line_number":986,"context_line":"                ansible_python_interpreter: /usr/libexec/platform-python"},{"line_number":987,"context_line":"                bootstrap_server_id: BOOTSTRAP_SERVER_ID"},{"line_number":988,"context_line":"                deploy_identifier: DEPLOY_IDENTIFIER"},{"line_number":989,"context_line":"                enable_debug: ENABLE_DEBUG"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"7faddb67_18440b1b","line":986,"range":{"start_line":984,"start_character":0,"end_line":986,"end_character":72},"updated":"2019-08-09 08:43:44.000000000","message":"this seems unrelated to the change, or missing an explanation in the commit msg?","commit_id":"7ebce4df7123bc973ea5466bb15a9a033eefae83"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"fb964b42f2d5e7716b96159546b6452e8046001b","unresolved":false,"context_lines":[{"line_number":981,"context_line":"              any_errors_fatal: yes"},{"line_number":982,"context_line":"              become: false"},{"line_number":983,"context_line":"              vars:"},{"line_number":984,"context_line":"                # Explicit ansible_python_interpreter to allow connecting"},{"line_number":985,"context_line":"                # to different OS releases (EL7/8) while using delegate_to."},{"line_number":986,"context_line":"                ansible_python_interpreter: /usr/libexec/platform-python"},{"line_number":987,"context_line":"                bootstrap_server_id: BOOTSTRAP_SERVER_ID"},{"line_number":988,"context_line":"                deploy_identifier: DEPLOY_IDENTIFIER"},{"line_number":989,"context_line":"                enable_debug: ENABLE_DEBUG"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"7faddb67_38db0722","line":986,"range":{"start_line":984,"start_character":0,"end_line":986,"end_character":72},"in_reply_to":"7faddb67_18440b1b","updated":"2019-08-09 08:57:24.000000000","message":"Ack, I guess this isn\u0027t needed as when we execute the minor update we\u0027re already in RHEL8. I\u0027ll remove it, thanks for the review.","commit_id":"7ebce4df7123bc973ea5466bb15a9a033eefae83"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"a5b3740549835e2ab988b69b0d63132f91a5ac32","unresolved":false,"context_lines":[{"line_number":701,"context_line":"                docker_puppet_process_count: DOCKER_PUPPET_PROCESS_COUNT"},{"line_number":702,"context_line":"                docker_puppet_mount_host_puppet: DOCKER_PUPPET_MOUNT_HOST_PUPPET"},{"line_number":703,"context_line":"              tasks:"},{"line_number":704,"context_line":"                - import_tasks: external_deploy_steps_tasks.yaml"},{"line_number":705,"context_line":"              tags:"},{"line_number":706,"context_line":"                - external"},{"line_number":707,"context_line":"                - external_deploy_steps"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"7faddb67_5b9efdb8","line":704,"range":{"start_line":704,"start_character":1,"end_line":704,"end_character":64},"updated":"2019-08-09 09:39:31.000000000","message":"so here \"import_tasks\" is used, wondering if that isn\u0027t the \"right\" solution.","commit_id":"1c08fefd091403b1db51b4eeeea5d1907766a3ee"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"a5b3740549835e2ab988b69b0d63132f91a5ac32","unresolved":false,"context_lines":[{"line_number":802,"context_line":"                docker_puppet_process_count: DOCKER_PUPPET_PROCESS_COUNT"},{"line_number":803,"context_line":"                docker_puppet_mount_host_puppet: DOCKER_PUPPET_MOUNT_HOST_PUPPET"},{"line_number":804,"context_line":"              tasks:"},{"line_number":805,"context_line":"                - import_tasks: external_post_deploy_steps_tasks.yaml"},{"line_number":806,"context_line":"              tags:"},{"line_number":807,"context_line":"                - external"},{"line_number":808,"context_line":"                - external_deploy_steps"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"7faddb67_bbacd1ee","line":805,"range":{"start_line":805,"start_character":1,"end_line":805,"end_character":69},"updated":"2019-08-09 09:39:31.000000000","message":"here as well.","commit_id":"1c08fefd091403b1db51b4eeeea5d1907766a3ee"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"a5b3740549835e2ab988b69b0d63132f91a5ac32","unresolved":false,"context_lines":[{"line_number":980,"context_line":"              gather_facts: {{ \u0027\"{{\u0027 }} gather_facts | default(false) {{ \u0027}}\"\u0027 }}"},{"line_number":981,"context_line":"              any_errors_fatal: yes"},{"line_number":982,"context_line":"              become: false"},{"line_number":983,"context_line":"              vars:"},{"line_number":984,"context_line":"                bootstrap_server_id: BOOTSTRAP_SERVER_ID"},{"line_number":985,"context_line":"                deploy_identifier: DEPLOY_IDENTIFIER"},{"line_number":986,"context_line":"                enable_debug: ENABLE_DEBUG"},{"line_number":987,"context_line":"                enable_puppet: ENABLE_PUPPET"},{"line_number":988,"context_line":"                container_cli: CONTAINER_CLI"},{"line_number":989,"context_line":"                container_log_stdout_path: CONTAINER_LOG_STDOUT_PATH"},{"line_number":990,"context_line":"                container_healthcheck_disabled: CONTAINER_HEALTHCHECK_DISABLED"},{"line_number":991,"context_line":"                docker_puppet_debug: DOCKER_PUPPET_DEBUG"},{"line_number":992,"context_line":"                docker_puppet_process_count: DOCKER_PUPPET_PROCESS_COUNT"},{"line_number":993,"context_line":"                docker_puppet_mount_host_puppet: DOCKER_PUPPET_MOUNT_HOST_PUPPET"},{"line_number":994,"context_line":"              tasks:"},{"line_number":995,"context_line":"                - include_tasks: external_update_steps_tasks.yaml"},{"line_number":996,"context_line":"                  with_sequence: start\u003d0 end\u003d{{external_update_steps_max-1}}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"7faddb67_5b87dd62","line":993,"range":{"start_line":983,"start_character":1,"end_line":993,"end_character":80},"updated":"2019-08-09 09:39:31.000000000","message":"why do we need to repeat this ?","commit_id":"1c08fefd091403b1db51b4eeeea5d1907766a3ee"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"a5b3740549835e2ab988b69b0d63132f91a5ac32","unresolved":false,"context_lines":[{"line_number":996,"context_line":"                  with_sequence: start\u003d0 end\u003d{{external_update_steps_max-1}}"},{"line_number":997,"context_line":"                  loop_control:"},{"line_number":998,"context_line":"                    loop_var: step"},{"line_number":999,"context_line":"                  tags: always"},{"line_number":1000,"context_line":"              tags:"},{"line_number":1001,"context_line":"                - external"},{"line_number":1002,"context_line":"                - external_update_steps"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"7faddb67_fb7b2978","line":999,"range":{"start_line":999,"start_character":5,"end_line":999,"end_character":30},"updated":"2019-08-09 09:39:31.000000000","message":"considering the behavior of include_tasks, I\u0027m wondering if we don\u0027t introduce unwanted side effect.","commit_id":"1c08fefd091403b1db51b4eeeea5d1907766a3ee"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"a5b3740549835e2ab988b69b0d63132f91a5ac32","unresolved":false,"context_lines":[{"line_number":1202,"context_line":"            - hosts: DEPLOY_TARGET_HOST"},{"line_number":1203,"context_line":"              any_errors_fatal: yes"},{"line_number":1204,"context_line":"              tasks:"},{"line_number":1205,"context_line":"                - include_tasks: post_upgrade_steps_tasks.yaml"},{"line_number":1206,"context_line":"                  with_sequence: start\u003d0 end\u003d{{post_upgrade_steps_max-1}}"},{"line_number":1207,"context_line":"                  vars:"},{"line_number":1208,"context_line":"                    bootstrap_server_id: BOOTSTRAP_SERVER_ID"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"7faddb67_7b6179d3","line":1205,"range":{"start_line":1205,"start_character":17,"end_line":1205,"end_character":62},"updated":"2019-08-09 09:39:31.000000000","message":"Not tag here so this should be ok.  But this is not in sync we all the other external task, maybe it\u0027s legit, don\u0027t know yet.","commit_id":"1c08fefd091403b1db51b4eeeea5d1907766a3ee"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"a5b3740549835e2ab988b69b0d63132f91a5ac32","unresolved":false,"context_lines":[{"line_number":1307,"context_line":"                  with_sequence: start\u003d0 end\u003d{{external_upgrade_steps_max-1}}"},{"line_number":1308,"context_line":"                  loop_control:"},{"line_number":1309,"context_line":"                    loop_var: step"},{"line_number":1310,"context_line":"                  tags: always"},{"line_number":1311,"context_line":"              tags:"},{"line_number":1312,"context_line":"                - external"},{"line_number":1313,"context_line":"                - external_upgrade_steps"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"7faddb67_5bd59d42","line":1310,"range":{"start_line":1310,"start_character":1,"end_line":1310,"end_character":30},"updated":"2019-08-09 09:39:31.000000000","message":"so wasn\u0027t import_tasks the rigth solution here as well ?","commit_id":"1c08fefd091403b1db51b4eeeea5d1907766a3ee"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"03c150bf2e0debbbd18fadf1760fb43a9a61362a","unresolved":false,"context_lines":[{"line_number":1307,"context_line":"                  with_sequence: start\u003d0 end\u003d{{external_upgrade_steps_max-1}}"},{"line_number":1308,"context_line":"                  loop_control:"},{"line_number":1309,"context_line":"                    loop_var: step"},{"line_number":1310,"context_line":"                  tags: always"},{"line_number":1311,"context_line":"              tags:"},{"line_number":1312,"context_line":"                - external"},{"line_number":1313,"context_line":"                - external_upgrade_steps"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"7faddb67_1bbba572","line":1310,"range":{"start_line":1310,"start_character":1,"end_line":1310,"end_character":30},"in_reply_to":"7faddb67_5bd59d42","updated":"2019-08-09 10:05:31.000000000","message":"As discussed in #rhos-upgrades irc channel, the reason to change from include into include/import_tasks was that include got depreacted from Ansible 2.4. include_tasks has a different handling of the tags compared to import_tasks, so you\u0027re right that the easy solution here would have been using import_tasks. However, you can\u0027t use import_tasks in a loop (you\u0027ll get -\u003e ERROR! You cannot use loops on \u0027import_tasks\u0027 statements. You should use \u0027include_tasks\u0027 instead.) Being that the main reason why the include got changed into include_tasks. Now, the only way to preserve the tasks execution when having an include_tasks, seems to be passing tags: always, as explained in this github issue: https://github.com/ansible/ansible/issues/30882#issuecomment-380596557.\nThis explains why adding tags: always let\u0027s us execute the tasks within external_upgrade_steps_tasks.yaml and not external_update_steps_tasks.yaml (which was missing it).","commit_id":"1c08fefd091403b1db51b4eeeea5d1907766a3ee"}]}