)]}'
{"deployment/ironic/ironic-inspector-container-puppet.yaml":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"43ef0aa33e258ad05c45c2cc54706afd2e4fa469","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        \u0027137 ironic-inspector\u0027:"},{"line_number":180,"context_line":"          dport:"},{"line_number":181,"context_line":"            - 5050"},{"line_number":182,"context_line":"        \u0027137 ironic-inspector dhcp input\u0027:"},{"line_number":183,"context_line":"          iniface: {get_param: IronicInspectorInterface}"},{"line_number":184,"context_line":"          proto: \u0027udp\u0027"},{"line_number":185,"context_line":"          chain: \u0027INPUT\u0027"},{"line_number":186,"context_line":"          dport: 67"},{"line_number":187,"context_line":"        \u0027137 ironic-inspector dhcp output\u0027:"},{"line_number":188,"context_line":"          proto: \u0027udp\u0027"},{"line_number":189,"context_line":"          chain: \u0027OUTPUT\u0027"},{"line_number":190,"context_line":"          dport: 68"},{"line_number":191,"context_line":"      monitoring_subscription: {get_param: MonitoringSubscriptionIronicInspector}"},{"line_number":192,"context_line":"      config_settings:"},{"line_number":193,"context_line":"        map_merge:"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"3fa7e38b_3ac0a250","line":190,"range":{"start_line":182,"start_character":0,"end_line":190,"end_character":19},"updated":"2019-09-21 15:17:00.000000000","message":"Not a problem specific to this change. But, we should have support for setting firewall rules based on IP version. The DHCP ports used for IPv4 is 67 (client) and 68 (server). On IPv6 DHCPv6 uses ports 546 (clients) and 547 (servers).\n\nI put some comments on https://review.opendev.org/680485 which is already merged. I think this needs fixing?","commit_id":"c960420c5545968a871f9b9293039cc4c12e241f"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"1d7814dd0b6aa9862203c5f518f631d1cc4b93c7","unresolved":false,"context_lines":[{"line_number":175,"context_line":"    description: Role data for the Ironic Inspector role."},{"line_number":176,"context_line":"    value:"},{"line_number":177,"context_line":"      service_name: ironic_inspector"},{"line_number":178,"context_line":"      firewall_rules:"},{"line_number":179,"context_line":"        \u0027137 ironic-inspector\u0027:"},{"line_number":180,"context_line":"          dport:"},{"line_number":181,"context_line":"            - 5050"},{"line_number":182,"context_line":"        \u0027137 ironic-inspector dhcp input\u0027:"},{"line_number":183,"context_line":"          iniface: {get_param: IronicInspectorInterface}"},{"line_number":184,"context_line":"          proto: \u0027udp\u0027"},{"line_number":185,"context_line":"          chain: \u0027INPUT\u0027"},{"line_number":186,"context_line":"          dport: 67"},{"line_number":187,"context_line":"        \u0027137 ironic-inspector dhcp output\u0027:"},{"line_number":188,"context_line":"          proto: \u0027udp\u0027"},{"line_number":189,"context_line":"          chain: \u0027OUTPUT\u0027"},{"line_number":190,"context_line":"          dport: 68"},{"line_number":191,"context_line":"      monitoring_subscription: {get_param: MonitoringSubscriptionIronicInspector}"},{"line_number":192,"context_line":"      config_settings:"},{"line_number":193,"context_line":"        map_merge:"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"3fa7e38b_4f601ed0","line":190,"range":{"start_line":178,"start_character":0,"end_line":190,"end_character":19},"updated":"2019-10-09 20:30:51.000000000","message":"This need an update to match:\nhttps://review.opendev.org/684385","commit_id":"c78deb7d98cfb958bc8e76f590a18f65dfabb591"}],"deployment/neutron/neutron-dhcp-container-puppet.yaml":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"1d7814dd0b6aa9862203c5f518f631d1cc4b93c7","unresolved":false,"context_lines":[{"line_number":180,"context_line":"    description: Role data for the Neutron DHCP role."},{"line_number":181,"context_line":"    value:"},{"line_number":182,"context_line":"      service_name: neutron_dhcp"},{"line_number":183,"context_line":"      firewall_rules:"},{"line_number":184,"context_line":"        \u0027115 neutron dhcp input\u0027:"},{"line_number":185,"context_line":"          proto: \u0027udp\u0027"},{"line_number":186,"context_line":"          dport: 67"},{"line_number":187,"context_line":"        \u0027116 neutron dhcp output\u0027:"},{"line_number":188,"context_line":"          proto: \u0027udp\u0027"},{"line_number":189,"context_line":"          chain: \u0027OUTPUT\u0027"},{"line_number":190,"context_line":"          dport: 68"},{"line_number":191,"context_line":"      monitoring_subscription: {get_param: MonitoringSubscriptionNeutronDhcp}"},{"line_number":192,"context_line":"      config_settings:"},{"line_number":193,"context_line":"        map_merge:"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"3fa7e38b_2fa122f9","line":190,"range":{"start_line":183,"start_character":0,"end_line":190,"end_character":19},"updated":"2019-10-09 20:30:51.000000000","message":"This need an update to match:\nhttps://review.opendev.org/684385","commit_id":"c78deb7d98cfb958bc8e76f590a18f65dfabb591"}],"deployment/neutron/neutron-ovs-dpdk-agent-container-puppet.yaml":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"a2af82e7e4f54a192df04ec383b249b6166a51c3","unresolved":false,"context_lines":[{"line_number":118,"context_line":"          - map_replace:"},{"line_number":119,"context_line":"            - get_attr: [NeutronOvsAgent, role_data, config_settings]"},{"line_number":120,"context_line":"            - keys:"},{"line_number":121,"context_line":"                tripleo::neutron_ovs_agent::firewall_rules: tripleo::neutron_ovs_dpdk_agent::firewall_rules"},{"line_number":122,"context_line":"          - neutron::agents::ml2::ovs::enable_dpdk: true"},{"line_number":123,"context_line":"          - get_attr: [Ovs, role_data, config_settings]"},{"line_number":124,"context_line":"          - get_attr: [RoleParametersValue, value]"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"3fa7e38b_ead6754f","side":"PARENT","line":121,"updated":"2019-11-14 21:15:48.000000000","message":"I\u0027m not sure what exactly this is doing but is this covered in this coversion?","commit_id":"def359fd3056a27318e91f00c6322704b0319684"}]}