)]}'
{"deployment/neutron/neutron-agents-ib-config-container-puppet.yaml":[{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"f5c04b66789a4ac19cb1060d92fb39007d1cdd31","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"  # Merging role-specific parameters (RoleParameters) with the default parameters."},{"line_number":49,"context_line":"  # RoleParameters will have the precedence over the default parameters."},{"line_number":50,"context_line":"  RoleParametersValue:"},{"line_number":51,"context_line":"    type: OS::Heat::Value"},{"line_number":52,"context_line":"    properties:"},{"line_number":53,"context_line":"      type: json"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5faad753_5d90cded","line":50,"updated":"2019-09-13 04:23:16.000000000","message":"As there is no role-specific merging is done, this resource is not required. The config settings could be merged directly at line @85","commit_id":"739e984e3eb5b255a0f2914ea2afcb8438cc005a"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"319d2c262904fb0dd5315b278e8e9856522f8fe9","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"  # Merging role-specific parameters (RoleParameters) with the default parameters."},{"line_number":49,"context_line":"  # RoleParameters will have the precedence over the default parameters."},{"line_number":50,"context_line":"  RoleParametersValue:"},{"line_number":51,"context_line":"    type: OS::Heat::Value"},{"line_number":52,"context_line":"    properties:"},{"line_number":53,"context_line":"      type: json"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5faad753_5ae74aad","line":50,"in_reply_to":"5faad753_5d90cded","updated":"2019-09-16 09:04:45.000000000","message":"Done","commit_id":"739e984e3eb5b255a0f2914ea2afcb8438cc005a"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"f5c04b66789a4ac19cb1060d92fb39007d1cdd31","unresolved":false,"context_lines":[{"line_number":113,"context_line":"                  - \u0027\u0027"},{"line_number":114,"context_line":"            environment:"},{"line_number":115,"context_line":"              - KOLLA_CONFIG_STRATEGY\u003dCOPY_ALWAYS"},{"line_number":116,"context_line":"      step_config: |"},{"line_number":117,"context_line":"        include ::tripleo::profile::base::neutron::plugins::ml2"},{"line_number":118,"context_line":"      metadata_settings:"},{"line_number":119,"context_line":"        get_attr: [NeutronBase, role_data, metadata_settings]"},{"line_number":120,"context_line":"      upgrade_tasks: []"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5faad753_ddb59d7f","line":117,"range":{"start_line":116,"start_character":6,"end_line":117,"end_character":63},"updated":"2019-09-13 04:23:16.000000000","message":"This section is not required as the config is being applied using the container.","commit_id":"739e984e3eb5b255a0f2914ea2afcb8438cc005a"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"319d2c262904fb0dd5315b278e8e9856522f8fe9","unresolved":false,"context_lines":[{"line_number":113,"context_line":"                  - \u0027\u0027"},{"line_number":114,"context_line":"            environment:"},{"line_number":115,"context_line":"              - KOLLA_CONFIG_STRATEGY\u003dCOPY_ALWAYS"},{"line_number":116,"context_line":"      step_config: |"},{"line_number":117,"context_line":"        include ::tripleo::profile::base::neutron::plugins::ml2"},{"line_number":118,"context_line":"      metadata_settings:"},{"line_number":119,"context_line":"        get_attr: [NeutronBase, role_data, metadata_settings]"},{"line_number":120,"context_line":"      upgrade_tasks: []"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5faad753_7ad326d6","line":117,"range":{"start_line":116,"start_character":6,"end_line":117,"end_character":63},"in_reply_to":"5faad753_ddb59d7f","updated":"2019-09-16 09:04:45.000000000","message":"Done","commit_id":"739e984e3eb5b255a0f2914ea2afcb8438cc005a"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"9ecc961228711ce67604c584537a2d2f518ec7d5","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    description: Mapping of service endpoint -\u003e protocol. Typically set"},{"line_number":34,"context_line":"                 via parameter_defaults in the resource registry."},{"line_number":35,"context_line":"    type: json"},{"line_number":36,"context_line":"  MultiInterfaceDriverMappings:"},{"line_number":37,"context_line":"    type: comma_delimited_list"},{"line_number":38,"context_line":"    default: \"\""},{"line_number":39,"context_line":"    tags:"},{"line_number":40,"context_line":"      - role_specific"},{"line_number":41,"context_line":"  IPoIBPhysicalInterface:"},{"line_number":42,"context_line":"    type: string"},{"line_number":43,"context_line":"    default: \u0027ib0\u0027"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3fa7e38b_0c6486b8","line":40,"range":{"start_line":36,"start_character":0,"end_line":40,"end_character":21},"updated":"2019-09-23 14:04:03.000000000","message":"You\u0027re missing the role specific param lookup for this.\n\nhttps://docs.openstack.org/project-deploy-guide/tripleo-docs/latest/features/role_specific_parameters.html","commit_id":"d68fd294d53c57b7243fdc4ed3fa6b635cc2f0a7"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"2b82d163b6bbda0a7edc59c3b6b24adf65ec34cf","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    description: Mapping of service endpoint -\u003e protocol. Typically set"},{"line_number":34,"context_line":"                 via parameter_defaults in the resource registry."},{"line_number":35,"context_line":"    type: json"},{"line_number":36,"context_line":"  MultiInterfaceDriverMappings:"},{"line_number":37,"context_line":"    type: comma_delimited_list"},{"line_number":38,"context_line":"    default: \"\""},{"line_number":39,"context_line":"    tags:"},{"line_number":40,"context_line":"      - role_specific"},{"line_number":41,"context_line":"  IPoIBPhysicalInterface:"},{"line_number":42,"context_line":"    type: string"},{"line_number":43,"context_line":"    default: \u0027ib0\u0027"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3fa7e38b_7ed26e02","line":40,"range":{"start_line":36,"start_character":0,"end_line":40,"end_character":21},"in_reply_to":"3fa7e38b_0c6486b8","updated":"2019-09-24 09:55:56.000000000","message":"Done","commit_id":"d68fd294d53c57b7243fdc4ed3fa6b635cc2f0a7"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"045a8c5da01c1c882e4286d8b3d5c2c297c3197f","unresolved":false,"context_lines":[{"line_number":77,"context_line":"      service_name: neutron_agents_ib_config"},{"line_number":78,"context_line":"      config_settings:"},{"line_number":79,"context_line":"        map_merge:"},{"line_number":80,"context_line":"          - get_attr: [NeutronBase, role_data, config_settings]"},{"line_number":81,"context_line":"          - neutron::agents::ml2::mlnx::enabled: False"},{"line_number":82,"context_line":"            neutron::agents::ml2::mlnx::manage_service: False"},{"line_number":83,"context_line":"            neutron::agents::ml2::mlnx::manage_package: False"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3fa7e38b_2f91224f","line":80,"updated":"2019-09-24 12:29:29.000000000","message":"Merge RoleParametersValue with config_settings like\n\n- get_attr: [RoleParametersValue, value]","commit_id":"075e9b38782e5f8e519f9dc02ed2c6ff5aec9a54"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"34cb2c27f4e73e9c9a81b842f1733098cbfa1398","unresolved":false,"context_lines":[{"line_number":77,"context_line":"      service_name: neutron_agents_ib_config"},{"line_number":78,"context_line":"      config_settings:"},{"line_number":79,"context_line":"        map_merge:"},{"line_number":80,"context_line":"          - get_attr: [NeutronBase, role_data, config_settings]"},{"line_number":81,"context_line":"          - neutron::agents::ml2::mlnx::enabled: False"},{"line_number":82,"context_line":"            neutron::agents::ml2::mlnx::manage_service: False"},{"line_number":83,"context_line":"            neutron::agents::ml2::mlnx::manage_package: False"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3fa7e38b_45747dfe","line":80,"in_reply_to":"3fa7e38b_2f91224f","updated":"2019-09-24 13:56:32.000000000","message":"Done","commit_id":"075e9b38782e5f8e519f9dc02ed2c6ff5aec9a54"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"045a8c5da01c1c882e4286d8b3d5c2c297c3197f","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            neutron::agents::ml2::mlnx::manage_package: False"},{"line_number":84,"context_line":"            neutron::agents::ml2::mlnx::dhcp_broadcast_reply: true"},{"line_number":85,"context_line":"            neutron::agents::ml2::mlnx::interface_driver : \u0027multi\u0027"},{"line_number":86,"context_line":"            neutron::agents::ml2::mlnx::ipoib_physical_interface : {get_param: IPoIBPhysicalInterface}"},{"line_number":87,"context_line":"            neutron::agents::ml2::mlnx::enable_multi_interface_driver_cache_maintenance : true"},{"line_number":88,"context_line":"      docker_config:"},{"line_number":89,"context_line":"        step_3:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3fa7e38b_8fa4d6a7","line":86,"range":{"start_line":86,"start_character":79,"end_line":86,"end_character":101},"updated":"2019-09-24 12:29:29.000000000","message":"Are you sure that you want this parameter IPoIBPhysicalInterface to be global and not as role-specific like MultiInterfaceDriverMappings?","commit_id":"075e9b38782e5f8e519f9dc02ed2c6ff5aec9a54"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"34cb2c27f4e73e9c9a81b842f1733098cbfa1398","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            neutron::agents::ml2::mlnx::manage_package: False"},{"line_number":84,"context_line":"            neutron::agents::ml2::mlnx::dhcp_broadcast_reply: true"},{"line_number":85,"context_line":"            neutron::agents::ml2::mlnx::interface_driver : \u0027multi\u0027"},{"line_number":86,"context_line":"            neutron::agents::ml2::mlnx::ipoib_physical_interface : {get_param: IPoIBPhysicalInterface}"},{"line_number":87,"context_line":"            neutron::agents::ml2::mlnx::enable_multi_interface_driver_cache_maintenance : true"},{"line_number":88,"context_line":"      docker_config:"},{"line_number":89,"context_line":"        step_3:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3fa7e38b_654ad9ac","line":86,"range":{"start_line":86,"start_character":79,"end_line":86,"end_character":101},"in_reply_to":"3fa7e38b_8fa4d6a7","updated":"2019-09-24 13:56:32.000000000","message":"fixed","commit_id":"075e9b38782e5f8e519f9dc02ed2c6ff5aec9a54"}],"deployment/neutron/neutron-mlnx-agent-container-puppet.yaml":[{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"67033fcb1f95d0341fcd4bd7cbeee1d180004f7a","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        map_replace:"},{"line_number":66,"context_line":"          - map_replace:"},{"line_number":67,"context_line":"            - neutron::agents::ml2::mlnx::physical_interface_mappings: NeutronPhysicalDevMappings"},{"line_number":68,"context_line":"              neutron::agents::ml2::mlnx::polling_interval: MlnxAgentPollingInterval"},{"line_number":69,"context_line":"            - values: {get_param: [RoleParameters]}"},{"line_number":70,"context_line":"          - values:"},{"line_number":71,"context_line":"              NeutronPhysicalDevMappings: {get_param: NeutronPhysicalDevMappings}"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3fa7e38b_667d51b0","side":"PARENT","line":68,"updated":"2019-09-19 12:15:30.000000000","message":"I dont know the reason for removing this parameter, but if it because it is not working, there is a line missing at line @71. It should be like below\n\n\n        map_replace:\n          - map_replace:\n            - neutron::agents::ml2::mlnx::physical_interface_mappings: NeutronPhysicalDevMappings\n              neutron::agents::ml2::mlnx::polling_interval: MlnxAgentPollingInterval\n            - values: {get_param: [RoleParameters]}\n          - values:\n              NeutronPhysicalDevMappings: {get_param: NeutronPhysicalDevMappings}\n              MlnxAgentPollingInterval: {get_param: MlnxAgentPollingInterval}","commit_id":"f7be913444d056ac3e7b9a13f1bb22ddf7528f00"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"a480850c165c5a83ef993ce1a29a9e6f20b9e5ea","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        map_replace:"},{"line_number":66,"context_line":"          - map_replace:"},{"line_number":67,"context_line":"            - neutron::agents::ml2::mlnx::physical_interface_mappings: NeutronPhysicalDevMappings"},{"line_number":68,"context_line":"              neutron::agents::ml2::mlnx::polling_interval: MlnxAgentPollingInterval"},{"line_number":69,"context_line":"            - values: {get_param: [RoleParameters]}"},{"line_number":70,"context_line":"          - values:"},{"line_number":71,"context_line":"              NeutronPhysicalDevMappings: {get_param: NeutronPhysicalDevMappings}"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3fa7e38b_0c227f53","side":"PARENT","line":68,"in_reply_to":"3fa7e38b_667d51b0","updated":"2019-09-19 12:41:30.000000000","message":"thanks, this way it works.\nwill apply the change in it\u0027s patch: https://review.opendev.org/#/c/674486/","commit_id":"f7be913444d056ac3e7b9a13f1bb22ddf7528f00"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"67033fcb1f95d0341fcd4bd7cbeee1d180004f7a","unresolved":false,"context_lines":[{"line_number":102,"context_line":"          - get_attr: [NeutronBase, role_data, config_settings]"},{"line_number":103,"context_line":"          - get_attr: [RoleParametersValue, value]"},{"line_number":104,"context_line":"          - get_attr: [MlnxAgentLogging, config_settings]"},{"line_number":105,"context_line":"          - neutron::agents::ml2::mlnx::polling_interval: MlnxAgentPollingInterval"},{"line_number":106,"context_line":"      puppet_config:"},{"line_number":107,"context_line":"        config_volume: \u0027neutron\u0027"},{"line_number":108,"context_line":"        puppet_tags: neutron_plugin_ml2"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3fa7e38b_86b16d92","line":105,"range":{"start_line":105,"start_character":58,"end_line":105,"end_character":82},"updated":"2019-09-19 12:15:30.000000000","message":"get_param is missing.","commit_id":"b1a66907102391e35aee0fd6018739e64e14a830"}],"environments/services/neutron-mlnx-agent-multi-interface.yaml":[{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"f5c04b66789a4ac19cb1060d92fb39007d1cdd31","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  ComputeSriovParameters:"},{"line_number":28,"context_line":"    # Kernel arguments for ComputeSriov node"},{"line_number":29,"context_line":"    KernelArgs: \"intel_iommu\u003don iommu\u003dpt\""},{"line_number":30,"context_line":"    TunedProfileName: \"throughput-performance\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5faad753_dd6a7deb","line":30,"range":{"start_line":30,"start_character":23,"end_line":30,"end_character":45},"updated":"2019-09-13 04:23:16.000000000","message":"Any specific reason for using this profile? All NFV deployments uses cpu partitioniong.","commit_id":"739e984e3eb5b255a0f2914ea2afcb8438cc005a"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"319d2c262904fb0dd5315b278e8e9856522f8fe9","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  ComputeSriovParameters:"},{"line_number":28,"context_line":"    # Kernel arguments for ComputeSriov node"},{"line_number":29,"context_line":"    KernelArgs: \"intel_iommu\u003don iommu\u003dpt\""},{"line_number":30,"context_line":"    TunedProfileName: \"throughput-performance\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5faad753_df180c1f","line":30,"range":{"start_line":30,"start_character":23,"end_line":30,"end_character":45},"in_reply_to":"5faad753_dd6a7deb","updated":"2019-09-16 09:04:45.000000000","message":"will remove TunedProfileName from here and leave it up to the operator.","commit_id":"739e984e3eb5b255a0f2914ea2afcb8438cc005a"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"4e182e7a8866a7b9695059afc36ce86437b7fbdd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# A Heat environment that can be used to enable MLNX agent in neutron with multi interface support."},{"line_number":2,"context_line":"resource_registry:"},{"line_number":3,"context_line":"  OS::TripleO::Services::NeutronMlnxAgent: ../../deployment/neutron/neutron-mlnx-agent-container-puppet.yaml"},{"line_number":4,"context_line":"  OS::TripleO::Services::NeutronCorePlugin: OS::TripleO::Services::NeutronCorePluginMLNXSDN"},{"line_number":5,"context_line":"  OS::TripleO::Services::NeutronAgentsIBConfig: ../../deployment/neutron/neutron-agents-ib-config-container-puppet.yaml"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"3fa7e38b_22cf6558","line":2,"updated":"2019-10-02 21:01:50.000000000","message":"just rename the file to neutron-mlnx-agent.yaml","commit_id":"6cac4ce10be3a56d980590324a230fc85b3efa64"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"6c665894024241b43b6fb856e001289b5afff765","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# A Heat environment that can be used to enable MLNX agent in neutron with multi interface support."},{"line_number":2,"context_line":"resource_registry:"},{"line_number":3,"context_line":"  OS::TripleO::Services::NeutronMlnxAgent: ../../deployment/neutron/neutron-mlnx-agent-container-puppet.yaml"},{"line_number":4,"context_line":"  OS::TripleO::Services::NeutronCorePlugin: OS::TripleO::Services::NeutronCorePluginMLNXSDN"},{"line_number":5,"context_line":"  OS::TripleO::Services::NeutronAgentsIBConfig: ../../deployment/neutron/neutron-agents-ib-config-container-puppet.yaml"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"3fa7e38b_e2d4e6bf","line":2,"in_reply_to":"3fa7e38b_22cf6558","updated":"2019-10-03 09:50:45.000000000","message":"Done, Also removed SDN params.","commit_id":"6cac4ce10be3a56d980590324a230fc85b3efa64"}]}