)]}'
{"deployment/nova/nova-api-container-puppet.yaml":[{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"b58c45914927cff984aa96cb6eb01ceeb846ffe6","unresolved":false,"context_lines":[{"line_number":455,"context_line":"            - name: Fail if nova-api healthcheck report failed status"},{"line_number":456,"context_line":"              fail:"},{"line_number":457,"context_line":"                msg: nova-api isn\u0027t working (healthcheck failed)"},{"line_number":458,"context_line":"              when: nova_api_healthcheck_state.status.ExecMainStatus !\u003d \u00270\u0027"},{"line_number":459,"context_line":"      host_prep_tasks: {get_attr: [NovaApiLogging, host_prep_tasks]}"},{"line_number":460,"context_line":"      external_upgrade_tasks:"},{"line_number":461,"context_line":"        - when: step|int \u003d\u003d 1"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5faad753_fb573cc9","line":458,"range":{"start_line":458,"start_character":14,"end_line":458,"end_character":19},"updated":"2019-09-13 10:56:01.000000000","message":"(mschuppert wrote:)\n\n\u003e another option would be to add a nova_wait_for_nova_api_service like we have for placement?\n\nThat will be necessary now as that these tasks are disabled when ContainerHealthcheckDisabled is true.","commit_id":"8269ffc8c24255fb9f021beb7692080a46278eee"}],"deployment/nova/nova-compute-common-container-puppet.yaml":[{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"a81cef6bb0c89cacdd2ac91203bd0a5ec1d68242","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            block:"},{"line_number":67,"context_line":"              # Could be included multiple times so ensure it only runs once"},{"line_number":68,"context_line":"              - set_fact:"},{"line_number":69,"context_line":"                  nova_cellv2_discovery_done: true"},{"line_number":70,"context_line":"              - name: discover via nova_compute?"},{"line_number":71,"context_line":"                set_fact:"},{"line_number":72,"context_line":"                  nova_cellv2_discovery_delegate_host: \"{{ groups[\u0027nova_compute\u0027][0] }}\""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"5faad753_4d6ebf2f","line":69,"range":{"start_line":69,"start_character":18,"end_line":69,"end_character":50},"updated":"2019-09-14 16:36:13.000000000","message":"looks like the block \u0027when\u0027 conditions are evaluated for each task not just at the beginning of the block, so this need to move to the end of the block or we will always skip","commit_id":"faf5c989ffbca6da250ccabeb891666d7ed2bd69"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"e70d5f8610984932627f89dbc068a6f2a10227c1","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            block:"},{"line_number":67,"context_line":"              - name: discover via nova_compute?"},{"line_number":68,"context_line":"                set_fact:"},{"line_number":69,"context_line":"                  nova_cellv2_discovery_delegate_host: \"{{ groups[\u0027nova_compute\u0027][0] }}\""},{"line_number":70,"context_line":"                when:"},{"line_number":71,"context_line":"                  - groups[\u0027nova_compute\u0027] is defined and (groups[\u0027nova_compute\u0027]|length\u003e0)"},{"line_number":72,"context_line":"              - name: discover via nova_ironic?"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3fa7e38b_5ef82ec3","line":69,"updated":"2019-09-18 15:15:51.000000000","message":"Add cacheable: false?","commit_id":"3e8e5f429ce47e0f506a9741ff47422c2893046d"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"9676369672a3c0cf5d5af0865156a9e551d62ad2","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            block:"},{"line_number":67,"context_line":"              - name: discover via nova_compute?"},{"line_number":68,"context_line":"                set_fact:"},{"line_number":69,"context_line":"                  nova_cellv2_discovery_delegate_host: \"{{ groups[\u0027nova_compute\u0027][0] }}\""},{"line_number":70,"context_line":"                when:"},{"line_number":71,"context_line":"                  - groups[\u0027nova_compute\u0027] is defined and (groups[\u0027nova_compute\u0027]|length\u003e0)"},{"line_number":72,"context_line":"              - name: discover via nova_ironic?"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3fa7e38b_beba82db","line":69,"in_reply_to":"3fa7e38b_5ef82ec3","updated":"2019-09-18 15:17:53.000000000","message":"defaults to false","commit_id":"3e8e5f429ce47e0f506a9741ff47422c2893046d"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"e70d5f8610984932627f89dbc068a6f2a10227c1","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                  - groups[\u0027nova_compute\u0027] is defined and (groups[\u0027nova_compute\u0027]|length\u003e0)"},{"line_number":72,"context_line":"              - name: discover via nova_ironic?"},{"line_number":73,"context_line":"                set_fact:"},{"line_number":74,"context_line":"                  nova_cellv2_discovery_delegate_host: \"{{ groups[\u0027nova_ironic\u0027][0] }}\""},{"line_number":75,"context_line":"                when:"},{"line_number":76,"context_line":"                  - nova_cellv2_discovery_delegate_host is not defined"},{"line_number":77,"context_line":"                  - groups[\u0027nova_ironic\u0027] is defined and (groups[\u0027nova_ironic\u0027]|length\u003e0)"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3fa7e38b_7ef5eaca","line":74,"updated":"2019-09-18 15:15:51.000000000","message":"Add cacheable: false?","commit_id":"3e8e5f429ce47e0f506a9741ff47422c2893046d"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"9676369672a3c0cf5d5af0865156a9e551d62ad2","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                  - groups[\u0027nova_compute\u0027] is defined and (groups[\u0027nova_compute\u0027]|length\u003e0)"},{"line_number":72,"context_line":"              - name: discover via nova_ironic?"},{"line_number":73,"context_line":"                set_fact:"},{"line_number":74,"context_line":"                  nova_cellv2_discovery_delegate_host: \"{{ groups[\u0027nova_ironic\u0027][0] }}\""},{"line_number":75,"context_line":"                when:"},{"line_number":76,"context_line":"                  - nova_cellv2_discovery_delegate_host is not defined"},{"line_number":77,"context_line":"                  - groups[\u0027nova_ironic\u0027] is defined and (groups[\u0027nova_ironic\u0027]|length\u003e0)"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3fa7e38b_1ec95677","line":74,"in_reply_to":"3fa7e38b_7ef5eaca","updated":"2019-09-18 15:17:53.000000000","message":"defaults to false","commit_id":"3e8e5f429ce47e0f506a9741ff47422c2893046d"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"e70d5f8610984932627f89dbc068a6f2a10227c1","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                  - nova_cellv2_discovery_delegate_host is defined"},{"line_number":85,"context_line":"              # Could be included multiple times so ensure it only runs once"},{"line_number":86,"context_line":"              - set_fact:"},{"line_number":87,"context_line":"                  nova_cellv2_discovery_done: true"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3fa7e38b_de041ec9","line":87,"updated":"2019-09-18 15:15:51.000000000","message":"Add cacheable: false?","commit_id":"3e8e5f429ce47e0f506a9741ff47422c2893046d"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"9676369672a3c0cf5d5af0865156a9e551d62ad2","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                  - nova_cellv2_discovery_delegate_host is defined"},{"line_number":85,"context_line":"              # Could be included multiple times so ensure it only runs once"},{"line_number":86,"context_line":"              - set_fact:"},{"line_number":87,"context_line":"                  nova_cellv2_discovery_done: true"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3fa7e38b_3ec69269","line":87,"in_reply_to":"3fa7e38b_de041ec9","updated":"2019-09-18 15:17:53.000000000","message":"defaults to false","commit_id":"3e8e5f429ce47e0f506a9741ff47422c2893046d"}],"deployment/nova/nova-compute-container-puppet.yaml":[{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"1a55a0d38666a02bfd637ddc5dee3f6357c2ddb0","unresolved":false,"context_lines":[{"line_number":944,"context_line":"        - - name: validate nova compute container state"},{"line_number":945,"context_line":"            when:"},{"line_number":946,"context_line":"              - not container_healthcheck_disabled"},{"line_number":947,"context_line":"              - step|int \u003d\u003d 5"},{"line_number":948,"context_line":"            tags:"},{"line_number":949,"context_line":"              - opendev-validation"},{"line_number":950,"context_line":"              - opendev-validation-nova"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5faad753_965af527","side":"PARENT","line":947,"range":{"start_line":947,"start_character":16,"end_line":947,"end_character":29},"updated":"2019-09-10 11:04:28.000000000","message":"not sure what to do with this, unless we add a step 6","commit_id":"cb3a6759681090669d60e1008d10fea7f54caf76"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"fd25839e97e33088ed7ea19370b7fd4db0370529","unresolved":false,"context_lines":[{"line_number":945,"context_line":"            when:"},{"line_number":946,"context_line":"              - container_cli \u003d\u003d \u0027podman\u0027"},{"line_number":947,"context_line":"              - not container_healthcheck_disabled"},{"line_number":948,"context_line":"              - step|int \u003d\u003d 6 #FIXME: there is no step6"},{"line_number":949,"context_line":"            tags:"},{"line_number":950,"context_line":"              - opendev-validation"},{"line_number":951,"context_line":"              - opendev-validation-nova"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"5faad753_2511255e","line":948,"range":{"start_line":948,"start_character":30,"end_line":948,"end_character":55},"updated":"2019-09-13 21:23:00.000000000","message":"Better to address this in a follow-up patch as this patch needs to be backported","commit_id":"ab2c4c6a86472a68baaaefbf75293ea2a6e15535"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"0136d1583c3741480a15ec55654bf36e040914e4","unresolved":false,"context_lines":[{"line_number":656,"context_line":"                          debug: {get_attr: [NovaBase, role_data, config_settings, \u0027nova::logging::debug\u0027]}"},{"line_number":657,"context_line":"        step_5:"},{"line_number":658,"context_line":"          map_merge:"},{"line_number":659,"context_line":"            - nova_wait_for_placement_service:"},{"line_number":660,"context_line":"                start_order: 2"},{"line_number":661,"context_line":"                image: *nova_compute_image"},{"line_number":662,"context_line":"                user: nova"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3fa7e38b_d3bfb7a7","line":659,"range":{"start_line":659,"start_character":14,"end_line":659,"end_character":46},"updated":"2019-09-25 17:02:19.000000000","message":"could move this to the nova-placement service step_4 now that compute is on step_5","commit_id":"3e8e5f429ce47e0f506a9741ff47422c2893046d"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"398aa0e7e0cf68553fbea98d35e033d6ce6d1742","unresolved":false,"context_lines":[{"line_number":924,"context_line":"          when:"},{"line_number":925,"context_line":"            - container_cli \u003d\u003d \u0027podman\u0027"},{"line_number":926,"context_line":"            - not container_healthcheck_disabled"},{"line_number":927,"context_line":"            - step|int \u003d\u003d 6 #FIXME: there is no step6"},{"line_number":928,"context_line":"          tags:"},{"line_number":929,"context_line":"            - opendev-validation"},{"line_number":930,"context_line":"            - opendev-validation-nova"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"3fa7e38b_2a99ed77","line":927,"range":{"start_line":927,"start_character":28,"end_line":927,"end_character":53},"updated":"2019-09-25 20:42:21.000000000","message":"I assume this will be replaced by https://review.opendev.org/682377, and whatever is calling that will need to deal with the task ordering issue, so I\u0027m inclined to ignore this for now....","commit_id":"c20c9e339687d42aee32c17bd3079dff25839f93"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"e527fa6653714e2fd4148669e6eba25b029d6a90","unresolved":false,"context_lines":[{"line_number":924,"context_line":"          when:"},{"line_number":925,"context_line":"            - container_cli \u003d\u003d \u0027podman\u0027"},{"line_number":926,"context_line":"            - not container_healthcheck_disabled"},{"line_number":927,"context_line":"            - step|int \u003d\u003d 6 #FIXME: there is no step6"},{"line_number":928,"context_line":"          tags:"},{"line_number":929,"context_line":"            - opendev-validation"},{"line_number":930,"context_line":"            - opendev-validation-nova"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"3fa7e38b_06be3afe","line":927,"range":{"start_line":927,"start_character":28,"end_line":927,"end_character":53},"updated":"2019-09-27 22:58:40.000000000","message":"I assume this will be replaced by https://review.opendev.org/682377, and whatever is calling that will need to deal with the task ordering issue, so I\u0027m inclined to ignore this for now - getting this fix backported is more urgent.","commit_id":"8811f71cacfbb7eacd300dbbd127e21b5bad30e1"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"2098c73cb570fd40c67d316de41b7c3f2c8e063f","unresolved":false,"context_lines":[{"line_number":924,"context_line":"          when:"},{"line_number":925,"context_line":"            - container_cli \u003d\u003d \u0027podman\u0027"},{"line_number":926,"context_line":"            - not container_healthcheck_disabled"},{"line_number":927,"context_line":"            - step|int \u003d\u003d 6 #FIXME: there is no step6"},{"line_number":928,"context_line":"          tags:"},{"line_number":929,"context_line":"            - opendev-validation"},{"line_number":930,"context_line":"            - opendev-validation-nova"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"3fa7e38b_687b22f4","line":927,"range":{"start_line":927,"start_character":28,"end_line":927,"end_character":53},"in_reply_to":"3fa7e38b_06be3afe","updated":"2019-10-01 06:48:29.000000000","message":"From checking with Rajesh yes. \n\nWe could verify the compute as part of the discovery external_post_deploy_tasks step as is runs after step_5, but having a final deploy_steps_tasks should be better.","commit_id":"8811f71cacfbb7eacd300dbbd127e21b5bad30e1"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"d8f2960dc55456fcee911cf3f340a48f5751fd71","unresolved":false,"context_lines":[{"line_number":924,"context_line":"          when:"},{"line_number":925,"context_line":"            - container_cli \u003d\u003d \u0027podman\u0027"},{"line_number":926,"context_line":"            - not container_healthcheck_disabled"},{"line_number":927,"context_line":"            - step|int \u003d\u003d 6 #FIXME: there is no step6"},{"line_number":928,"context_line":"            - false"},{"line_number":929,"context_line":"          tags:"},{"line_number":930,"context_line":"            - opendev-validation"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"3fa7e38b_1c209b49","line":927,"range":{"start_line":927,"start_character":28,"end_line":927,"end_character":53},"updated":"2019-10-02 10:02:43.000000000","message":"see https://review.opendev.org/#/c/681042/18/deployment/nova/nova-compute-container-puppet.yaml@927","commit_id":"8a87cbcc349feb9cbd710e91d9805b0db2b8aba9"}]}