)]}'
{"deployment/nova/nova-compute-container-puppet.yaml":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f7c2fdc414bcbcd0f0bdce56d4b8f4c5de55183f","unresolved":false,"context_lines":[{"line_number":149,"context_line":"      - role_specific"},{"line_number":150,"context_line":"  NovaVcpuPinSet:"},{"line_number":151,"context_line":"    description: \u003e"},{"line_number":152,"context_line":"      A list or range of physical CPU cores to reserve for virtual machine"},{"line_number":153,"context_line":"      processes."},{"line_number":154,"context_line":"      Ex. NovaVcpuPinSet: [\u00274-12\u0027,\u0027^8\u0027] will reserve cores from 4-12 excluding 8"},{"line_number":155,"context_line":"    type: comma_delimited_list"},{"line_number":156,"context_line":"    default: []"},{"line_number":157,"context_line":"    tags:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5faad753_ea025609","line":154,"range":{"start_line":152,"start_character":0,"end_line":154,"end_character":80},"updated":"2019-09-10 13:20:28.000000000","message":"This is deprecated now so you might want to indicate that here, right?","commit_id":"98ac1fd3a6aa4b6a1c251d9caa92b9f4b3593e42"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f7c2fdc414bcbcd0f0bdce56d4b8f4c5de55183f","unresolved":false,"context_lines":[{"line_number":158,"context_line":"      - role_specific"},{"line_number":159,"context_line":"  NovaComputeCpuSharedSet:"},{"line_number":160,"context_line":"    description: \u003e"},{"line_number":161,"context_line":"      A list or range of physical CPU cores will be used for best-effort guest"},{"line_number":162,"context_line":"      vCPU resources (e.g. emulator threads in libvirt/QEMU)."},{"line_number":163,"context_line":"      Ex. NovaComputeCpuSharedSet: [4-12,^8,15] will reserve cores from 4-12"},{"line_number":164,"context_line":"      and 15, excluding 8."},{"line_number":165,"context_line":"    type: comma_delimited_list"},{"line_number":166,"context_line":"    default: []"},{"line_number":167,"context_line":"    tags:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5faad753_ef07c81b","line":164,"range":{"start_line":161,"start_character":0,"end_line":164,"end_character":26},"updated":"2019-09-10 13:20:28.000000000","message":"This needs to be updated now since it\u0027s used for emulator threads if vcpu_pin_set is set, otherwise it\u0027s used for emulator threads and for virtual machine process. See [1] for details.\n\n[1] https://review.opendev.org/#/c/671793/23/nova/conf/compute.py","commit_id":"98ac1fd3a6aa4b6a1c251d9caa92b9f4b3593e42"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f7c2fdc414bcbcd0f0bdce56d4b8f4c5de55183f","unresolved":false,"context_lines":[{"line_number":336,"context_line":"    default: 0.0"},{"line_number":337,"context_line":"    tags:"},{"line_number":338,"context_line":"      - role_specific"},{"line_number":339,"context_line":"  NovaComputeCpuDedicatedSet:"},{"line_number":340,"context_line":"    description: \u003e"},{"line_number":341,"context_line":"      A list or range of dedicated physical CPU cores to reserve for virtual"},{"line_number":342,"context_line":"      machine processes which"},{"line_number":343,"context_line":"      Ex. NovaComputeCpuDedicatedSet: [4-12,^8,15] will reserve cores from 4-12"},{"line_number":344,"context_line":"      and 15, excluding 8."},{"line_number":345,"context_line":"    type: comma_delimited_list"},{"line_number":346,"context_line":"    default: []"},{"line_number":347,"context_line":"    tags:"},{"line_number":348,"context_line":"      - role_specific"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"resources:"},{"line_number":351,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5faad753_ea2b367f","line":348,"range":{"start_line":339,"start_character":0,"end_line":348,"end_character":21},"updated":"2019-09-10 13:20:28.000000000","message":"I think it would be good to group this with the other options above","commit_id":"98ac1fd3a6aa4b6a1c251d9caa92b9f4b3593e42"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f7c2fdc414bcbcd0f0bdce56d4b8f4c5de55183f","unresolved":false,"context_lines":[{"line_number":415,"context_line":"              nova::cpu_allocation_ratio: NovaCPUAllocationRatio"},{"line_number":416,"context_line":"              nova::ram_allocation_ratio: NovaRAMAllocationRatio"},{"line_number":417,"context_line":"              nova::disk_allocation_ratio: NovaDiskAllocationRatio"},{"line_number":418,"context_line":"              nova::compute::cpu_dedicated_set: NovaComputeCpuDedicatedSet"},{"line_number":419,"context_line":"            - values: {get_param: [RoleParameters]}"},{"line_number":420,"context_line":"          - values:"},{"line_number":421,"context_line":"              NovaVcpuPinSet: {get_param: NovaVcpuPinSet}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5faad753_aa5a1e27","line":418,"range":{"start_line":418,"start_character":14,"end_line":418,"end_character":74},"updated":"2019-09-10 13:20:28.000000000","message":"It\u0027d be nice to group this with the config for \u0027nova::compute::cpu_shared_set\u0027 above","commit_id":"98ac1fd3a6aa4b6a1c251d9caa92b9f4b3593e42"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f7c2fdc414bcbcd0f0bdce56d4b8f4c5de55183f","unresolved":false,"context_lines":[{"line_number":441,"context_line":"              NovaCPUAllocationRatio: {get_param: NovaCPUAllocationRatio}"},{"line_number":442,"context_line":"              NovaRAMAllocationRatio: {get_param: NovaRAMAllocationRatio}"},{"line_number":443,"context_line":"              NovaDiskAllocationRatio: {get_param: NovaDiskAllocationRatio}"},{"line_number":444,"context_line":"              NovaComputeCpuDedicatedSet: {get_param: NovaComputeCpuDedicatedSet}"},{"line_number":445,"context_line":""},{"line_number":446,"context_line":"conditions:"},{"line_number":447,"context_line":"  enable_instance_ha: {equals: [{get_param: EnableInstanceHA}, true]}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5faad753_6a3746e5","line":444,"range":{"start_line":444,"start_character":14,"end_line":444,"end_character":80},"updated":"2019-09-10 13:20:28.000000000","message":"Ditto","commit_id":"98ac1fd3a6aa4b6a1c251d9caa92b9f4b3593e42"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"f9fc3da6c4d28848468fe319fc30d55046de0f6a","unresolved":false,"context_lines":[{"line_number":147,"context_line":"    default: \u0027\u0027"},{"line_number":148,"context_line":"    tags:"},{"line_number":149,"context_line":"      - role_specific"},{"line_number":150,"context_line":"  NovaVcpuPinSet:"},{"line_number":151,"context_line":"    description: \u003e"},{"line_number":152,"context_line":"      (DEPRECATED) A list or range of physical CPU cores to reserve for virtual machine"},{"line_number":153,"context_line":"      processes if NovaComputeCpuDedicatedSet is not set."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_2a93c9a5","line":150,"range":{"start_line":150,"start_character":2,"end_line":150,"end_character":16},"updated":"2019-10-02 12:00:32.000000000","message":"Please also add a paramater_groups like e.g. in [1] and add NovaVcpuPinSet to it.\n\n[1] https://github.com/openstack/tripleo-heat-templates/blob/master/deployment/neutron/neutron-api-container-puppet.yaml#L155-L163","commit_id":"e1f286b769fa08edc37e48c4ac32cf6db73b6bcc"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"177ead88b274f24b4be7c023c1a31b3aa1946b39","unresolved":false,"context_lines":[{"line_number":330,"context_line":"      - role_specific"},{"line_number":331,"context_line":"  NovaComputeCpuDedicatedSet:"},{"line_number":332,"context_line":"    description: \u003e"},{"line_number":333,"context_line":"      A list or range of dedicated physical CPU cores to reserve for virtual"},{"line_number":334,"context_line":"      machine processes which"},{"line_number":335,"context_line":"      Ex. NovaComputeCpuDedicatedSet: [4-12,^8,15] will reserve cores from 4-12"},{"line_number":336,"context_line":"      and 15, excluding 8."},{"line_number":337,"context_line":"    type: comma_delimited_list"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_0849205f","line":334,"range":{"start_line":333,"start_character":0,"end_line":334,"end_character":29},"updated":"2019-10-03 14:36:02.000000000","message":"This seems incomplete, and it\u0027d be nice if there was some symmetry between this and \u0027NovaComputeCpuSharedSet\u0027. How about:\n\n  A list or range of host CPU cores to which processes for pinned\n  instance CPUs (PCPUs) can be scheduled.\n\nAnd then reword the above to:\n\n  A list or range of host CPU cores to which emulator threads\n  can be scheduled, if NovaVcpuPinSet is set, or to which\n  both emulator threads and processes for unpinned instance\n  CPUs (VCPUs) can be scheduled, if NovaVcpuPinSet is\n  unset.\n\nWould probably need to reword \u0027NovaVcpuPinSet\u0027 accordingly too","commit_id":"64bc3cbabd8c861bd96c4f6d47de076fbd9c2266"}],"environments/lifecycle/upgrade-converge.yaml":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f7c2fdc414bcbcd0f0bdce56d4b8f4c5de55183f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5faad753_aaa8deda","line":10,"updated":"2019-09-10 13:20:28.000000000","message":"I don\u0027t know enough about the lifecycle of TripleO deployment, but does this run straight after an upgrade or is there an intermediate step? We have to be careful to ensure that \u0027vcpu_pin_set\u0027 has been migrated to \u0027cpu_dedicated_set\u0027 or \u0027cpu_shared_set\u0027 (or both) before we toggle this, otherwise you\u0027ll start seeing a lot of NoValidHost errors.","commit_id":"98ac1fd3a6aa4b6a1c251d9caa92b9f4b3593e42"}]}