)]}'
{"docker/services/nova-api.yaml":[{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"45de92628f84e965e6de157862a6b7badc17ea70","unresolved":false,"context_lines":[{"line_number":69,"context_line":"  NovaHostDiscoveryService:"},{"line_number":70,"context_line":"    description: Service used by NovaHostDiscoveryWorkflowName to select discovery host."},{"line_number":71,"context_line":"    type: string"},{"line_number":72,"context_line":"    default: \u0027nova_api\u0027"},{"line_number":73,"context_line":"  NovaHostDiscoveryContainer:"},{"line_number":74,"context_line":"    description: Container used by NovaHostDiscoveryWorkflowName for host discovery."},{"line_number":75,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_54de7c6d","line":72,"range":{"start_line":72,"start_character":14,"end_line":72,"end_character":22},"updated":"2019-09-23 20:18:26.000000000","message":"this should be run via nova_compute/nova_ironic (for now at least)","commit_id":"5ad773b190303dda5c1b52b6a6bf59afd5e39582"}],"docker/services/nova-compute.yaml":[{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"70adad0446a9a435e801e6c426e5c41d528254cf","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    description: \u003e"},{"line_number":82,"context_line":"      Setting this to a unique value will re-run any deployment tasks which"},{"line_number":83,"context_line":"      perform configuration on a Heat stack-update."},{"line_number":84,"context_line":"  NovaHostDiscoveryWorkflowName:"},{"line_number":85,"context_line":"    description: Mistral workflow name for nova cellv2 host discovery"},{"line_number":86,"context_line":"                 once the overcloud is ready."},{"line_number":87,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3fa7e38b_7bdee711","line":84,"range":{"start_line":84,"start_character":0,"end_line":84,"end_character":32},"updated":"2019-09-25 09:46:34.000000000","message":"I have not hard coded this to have it the same as we do it\nin octavia, ceph or skydive","commit_id":"4d78571309da6bc7c593269a51c13ef0093bbdbb"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"8edddf890930e275282c3faa8f8b1a984e1a1fa2","unresolved":false,"context_lines":[{"line_number":286,"context_line":"                  nova_host_discovery_service: \u0027nova_compute\u0027"},{"line_number":287,"context_line":"                  nova_host_discovery_container: \u0027nova_compute\u0027"},{"line_number":288,"context_line":"                  nova_host_discovery_ansible_playbook: \u0027/usr/share/tripleo-common/playbooks/nova_cellv2_host_discover.yaml\u0027"},{"line_number":289,"context_line":"          - null"},{"line_number":290,"context_line":"      # deploy_steps_tasks only run in queens when config-download is used"},{"line_number":291,"context_line":"      deploy_steps_tasks: {get_attr: [NovaComputeCommon, nova_compute_common_deploy_steps_tasks]}"},{"line_number":292,"context_line":"      host_prep_tasks:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3fa7e38b_fa59aa34","line":289,"range":{"start_line":289,"start_character":12,"end_line":289,"end_character":16},"updated":"2019-10-08 09:53:06.000000000","message":"{} might be safer in case anything inspecting this expects a dict","commit_id":"f4c446abcd4ffaac65c2cf38e6ed26f658ed4f93"}],"docker/services/nova-ironic.yaml":[{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"eba1e9c823e3aac1b389ac8ee6a3c77336b02d6b","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    default: false"},{"line_number":41,"context_line":"    description: Remove package if the service is being disabled during upgrade"},{"line_number":42,"context_line":"    type: boolean"},{"line_number":43,"context_line":"  NovaHostDiscoveryWorkflowName:"},{"line_number":44,"context_line":"    description: Mistral workflow name for nova cellv2 host discovery"},{"line_number":45,"context_line":"                 once the overcloud is ready."},{"line_number":46,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_1e67babf","line":43,"range":{"start_line":43,"start_character":2,"end_line":43,"end_character":31},"updated":"2019-09-24 09:44:12.000000000","message":"are these params used for anything?","commit_id":"f24c2330c64e0e27f6ad967ba20d5c01afed0393"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"b6dfe2a8371d954e51d189a553dc5e4eb9d49b46","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    default: false"},{"line_number":41,"context_line":"    description: Remove package if the service is being disabled during upgrade"},{"line_number":42,"context_line":"    type: boolean"},{"line_number":43,"context_line":"  NovaHostDiscoveryWorkflowName:"},{"line_number":44,"context_line":"    description: Mistral workflow name for nova cellv2 host discovery"},{"line_number":45,"context_line":"                 once the overcloud is ready."},{"line_number":46,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_9e7c0a20","line":43,"range":{"start_line":43,"start_character":2,"end_line":43,"end_character":31},"in_reply_to":"3fa7e38b_1e67babf","updated":"2019-09-24 10:21:08.000000000","message":"\u003e are these params used for anything?\n\nNovaHostDiscoveryWorkflowName can right now only have one\nvalue which we have as the default. There are no other \ndiscovery workflows.\nThe others are used to control which nodes [1] and container [2] are used for the discovery.\n\n[1] https://review.opendev.org/gitweb?p\u003dopenstack/tripleo-common.git;f\u003dworkbooks/nova_host_discovery.yaml;hb\u003drefs/changes/67/683067/5#l22\n[2] https://review.opendev.org/gitweb?p\u003dopenstack/tripleo-common.git;f\u003dworkbooks/nova_host_discovery.yaml;hb\u003drefs/changes/67/683067/5#l53","commit_id":"f24c2330c64e0e27f6ad967ba20d5c01afed0393"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"eba1e9c823e3aac1b389ac8ee6a3c77336b02d6b","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                 once the overcloud is ready."},{"line_number":46,"context_line":"    type: string"},{"line_number":47,"context_line":"    default: \u0027tripleo.nova.v1.cellv2_discovery\u0027"},{"line_number":48,"context_line":"  NovaHostDiscoveryService:"},{"line_number":49,"context_line":"    description: Service used by NovaHostDiscoveryWorkflowName to select discovery host."},{"line_number":50,"context_line":"    type: string"},{"line_number":51,"context_line":"    default: \u0027nova_compute\u0027"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_5ee1b229","line":48,"range":{"start_line":48,"start_character":4,"end_line":48,"end_character":26},"updated":"2019-09-24 09:44:12.000000000","message":"does this need to be nova_ironic when there are no computes?","commit_id":"f24c2330c64e0e27f6ad967ba20d5c01afed0393"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"b6dfe2a8371d954e51d189a553dc5e4eb9d49b46","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                 once the overcloud is ready."},{"line_number":46,"context_line":"    type: string"},{"line_number":47,"context_line":"    default: \u0027tripleo.nova.v1.cellv2_discovery\u0027"},{"line_number":48,"context_line":"  NovaHostDiscoveryService:"},{"line_number":49,"context_line":"    description: Service used by NovaHostDiscoveryWorkflowName to select discovery host."},{"line_number":50,"context_line":"    type: string"},{"line_number":51,"context_line":"    default: \u0027nova_compute\u0027"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_11d9eb7d","line":48,"range":{"start_line":48,"start_character":4,"end_line":48,"end_character":26},"in_reply_to":"3fa7e38b_5ee1b229","updated":"2019-09-24 10:21:08.000000000","message":"\u003e does this need to be nova_ironic when there are no computes?\n\ngood catch, need to check","commit_id":"f24c2330c64e0e27f6ad967ba20d5c01afed0393"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"b630cfc4e800497f5c546de235d32417f191719b","unresolved":false,"context_lines":[{"line_number":174,"context_line":"            user: root"},{"line_number":175,"context_line":"            command: \"/docker-config-scripts/nova_wait_for_compute_service.py\""},{"line_number":176,"context_line":"      workflow_tasks:"},{"line_number":177,"context_line":"        step5:"},{"line_number":178,"context_line":"            # discover hosts via workflow that we also run it when:"},{"line_number":179,"context_line":"            # - nodes get blacklisted"},{"line_number":180,"context_line":"            # - deployment is run with skip-deploy-identifier"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_71993fc2","line":177,"range":{"start_line":177,"start_character":8,"end_line":177,"end_character":13},"updated":"2019-09-24 10:18:20.000000000","message":"does this run before or after the step5 containers?","commit_id":"f24c2330c64e0e27f6ad967ba20d5c01afed0393"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"715260da6c971edac5da742ffb61eb7e0d2d81da","unresolved":false,"context_lines":[{"line_number":174,"context_line":"            user: root"},{"line_number":175,"context_line":"            command: \"/docker-config-scripts/nova_wait_for_compute_service.py\""},{"line_number":176,"context_line":"      workflow_tasks:"},{"line_number":177,"context_line":"        step5:"},{"line_number":178,"context_line":"            # discover hosts via workflow that we also run it when:"},{"line_number":179,"context_line":"            # - nodes get blacklisted"},{"line_number":180,"context_line":"            # - deployment is run with skip-deploy-identifier"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_d1dfd337","line":177,"range":{"start_line":177,"start_character":8,"end_line":177,"end_character":13},"in_reply_to":"3fa7e38b_71993fc2","updated":"2019-09-24 10:31:01.000000000","message":"\u003e does this run before or after the step5 containers?\n\nit runs before the config step if that is the question.\nSo:\nworkflow step5 -\u003e config step5","commit_id":"f24c2330c64e0e27f6ad967ba20d5c01afed0393"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"645011bd31f1b87cca6b81eb51ac4f1cabe00911","unresolved":false,"context_lines":[{"line_number":179,"context_line":"            # - nodes get blacklisted"},{"line_number":180,"context_line":"            # - deployment is run with skip-deploy-identifier"},{"line_number":181,"context_line":"          - name: nova_ironic_discovery_workflow"},{"line_number":182,"context_line":"            workflow: { get_param: NovaHostDiscoveryWorkflowName }"},{"line_number":183,"context_line":"            input:"},{"line_number":184,"context_line":"              nova_host_discovery_service: { get_param: NovaHostDiscoveryService }"},{"line_number":185,"context_line":"              nova_host_discovery_container: { get_param: NovaHostDiscoveryContainer }"},{"line_number":186,"context_line":"              nova_host_discovery_ansible_playbook: \u0027/usr/share/tripleo-common/playbooks/nova_cellv2_host_discover.yaml\u0027"},{"line_number":187,"context_line":"      # deploy_steps_tasks only run in queens when config-download is used"},{"line_number":188,"context_line":"      deploy_steps_tasks: {get_attr: [NovaComputeCommon, nova_compute_common_deploy_steps_tasks]}"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3fa7e38b_3fb4d4d0","line":185,"range":{"start_line":182,"start_character":0,"end_line":185,"end_character":86},"updated":"2019-09-25 14:20:48.000000000","message":"why not just hardcode here and remove the params?","commit_id":"43a358dfb450f3dd9b83fbfb08283630d92060eb"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"c261bd7876f3ce82b90fb835d3aaa60c774e38ca","unresolved":false,"context_lines":[{"line_number":179,"context_line":"            # - nodes get blacklisted"},{"line_number":180,"context_line":"            # - deployment is run with skip-deploy-identifier"},{"line_number":181,"context_line":"          - name: nova_ironic_discovery_workflow"},{"line_number":182,"context_line":"            workflow: { get_param: NovaHostDiscoveryWorkflowName }"},{"line_number":183,"context_line":"            input:"},{"line_number":184,"context_line":"              nova_host_discovery_service: { get_param: NovaHostDiscoveryService }"},{"line_number":185,"context_line":"              nova_host_discovery_container: { get_param: NovaHostDiscoveryContainer }"},{"line_number":186,"context_line":"              nova_host_discovery_ansible_playbook: \u0027/usr/share/tripleo-common/playbooks/nova_cellv2_host_discover.yaml\u0027"},{"line_number":187,"context_line":"      # deploy_steps_tasks only run in queens when config-download is used"},{"line_number":188,"context_line":"      deploy_steps_tasks: {get_attr: [NovaComputeCommon, nova_compute_common_deploy_steps_tasks]}"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3fa7e38b_e26a23b1","line":185,"range":{"start_line":182,"start_character":0,"end_line":185,"end_character":86},"in_reply_to":"3fa7e38b_3fb4d4d0","updated":"2019-09-25 14:42:14.000000000","message":"basically I introduced them to do it the same way as we do it for octavia, ceph and skydive. Also you\u0027d need NovaHostDiscoveryService and NovaHostDiscoveryContainer for the manager.","commit_id":"43a358dfb450f3dd9b83fbfb08283630d92060eb"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"cf79e12c2c07e1de0ebd51e9da029e4f2a16ee45","unresolved":false,"context_lines":[{"line_number":179,"context_line":"            # - nodes get blacklisted"},{"line_number":180,"context_line":"            # - deployment is run with skip-deploy-identifier"},{"line_number":181,"context_line":"          - name: nova_ironic_discovery_workflow"},{"line_number":182,"context_line":"            workflow: { get_param: NovaHostDiscoveryWorkflowName }"},{"line_number":183,"context_line":"            input:"},{"line_number":184,"context_line":"              nova_host_discovery_service: { get_param: NovaHostDiscoveryService }"},{"line_number":185,"context_line":"              nova_host_discovery_container: { get_param: NovaHostDiscoveryContainer }"},{"line_number":186,"context_line":"              nova_host_discovery_ansible_playbook: \u0027/usr/share/tripleo-common/playbooks/nova_cellv2_host_discover.yaml\u0027"},{"line_number":187,"context_line":"      # deploy_steps_tasks only run in queens when config-download is used"},{"line_number":188,"context_line":"      deploy_steps_tasks: {get_attr: [NovaComputeCommon, nova_compute_common_deploy_steps_tasks]}"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3fa7e38b_15c9b7aa","line":185,"range":{"start_line":182,"start_character":0,"end_line":185,"end_character":86},"in_reply_to":"3fa7e38b_e26a23b1","updated":"2019-09-25 15:14:12.000000000","message":"ok, might be better to drop the for now. Will probably have to add them for the manager but the behaviour is likely to be different (e.g default to \u0027\u0027 which means use the hardcoded nova-compute/nova-ironic)","commit_id":"43a358dfb450f3dd9b83fbfb08283630d92060eb"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"9a26de37d034800c3856ea673ca8c404f00661ba","unresolved":false,"context_lines":[{"line_number":185,"context_line":"              nova_host_discovery_container: { get_param: NovaHostDiscoveryContainer }"},{"line_number":186,"context_line":"              nova_host_discovery_ansible_playbook: \u0027/usr/share/tripleo-common/playbooks/nova_cellv2_host_discover.yaml\u0027"},{"line_number":187,"context_line":"      # deploy_steps_tasks only run in queens when config-download is used"},{"line_number":188,"context_line":"      deploy_steps_tasks: {get_attr: [NovaComputeCommon, nova_compute_common_deploy_steps_tasks]}"},{"line_number":189,"context_line":"      host_prep_tasks:"},{"line_number":190,"context_line":"        - name: create persistent directories"},{"line_number":191,"context_line":"          file:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3fa7e38b_dfb26094","line":188,"range":{"start_line":188,"start_character":6,"end_line":188,"end_character":24},"updated":"2019-09-25 14:30:13.000000000","message":"I assume workflow_tasks do not run when config-download is used?","commit_id":"43a358dfb450f3dd9b83fbfb08283630d92060eb"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"c261bd7876f3ce82b90fb835d3aaa60c774e38ca","unresolved":false,"context_lines":[{"line_number":185,"context_line":"              nova_host_discovery_container: { get_param: NovaHostDiscoveryContainer }"},{"line_number":186,"context_line":"              nova_host_discovery_ansible_playbook: \u0027/usr/share/tripleo-common/playbooks/nova_cellv2_host_discover.yaml\u0027"},{"line_number":187,"context_line":"      # deploy_steps_tasks only run in queens when config-download is used"},{"line_number":188,"context_line":"      deploy_steps_tasks: {get_attr: [NovaComputeCommon, nova_compute_common_deploy_steps_tasks]}"},{"line_number":189,"context_line":"      host_prep_tasks:"},{"line_number":190,"context_line":"        - name: create persistent directories"},{"line_number":191,"context_line":"          file:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3fa7e38b_e2c6a39a","line":188,"range":{"start_line":188,"start_character":6,"end_line":188,"end_character":24},"in_reply_to":"3fa7e38b_dfb26094","updated":"2019-09-25 14:42:14.000000000","message":"\u003e I assume workflow_tasks do not run when config-download is used?\n\nNo, they run and they run before the ansible config run. Therefore for the first run where we don\u0027t have containers we check in the ansible playbook if the container exists.\n\nIs there a way to prevent the workflow_tasks to run in config-download?","commit_id":"43a358dfb450f3dd9b83fbfb08283630d92060eb"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"cf79e12c2c07e1de0ebd51e9da029e4f2a16ee45","unresolved":false,"context_lines":[{"line_number":185,"context_line":"              nova_host_discovery_container: { get_param: NovaHostDiscoveryContainer }"},{"line_number":186,"context_line":"              nova_host_discovery_ansible_playbook: \u0027/usr/share/tripleo-common/playbooks/nova_cellv2_host_discover.yaml\u0027"},{"line_number":187,"context_line":"      # deploy_steps_tasks only run in queens when config-download is used"},{"line_number":188,"context_line":"      deploy_steps_tasks: {get_attr: [NovaComputeCommon, nova_compute_common_deploy_steps_tasks]}"},{"line_number":189,"context_line":"      host_prep_tasks:"},{"line_number":190,"context_line":"        - name: create persistent directories"},{"line_number":191,"context_line":"          file:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3fa7e38b_e22543c3","line":188,"range":{"start_line":188,"start_character":6,"end_line":188,"end_character":24},"in_reply_to":"3fa7e38b_e2c6a39a","updated":"2019-09-25 15:14:12.000000000","message":"I don\u0027t see a way right now but we could pass a param to indicate it\u0027s config-download","commit_id":"43a358dfb450f3dd9b83fbfb08283630d92060eb"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"984eb8b3428fd0b0dc3b9dd8653d7c0cc32b6f73","unresolved":false,"context_lines":[{"line_number":165,"context_line":"            # discover hosts via workflow that we also run it when:"},{"line_number":166,"context_line":"            # - nodes get blacklisted"},{"line_number":167,"context_line":"            # - deployment is run with skip-deploy-identifier"},{"line_number":168,"context_line":"          - name: nova_ironic_discovery_workflow"},{"line_number":169,"context_line":"            workflow: \u0027tripleo.nova.v1.cellv2_discovery\u0027"},{"line_number":170,"context_line":"            input:"},{"line_number":171,"context_line":"              nova_host_discovery_service: \u0027nova_ironic\u0027"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3fa7e38b_5ce8537b","line":168,"updated":"2019-10-02 10:32:43.000000000","message":"doesn\u0027t this need the ConfigDownload logic too?","commit_id":"f5806cc01fd5a65470f092f35901fbb18ef7baa4"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"329b1feb860345a4bc0c727001d17b87128f9718","unresolved":false,"context_lines":[{"line_number":165,"context_line":"            # discover hosts via workflow that we also run it when:"},{"line_number":166,"context_line":"            # - nodes get blacklisted"},{"line_number":167,"context_line":"            # - deployment is run with skip-deploy-identifier"},{"line_number":168,"context_line":"          - name: nova_ironic_discovery_workflow"},{"line_number":169,"context_line":"            workflow: \u0027tripleo.nova.v1.cellv2_discovery\u0027"},{"line_number":170,"context_line":"            input:"},{"line_number":171,"context_line":"              nova_host_discovery_service: \u0027nova_ironic\u0027"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3fa7e38b_8ad0bd55","line":168,"in_reply_to":"3fa7e38b_1f6bad1f","updated":"2019-10-02 12:04:48.000000000","message":"gnahhh, sorry missunderstood that. sure we need that here too.","commit_id":"f5806cc01fd5a65470f092f35901fbb18ef7baa4"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"4b200ea84b5ba9ed84ca15ae8388af01efba5bac","unresolved":false,"context_lines":[{"line_number":165,"context_line":"            # discover hosts via workflow that we also run it when:"},{"line_number":166,"context_line":"            # - nodes get blacklisted"},{"line_number":167,"context_line":"            # - deployment is run with skip-deploy-identifier"},{"line_number":168,"context_line":"          - name: nova_ironic_discovery_workflow"},{"line_number":169,"context_line":"            workflow: \u0027tripleo.nova.v1.cellv2_discovery\u0027"},{"line_number":170,"context_line":"            input:"},{"line_number":171,"context_line":"              nova_host_discovery_service: \u0027nova_ironic\u0027"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3fa7e38b_1f6bad1f","line":168,"in_reply_to":"3fa7e38b_5ce8537b","updated":"2019-10-02 11:25:29.000000000","message":"no, ConfigDownload uses discovery from deploy_steps_tasks.","commit_id":"f5806cc01fd5a65470f092f35901fbb18ef7baa4"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"8edddf890930e275282c3faa8f8b1a984e1a1fa2","unresolved":false,"context_lines":[{"line_number":183,"context_line":"                  nova_host_discovery_service: \u0027nova_compute\u0027"},{"line_number":184,"context_line":"                  nova_host_discovery_container: \u0027nova_compute\u0027"},{"line_number":185,"context_line":"                  nova_host_discovery_ansible_playbook: \u0027/usr/share/tripleo-common/playbooks/nova_cellv2_host_discover.yaml\u0027"},{"line_number":186,"context_line":"          - null"},{"line_number":187,"context_line":"      # deploy_steps_tasks only run in queens when config-download is used"},{"line_number":188,"context_line":"      deploy_steps_tasks: {get_attr: [NovaComputeCommon, nova_compute_common_deploy_steps_tasks]}"},{"line_number":189,"context_line":"      host_prep_tasks:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3fa7e38b_9aae76e5","line":186,"range":{"start_line":186,"start_character":10,"end_line":186,"end_character":16},"updated":"2019-10-08 09:53:06.000000000","message":"{} might be safer in case anything inspecting this expects a dict","commit_id":"f4c446abcd4ffaac65c2cf38e6ed26f658ed4f93"}]}