)]}'
{"common/container-puppet.sh":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"2a65a2d0d7b8ff187211b2d9727579a2974bf397","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":3,"context_line":"# not use this file except in compliance with the License. You may obtain"},{"line_number":4,"context_line":"# a copy of the License at"}],"source_content_type":"text/x-sh","patch_set":4,"id":"3fa7e38b_a36a14ea","line":1,"updated":"2019-09-24 07:01:31.000000000","message":"https://review.opendev.org/#/c/683270/3..4/common/container-puppet.sh\n\nbut are these changes from v3 from a rebase (this is new file?) in which case maybe it should be a follow up patch for improvement? mainly because am not sure if this has introduced a nit or if there is something else wrong with ci right now (just checked grafana i see \"restarted zuul scheduler on commit 80ef01534d90751aa2d9cd3bf4a356fca292bed8\n\" in infra messages but from yesterday, going to ping ruck|rover too)","commit_id":"6bcf7250ad58049ca4864e91ae2e084217ad9402"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"f66eb095d9f83ada927c6303be0744cd49cdcb47","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":3,"context_line":"# not use this file except in compliance with the License. You may obtain"},{"line_number":4,"context_line":"# a copy of the License at"}],"source_content_type":"text/x-sh","patch_set":4,"id":"3fa7e38b_a56bf11b","line":1,"in_reply_to":"3fa7e38b_a36a14ea","updated":"2019-09-24 13:53:10.000000000","message":"I rebased the change on master and in https://review.opendev.org/#/c/674580/ the nested bash script was modified a bit.","commit_id":"6bcf7250ad58049ca4864e91ae2e084217ad9402"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"7e3362c04d80be036e6ebbe26b61b0d4a126ed13","unresolved":false,"context_lines":[{"line_number":16,"context_line":"mkdir -p /etc/puppet"},{"line_number":17,"context_line":"cp -dR /tmp/puppet-etc/* /etc/puppet"},{"line_number":18,"context_line":"rm -Rf /etc/puppet/ssl # not in use and causes permission errors"},{"line_number":19,"context_line":"echo \"{\\\\\"step\\\\\": $STEP}\" \u003e /etc/puppet/hieradata/docker_puppet.json"},{"line_number":20,"context_line":"TAGS\u003d\"\""},{"line_number":21,"context_line":"if [ -n \"$PUPPET_TAGS\" ]; then"},{"line_number":22,"context_line":"    TAGS\u003d\"--tags \\\"$PUPPET_TAGS\\\"\""}],"source_content_type":"text/x-sh","patch_set":4,"id":"3fa7e38b_869031ef","line":19,"range":{"start_line":19,"start_character":7,"end_line":19,"end_character":12},"updated":"2019-09-25 05:46:05.000000000","message":"this was the problem looks like?","commit_id":"6bcf7250ad58049ca4864e91ae2e084217ad9402"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"2e2a9b8c876ddcb438ba76e02929f247d42ac1f1","unresolved":false,"context_lines":[{"line_number":16,"context_line":"mkdir -p /etc/puppet"},{"line_number":17,"context_line":"cp -dR /tmp/puppet-etc/* /etc/puppet"},{"line_number":18,"context_line":"rm -Rf /etc/puppet/ssl # not in use and causes permission errors"},{"line_number":19,"context_line":"echo \"{\\\"step\\\": $STEP}\" \u003e /etc/puppet/hieradata/docker_puppet.json"},{"line_number":20,"context_line":"TAGS\u003d\"\""},{"line_number":21,"context_line":"if [ -n \"$PUPPET_TAGS\" ]; then"},{"line_number":22,"context_line":"    TAGS\u003d\"--tags \\\"$PUPPET_TAGS\\\"\""}],"source_content_type":"text/x-sh","patch_set":5,"id":"3fa7e38b_273db02a","line":19,"range":{"start_line":19,"start_character":5,"end_line":19,"end_character":24},"updated":"2019-09-25 12:41:02.000000000","message":"on the last rebase this was the issue. In the nested script the json is double escape quoted.","commit_id":"62593297e5f5d70531841606605facaa16b13c7f"}],"common/deploy-steps.j2":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"2ee401de5be713ca874a60f7ec8618afc1e98065","unresolved":false,"context_lines":[{"line_number":493,"context_line":"                  copy: src\u003ddocker_puppet_script.yaml dest\u003d/var/lib/container-puppet/container-puppet.py force\u003dyes mode\u003d0600"},{"line_number":494,"context_line":"                - name: Write container-puppet.sh"},{"line_number":495,"context_line":"                  no_log: True"},{"line_number":496,"context_line":"                  copy: src\u003dcontainer_puppet_script.yaml dest\u003d/var/lib/container-puppet/container-puppet.sh force\u003dyes mode\u003d0700"},{"line_number":497,"context_line":""},{"line_number":498,"context_line":"{%- for role in roles %}"},{"line_number":499,"context_line":"                - import_tasks: {{role.name}}/deploy_steps_tasks.yaml"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3fa7e38b_7392d84d","line":496,"range":{"start_line":496,"start_character":123,"end_line":496,"end_character":127},"updated":"2019-09-20 13:50:00.000000000","message":"it\u0027s original mode was 0755. Not sure we should change it in this unit of work.","commit_id":"df15cfebc1e0196b75bd9baceb23030fb3dec00e"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"7dadb05beaa77aaac15516f8187aec8e0d82de99","unresolved":false,"context_lines":[{"line_number":493,"context_line":"                  copy: src\u003ddocker_puppet_script.yaml dest\u003d/var/lib/container-puppet/container-puppet.py force\u003dyes mode\u003d0600"},{"line_number":494,"context_line":"                - name: Write container-puppet.sh"},{"line_number":495,"context_line":"                  no_log: True"},{"line_number":496,"context_line":"                  copy: src\u003dcontainer_puppet_script.yaml dest\u003d/var/lib/container-puppet/container-puppet.sh force\u003dyes mode\u003d0700"},{"line_number":497,"context_line":""},{"line_number":498,"context_line":"{%- for role in roles %}"},{"line_number":499,"context_line":"                - import_tasks: {{role.name}}/deploy_steps_tasks.yaml"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3fa7e38b_74763ba7","line":496,"range":{"start_line":496,"start_character":123,"end_line":496,"end_character":127},"in_reply_to":"3fa7e38b_7392d84d","updated":"2019-09-20 16:36:30.000000000","message":"Done","commit_id":"df15cfebc1e0196b75bd9baceb23030fb3dec00e"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"6f242dcc49c84138c800b44aec641947e41b580c","unresolved":false,"context_lines":[{"line_number":493,"context_line":"                  copy: src\u003ddocker_puppet_script.yaml dest\u003d/var/lib/container-puppet/container-puppet.py force\u003dyes mode\u003d0600"},{"line_number":494,"context_line":"                - name: Write container-puppet.sh"},{"line_number":495,"context_line":"                  no_log: True"},{"line_number":496,"context_line":"                  copy: src\u003dcontainer_puppet_script.yaml dest\u003d/var/lib/container-puppet/container-puppet.sh force\u003dyes mode\u003d0755"},{"line_number":497,"context_line":""},{"line_number":498,"context_line":"{%- for role in roles %}"},{"line_number":499,"context_line":"                - import_tasks: {{role.name}}/deploy_steps_tasks.yaml"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"3fa7e38b_42f49086","line":496,"range":{"start_line":496,"start_character":51,"end_line":496,"end_character":57},"updated":"2019-09-23 06:35:11.000000000","message":"what am i missing here that is defined as \"container_puppet_script:\" above line 371\n\n\u0027what am i missing\u0027 because i see the same is done with \"docker_puppet_script.yaml\"\n\n+ the file is created correctly @ https://storage.bhs1.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_ec0/683270/3/check/tripleo-ci-centos-7-undercloud-containers/ec068db/logs/undercloud/var/lib/container-puppet/","commit_id":"eac1dbf3586d654384855beb4531f2b7c789419c"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"9a5af238bea315c08afe67a0193272df33199acb","unresolved":false,"context_lines":[{"line_number":493,"context_line":"                  copy: src\u003ddocker_puppet_script.yaml dest\u003d/var/lib/container-puppet/container-puppet.py force\u003dyes mode\u003d0600"},{"line_number":494,"context_line":"                - name: Write container-puppet.sh"},{"line_number":495,"context_line":"                  no_log: True"},{"line_number":496,"context_line":"                  copy: src\u003dcontainer_puppet_script.yaml dest\u003d/var/lib/container-puppet/container-puppet.sh force\u003dyes mode\u003d0755"},{"line_number":497,"context_line":""},{"line_number":498,"context_line":"{%- for role in roles %}"},{"line_number":499,"context_line":"                - import_tasks: {{role.name}}/deploy_steps_tasks.yaml"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"3fa7e38b_b75c9c7e","line":496,"range":{"start_line":496,"start_character":51,"end_line":496,"end_character":57},"in_reply_to":"3fa7e38b_42f49086","updated":"2019-09-23 12:45:47.000000000","message":"https://review.opendev.org/#/c/683270/3/common/deploy-steps.j2@371 I don\u0027t know all the ins-and-outs of heat, but, it seems to create the file within the generated template as a local file, which happens to have a yaml extension, and is available to the heat-ansible runner.","commit_id":"eac1dbf3586d654384855beb4531f2b7c789419c"}]}