)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"d7b00603b9f30f727c61fd404fb4013f514ba884","unresolved":false,"context_lines":[{"line_number":10,"context_line":"script and into ansible tasks. While this change should not have"},{"line_number":11,"context_line":"any notable performance improvements, it continues the ongoing"},{"line_number":12,"context_line":"effort to deconstruct / refactor the container puppet process so"},{"line_number":13,"context_line":"that its more managable, and maintainable."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"In order to make the code more legible all of the pep8 vilolations"},{"line_number":16,"context_line":"have been resolved. While the pep8 fixes are mostly cosmetic,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3fa7e38b_bfcf92ae","line":13,"range":{"start_line":13,"start_character":5,"end_line":13,"end_character":8},"updated":"2019-09-23 14:52:48.000000000","message":"nit: \"it\u0027s\"","commit_id":"323171858e410239d343642bee782333861118d3"}],"common/deploy-steps-tasks.yaml":[{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"d7b00603b9f30f727c61fd404fb4013f514ba884","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        - path: \"/var/log/containers\""},{"line_number":35,"context_line":"          state: \"directory\""},{"line_number":36,"context_line":"          setype: \"container_file_t\""},{"line_number":37,"context_line":"          selevel: s0"},{"line_number":38,"context_line":"        - path: \"{{ container_log_stdout_path }}\""},{"line_number":39,"context_line":"          state: \"directory\""},{"line_number":40,"context_line":"          selevel: s0"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_7f6fda91","line":37,"range":{"start_line":37,"start_character":19,"end_line":37,"end_character":21},"updated":"2019-09-23 14:52:48.000000000","message":"consistency: some are quoted, some not","commit_id":"323171858e410239d343642bee782333861118d3"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"d7b00603b9f30f727c61fd404fb4013f514ba884","unresolved":false,"context_lines":[{"line_number":37,"context_line":"          selevel: s0"},{"line_number":38,"context_line":"        - path: \"{{ container_log_stdout_path }}\""},{"line_number":39,"context_line":"          state: \"directory\""},{"line_number":40,"context_line":"          selevel: s0"},{"line_number":41,"context_line":"        - path: \"/var/lib/tripleo-config\""},{"line_number":42,"context_line":"          state: \"directory\""},{"line_number":43,"context_line":"          setype: \"svirt_sandbox_file_t\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_3f69628a","line":40,"range":{"start_line":40,"start_character":19,"end_line":40,"end_character":21},"updated":"2019-09-23 14:52:48.000000000","message":"ditto","commit_id":"323171858e410239d343642bee782333861118d3"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"d7b00603b9f30f727c61fd404fb4013f514ba884","unresolved":false,"context_lines":[{"line_number":40,"context_line":"          selevel: s0"},{"line_number":41,"context_line":"        - path: \"/var/lib/tripleo-config\""},{"line_number":42,"context_line":"          state: \"directory\""},{"line_number":43,"context_line":"          setype: \"svirt_sandbox_file_t\""},{"line_number":44,"context_line":"          selevel: \"s0\""},{"line_number":45,"context_line":"        - path: \"/var/lib/tripleo-config/check-mode\""},{"line_number":46,"context_line":"          state: \"{{ (ansible_check_mode | bool) | ternary(\u0027directory\u0027, \u0027absent\u0027) }}\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_7f1d9a0d","line":43,"range":{"start_line":43,"start_character":19,"end_line":43,"end_character":39},"updated":"2019-09-23 14:52:48.000000000","message":"you can use container_file_t - they are the same","commit_id":"323171858e410239d343642bee782333861118d3"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"d7b00603b9f30f727c61fd404fb4013f514ba884","unresolved":false,"context_lines":[{"line_number":48,"context_line":"          selevel: \"{{ (ansible_check_mode | bool) | ternary(omit, \u0027s0\u0027) }}\""},{"line_number":49,"context_line":"        - path: \"/var/lib/container-puppet\""},{"line_number":50,"context_line":"          state: \"directory\""},{"line_number":51,"context_line":"          setype: \"svirt_sandbox_file_t\""},{"line_number":52,"context_line":"          selevel: \"s0\""},{"line_number":53,"context_line":"        - path: \"/var/lib/docker-puppet\""},{"line_number":54,"context_line":"          state: \"directory\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_5f221e54","line":51,"range":{"start_line":51,"start_character":19,"end_line":51,"end_character":39},"updated":"2019-09-23 14:52:48.000000000","message":"ditto","commit_id":"323171858e410239d343642bee782333861118d3"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"d7b00603b9f30f727c61fd404fb4013f514ba884","unresolved":false,"context_lines":[{"line_number":58,"context_line":"          selevel: \"{{ (ansible_check_mode | bool) | ternary(omit, \u0027s0\u0027) }}\""},{"line_number":59,"context_line":"        - path: \"/var/lib/container-config-scripts\""},{"line_number":60,"context_line":"          state: \"directory\""},{"line_number":61,"context_line":"          setype: \"svirt_sandbox_file_t\""},{"line_number":62,"context_line":"          selevel: \"s0\""},{"line_number":63,"context_line":"        # The container config files"},{"line_number":64,"context_line":"        # /var/lib/container-startup-configs.json is removed as we now write"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_3f1722f0","line":61,"range":{"start_line":61,"start_character":19,"end_line":61,"end_character":39},"updated":"2019-09-23 14:52:48.000000000","message":"ditto","commit_id":"323171858e410239d343642bee782333861118d3"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"d7b00603b9f30f727c61fd404fb4013f514ba884","unresolved":false,"context_lines":[{"line_number":71,"context_line":"          state: absent"},{"line_number":72,"context_line":"        - path: \"/var/lib/kolla/config_files\""},{"line_number":73,"context_line":"          state: \"directory\""},{"line_number":74,"context_line":"          setype: \"svirt_sandbox_file_t\""},{"line_number":75,"context_line":"          selevel: \"s0\""},{"line_number":76,"context_line":"        - path: \"/var/lib/config-data\""},{"line_number":77,"context_line":"          state: \"directory\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_bfe0f2fb","line":74,"range":{"start_line":74,"start_character":19,"end_line":74,"end_character":39},"updated":"2019-09-23 14:52:48.000000000","message":"ditto","commit_id":"323171858e410239d343642bee782333861118d3"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"d7b00603b9f30f727c61fd404fb4013f514ba884","unresolved":false,"context_lines":[{"line_number":75,"context_line":"          selevel: \"s0\""},{"line_number":76,"context_line":"        - path: \"/var/lib/config-data\""},{"line_number":77,"context_line":"          state: \"directory\""},{"line_number":78,"context_line":"          setype: \"svirt_sandbox_file_t\""},{"line_number":79,"context_line":"          selevel: \"s0\""},{"line_number":80,"context_line":"        - path: /var/lib/config-data/check-mode"},{"line_number":81,"context_line":"          state: \"{{ (ansible_check_mode | bool) | ternary(\u0027directory\u0027, \u0027absent\u0027) }}\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_5fe77e13","line":78,"range":{"start_line":78,"start_character":19,"end_line":78,"end_character":39},"updated":"2019-09-23 14:52:48.000000000","message":"ditto","commit_id":"323171858e410239d343642bee782333861118d3"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"d7b00603b9f30f727c61fd404fb4013f514ba884","unresolved":false,"context_lines":[{"line_number":79,"context_line":"          selevel: \"s0\""},{"line_number":80,"context_line":"        - path: /var/lib/config-data/check-mode"},{"line_number":81,"context_line":"          state: \"{{ (ansible_check_mode | bool) | ternary(\u0027directory\u0027, \u0027absent\u0027) }}\""},{"line_number":82,"context_line":"          setype: \"{{ (ansible_check_mode | bool) | ternary(omit, \u0027svirt_sandbox_file_t\u0027) }}\""},{"line_number":83,"context_line":"          selevel: \"{{ (ansible_check_mode | bool) | ternary(omit, \u0027s0\u0027) }}\""},{"line_number":84,"context_line":"        - path: /etc/puppet/check-mode"},{"line_number":85,"context_line":"          state: \"{{ (ansible_check_mode | bool) | ternary(\u0027directory\u0027, \u0027absent\u0027) }}\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_1ff106ce","line":82,"range":{"start_line":82,"start_character":67,"end_line":82,"end_character":87},"updated":"2019-09-23 14:52:48.000000000","message":"ditto","commit_id":"323171858e410239d343642bee782333861118d3"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"d7b00603b9f30f727c61fd404fb4013f514ba884","unresolved":false,"context_lines":[{"line_number":83,"context_line":"          selevel: \"{{ (ansible_check_mode | bool) | ternary(omit, \u0027s0\u0027) }}\""},{"line_number":84,"context_line":"        - path: /etc/puppet/check-mode"},{"line_number":85,"context_line":"          state: \"{{ (ansible_check_mode | bool) | ternary(\u0027directory\u0027, \u0027absent\u0027) }}\""},{"line_number":86,"context_line":"          setype: \"{{ (ansible_check_mode | bool) | ternary(omit, \u0027svirt_sandbox_file_t\u0027) }}\""},{"line_number":87,"context_line":"          selevel: \"{{ (ansible_check_mode | bool) | ternary(omit, \u0027s0\u0027) }}\""},{"line_number":88,"context_line":"        - path: /etc/puppet/check-mode/hieradata"},{"line_number":89,"context_line":"          state: \"{{ (ansible_check_mode | bool) | ternary(\u0027directory\u0027, \u0027absent\u0027) }}\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_9fb656fa","line":86,"range":{"start_line":86,"start_character":67,"end_line":86,"end_character":87},"updated":"2019-09-23 14:52:48.000000000","message":"ditto","commit_id":"323171858e410239d343642bee782333861118d3"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"d7b00603b9f30f727c61fd404fb4013f514ba884","unresolved":false,"context_lines":[{"line_number":87,"context_line":"          selevel: \"{{ (ansible_check_mode | bool) | ternary(omit, \u0027s0\u0027) }}\""},{"line_number":88,"context_line":"        - path: /etc/puppet/check-mode/hieradata"},{"line_number":89,"context_line":"          state: \"{{ (ansible_check_mode | bool) | ternary(\u0027directory\u0027, \u0027absent\u0027) }}\""},{"line_number":90,"context_line":"          setype: \"{{ (ansible_check_mode | bool) | ternary(omit, \u0027svirt_sandbox_file_t\u0027) }}\""},{"line_number":91,"context_line":"          selevel: \"{{ (ansible_check_mode | bool) | ternary(omit, \u0027s0\u0027) }}\""},{"line_number":92,"context_line":"        - path: /var/lib/container-puppet/puppetlabs"},{"line_number":93,"context_line":"          state: \"directory\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_5fd0de1f","line":90,"range":{"start_line":90,"start_character":67,"end_line":90,"end_character":87},"updated":"2019-09-23 14:52:48.000000000","message":"ditto","commit_id":"323171858e410239d343642bee782333861118d3"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"d7b00603b9f30f727c61fd404fb4013f514ba884","unresolved":false,"context_lines":[{"line_number":91,"context_line":"          selevel: \"{{ (ansible_check_mode | bool) | ternary(omit, \u0027s0\u0027) }}\""},{"line_number":92,"context_line":"        - path: /var/lib/container-puppet/puppetlabs"},{"line_number":93,"context_line":"          state: \"directory\""},{"line_number":94,"context_line":"          setype: svirt_sandbox_file_t"},{"line_number":95,"context_line":"          selevel: s0"},{"line_number":96,"context_line":"        - path: /var/lib/container-puppet/container-puppet-tasks{{ step }}.json"},{"line_number":97,"context_line":"          state: absent"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_dfbccedd","line":94,"range":{"start_line":94,"start_character":18,"end_line":94,"end_character":38},"updated":"2019-09-23 14:52:48.000000000","message":"ditto","commit_id":"323171858e410239d343642bee782333861118d3"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"d7b00603b9f30f727c61fd404fb4013f514ba884","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        - path: /var/lib/container-puppet/puppetlabs"},{"line_number":93,"context_line":"          state: \"directory\""},{"line_number":94,"context_line":"          setype: svirt_sandbox_file_t"},{"line_number":95,"context_line":"          selevel: s0"},{"line_number":96,"context_line":"        - path: /var/lib/container-puppet/container-puppet-tasks{{ step }}.json"},{"line_number":97,"context_line":"          state: absent"},{"line_number":98,"context_line":"      tags:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_df05aec3","line":95,"range":{"start_line":95,"start_character":19,"end_line":95,"end_character":21},"updated":"2019-09-23 14:52:48.000000000","message":"ditto","commit_id":"323171858e410239d343642bee782333861118d3"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"711f46eab0925fac7ed3612f1532438a1fb254c2","unresolved":false,"context_lines":[{"line_number":61,"context_line":"      tags:"},{"line_number":62,"context_line":"        - host_config"},{"line_number":63,"context_line":"        - container_config"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    - name: Write the config_step hieradata"},{"line_number":66,"context_line":"      no_log: True"},{"line_number":67,"context_line":"      copy:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3fa7e38b_3b1e48bb","side":"PARENT","line":64,"updated":"2019-10-09 17:51:04.000000000","message":"why were these removed? i don\u0027t think /etc/puppet/check-mode/hieradata will exist without these tasks during check mode.","commit_id":"505b43dfedf28e82900b4874d135d0988ef36521"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"7eb5b16456588471a20c3f05c83198db0f28d9e2","unresolved":false,"context_lines":[{"line_number":61,"context_line":"      tags:"},{"line_number":62,"context_line":"        - host_config"},{"line_number":63,"context_line":"        - container_config"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    - name: Write the config_step hieradata"},{"line_number":66,"context_line":"      no_log: True"},{"line_number":67,"context_line":"      copy:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3fa7e38b_916abb17","side":"PARENT","line":64,"in_reply_to":"3fa7e38b_3b1e48bb","updated":"2019-10-09 19:26:31.000000000","message":"good catch this actually needed to be restored.","commit_id":"505b43dfedf28e82900b4874d135d0988ef36521"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"711f46eab0925fac7ed3612f1532438a1fb254c2","unresolved":false,"context_lines":[{"line_number":152,"context_line":"      environment:"},{"line_number":153,"context_line":"        NET_HOST: \u0027true\u0027"},{"line_number":154,"context_line":"        DEBUG: \u0027{{ docker_puppet_debug | bool }}\u0027"},{"line_number":155,"context_line":"        PROCESS_COUNT: \"{{ ansible_processor_vcpus }}\""},{"line_number":156,"context_line":"        CONTAINER_CLI: \"{{ container_cli }}\""},{"line_number":157,"context_line":"        CONFIG: \u0027/var/lib/container-puppet/{{ ansible_check_mode | bool | ternary(\"check-mode/\", \"\") }}container-puppet.json\u0027"},{"line_number":158,"context_line":"        CONFIG_VOLUME_PREFIX: \u0027/var/lib/config-data{{ ansible_check_mode | bool | ternary(\"/check-mode\", \"\") }}\u0027"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3fa7e38b_dbd294d1","line":155,"updated":"2019-10-09 17:51:04.000000000","message":"docker_puppet_process_count defaulted to 6, and was previously configurable with the DockerPuppetProcessCount parameter.\n\nThis patch would change it to be set to the # of vcpus, and not configurable.\n\nIf you have a large number of cores (~32), this could help, or it could hurt due to resource contention. Do we have any data one way or another?","commit_id":"1efe5d959c838201563718212db10dab0aa8e904"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"7eb5b16456588471a20c3f05c83198db0f28d9e2","unresolved":false,"context_lines":[{"line_number":152,"context_line":"      environment:"},{"line_number":153,"context_line":"        NET_HOST: \u0027true\u0027"},{"line_number":154,"context_line":"        DEBUG: \u0027{{ docker_puppet_debug | bool }}\u0027"},{"line_number":155,"context_line":"        PROCESS_COUNT: \"{{ ansible_processor_vcpus }}\""},{"line_number":156,"context_line":"        CONTAINER_CLI: \"{{ container_cli }}\""},{"line_number":157,"context_line":"        CONFIG: \u0027/var/lib/container-puppet/{{ ansible_check_mode | bool | ternary(\"check-mode/\", \"\") }}container-puppet.json\u0027"},{"line_number":158,"context_line":"        CONFIG_VOLUME_PREFIX: \u0027/var/lib/config-data{{ ansible_check_mode | bool | ternary(\"/check-mode\", \"\") }}\u0027"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3fa7e38b_716dbf30","line":155,"in_reply_to":"3fa7e38b_dbd294d1","updated":"2019-10-09 19:26:31.000000000","message":"I\u0027ll restore what we had and address this in a follow on so we can get the value right.","commit_id":"1efe5d959c838201563718212db10dab0aa8e904"}]}