)]}'
{"deployment/ironic/ironic-pxe-container-puppet.yaml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"e74200bbb74c3c78c53283614cf2819370400c8d","unresolved":false,"context_lines":[{"line_number":157,"context_line":"            - { \u0027path\u0027: /var/log/containers/ironic, \u0027setype\u0027: svirt_sandbox_file_t }"},{"line_number":158,"context_line":"            - { \u0027path\u0027: /var/log/containers/httpd/ironic-pxe, \u0027setype\u0027: svirt_sandbox_file_t }"},{"line_number":159,"context_line":"            - { \u0027path\u0027: /var/log/ironic, \u0027setype\u0027: svirt_sandbox_file_t }"},{"line_number":160,"context_line":"            - { \u0027path\u0027: /var/lib/ironic/tftpboot, \u0027setype\u0027: tftpdir_t }"},{"line_number":161,"context_line":"        - name: ironic logs readme"},{"line_number":162,"context_line":"          copy:"},{"line_number":163,"context_line":"            dest: /var/log/ironic/readme.txt"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_1e6801b7","line":160,"updated":"2019-09-25 10:05:15.000000000","message":"technically we could also ensure the/var/lib/ironic/tftpboot/pxelinux.cfg directory here as well to complement the inconsistency places with puppets. But I\u0027m not sure duplicating puppet bits here would be a solid fix. Instead we should make sure puppet includes its ::ironic::pxe. That class normally creates\nthe required tftpboot/pxelinux.cfg path here https://opendev.org/openstack/puppet-ironic/src/branch/master/manifests/pxe.pp#L93","commit_id":"b616aa54dd0a61273a758f4aae041dbfddfc8008"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"fbd87468cf5a4726797768f4c736dcd7ba8aaaec","unresolved":false,"context_lines":[{"line_number":157,"context_line":"            - { \u0027path\u0027: /var/log/containers/ironic, \u0027setype\u0027: svirt_sandbox_file_t }"},{"line_number":158,"context_line":"            - { \u0027path\u0027: /var/log/containers/httpd/ironic-pxe, \u0027setype\u0027: svirt_sandbox_file_t }"},{"line_number":159,"context_line":"            - { \u0027path\u0027: /var/log/ironic, \u0027setype\u0027: svirt_sandbox_file_t }"},{"line_number":160,"context_line":"            - { \u0027path\u0027: /var/lib/ironic/tftpboot, \u0027setype\u0027: tftpdir_t }"},{"line_number":161,"context_line":"        - name: ironic logs readme"},{"line_number":162,"context_line":"          copy:"},{"line_number":163,"context_line":"            dest: /var/log/ironic/readme.txt"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_5e5e7976","line":160,"in_reply_to":"3fa7e38b_1e6801b7","updated":"2019-09-25 10:28:05.000000000","message":"https://review.opendev.org/#/c/684689/ addresses that part","commit_id":"b616aa54dd0a61273a758f4aae041dbfddfc8008"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"82356026832dd8c5f8cf2b3730ab7273e1842bdd","unresolved":false,"context_lines":[{"line_number":157,"context_line":"            - { \u0027path\u0027: /var/log/containers/ironic, \u0027setype\u0027: svirt_sandbox_file_t }"},{"line_number":158,"context_line":"            - { \u0027path\u0027: /var/log/containers/httpd/ironic-pxe, \u0027setype\u0027: svirt_sandbox_file_t }"},{"line_number":159,"context_line":"            - { \u0027path\u0027: /var/log/ironic, \u0027setype\u0027: svirt_sandbox_file_t }"},{"line_number":160,"context_line":"            - { \u0027path\u0027: /var/lib/ironic/tftpboot, \u0027setype\u0027: tftpdir_t }"},{"line_number":161,"context_line":"        - name: ironic logs readme"},{"line_number":162,"context_line":"          copy:"},{"line_number":163,"context_line":"            dest: /var/log/ironic/readme.txt"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_e7b54333","line":160,"in_reply_to":"3fa7e38b_5e5e7976","updated":"2019-09-26 09:30:58.000000000","message":"hmmm, since the parent directory is owned by svirt_sandbox_file_t (aka container_file_t), I\u0027m not 100% sure httpd has right to access it.\n\nI *think* I\u0027ve pushed a patch sometimes ago that should allow that, but.... not sure if it\u0027s a boolean, or a new rule.","commit_id":"b616aa54dd0a61273a758f4aae041dbfddfc8008"}]}